Re: Why 2 space indentations??

2013-03-18 Thread Ken Giusti
- Original Message - From: Phil Harvey p...@philharveyonline.com To: proton@qpid.apache.org Sent: Saturday, March 16, 2013 1:09:49 AM Subject: Re: Why 2 space indentations?? I'm feeling a bit guilty about this one because I suspect it was my indentation-related review comments

Re: Why 2 space indentations??

2013-03-18 Thread Rafael Schloming
On Sat, Mar 16, 2013 at 1:09 AM, Phil Harvey p...@philharveyonline.comwrote: I'm feeling a bit guilty about this one because I suspect it was my indentation-related review comments on some of Ken's recent soak test work that may have been the catalyst for this thread. We've got a few options

Re: Why 2 space indentations??

2013-03-15 Thread Ted Ross
+1. I've also wondered why this one codebase was written with 2-space indentation. My editors are all set up for 4-spaces so doing any work in this code is a pain. I'm in favor of converting all of it to comply with the 4-space convention. -Ted On 03/14/2013 09:18 AM, Ken Giusti wrote:

Re: Why 2 space indentations??

2013-03-15 Thread Phil Harvey
I'm feeling a bit guilty about this one because I suspect it was my indentation-related review comments on some of Ken's recent soak test work that may have been the catalyst for this thread. We've got a few options about what to do, each bringing their own special kind of pain. I would be in

Re: Why 2 space indentations??

2013-03-14 Thread Rafael Schloming
On Thu, Mar 14, 2013 at 10:50 AM, Ken Giusti kgiu...@redhat.com wrote: - Original Message - From: Rafael Schloming r...@alum.mit.edu To: proton@qpid.apache.org Sent: Thursday, March 14, 2013 10:07:02 AM Subject: Re: Why 2 space indentations?? On Thu, Mar 14, 2013 at 9:18 AM