Re: review request: patch to cmake for windows builds

2012-11-02 Thread Ken Giusti
w > libraries automatically included etc...) > The first is the winsock2 library. Rpcrt4.lib and uuid.lib are used > for > creating the uuid. > > Mary > > -Original Message- > From: Rafael Schloming [mailto:r...@alum.mit.edu] > Sent: Thursday, November 01, 2012 1

RE: review request: patch to cmake for windows builds

2012-11-01 Thread Mary Hinton
ailto:r...@alum.mit.edu] Sent: Thursday, November 01, 2012 12:17 PM To: proton@qpid.apache.org Subject: Re: review request: patch to cmake for windows builds FWIW, a lot of the patches that have been made to the build system so far were taken from the cpp broker's build and to be honest when yo

Re: review request: patch to cmake for windows builds

2012-11-01 Thread Cliff Jansen
e this project. So I'm not an expert. >> >> > >> >> > I'll be happy to have your help with creating good support for >> >> > building proton from cmake. >> >> > >> >> > The python support definitely needs to be fixed

Re: review request: patch to cmake for windows builds

2012-11-01 Thread Rafael Schloming
t; >> > > > >> > I'll be happy to have your help with creating good support for > > >> > building proton from cmake. > > >> > > > >> > The python support definitely needs to be fixed. And I would be > > >> > happy &

Re: review request: patch to cmake for windows builds

2012-11-01 Thread Ken Giusti
> >> > to have that part working properly. I've been creating the > >> > header > >> > files (encodings.h and protocol.h) and setting up the python > >> > to > >> > run the tests outside of the project files. I'll look at your &

Re: review request: patch to cmake for windows builds

2012-11-01 Thread Ken Giusti
I've created a project branch "kgiusti-msvc2010" on the apache site - no need to use github. Here is the current diff in all it's glory: https://reviews.apache.org/r/7826/ -K - Original Message - > On Wed, 2012-10-31 at 13:46 -0400, Ken Giusti wrote: > > Hi Cliff/Mary, > > > > I'm try

Re: review request: patch to cmake for windows builds

2012-10-31 Thread Cliff Jansen
to be fixed. And I would be >> > happy >> > to have that part working properly. I've been creating the header >> > files (encodings.h and protocol.h) and setting up the python to >> > run the tests outside of the project files. I'll look at your >> > cha

Re: review request: patch to cmake for windows builds

2012-10-31 Thread Andrew Stitcher
On Wed, 2012-10-31 at 13:46 -0400, Ken Giusti wrote: > Hi Cliff/Mary, > > I'm trying to add support for building proton using Microsoft Visual C++ > express. This patch updates cmake to enable generation of the VC++ project > files for proton. Can you review and try it out - let me know what y

RE: review request: patch to cmake for windows builds

2012-10-31 Thread Mary Hinton
IFESTUAC:"level='asInvoker' uiAccess='false'" /PDB:"C:/qpid/qpid/proton/proton-c/Release/qpid-proton.pdb" /SUBSYSTEM:CONSOLE /STACK:"1000" /PGD:"C:\qpid\qpid\proton\proton-c\Release\qpid-proton.pgd" /TLBID:1 /DYNAMICBASE /NXCOMPAT

Re: review request: patch to cmake for windows builds

2012-10-31 Thread Ken Giusti
d setting up the python to > > run the tests outside of the project files. I'll look at your > > changes as soon as I can. > > > > Mary > > > > -Original Message- > > From: Ken Giusti [mailto:kgiu...@redhat.com] > > Sent: Wednesda

Re: review request: patch to cmake for windows builds

2012-10-31 Thread Ken Giusti
, 2012 1:47 PM > To: cliffjan...@gmail.com; Mary Hinton > Cc: proton@qpid.apache.org > Subject: review request: patch to cmake for windows builds > > Hi Cliff/Mary, > > I'm trying to add support for building proton using Microsoft Visual > C++ express. This patch updates

RE: review request: patch to cmake for windows builds

2012-10-31 Thread Mary Hinton
as soon as I can. Mary -Original Message- From: Ken Giusti [mailto:kgiu...@redhat.com] Sent: Wednesday, October 31, 2012 1:47 PM To: cliffjan...@gmail.com; Mary Hinton Cc: proton@qpid.apache.org Subject: review request: patch to cmake for windows builds Hi Cliff/Mary, I'm tryi

review request: patch to cmake for windows builds

2012-10-31 Thread Ken Giusti
Hi Cliff/Mary, I'm trying to add support for building proton using Microsoft Visual C++ express. This patch updates cmake to enable generation of the VC++ project files for proton. Can you review and try it out - let me know what you think? Note that the patch only adds build support - the pr