[Prototype-core] event memo modified is evaluated to false

2010-03-26 Thread Cédric Bertolini
Hi there. I don't know if this mailing list is the right place to post this message. I'd like to discuss a choice made in Prototype. I have a problem with the Event.fire function and the event.memo property. Prototype 1.6.1 says event.memo = memo || { }; // line 4070 So any memo value

[Prototype-core] Re: event memo modified is evaluated to false

2010-03-26 Thread Tobie Langel
The reason for this design choice was to avoid the following altogether: if (event.memo) { foo = event.memo.foo; } and allow this instead: foo = event.memo.foo; There are memory costs involved with this design choice, but these can easily be mitigated by passing in a value to

Re: [Prototype-core] Re: event memo modified is evaluated to false

2010-03-26 Thread Christophe Porteneuve
Tobie, If that's so, then we should explictly forbid memo not being an object, shoudln't we? Or at least make this crystal-clear in the docs. The current docs only state memo: metadata for the event. Otherwise, you can pull my commit b1bfdd5, fresh off the current main master :-) Le