Re: Filename Encoding

2013-12-22 Thread Ben Pfaff
t; back to other encodings as necessary. > > I'm not sure this was the best decision. How do we know to which > encoding we should convert back to? I guess you mean, in the context of filenames. We have to know what is the system filename encoding. There can only reasonab

Re: Filename Encoding

2013-12-22 Thread John Darrington
On Tue, Dec 10, 2013 at 12:38:04PM -0800, Ben Pfaff wrote: in syntax and the output engine, we tend to convert everything we receive externally into UTF-8 for internal processing, and then convert back to other encodings as necessary. I'm not sure this was the best decision. How

Re: Filename Encoding

2013-12-11 Thread John Darrington
ing is superior? > > Both solutions have advantages and disadvantages. > > The converting-all-filenames-to-utf8 solution has two disadvantages that I > can see: > > *. Unnecessary recoding - often it will be necessary to convert from

Re: Filename Encoding

2013-12-11 Thread Ben Pfaff
solution has two disadvantages that I > can see: > > *. Unnecessary recoding - often it will be necessary to convert from > "filename encoding" > to utf8 and then, back to "filename encoding". Is the concern here about performance, or something else? I do

Re: Filename Encoding

2013-12-11 Thread John Darrington
. Do you think that storing file name plus encoding is superior? Both solutions have advantages and disadvantages. The converting-all-filenames-to-utf8 solution has two disadvantages that I can see: *. Unnecessary recoding - often it will be necessary to convert from "filename encoding&qu

Re: Filename Encoding

2013-12-10 Thread Ben Pfaff
On Tue, Dec 10, 2013 at 07:24:39PM +0100, John Darrington wrote: > On Mon, Dec 09, 2013 at 08:30:17PM -0800, Ben Pfaff wrote: > On Sun, Dec 08, 2013 at 07:43:25PM +0100, John Darrington wrote: > > Thanks to Harry's feedback, I've started to understand the issues > concerning > > bu

Re: Filename Encoding

2013-12-10 Thread John Darrington
On Mon, Dec 09, 2013 at 08:30:17PM -0800, Ben Pfaff wrote: On Sun, Dec 08, 2013 at 07:43:25PM +0100, John Darrington wrote: > Thanks to Harry's feedback, I've started to understand the issues concerning > bug #33255 . Can you explain the issue as you see it? I don't see

Re: Filename Encoding

2013-12-09 Thread Ben Pfaff
On Sun, Dec 08, 2013 at 07:43:25PM +0100, John Darrington wrote: > Thanks to Harry's feedback, I've started to understand the issues concerning > bug #33255 . Can you explain the issue as you see it? I don't see any recent substantive comments in that bug report. ___

Filename Encoding

2013-12-08 Thread John Darrington
Thanks to Harry's feedback, I've started to understand the issues concerning bug #33255 . I'm coming to the conclusion that the easiest way to solve the problem will involve adding a member to struct file_handle to store the encoding of the filename. (There is already an "encoding" member, but th

[patch #6788] Filename encoding experiments

2009-04-07 Thread John Darrington
Update of patch #6788 (project pspp): Open/Closed:Open => Closed ___ Reply to this item at: ___ Mess

[patch #6788] Filename encoding experiments

2009-03-23 Thread John Darrington
Follow-up Comment #3, patch #6788 (project pspp): Take 4 (file #17763) ___ Additional Item Attachment: File name: filename-encoding4.patch Size:4 KB ___ Reply to this item a

[patch #6788] Filename encoding experiments

2009-03-22 Thread John Darrington
Follow-up Comment #2, patch #6788 (project pspp): Patch 3. Should fix problems opening syntax files. (file #17762) ___ Additional Item Attachment: File name: filename-encoding3.patch Size:4 KB

[patch #6788] Filename encoding experiments

2009-03-22 Thread John Darrington
Follow-up Comment #1, patch #6788 (project pspp): Another patch. (file #17761) ___ Additional Item Attachment: File name: filename-encoding2.patch Size:4 KB ___ Reply to thi

[patch #6788] Filename encoding experiments

2009-03-22 Thread John Darrington
URL: <http://savannah.gnu.org/patch/?6788> Summary: Filename encoding experiments Project: PSPP Submitted by: jmd Submitted on: Mon 23 Mar 2009 10:05:32 AM WST Category: None Item Group