Bug in vergil.tree.PTree

2006-02-16 Thread Kevin Ruland
Hi all, Found a simple bugger at line 113 in vergil.tree.PTree. Seems the test for if the path is null appears after its use in another condition. Here's a little patch: Index: ptolemy/vergil/tree/PTree.java === RCS file: /home/cvs

Re: Actor attributeChanged() methods and validating mutliple changes.

2006-02-16 Thread Kevin Ruland
Efrat, That's what would end up happening now - except the user could be presented with some ugly intermediate states. Kevin Efrat Frank wrote: Hi Kevin, We tried to address this issue several times in the past, both for the WebService and OpenDBConnection actors, but still there doesn't

Re: Actor attributeChanged() methods and validating mutliple changes.

2006-02-16 Thread Kevin Ruland
ps more likely, I found the documentation incomprehensible and couldn't get it to work). I'm open to a change in the dialog box that would issue the change request only when an Apply or OK button is pressed... This would probably solve the problem... Edward At 09:36 AM 2/16/2006, Kevi

Re: Actor attributeChanged() methods and validating mutliple changes.

2006-02-16 Thread Kevin Ruland
ld I have notification of "commit"? Kevin Edward A. Lee wrote: At 07:24 AM 2/16/2006, Kevin Ruland wrote: Is there any way for the actor be notified when the user decides all the changes are complete? Not really... I'm not sure how one could do that... You could chec

Re: Actor attributeChanged() methods and validating mutliple changes.

2006-02-16 Thread Kevin Ruland
as follows: This looks to me like a rather non-orthogonal design. Why not have: a1 = something a3 = 0 or 1 ortrue or false(depending on semantics) then calculate what you now call a2: a2 = 2*a1 + a3 Edward At 10:36 AM 2/15/2006, Kevin Ruland wrote: Hi all, We have a number of ac

Actor attributeChanged() methods and validating mutliple changes.

2006-02-15 Thread Kevin Ruland
Hi all, We have a number of actors which require certain conditions to be satisfied by attributes as a collection. For sake of example, suppose we have two attributes a1, a2 which are integers. And the following conditions must hold: a1 = 1 <=> a2 = 1, 2 a1 = 2 <=> a2 = 3, 4 You get the i

Re: Failure to find ptII.properties

2006-02-10 Thread Kevin Ruland
BTW - when Vergil or Kepler is run from an installer as an application then standard out and standard error will be eaten because there is no standard out. We do have a certain amount of verbiage going on though. It should all go in to a log file somewhere. Christopher, This is true. W

Failure to find ptII.properties

2006-02-10 Thread Kevin Ruland
Hi all. I'm curious about the ptII.properties file loaded from $CLASSPATH/lib/. I looked at the one generated for my laptop and it is a bunch of paths to various system things. The problems its causing me is on startup if it cannot be found, I'm notified with: java.io.IOException: Could no

Re: [kepler-dev] [Fwd: Re: kepler/src/util URLToLocalFile.java]

2006-02-02 Thread Kevin Ruland
Well, it seems I cannot reproduce the problem Efrat was having. Maybe that was a data problem. However, even with the test workflow, and the previous revision of URLToLocalFile, I cannot reproduce the problem. Kevin Dan, I was talking to Efrat a while ago, and I think this fix actually c

Re:kepler/src/util URLToLocalFile.java

2006-02-02 Thread Kevin Ruland
Dan, I was talking to Efrat a while ago, and I think this fix actually covers up a bug in ptII's ptolemy.util.FileUtilities.nameToURL() which appears to add an extra "/" to the string, which then makes the name look like this: "http:///www";. What this really indicates to Java when converte

Re: [kepler-dev] Can "stop" interrupt "initialize()"

2006-02-01 Thread Kevin Ruland
Edward A. Lee wrote: At 11:22 AM 2/1/2006 -0600, Kevin Ruland wrote: 1) Should CompositeActor release the read-lock prior to making the open call to the director's preinitialize()? This would have to be done very carefully. If you don't hold a read lock, then the structure of the

Re: Can "stop" interrupt "initialize()"

2006-02-01 Thread Kevin Ruland
Hi all, I was happily working through the issues I was having with stop and intialize(). The answer I ended up with was this in ititialize(): try { sychronized( _entityCountDown ) { while ( _entityCountDown.currentCount() > 0 && !getDirector.isStopRequested() ) { _entityCountDown.wai

Re: Can "stop" interrupt "initialize()"

2006-01-31 Thread Kevin Ruland
Edward A. Lee wrote: At 01:49 PM 1/30/2006 -0600, Kevin Ruland wrote: Every Director has a method isStopRequested(). A long running initialize() method should just call this method and abort if it returns true... I think I can use this in some kind of spin wait. What's the easiest wa

Re: Can "stop" interrupt "initialize()"

2006-01-30 Thread Kevin Ruland
Edward A. Lee wrote: At 08:41 AM 1/30/2006 -0600, Kevin Ruland wrote: Also, if some actor somewhere does do something extremely time consuming in it's initialize method, there is currently no pleasant way to interrupt it. The user can click on the stop button, and it does appear to have

Re: Can "stop" interrupt "initialize()"

2006-01-30 Thread Kevin Ruland
not have spoken because I don't know what the desired functionality of this portion of the system is. Kevin Shawn Bowers wrote: On Mon, 30 Jan 2006, Kevin Ruland wrote: Bertram, Things like static type checking may be optional (to the workflow) in the sense that one could still execut

Re: Can "stop" interrupt "initialize()"

2006-01-30 Thread Kevin Ruland
Bertram Ludaescher wrote: On Mon, 30 Jan 2006 08:41:50 -0600 Kevin Ruland <[EMAIL PROTECTED]> wrote: KR> KR> Bertram, KR> KR> Things like static type checking may be optional (to the workflow) in KR> the sense that one could still execute a workflow without

Re: Can "stop" interrupt "initialize()"

2006-01-30 Thread Kevin Ruland
meeting.. What do you think? cheers Bertram On Sun, 29 Jan 2006 17:51:11 -0600 Kevin Ruland <[EMAIL PROTECTED]> wrote: KR> KR> Hi. KR> In Kepler we have some actors which download large volume of data in the KR> background. They do this without any control fr

Can "stop" interrupt "initialize()"

2006-01-29 Thread Kevin Ruland
Hi. In Kepler we have some actors which download large volume of data in the background. They do this without any control from the director. In essence this is done when the actor is instantiated and should complete prior to the user running the workflow (ie, before initialize() is called).

Re: Storing XYPlotter graph as video

2006-01-25 Thread Kevin Ruland
Nandita, Don't know about an actor, but you can take a sequence of static images and make them into a movie (animated gif or mpeg) using ImageMagick. Kevin Nandita Mangal wrote: Hi there, I had a question, if there are any actors /ways to store the results plotted on an XY Plotter as a v

Re: Startup performance

2005-12-30 Thread Kevin Ruland
Christopher, I've run the code though demo copies of many different profile monitoring tools. They all indicate a major time skew when reporting cpu performance. One product described the reason which is the jvm instrumentation provides only wall clock miliseconds when profiling. It does

Re: Startup performance

2005-12-28 Thread Kevin Ruland
Christopher, TPTP is very dogged slow on my machine too and I have a 2x Xenon 3Ghz warming my toes. I've found the only way to execute it in a reasonable amount of time is to turn off the "per-instance" things. This apparently really turns down the amount of data collected. Also, I start

Re: Startup performance

2005-12-28 Thread Kevin Ruland
Christopher, I saw a commit you made to ptolemy.kernel.util.NamedObj, specificially r1.303 where you reimplemented the ContainedObjectsIterator to no longer use lazy initialization. I have seen no ill effects of this change. However, I did notice something else. Since the lazy initialization h

Re: Memory leak.

2005-12-21 Thread Kevin Ruland
Edward, I don't fully understand the situation and defer to you or Christopher for greater details. Perhaps there is something in the Kepler code which is holding onto a MoMLParser too long. In kepler there is this code in ActorMetadata.ActorMetadata( InputStream moml): { MoMLParser pa

Re: Memory leak.

2005-12-21 Thread Kevin Ruland
Christopher, Christopher Brooks wrote: Hi Kevin, Yep, this looks like a leak of some sort. In MoMLParser, _parser is declared as: private XmlParser _parser = new XmlParser(); I'm not sure if setting _parser to null in 1326 of MoMLParser.parse(URL, Reader) is safe or not. What happens the

Memory leak.

2005-12-20 Thread Kevin Ruland
Hi guys, As everybody else, I was concerned that Kepler's memory consumption, so I ran just kepler startup through -Xrunhprof and looked at the 250M memory report. I terminated the application "normally" by closing the main window as soon as it appeared. The answer is... Kepler is leaking.

Startup performance

2005-12-13 Thread Kevin Ruland
Hi all, I ran the Kepler startup through a performance monitoring tool the other day and learned some things which I would like to pass along. I used the TPTP system in Eclipse to measure the performance. This is an amazing tool and I suggest you check it out sometime. Since I'm a rookie w