Re: [ptxdist] [PATCH v2] configure_helper.py: check for emptyish ptxdist environment variables

2019-10-16 Thread Michael Olbrich
On Wed, Oct 16, 2019 at 01:58:07PM +0200, Roland Hieber wrote: > On Wed, Oct 16, 2019 at 01:38:56PM +0200, Michael Olbrich wrote: > > On Wed, Oct 16, 2019 at 12:53:10PM +0200, Roland Hieber wrote: > > > Michael, any comments? It does not seem to be applied yet. > > > > Right, this got lost. I'm

Re: [ptxdist] [PATCH v2] configure_helper.py: check for emptyish ptxdist environment variables

2019-10-16 Thread Roland Hieber
On Wed, Oct 16, 2019 at 01:38:56PM +0200, Michael Olbrich wrote: > On Wed, Oct 16, 2019 at 12:53:10PM +0200, Roland Hieber wrote: > > Michael, any comments? It does not seem to be applied yet. > > Right, this got lost. I'm not sure I like this. Why would there be an empty > PTXDIST env variable?

Re: [ptxdist] [PATCH v2] configure_helper.py: check for emptyish ptxdist environment variables

2019-10-16 Thread Michael Olbrich
On Wed, Oct 16, 2019 at 12:53:10PM +0200, Roland Hieber wrote: > Michael, any comments? It does not seem to be applied yet. Right, this got lost. I'm not sure I like this. Why would there be an empty PTXDIST env variable? Michael > On Wed, Sep 25, 2019 at 03:13:40PM +0200, Roland Hieber wrote:

Re: [ptxdist] [PATCH v2] configure_helper.py: check for emptyish ptxdist environment variables

2019-10-16 Thread Roland Hieber
Michael, any comments? It does not seem to be applied yet. - Roland On Wed, Sep 25, 2019 at 03:13:40PM +0200, Roland Hieber wrote: > When the environment variable exists, but is empty, os.environment.get() > will return its value instead of using the supplied default. Check for > cases like

[ptxdist] [PATCH v2] configure_helper.py: check for emptyish ptxdist environment variables

2019-09-25 Thread Roland Hieber
When the environment variable exists, but is empty, os.environment.get() will return its value instead of using the supplied default. Check for cases like that to prevent calling an empty command. Signed-off-by: Roland Hieber --- v1 -> v2: - prevent "AttributeError: 'NoneType' object has no