RE: [indexeddb] Do we need to support keyPaths with an empty string?

2012-01-25 Thread Israel Hilerio
On Wednesday, January 25, 2012 1:47 AM, Jonas Sicking wrote: > On Tue, Jan 24, 2012 at 12:07 PM, Israel Hilerio > > wrote: > > On Tuesday, January 24, 2012 2:46 AM Jonas Sicking wrote: > >> On Fri, Jan 20, 2012 at 3:38 PM, Israel Hilerio > >> > >> wrote: > >> > On Friday, January 20, 2012 2:31

Re: [indexeddb] Do we need to support keyPaths with an empty string?

2012-01-25 Thread Jonas Sicking
On Tue, Jan 24, 2012 at 12:07 PM, Israel Hilerio wrote: > On Tuesday, January 24, 2012 2:46 AM Jonas Sicking wrote: >> On Fri, Jan 20, 2012 at 3:38 PM, Israel Hilerio >> wrote: >> > On Friday, January 20, 2012 2:31 PM, Jonas Sicking wrote: >> >> On Fri, Jan 20, 2012 at 12:23 PM, ben turner >> wr

RE: [indexeddb] Do we need to support keyPaths with an empty string?

2012-01-24 Thread Israel Hilerio
On Tuesday, January 24, 2012 2:46 AM Jonas Sicking wrote: > On Fri, Jan 20, 2012 at 3:38 PM, Israel Hilerio > wrote: > > On Friday, January 20, 2012 2:31 PM, Jonas Sicking wrote: > >> On Fri, Jan 20, 2012 at 12:23 PM, ben turner > wrote: > >> > Mozilla is fine with removing the special |keyPath:"

Re: [indexeddb] Do we need to support keyPaths with an empty string?

2012-01-24 Thread Jonas Sicking
On Fri, Jan 20, 2012 at 3:38 PM, Israel Hilerio wrote: > On Friday, January 20, 2012 2:31 PM, Jonas Sicking wrote: >> On Fri, Jan 20, 2012 at 12:23 PM, ben turner wrote: >> > Mozilla is fine with removing the special |keyPath:""| behavior. >> > Please note that this will also mean that step 1 of

RE: [indexeddb] Do we need to support keyPaths with an empty string?

2012-01-20 Thread Israel Hilerio
On Friday, January 20, 2012 2:31 PM, Jonas Sicking wrote: > On Fri, Jan 20, 2012 at 12:23 PM, ben turner wrote: > > Mozilla is fine with removing the special |keyPath:""| behavior. > > Please note that this will also mean that step 1 of the algorithm here > > > > > > http://dvcs.w3.org/hg/IndexedD

Re: [indexeddb] Do we need to support keyPaths with an empty string?

2012-01-20 Thread Jonas Sicking
On Fri, Jan 20, 2012 at 12:23 PM, ben turner wrote: > Mozilla is fine with removing the special |keyPath:""| behavior. > Please note that this will also mean that step 1 of the algorithm here > >  http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#dfn-steps-for-extracting-a-key-from-a-valu

Re: [indexeddb] Do we need to support keyPaths with an empty string?

2012-01-20 Thread ben turner
Mozilla is fine with removing the special |keyPath:""| behavior. Please note that this will also mean that step 1 of the algorithm here http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#dfn-steps-for-extracting-a-key-from-a-value-using-a-key-path will need to change. We do want to co

RE: [indexeddb] Do we need to support keyPaths with an empty string?

2012-01-20 Thread Israel Hilerio
.com] On Behalf Of Joshua Bell Sent: Friday, January 20, 2012 10:48 AM To: Israel Hilerio Cc: Odin Hørthe Omdal; Jonas Sicking (jo...@sicking.cc); ben turner (bent.mozi...@gmail.com); Adam Herchenroether; David Sheldon; public-webapps@w3.org Subject: Re: [indexeddb] Do we need to support keyPath

Re: [indexeddb] Do we need to support keyPaths with an empty string?

2012-01-20 Thread Joshua Bell
Empty strings, null, and undefined are all dangerous traps for the unwary in JavaScript already; all are falsy, some compare equal with ==, all ToString differently, some ToNumber differently. Personally, I try not to make any assumptions about how an API will respond to these inputs and approach w

RE: [indexeddb] Do we need to support keyPaths with an empty string?

2012-01-20 Thread Israel Hilerio
Any updates on this thread? Odin from Opera prefers the FailFast method we've been discussing. We're in the process of cleaning some issues and would like to get this resolved ASAP. If we believe the current implementation in Firefox and Chrome is the way to go, I'm okay with it but I would li

Re: [indexeddb] Do we need to support keyPaths with an empty string?

2012-01-19 Thread Odin Hørthe Omdal
On Wed, 18 Jan 2012 22:16:29 +0100, Israel Hilerio wrote: Given the different behaviors, I wonder if the use case you described below (i.e. set scenario) is worth supporting. Not supporting keyPath = undefined, null, and “” seem to provide a more consistent and clean story. Returning a

RE: [indexeddb] Do we need to support keyPaths with an empty string?

2012-01-18 Thread Israel Hilerio
Based on our retesting of Aurora and Canary, this is the behavior we're seeing: When a null or undefined keyPath is provided to the createObjectStore API, you can add values to an Object Store as long as a key is specified during the execution of the Add API. Not providing a key for the Add API

Re: [indexeddb] Do we need to support keyPaths with an empty string?

2012-01-18 Thread Joshua Bell
On Wed, Jan 18, 2012 at 1:51 PM, ben turner wrote: > On Wed, Jan 18, 2012 at 1:40 PM, Israel Hilerio > wrote: > > We tested on Firefox 8.0.1 > > Ah, ok. We made lots of big changes to key handling that will be in 11 > I think. If you're curious I would recommend retesting with an aurora > build

Re: [indexeddb] Do we need to support keyPaths with an empty string?

2012-01-18 Thread ben turner
On Wed, Jan 18, 2012 at 1:40 PM, Israel Hilerio wrote: > We tested on Firefox 8.0.1 Ah, ok. We made lots of big changes to key handling that will be in 11 I think. If you're curious I would recommend retesting with an aurora build from https://www.mozilla.org/en-US/firefox/aurora. Thanks for the

RE: [indexeddb] Do we need to support keyPaths with an empty string?

2012-01-18 Thread Israel Hilerio
On Wednesday, January 18, 2012 1:27 PM, ben turner wrote: > On Wed, Jan 18, 2012 at 1:16 PM, Israel Hilerio > wrote: > > > > We did some testing in FF and Chrome and found different behaviors: > > Hi Israel, > > Which version of Firefox did you test with? > > Thanks, > Ben We tested on Firefox

Re: [indexeddb] Do we need to support keyPaths with an empty string?

2012-01-18 Thread ben turner
On Wed, Jan 18, 2012 at 1:16 PM, Israel Hilerio wrote: > > We did some testing in FF and Chrome and found different behaviors: Hi Israel, Which version of Firefox did you test with? Thanks, Ben

RE: [indexeddb] Do we need to support keyPaths with an empty string?

2012-01-18 Thread Israel Hilerio
Joshua, We did some testing in FF and Chrome and found different behaviors: *With keyPath: undefined or null. In this scenario, FF and Chrome fails when executing add("foobar") without a key value. However, Chrome allows you to add a valid key value or an object if you specify a key (

Re: [indexeddb] Do we need to support keyPaths with an empty string?

2012-01-18 Thread Joshua Bell
On Wed, Jan 18, 2012 at 11:30 AM, Israel Hilerio wrote: > On Friday, January 13, 2012 1:33 PM, Israel Hilerio wrote: > > Given the changes that Jonas made to the spec, on which other scenarios > do we > > expect developers to specify a keyPath with an empty string (i.e. > keyPath = "")? > > Do we

RE: [indexeddb] Do we need to support keyPaths with an empty string?

2012-01-18 Thread Israel Hilerio
On Friday, January 13, 2012 1:33 PM, Israel Hilerio wrote: > Given the changes that Jonas made to the spec, on which other scenarios do we > expect developers to specify a keyPath with an empty string (i.e. keyPath = > "")? > Do we still need to support this or can we just throw if this takes plac