I left many comments. Mostly language and clarification requests.
Since there are so many comments the pull request is a bit unreadable. FYI,
you can see a rendered version of the current state here:
https://github.com/asmacdo/pups/blob/google-docstrings/pup-0002.md
Thanks @asmacdo for leading
The "datadir" idea is a good option to have, and I can see how it could
work. That said, it has a couple of drawbacks worth considering.
1) I regularly think about the Principle of Least Surprise, and it applies
well here. Python devs know that python code usually goes in site-packages.
Not
+1 for the pcreech {datadir} plan.
If we go with the pcreech plan, I am -0 on using `pulpproj` for our PyPI
name. If we are not using the PyPI name at import time, then the length
problem [0] no longer exists, and we are abbreviating without a good
reason. I think "pulpproject" would be best,
The Sprint 17 demo is scheduled for Thursday April 13 at 14:00 UTC [0]. If
you've done any of the following as part of Sprint 17, please consider
signing up as a presenter [1].
- Notable feature
- Notable bugfix
- QE update/activity
This sprint demo will be a live community event. Please sign up
PUP 2 [0] is still getting feedback and changing, so we are extending the
vote to April 12 at 9pm UTC [1]. Voting procedure is described in PUP 1. [2]
Comments, nitpicks, and votes are welcome from anyone who is interested!
[0] - https://github.com/pulp/pups/pull/2
[1] - http://bit.ly/2oXOREo
After considering @pcreech's point, +1 installing Pulp in {datadir} and
having it install there using setup.cfg options. In terms of setting the
PYTHONPATH at runtime, it would be best if we could have the Python code do
it itself at startup. As an alternative we could do it with the systemd
