Re: [Pulp-dev] Pulpcore RC5 Release Planning

2019-09-10 Thread David Davis
I started working on an RC5 release but ran out of time today. I'll finish up and release tomorrow first thing. David On Tue, Sep 10, 2019 at 2:00 PM Austin Macdonald wrote: > There was a new feature, but it was missed because it wasn't in the > release notes: https://github.com/pulp/pulpcore-

Re: [Pulp-dev] renaming user facing fields on content serializers

2019-09-10 Thread Brian Bouterse
I also agree with this. As a user, it would feel random to have to specify a field as _artifact or _relative_path when the underscore isn't a well-known convention. +1 to filing an issue and proceeding to fix. It'll be a breaking change so it needs to be declared on the mailing list with the [BREA

Re: [Pulp-dev] Pulpcore RC5 Release Planning

2019-09-10 Thread Austin Macdonald
There was a new feature, but it was missed because it wasn't in the release notes: https://github.com/pulp/pulpcore-plugin/pull/125 The docker plugin is already using the new filter, so a new rc would be helpful. On Tue, Sep 3, 2019 at 12:12 PM Ina Panova wrote: > Thank for clarification, then

[Pulp-dev] [BREAKING] Identifier within sync task progress_reports

2019-09-10 Thread Fabricio Aguiar
On September 13th due to issue #5184 we are gonna have a new attribute on *ProgressReport* for identifying the type of progress report. The new attribute is *code* and it will be required. *Related PRs:* - Add a required field: https://github.com/pulp/pulpcore/pu

Re: [Pulp-dev] renaming user facing fields on content serializers

2019-09-10 Thread David Davis
Matthias, I agree. Can you open an issue? David On Tue, Sep 10, 2019 at 4:39 AM Matthias Dellweg wrote: > TL;DR: Should the fields "_relative_path" and "_artifact" on the > SingleArtifactSerializer be renamed to "relative_path" and "artifact" > respectively? > > While working on the upload cr

[Pulp-dev] renaming user facing fields on content serializers

2019-09-10 Thread Matthias Dellweg
TL;DR: Should the fields "_relative_path" and "_artifact" on the SingleArtifactSerializer be renamed to "relative_path" and "artifact" respectively? While working on the upload create content serializer story [0], i noticed, that there are two fields on the SingleArtifactContentSerializer with unn