Re: [Pulp-dev] [Breaking] Stopping the installer from auto-creating migrations - Sept 3rd

2019-09-04 Thread Mike DePaulo
And from the container image scripts & Dockerfile: https://github.com/pulp/pulpcore/pull/282 *This affects* any plugins using the new plugin-template for container-based CI. On Tue, Sep 3, 2019 at 3:58 PM David Davis wrote: > The step to create migrations has been removed from the installer: >

Re: [Pulp-dev] [Breaking] Stopping the installer from auto-creating migrations - Sept 3rd

2019-09-03 Thread David Davis
The step to create migrations has been removed from the installer: https://github.com/pulp/ansible-pulp/pull/144 David On Tue, Aug 27, 2019 at 3:31 PM Mike DePaulo wrote: > Yes, just create a pulpcore PR that removes the makemigrations line, as > well as the line above it. > (Honestly, commen

Re: [Pulp-dev] [Breaking] Stopping the installer from auto-creating migrations - Sept 3rd

2019-08-27 Thread Mike DePaulo
Yes, just create a pulpcore PR that removes the makemigrations line, as well as the line above it. (Honestly, comment the line above it out. We may want the list of plugins in the future.) On Tue, Aug 27, 2019 at 3:14 PM Brian Bouterse wrote: > > > On Tue, Aug 27, 2019 at 3:04 PM Mike DePaulo >

Re: [Pulp-dev] [Breaking] Stopping the installer from auto-creating migrations - Sept 3rd

2019-08-27 Thread Brian Bouterse
On Tue, Aug 27, 2019 at 3:04 PM Mike DePaulo wrote: > Note that we makemigrations & migrate at pulp-api container start > time. And all the containers (e.g., pulp-content) wait on the pulp-api > container to do them: > > https://github.com/pulp/pulpcore/blob/master/containers/images/pulp/containe

Re: [Pulp-dev] [Breaking] Stopping the installer from auto-creating migrations - Sept 3rd

2019-08-27 Thread Mike DePaulo
Note that we makemigrations & migrate at pulp-api container start time. And all the containers (e.g., pulp-content) wait on the pulp-api container to do them: https://github.com/pulp/pulpcore/blob/master/containers/images/pulp/container-assets/pulp-api#L11 Once I took over the containers, I envisi

Re: [Pulp-dev] [Breaking] Stopping the installer from auto-creating migrations - Sept 3rd

2019-08-27 Thread Brian Bouterse
Excellent and good catch on the duplicate already on sprint. Yes let's use 5321 as you suggest. I added to that issue that this was announced and scheduled for Sept 3rd. If it's still at NEW on the 3rd, I have a reminder to make a PR and merge on that day. Otherwise anyone can make a PR ahead of t

Re: [Pulp-dev] [Breaking] Stopping the installer from auto-creating migrations - Sept 3rd

2019-08-27 Thread Austin Macdonald
This all sounds good to me. FYI, I closed https://pulp.plan.io/issues/5361 as a dupe since https://pulp.plan.io/issues/5321 has already been added to the sprint. Feel free to use 5361 and close 5321 if you prefer. On Tue, Aug 27, 2019 at 2:16 PM Brian Bouterse wrote: > tl;dr if we make this chan

[Pulp-dev] [Breaking] Stopping the installer from auto-creating migrations - Sept 3rd

2019-08-27 Thread Brian Bouterse
tl;dr if we make this change on Sept 3rd, the installer won't auto-create migrations anymore. For every change needing a migration, please commit one. # Background We enabled the installer to "auto-create" migrations as a solution to the problem of them changing a crazy amount early on in Pulp3's