No problem! Thanks for fixing it.
David
On Wed, Jan 6, 2021 at 8:22 AM Tanya Tereshchenko
wrote:
> I went through the list of repos from this thread and pulp 3 related
> branches and unset the up-to-date check where it was set.
> Thanks for noticing and pointing out the problem.
>
> Tanya
>
>
I went through the list of repos from this thread and pulp 3 related
branches and unset the up-to-date check where it was set.
Thanks for noticing and pointing out the problem.
Tanya
On Wed, Jan 6, 2021 at 12:58 PM Tanya Tereshchenko
wrote:
> Interesting, I didn't notice that.
> In any case, I
Interesting, I didn't notice that.
In any case, I didn't enable it on purpose. Moreover, some repos were
updated already, so maybe David is right that it's a default.
Let's turn it off.
On Wed, Jan 6, 2021 at 12:12 PM Matthias Dellweg
wrote:
> I noticed this too. Somehow i used the wrong channel
I noticed this too. Somehow i used the wrong channel to ask about it.
Anyway, i think this is breaking any considerable collaboration approach,
because every single PR must be refreshed immediately before merging. This
will put off external contributors.
On Tue, Jan 5, 2021 at 10:42 PM David Davis
I noticed for the repos that got updated, PRs must now be up to date before
merging. I think we previously had this disabled but I am guessing it got
enabled since it's the default when required status checks are enabled?
David
On Fri, Dec 11, 2020 at 7:26 AM Tanya Tereshchenko
wrote:
> FYI, I
Thanks Tanya!
Regards,
Ina Panova
Senior Software Engineer| Pulp| Red Hat Inc.
"Do not go where the path may lead,
go instead where there is no path and leave a trail."
On Fri, Dec 11, 2020 at 1:26 PM Tanya Tereshchenko
wrote:
> FYI, I went through the following repos and enabled
FYI, I went through the following repos and enabled required checks (lint,
test(pulp), test(docs), and test(s3)) where they were missing, for the
master and for the release branches if such rules existed:
- pulpcore
- pulp_file
- pulp_rpm
- pulp_container
- pulp_ansible
- pulp_python
- pulp_
When we stopped using Travis, I disabled the required status checks in
Github for pull requests. To re-enable these required status checks, visit
the branch protection settings page for your plugin's repo. Configure a
branch protection rule and there should be a setting to require status
checks.
D
