[pulseaudio-discuss] [PATCH] resampler: Some minor tweaks

2011-11-28 Thread Maarten Bosmans
that were forgotten in the previous peaks resampler commits. --- src/pulsecore/resampler.c | 18 -- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a/src/pulsecore/resampler.c b/src/pulsecore/resampler.c index dda6a2f..3cee06f 100644 --- a/src/pulsecore/resampler.c

Re: [pulseaudio-discuss] [PATCH 8/8] Improve performance of peaks resampler

2011-11-28 Thread Maarten Bosmans
2011/11/27 Colin Guthrie : > 'Twas brillig, and Maarten Bosmans at 02/11/11 20:54 did gyre and gimble: >> This is mainly achieved by special-casing the common 1ch float case, >> which is used by applications such as pavucontrol. > > OK, I pushed this and the previous patch too. > > I didn't check t

Re: [pulseaudio-discuss] [PATCH] resampler: Some minor tweaks

2011-11-28 Thread Colin Guthrie
'Twas brillig, and Maarten Bosmans at 28/11/11 09:36 did gyre and gimble: > that were forgotten in the previous peaks resampler commits. Damn, sorry, thought I'd gotten them all :( My mailbox is still in a mess after they were all suddenly marked as unread due to Thunderbird generally cocking up.

Re: [pulseaudio-discuss] [PATCH 8/8] Improve performance of peaks resampler

2011-11-28 Thread Colin Guthrie
'Twas brillig, and Maarten Bosmans at 28/11/11 09:45 did gyre and gimble: > 2011/11/27 Colin Guthrie : >> 'Twas brillig, and Maarten Bosmans at 02/11/11 20:54 did gyre and gimble: >>> This is mainly achieved by special-casing the common 1ch float case, >>> which is used by applications such as pavu

Re: [pulseaudio-discuss] [PATCH 2/8] build-sys: Remove check for alloca()

2011-11-28 Thread Colin Guthrie
'Twas brillig, and Arun Raghavan at 14/11/11 05:28 did gyre and gimble: > On Wed, 2011-11-02 at 21:54 +0100, Maarten Bosmans wrote: >> As it isn't used anymore. >> Also, some minor cleanup. > Please break up patches into related changes only. I know that it's a > lot of small changes, but this sor

Re: [pulseaudio-discuss] RFC: Routing and Priority lists

2011-11-28 Thread Janos Kovacs
Hi, I apologize for the slow reaction. > I liked the "my idea was that we would use quite static priority lists > what would change only if you get an external event" part, but the "like > incoming call" example ruined it :) Why should an incoming call affect > any routing priority lists? When an

Re: [pulseaudio-discuss] RFC: Routing and Priority lists

2011-11-28 Thread Xavier Bestel
On Mon, 2011-11-28 at 16:07 +0200, Janos Kovacs wrote: > Voice guided navigation should never be routed to the earpiece (the > built-in mono speaker) because if you would listen you would not able > to see the map. And that's how I use navigation when I'm biking. Xav ___

Re: [pulseaudio-discuss] [PATCH 2/8] build-sys: Remove check for alloca()

2011-11-28 Thread Maarten Bosmans
2011/11/28 Colin Guthrie : > 'Twas brillig, and Arun Raghavan at 14/11/11 05:28 did gyre and gimble: >> On Wed, 2011-11-02 at 21:54 +0100, Maarten Bosmans wrote: >>> As it isn't used anymore. >>> Also, some minor cleanup. > >> Please break up patches into related changes only. I know that it's a >>

Re: [pulseaudio-discuss] RFC: Routing and Priority lists

2011-11-28 Thread Tanu Kaskinen
On Mon, 2011-11-28 at 16:07 +0200, Janos Kovacs wrote: > > I liked the "my idea was that we would use quite static priority lists > > what would change only if you get an external event" part, but the "like > > incoming call" example ruined it :) Why should an incoming call affect > > any routing p

Re: [pulseaudio-discuss] RFC: Routing and Priority lists

2011-11-28 Thread Janos Kovacs
Hi, >> In some cases we might have multiple zones, e.g a desktop PC >> were in one room and a stereo amplifier would be in another >> connected via  S/PDIF.  Say you want to do the usual stuff and >> see youtube videos in one room, while playing out music to the >> other room. > Overall I think i

[pulseaudio-discuss] echo-cancel test program: fix memory leak

2011-11-28 Thread Peter Meerwald
echo-cancel test program: fix memory leak memory for pa_echo_canceller is allocated in init_common() a second time, hence the allocated memory in main() is leaked diff --git a/src/modules/echo-cancel/module-echo-cancel.c b/src/modules/echo-cancel/module-echo-cancel.c index 1fad12a..8bf6670

Re: [pulseaudio-discuss] echo-cancel test program: fix memory leak

2011-11-28 Thread Arun Raghavan
On Mon, 2011-11-28 at 16:14 +0100, Peter Meerwald wrote: > echo-cancel test program: fix memory leak > > memory for pa_echo_canceller is allocated in init_common() a second time, > hence the allocated memory in main() is leaked Pulled to my tree, thanks! -- Arun