Re: [pulseaudio-discuss] [PATCH] add module-virtual-surround-sink

2012-02-23 Thread Tanu Kaskinen
On Fri, 2012-02-17 at 15:56 +0100, Niels Ole Salscheider wrote: I'd put this variable inside the innermost if, because it's not used elsewhere in this function. I think that is not allowed in C89/C90... I think C89 allows variable declarations at the beginning of any block. And even if it

Re: [pulseaudio-discuss] [PATCH] add module-virtual-surround-sink

2012-02-23 Thread Niels Ole Salscheider
Hello, One question about the processing: does it add any latency? That depends on the impulse response. In general, the current output sample is a weighted sum of the current input sample and some preceding. Provided that the first values of the impulse response are not equal (or

Re: [pulseaudio-discuss] [PATCH] UCM patches on ubuntu 1:1.1-0ubuntu4

2012-02-23 Thread David Henningsson
On 02/21/2012 04:34 AM, Feng Wei wrote: Hi Arun, I'm not clear what should I do to upstream patches. I tested them on ubuntu, so that I must follow what David had done in port structure. In my original mind, I will first upstream to ubuntu, then pulseaudio community. My current patches are

Re: [pulseaudio-discuss] [PATCH] UCM patches on ubuntu 1:1.1-0ubuntu4

2012-02-23 Thread Feng Wei
Hi David, I'm appreciated for your comments. UCM really has a long way to go. 2012/2/24 David Henningsson david.hennings...@canonical.com: On 02/21/2012 04:34 AM, Feng Wei wrote: Hi Arun, I'm not clear what should I do to upstream patches. I tested them on ubuntu, so that I must follow what