Re: [pulseaudio-discuss] [PATCH] loopback: Fix crash if Max Request change at unload

2012-03-23 Thread Tanu Kaskinen
On Fri, 2012-03-23 at 16:19 +0100, David Henningsson wrote: > On 03/23/2012 02:47 PM, Dalleau, Frederic wrote: > > Hi David, > > > >> For reference, the stack trace is here: > >> > >> https://bugs.launchpad.net/bugs/946400 > > > > It is likely that the issues related : here is the backtrace I got >

Re: [pulseaudio-discuss] Trying to update translations

2012-03-23 Thread Rémi Denis-Courmont
Hej David, Le vendredi 23 mars 2012 17:50:01 David Henningsson, vous avez écrit : > So I tried to update the Swedish translation, and it feels like things > are not that great. > > First and foremost, a lot of entries are marked "fuzzy". In 90% of the > cases, these are plain wrong and ar

[pulseaudio-discuss] Trying to update translations

2012-03-23 Thread David Henningsson
So I tried to update the Swedish translation, and it feels like things are not that great. First and foremost, a lot of entries are marked "fuzzy". In 90% of the cases, these are plain wrong and are better left without translation at all. Example: #: ../src/utils/pacmd.c:184 #, fuzzy, c-form

Re: [pulseaudio-discuss] [PATCH] loopback: Fix crash if Max Request change at unload

2012-03-23 Thread David Henningsson
On 03/23/2012 02:47 PM, Dalleau, Frederic wrote: Hi David, For reference, the stack trace is here: https://bugs.launchpad.net/bugs/946400 It is likely that the issues related : here is the backtrace I got after applying your patch (without mine) #0 0xb7e9b520 in adjust_rates (u=0x80b3668)

Re: [pulseaudio-discuss] [PATCH] loopback: Fix crash if Max Request change at unload

2012-03-23 Thread Tanu Kaskinen
On Fri, 2012-03-16 at 08:25 +0200, Tanu Kaskinen wrote: > On Fri, 2012-02-10 at 17:39 +0100, Frédéric Dalleau wrote: > > Module-bluetooth-policy can load and unload module-loopback on demand. > > Sometimes if there is an error, module-loopback can be unloaded early. > > When module-loopback is load

Re: [pulseaudio-discuss] [PATCH] loopback: Fix crash if Max Request change at unload

2012-03-23 Thread Dalleau, Frederic
Hi David, > No, I just saw the crash report on launchpad and tried to figure out the > likely cause for it. The person in question had combined module-null-sink > with module-loopback and got a segfault from sink_input_update_max_request > calling adjust_rates with a null u->source. It is likely

Re: [pulseaudio-discuss] [PATCH] qpaeq: Try to load equalizer module before failing, better error messages

2012-03-23 Thread Colin Guthrie
'Twas brillig, and Matěj Laitl at 19/03/12 21:44 did gyre and gimble: > This fixes bug 38728 [1]. When equalizer features are unavailable in running > pulseaudio daemon, try to load relevant module. If this fails, following error > is printed on stderr instead of a confusing traceback: > > It seem

Re: [pulseaudio-discuss] [PATCH] sample-util: Remove redundant check from pa_volume_memchunk.

2012-03-23 Thread Colin Guthrie
'Twas brillig, and Tanu Kaskinen at 23/03/12 09:01 did gyre and gimble: > Add also an assertion for the sample spec validity. The > existing code already does crash in case of an invalid > sample spec, but the error would not be as obvious: the > crash would happen due to a divide-by-zero operation

Re: [pulseaudio-discuss] [PATCH] dbus: Fix device latency querying.

2012-03-23 Thread Colin Guthrie
'Twas brillig, and Tanu Kaskinen at 23/03/12 07:59 did gyre and gimble: > --- > src/modules/dbus/iface-device.c | 10 +++--- > 1 files changed, 7 insertions(+), 3 deletions(-) ACK... And please ignore my reply to the earlier email. Seems I'm as bad at out-of-order email reading as I am at

Re: [pulseaudio-discuss] [PATCH] dbus: Remove a silly return statement.

2012-03-23 Thread Colin Guthrie
'Twas brillig, and Tanu Kaskinen at 23/03/12 07:49 did gyre and gimble: > On Fri, 2012-03-23 at 09:46 +0200, Tanu Kaskinen wrote: >> --- >> src/modules/dbus/iface-device.c |1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) >> >> diff --git a/src/modules/dbus/iface-device.c >> b/src/mod

Re: [pulseaudio-discuss] [PATCH] padsp: Fix a double-free bug.

2012-03-23 Thread Colin Guthrie
'Twas brillig, and Tanu Kaskinen at 23/03/12 08:11 did gyre and gimble: > --- > src/utils/padsp.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/src/utils/padsp.c b/src/utils/padsp.c > index a8bc8d2..f6a3520 100644 > --- a/src/utils/padsp.c > +++ b/src/utils/padsp.c

Re: [pulseaudio-discuss] [PATCH] device-manager: Fix a memory leak.

2012-03-23 Thread Colin Guthrie
'Twas brillig, and Tanu Kaskinen at 23/03/12 09:36 did gyre and gimble: > --- > src/modules/module-device-manager.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/src/modules/module-device-manager.c > b/src/modules/module-device-manager.c > index d7f30c6..2ce4c78

Re: [pulseaudio-discuss] [PATCH] fix compilation warning via PRI prefix

2012-03-23 Thread David Henningsson
On 03/22/2012 02:52 PM, Deng Zhenrong wrote: modules/alsa/alsa-mixer.c:3110:21: warning: format '%lx' expects argument of type 'long unsigned int', but argument 7 has type 'pa_channel_position_mask_t' [-Wformat] modules/alsa/alsa-mixer.c:3110:21: warning: format '%lx' expects argument

[pulseaudio-discuss] [PATCH] device-manager: Fix a memory leak.

2012-03-23 Thread Tanu Kaskinen
--- src/modules/module-device-manager.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/modules/module-device-manager.c b/src/modules/module-device-manager.c index d7f30c6..2ce4c78 100644 --- a/src/modules/module-device-manager.c +++ b/src/modules/module-device-manag

[pulseaudio-discuss] [PATCH] sample-util: Remove redundant check from pa_volume_memchunk.

2012-03-23 Thread Tanu Kaskinen
Add also an assertion for the sample spec validity. The existing code already does crash in case of an invalid sample spec, but the error would not be as obvious: the crash would happen due to a divide-by-zero operation in pa_frame_aligned(). --- src/pulsecore/sample-util.c |6 +- 1 files

[pulseaudio-discuss] [PATCH] padsp: Fix a double-free bug.

2012-03-23 Thread Tanu Kaskinen
--- src/utils/padsp.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/utils/padsp.c b/src/utils/padsp.c index a8bc8d2..f6a3520 100644 --- a/src/utils/padsp.c +++ b/src/utils/padsp.c @@ -1444,6 +1444,7 @@ static int sndstat_open(int flags, int *_errno) { unlink(f

[pulseaudio-discuss] [PATCH] dbus: Fix device latency querying.

2012-03-23 Thread Tanu Kaskinen
--- src/modules/dbus/iface-device.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/modules/dbus/iface-device.c b/src/modules/dbus/iface-device.c index df64d36..a5af730 100644 --- a/src/modules/dbus/iface-device.c +++ b/src/modules/dbus/iface-device.c @@ -598,

Re: [pulseaudio-discuss] [PATCH] dbus: Remove a silly return statement.

2012-03-23 Thread Tanu Kaskinen
On Fri, 2012-03-23 at 09:46 +0200, Tanu Kaskinen wrote: > --- > src/modules/dbus/iface-device.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/src/modules/dbus/iface-device.c b/src/modules/dbus/iface-device.c > index df64d36..97ccd91 100644 > --- a/src/modules/dbus/

[pulseaudio-discuss] [PATCH] dbus: Remove a silly return statement.

2012-03-23 Thread Tanu Kaskinen
--- src/modules/dbus/iface-device.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/modules/dbus/iface-device.c b/src/modules/dbus/iface-device.c index df64d36..97ccd91 100644 --- a/src/modules/dbus/iface-device.c +++ b/src/modules/dbus/iface-device.c @@ -604,7 +604,6

Re: [pulseaudio-discuss] no output from pulseaudio on embedded arm platform

2012-03-23 Thread Arun Raghavan
On Fri, 2012-03-23 at 07:30 +0100, Jan Pohanka wrote: > Hello, > > thank you for the answers. I have pulseaudio working now. The last thing > I'm not sure about is how to handle its memory requirements. > > > PulseAudio tries to allocate 64MB per default I think, maybe too much; > > can > > b