Re: [pulseaudio-discuss] [PATCH] rtsp-client: Fix rtp_port reading.

2012-03-29 Thread David Henningsson
On 03/29/2012 03:03 PM, Tanu Kaskinen wrote: pa_atou() return value was not checked, and the cast of a 16-bit variable pointer to a 32-bit variable pointer could corrupt cseq. Good catch. Ack. --- src/modules/rtp/rtsp_client.c | 12 ++-- 1 files changed, 10 insertions(+), 2 delet

Re: [pulseaudio-discuss] [PATCH] pasuspender: Check pa_context_connect() return value.

2012-03-29 Thread Tanu Kaskinen
On Thu, 2012-03-29 at 23:14 +0200, David Henningsson wrote: > On 03/29/2012 11:18 AM, Tanu Kaskinen wrote: > > --- > > src/utils/pasuspender.c |6 +- > > 1 files changed, 5 insertions(+), 1 deletions(-) > > > > diff --git a/src/utils/pasuspender.c b/src/utils/pasuspender.c > > index 0a60

Re: [pulseaudio-discuss] more thoughts about my GSoC plan

2012-03-29 Thread Arun Raghavan
On Sun, 2012-03-25 at 20:51 +0800, rong deng wrote: > Hi all, > > > I would like to apply for logging/testing project. Here's my attempt > to write more about my thoughts on how this should be done: > > > First about logging: > > > 1. pulseaudio has already had some support for log level, but

Re: [pulseaudio-discuss] [PATCH] use CLOCK_MONOTONIC_COARSE to reduce the system call

2012-03-29 Thread Arun Raghavan
Hi, On Thu, 2012-03-29 at 21:31 +0800, Deng Zhenrong wrote: > According to the description below: > > http://lkml.org/lkml/2009/7/17/258 > > There are two benefits: > a) it doesn't need to access the hardware. > b) avoid the syscall by using vdso clock_gettime(). > > The cons is the CLO

Re: [pulseaudio-discuss] [PATCH] use CLOCK_MONOTONIC_COARSE to reduce the system call

2012-03-29 Thread Pierre-Louis Bossart
On 3/29/2012 8:31 AM, Deng Zhenrong wrote: According to the description below: http://lkml.org/lkml/2009/7/17/258 There are two benefits: a) it doesn't need to access the hardware. b) avoid the syscall by using vdso clock_gettime(). The cons is the CLOCK_MONOTONIC_COARSE returns the t

Re: [pulseaudio-discuss] [PATCH] pasuspender: Check pa_context_connect() return value.

2012-03-29 Thread David Henningsson
On 03/29/2012 11:18 AM, Tanu Kaskinen wrote: --- src/utils/pasuspender.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/utils/pasuspender.c b/src/utils/pasuspender.c index 0a60923..ac764d2 100644 --- a/src/utils/pasuspender.c +++ b/src/utils/pasuspender.c @@

Re: [pulseaudio-discuss] NVidia HDMI output

2012-03-29 Thread Julian Sikorski
W dniu 2011-06-07 19:25, Colin Guthrie pisze: 'Twas brillig, and Stephen Warren at 07/06/11 17:47 did gyre and gimble: Paul Menzel wrote at Tuesday, June 07, 2011 9:17 AM: Am Dienstag, den 07.06.2011, 17:38 +0300 schrieb Lasse Kärkkäinen: The NVidia HDMI ALSA device, present on recent hardware

[pulseaudio-discuss] [PATCH] use CLOCK_MONOTONIC_COARSE to reduce the system call

2012-03-29 Thread Deng Zhenrong
According to the description below: http://lkml.org/lkml/2009/7/17/258 There are two benefits: a) it doesn't need to access the hardware. b) avoid the syscall by using vdso clock_gettime(). The cons is the CLOCK_MONOTONIC_COARSE returns the time at the last tick. Signed-off-by: Deng Zhe

[pulseaudio-discuss] [PATCH] rtsp-client: Fix rtp_port reading.

2012-03-29 Thread Tanu Kaskinen
pa_atou() return value was not checked, and the cast of a 16-bit variable pointer to a 32-bit variable pointer could corrupt cseq. --- src/modules/rtp/rtsp_client.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/modules/rtp/rtsp_client.c b/src/modules/rtp/

[pulseaudio-discuss] [PATCH] Fix pa_parse_boolean() return value checking.

2012-03-29 Thread Tanu Kaskinen
pa_parse_boolean() return value shouldn't be stored in pa_bool_t, because 1 and -1 need to be distinguished. --- src/daemon/cmdline.c| 37 + src/pulsecore/cli-command.c |4 ++-- src/utils/pactl.c | 18 -- 3 files changed

[pulseaudio-discuss] [PATCH] pasuspender: Check pa_context_connect() return value.

2012-03-29 Thread Tanu Kaskinen
--- src/utils/pasuspender.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/utils/pasuspender.c b/src/utils/pasuspender.c index 0a60923..ac764d2 100644 --- a/src/utils/pasuspender.c +++ b/src/utils/pasuspender.c @@ -292,7 +292,11 @@ int main(int argc, char *argv[]

[pulseaudio-discuss] [PATCH] rtp: Get rid of an "unitialized value" warning from Coverity.

2012-03-29 Thread Tanu Kaskinen
Coverity warned that r was possibly being used without initialization. The fix is to add pa_assert_not_reached() to handle the case where the address family is invalid. I also felt that using switch would be more appropriate here than using ifs and else-ifs, which makes this patch a bit larger. I a