[pulseaudio-discuss] [PATCH] add set-log-target command for pacmd

2012-05-24 Thread rong deng
Please review! This helps to change log target on the fly. 0001-add-set-log-target-command-for-pacmd.patch Description: Binary data ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listin

[pulseaudio-discuss] [PATCH] use pa_streq instead of plain strcmp in daemon-conf.c

2012-05-24 Thread rong deng
Please review and hopefully got accepted. :) I did a simple grep and saw there are lots of other usages of strcmp, but let's translate it bit by bit... --deng 0001-use-pa_streq-instead-of-plain-strcmp.patch Description: Binary data ___ pulseaudio-disc

[pulseaudio-discuss] VLC + pulseaudio issues

2012-05-24 Thread Drew
I've been trying to figure out a problem I'm having with continuous dopplering of VLC when using pulseaudio for sound. There is no dopplering with use of pure ALSA output. I'd greatly appreciate any assistance as I've been unable to resolve this on my own after extensive google digging. Here's t

Re: [pulseaudio-discuss] User volume vs. Application volume

2012-05-24 Thread Andrew Eikum
On Thu, May 24, 2012 at 06:33:43PM +0300, Tanu Kaskinen wrote: > I agree that Pulseaudio should provide facilities for fading. We could > insist that applications do such processing themselves (like is > currently required), but the problem is that it's a non-trivial thing > with large buffers when

[pulseaudio-discuss] [PATCH 1/2] module-pipe: whitespace and log output cleanup

2012-05-24 Thread Peter Meerwald
From: Peter Meerwald --- src/modules/module-pipe-sink.c |4 ++-- src/modules/module-pipe-source.c | 10 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/modules/module-pipe-sink.c b/src/modules/module-pipe-sink.c index 91e01f9..fa0a080 100644 --- a/src/module

[pulseaudio-discuss] [PATCH 2/2] module-pipe: check return value of mkfifo()

2012-05-24 Thread Peter Meerwald
From: Peter Meerwald --- src/modules/module-pipe-sink.c |5 - src/modules/module-pipe-source.c |5 - 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/modules/module-pipe-sink.c b/src/modules/module-pipe-sink.c index fa0a080..ef18fad 100644 --- a/src/modules/mo

[pulseaudio-discuss] module-pipe-source,sink

2012-05-24 Thread Peter Meerwald
Hello, I have a couple of issues with module-pipe: 1. module-pipe-source and module-pipe-sink do not check the return value ofmkfifo(), hence PulseAudio happily opens the same pipe several times I think PulseAudio should check if mkfifo() fails to create the FIFO file and abort -- see suggeste

Re: [pulseaudio-discuss] User volume vs. Application volume

2012-05-24 Thread Tanu Kaskinen
On Thu, 2012-05-24 at 09:28 -0500, Andrew Eikum wrote: > Hi folks, > > I've been thinking about this issue for a while and I'd like to share > my thoughts and receive opinions back. > > While developing a PulseAudio driver for Wine, I ran into the issue of > implementing the volume control interf

[pulseaudio-discuss] User volume vs. Application volume

2012-05-24 Thread Andrew Eikum
Hi folks, I've been thinking about this issue for a while and I'd like to share my thoughts and receive opinions back. While developing a PulseAudio driver for Wine, I ran into the issue of implementing the volume control interfaces. Microsoft's APIs allow the application to make calls that set t

[pulseaudio-discuss] [PATCH] add log category

2012-05-24 Thread Deng Zhengrong
--- src/modules/module-loopback.c |5 ++ src/pulse/channelmap.c |2 + src/pulse/client-conf.c|2 + src/pulse/context.c|2 + src/pulse/ext-device-manager.c |2 + src/pulse/ext-device-restore.c |2 + src/pulse/ext-stream-restore.c |2 + src/pu

Re: [pulseaudio-discuss] About My Blog Space

2012-05-24 Thread rong deng
2012/5/22 Colin Guthrie > If you would like a little face icon to go with your posts (e.g. see > what Arun's posts look like) please email me a suitable png file. Size > isn't too important but about 80x100px is probably about right. > > OK. I'll send you one if I find a suitable one. > Also, I

Re: [pulseaudio-discuss] [PATCH 2/2] core: Add debug prints for state changes in sinks and sink-inputs.

2012-05-24 Thread David Henningsson
On 05/24/2012 12:43 PM, Jarkko Suontausta wrote: --- src/pulsecore/sink-input.c |5 + src/pulsecore/sink.c |6 ++ 2 files changed, 11 insertions(+), 0 deletions(-) In general I think this is a good idea, but I'm missing corresponding changes to sources and source outp

Re: [pulseaudio-discuss] [PATCH 2/2] modules, pulse, core: React to failing pa_memblockq_push calls.

2012-05-24 Thread David Henningsson
On 05/24/2012 09:38 AM, Jarkko Suontausta wrote: This adds an assertion to pa_memblockq_push() and pa_memblockq_push_align() calls, the return value of which was mostly ignored in the core and modules. The calls return a negative value in case the maximum memblock queue size would be exceeded. T

[pulseaudio-discuss] [PATCH 2/2] core: Add debug prints for state changes in sinks and sink-inputs.

2012-05-24 Thread Jarkko Suontausta
--- src/pulsecore/sink-input.c |5 + src/pulsecore/sink.c |6 ++ 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/src/pulsecore/sink-input.c b/src/pulsecore/sink-input.c index f6f93b8..a45cc8c 100644 --- a/src/pulsecore/sink-input.c +++ b/src/pulsecore/sink-inp

[pulseaudio-discuss] [PATCH 1/2] core: Add functions that return the logical name of the state of sinks and sink inputs.

2012-05-24 Thread Jarkko Suontausta
--- src/pulsecore/sink-input.h | 12 src/pulsecore/sink.h | 13 + 2 files changed, 25 insertions(+), 0 deletions(-) diff --git a/src/pulsecore/sink-input.h b/src/pulsecore/sink-input.h index af2177a..e46c77c 100644 --- a/src/pulsecore/sink-input.h +++ b/src/puls

[pulseaudio-discuss] [PATCH 0/2] core: Add debug prints for state changes in sinks and sink-inputs.

2012-05-24 Thread Jarkko Suontausta
These two patches add state change debug prints to sinks and sink-inputs. Jarkko Suontausta (2): core: Add functions that return the logical name of the state of sinks and sink inputs. core: Add debug prints for state changes in sinks and sink-inputs. src/pulsecore/sink-input.c |5 ++

Re: [pulseaudio-discuss] [PATCH 0/3] Unloading modules by name

2012-05-24 Thread David Henningsson
On 05/22/2012 06:06 PM, poljar wrote: A new function was added to module.c to handle unload requests by name. The native protocol was extended and a new opcode was introduced, and finally pactl was extended to make use of the new functionality. I gave them a quick read through and they all look

Re: [pulseaudio-discuss] [PATCH 0/2] modules, pulse, core: React to failing pa_memblockq_push calls.

2012-05-24 Thread Tanu Kaskinen
On Thu, 2012-05-24 at 10:52 +0300, Tanu Kaskinen wrote: > On Thu, 2012-05-24 at 10:38 +0300, Jarkko Suontausta wrote: > > Based on Coverity findings, the return values of pa_memblockq_push and > > pa_memblockq_push_align calls were not taken into account. These patches > > are addressing many of th

Re: [pulseaudio-discuss] Is it OK for PulseAudio to crash when BlueZ is buggy?

2012-05-24 Thread Tanu Kaskinen
On Thu, 2012-05-24 at 11:29 +0300, Luiz Augusto von Dentz wrote: > Hi Tanu, > > On Wed, May 23, 2012 at 4:11 PM, Tanu Kaskinen > wrote: > > On Wed, 2012-05-23 at 12:20 +0300, Luiz Augusto von Dentz wrote: > >> Btw, are you sure this is a problem? We can have the same address in > >> different de

Re: [pulseaudio-discuss] Is it OK for PulseAudio to crash when BlueZ is buggy?

2012-05-24 Thread Luiz Augusto von Dentz
Hi Tanu, On Wed, May 23, 2012 at 4:11 PM, Tanu Kaskinen wrote: > On Wed, 2012-05-23 at 12:20 +0300, Luiz Augusto von Dentz wrote: >> Btw, are you sure this is a problem? We can have the same address in >> different devices if they are paired with different adapters, >> otherwise it is a bug and w

Re: [pulseaudio-discuss] [PATCH 0/2] modules, pulse, core: React to failing pa_memblockq_push calls.

2012-05-24 Thread Tanu Kaskinen
On Thu, 2012-05-24 at 10:38 +0300, Jarkko Suontausta wrote: > Based on Coverity findings, the return values of pa_memblockq_push and > pa_memblockq_push_align calls were not taken into account. These patches > are addressing many of those cases by adding an assertion. > > Thanks to a thorough revi

[pulseaudio-discuss] [PATCH 2/2] modules, pulse, core: React to failing pa_memblockq_push calls.

2012-05-24 Thread Jarkko Suontausta
This adds an assertion to pa_memblockq_push() and pa_memblockq_push_align() calls, the return value of which was mostly ignored in the core and modules. The calls return a negative value in case the maximum memblock queue size would be exceeded. The maximum queue sizes are currently set to be at l

[pulseaudio-discuss] [PATCH 1/2] core: Assert on memchunk divisibility by sample spec in pa_memblockq_push().

2012-05-24 Thread Jarkko Suontausta
Earlier, -1 was returned if the memchunk size was not a multiple of the frame size. Now, it is verified unconditionally through an assertion. Error code -1 is still returned when the memblock queue is full. In those few cases where the return value of pa_memblockq_push() is checked, an overflow is

[pulseaudio-discuss] [PATCH 0/2] modules, pulse, core: React to failing pa_memblockq_push calls.

2012-05-24 Thread Jarkko Suontausta
Based on Coverity findings, the return values of pa_memblockq_push and pa_memblockq_push_align calls were not taken into account. These patches are addressing many of those cases by adding an assertion. Thanks to a thorough review of the first version, Tanu is already familiar with the patches. He

[pulseaudio-discuss] PulseAudio with mutiple users and MPD

2012-05-24 Thread Stefan Monnier
I'm trying to understand how PulseAudio is supposed to work in my situation but I think I need some help: Basically my workstation is shared between 3 users who are always logged in (tho on different virtual consoles). Additionally, they all share a single (system-wide) MPD daemon to play the musi