Re: [pulseaudio-discuss] [PATCH PA1.1 1/2] alsa-sink: add missing header

2012-05-30 Thread eero . nurkkala
Quoting Paul Menzel : #include +#include Is sorting headers in these blocks useful? Hi, I missed the point about sorting - would you rather want the signal.h on top of stdio.h maybe? #include It would be great if you could resend as [PATCH v2]. You could also make the commit summar

Re: [pulseaudio-discuss] [PATCH v3 1/2] loopback: Enable routing on loopback streams

2012-05-30 Thread Dalleau, Frederic
Hi Tanu, On Wed, May 30, 2012 at 6:06 PM, Tanu Kaskinen wrote: > Ok. Given what I wrote in the previous mail (i.e. you don't need to > modify pa_sink_input_new(), you only need to initialize the sample spec > to be valid to avoid the assertion crash), do you agree that it still > makes sense to

Re: [pulseaudio-discuss] [PATCH PA1.1 1/2] alsa-sink: add missing header

2012-05-30 Thread Paul Menzel
Dear Eero, thank you for you patch. Am Donnerstag, den 31.05.2012, 07:57 +0300 schrieb eero.nurkk...@offcode.fi: > From: Eero Nurkkala > > Compilation with -DDEBUG_TIMING fails due to a missing header: > > modules/alsa/alsa-sink.c: In function 'check_left_to_play': > modules/alsa/alsa-sink.c:

[pulseaudio-discuss] [PATCH PA1.1 2/2] alsa-source: add missing header

2012-05-30 Thread eero . nurkkala
From: Eero Nurkkala Compilation with -DDEBUG_TIMING fails due to a missing header: modules/alsa/alsa-source.c: In function 'check_left_to_record': modules/alsa/alsa-source.c:426:9: warning: implicit declaration of function 'raise' [-Wimplicit-function-declaration] modules/alsa/alsa-source.c:426

[pulseaudio-discuss] [PATCH PA1.1 1/2] alsa-sink: add missing header

2012-05-30 Thread eero . nurkkala
From: Eero Nurkkala Compilation with -DDEBUG_TIMING fails due to a missing header: modules/alsa/alsa-sink.c: In function 'check_left_to_play': modules/alsa/alsa-sink.c:453:9: warning: implicit declaration of function 'raise' [-Wimplicit-function-declaration] modules/alsa/alsa-sink.c:453:9: error

Re: [pulseaudio-discuss] pulseaudio-discuss Digest, Vol 13, Issue 46

2012-05-30 Thread Rémi Denis-Courmont
Le lundi 28 mai 2012 22:34:32 Drew, vous avez écrit : > On Mon, May 28, 2012 at 3:00 PM, > wrote: > > The log just shows that the latency estimation that PulseAudio provides > > to VLC are unstable, showing a steep increase at nominal playback speed. > > If it keeps on happening all the time, some

Re: [pulseaudio-discuss] Internal Mics and Speakers not visible in PulseAudio

2012-05-30 Thread David Henningsson
On 05/30/2012 04:56 PM, Takashi Iwai wrote: At Wed, 30 May 2012 14:46:48 +0200, David Henningsson wrote: Posted to both alsa-devel and pulseaudio-discuss lists, as this is a cross issue. PulseAudio tries to figure out what equipment is present on the machine using the mixer. If it finds e g "H

Re: [pulseaudio-discuss] [PATCH v3 1/2] loopback: Enable routing on loopback streams

2012-05-30 Thread Tanu Kaskinen
On Wed, 2012-05-30 at 18:01 +0300, Dalleau, Frederic wrote: > Tanu, > > On Wed, May 30, 2012 at 4:03 PM, Tanu Kaskinen wrote: > > On Wed, 2012-05-30 at 11:36 +0300, Dalleau, Frederic wrote: > >> At first I considered that loading module loopback with specifying > >> anything is not really a frequ

Re: [pulseaudio-discuss] [PATCH v3 1/2] loopback: Enable routing on loopback streams

2012-05-30 Thread Dalleau, Frederic
Tanu, On Wed, May 30, 2012 at 4:03 PM, Tanu Kaskinen wrote: > On Wed, 2012-05-30 at 11:36 +0300, Dalleau, Frederic wrote: >> At first I considered that loading module loopback with specifying >> anything is not really a frequent use case. That make a lot of changes >> to add this feature I think.

Re: [pulseaudio-discuss] Internal Mics and Speakers not visible in PulseAudio

2012-05-30 Thread Takashi Iwai
At Wed, 30 May 2012 14:46:48 +0200, David Henningsson wrote: > > Posted to both alsa-devel and pulseaudio-discuss lists, as this is a > cross issue. > > PulseAudio tries to figure out what equipment is present on the machine > using the mixer. If it finds e g "Headphone Playback Volume", "Headp

Re: [pulseaudio-discuss] [alsa-devel] Internal Mics and Speakers not visible in PulseAudio

2012-05-30 Thread David Henningsson
On 05/30/2012 03:04 PM, Raymond Yau wrote: 2012/5/30 David Henningsson: Posted to both alsa-devel and pulseaudio-discuss lists, as this is a cross issue. PulseAudio tries to figure out what equipment is present on the machine using the mixer. If it finds e g "Headphone Playback Volume", "Headph

Re: [pulseaudio-discuss] [PATCH v3 1/2] loopback: Enable routing on loopback streams

2012-05-30 Thread Tanu Kaskinen
On Wed, 2012-05-30 at 11:36 +0300, Dalleau, Frederic wrote: > PA_SINK_INPUT_FIX_FORMAT doesn't seem to work as expected. > If I set this flag without defining the sample_spec, I get an assertion > in pa_sink_input_new when pa_format_info_from_sample_spec is called. You can probably get around that

Re: [pulseaudio-discuss] [PATCH 1/2] pactl: Add unloading modules by name.

2012-05-30 Thread Tanu Kaskinen
On Wed, 2012-05-30 at 14:27 +0200, poljar wrote: > pactl should allow unloading modules by name. > > If there are multiple modules with the same name all > of them will be unloaded. Thanks, I'll fix the small issues pointed out below, and apply the patch. > BugLink: https://bugs.freedesktop.org/

[pulseaudio-discuss] Internal Mics and Speakers not visible in PulseAudio

2012-05-30 Thread David Henningsson
Posted to both alsa-devel and pulseaudio-discuss lists, as this is a cross issue. PulseAudio tries to figure out what equipment is present on the machine using the mixer. If it finds e g "Headphone Playback Volume", "Headphone Playback Switch", or "Headphone Jack", it assumes that a headphone

[pulseaudio-discuss] [PATCH 2/2] pacmd: Add unloading modules by name.

2012-05-30 Thread poljar
pacmd should allow unloading modules by name. The command_unload() function was expanded to handle names while unloading modules. If there are multiple modules with the same name all of them will be unloaded. BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=48289 --- src/pulsecore/cli-comma

[pulseaudio-discuss] [PATCH 1/2] pactl: Add unloading modules by name.

2012-05-30 Thread poljar
pactl should allow unloading modules by name. If there are multiple modules with the same name all of them will be unloaded. BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=48289 --- man/pactl.1.xml.in |4 ++-- src/utils/pactl.c | 40 2 files

[pulseaudio-discuss] [PATCH v2 0/2] Module unloading by name

2012-05-30 Thread poljar
This is the client side implementations of the module unloading by name patch. BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=48289 man/pactl.1.xml.in |4 ++-- src/pulsecore/cli-command.c | 32 src/utils/pacmd.c |2 +- src/util

Re: [pulseaudio-discuss] [PATCH v3 1/2] loopback: Enable routing on loopback streams

2012-05-30 Thread Dalleau, Frederic
Hi Tanu, Thanks for this review ! On Tue, May 29, 2012 at 2:24 PM, Tanu Kaskinen wrote: > > +sink = pa_namereg_get_default_sink(m->core); > > This still overrides the routing modules, right? > > I guess this is done, because otherwise you don't know how to initialize > ss and map? I thi