[pulseaudio-discuss] [PATCH] core-util: Blame systemd for not setting up XDG_RUNTIME_DIR correctly

2013-11-11 Thread David Henningsson
Hi Lennart, I think you're wrong about this bug: https://bugzilla.redhat.com/show_bug.cgi?id=753882 You're claiming that PA will only work if XDG_RUNTIME_DIR remains the same as the original user. However, PA will use the PULSE_SERVER X11 property instead of using XDG_RUNTIME_DIR, so this enviro

Re: [pulseaudio-discuss] [PATCH] doxygen: Replace "\deprecated" with "\b Deprecated."

2013-11-11 Thread Arun Raghavan
On Mon, 2013-11-11 at 13:54 +0100, Thomas Martitz wrote: > Am 11.11.2013 12:43, schrieb Tanu Kaskinen: > > On Fri, 2013-11-08 at 20:29 +0100, Thomas Martitz wrote: > >> Am 08.11.2013 14:46, schrieb Tanu Kaskinen: > >>> The effect of the \deprecated tag is (for a reason unknown to me) that > >>> all

Re: [pulseaudio-discuss] [PATCH 03/11] resampler: Change interface, resampler may return the number of leftover frames

2013-11-11 Thread Alexander E. Patrakov
2013/11/11 Tanu Kaskinen : > On Sat, 2013-11-09 at 02:34 +0600, Alexander E. Patrakov wrote: >> Peter Meerwald wrote: >> >> > some resampler implementations (e.g. libsamplerate and ffmpeg) do not >> > consume >> > the entire input buffer; the impl_resample() function now has a return >> > value >

Re: [pulseaudio-discuss] [PATCH] doxygen: Replace "\deprecated" with "\b Deprecated."

2013-11-11 Thread Thomas Martitz
Am 11.11.2013 12:43, schrieb Tanu Kaskinen: On Fri, 2013-11-08 at 20:29 +0100, Thomas Martitz wrote: Am 08.11.2013 14:46, schrieb Tanu Kaskinen: The effect of the \deprecated tag is (for a reason unknown to me) that all documentation for the tagged entity is removed. That's not nice, so this pa

Re: [pulseaudio-discuss] [PATCH 03/11] resampler: Change interface, resampler may return the number of leftover frames

2013-11-11 Thread Tanu Kaskinen
On Sat, 2013-11-09 at 02:34 +0600, Alexander E. Patrakov wrote: > Peter Meerwald wrote: > > > some resampler implementations (e.g. libsamplerate and ffmpeg) do not > > consume > > the entire input buffer; the impl_resample() function now has a return value > > returning the number of frames in th

Re: [pulseaudio-discuss] [PATCH] doxygen: Replace "\deprecated" with "\b Deprecated."

2013-11-11 Thread Tanu Kaskinen
On Fri, 2013-11-08 at 20:29 +0100, Thomas Martitz wrote: > Am 08.11.2013 14:46, schrieb Tanu Kaskinen: > > The effect of the \deprecated tag is (for a reason unknown to me) that > > all documentation for the tagged entity is removed. That's not nice, > > so this patch replaces the tag with plain te

Re: [pulseaudio-discuss] Possible bug in pa_sink_input_request_rewind

2013-11-11 Thread Tanu Kaskinen
On Fri, 2013-11-08 at 23:18 +0600, Alexander E. Patrakov wrote: > Hello. > > In pa_sink_input_request_rewind, nbytes == 0 means "rewind as far as > possible". However, I think I have found (by code inspection) a case > where it is not honored. The case is where > i->thread_info.rewrite_nbytes is a

Re: [pulseaudio-discuss] resubmit reverted resampler patch

2013-11-11 Thread Peter Meerwald
> > I have rebased and reviewed patches 1-5, and all looked good, so pushed. > > I'll continue the review later (hopefully today). > > I pushed patches 6, 7 and 8 too. Patch 9 had some issues (see my reply > to that patch), so I'm waiting for updated versions of patches 9-11. will do, thanks, p.

Re: [pulseaudio-discuss] resubmit reverted resampler patch

2013-11-11 Thread Tanu Kaskinen
On Fri, 2013-11-08 at 10:44 +0200, Tanu Kaskinen wrote: > On Sun, 2013-07-21 at 23:14 +0200, Peter Meerwald wrote: > > Hello, > > > > the patch series aims to resubmit a patch to reorder the resampling > > pipeline; it former patch was dropped due to issues with leftover data > > handling; patc