On Sat, 2014-03-15 at 11:44 +0100, Peter Meerwald wrote:
>
> sounds way better
>
> the \ref before pa_threaded_mainloop is gone; needed?
Oh, I dropped that accidentally. I now pushed the patch with added \ref.
Thanks for the review!
--
Tanu
___
pul
sounds way better
the \ref before pa_threaded_mainloop is gone; needed?
p.
> ---
> src/pulse/mainloop-api.h | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/src/pulse/mainloop-api.h b/src/pulse/mainloop-api.h
> index b4eccb1..2e3e95e 100644
> --- a/src/pulse/ma
Hello Tanu,
I've totally forgotten about the patch my now :)
let's see if Parin steps in, otherwise I'll do the clearup
thanks, p.
> On Thu, 2014-02-20 at 23:14 +0100, Peter Meerwald wrote:
> > From: Parin Porecha
> >
> > Example: pactl set-sink-volume "sink_name" 32000 4
> > If the number
I found two issues in the shutdown code in module-zeroconf-publish
while investigating bug 76184[1]. The first patch probably doesn't
have anything to do with bug 76184, it's just something that caught
my eye.
[1] https://bugs.freedesktop.org/show_bug.cgi?id=76184
Tanu Kaskinen (2):
zeroconf-pu
This fixes a case where pa__done() is called while
AVAHI_MESSAGE_PUBLISH_ALL is waiting for processing. The
pa_asyncmsgq_wait_for(AVAHI_MESSAGE_SHUTDOWN_COMPLETE) call will
process all pending messages, and processing AVAHI_MESSAGE_PUBLISH_ALL
causes publish_all_services(), and that in turn accesse
Commit e1e154c739377fa1a36655a10effd693f7b5 added locking around
pa_mainloop_api_once() everywhere except pa__done(). This fixes that
omission.
---
src/modules/module-zeroconf-publish.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/modules/module-zeroconf-publish.c
b/src/modules/m
On Thu, 2014-02-20 at 23:14 +0100, Peter Meerwald wrote:
> Signed-off-by: Peter Meerwald
> ---
> man/pactl.1.xml.in | 20
> 1 file changed, 12 insertions(+), 8 deletions(-)
Looks good to me. The --help text of pactl could be updated too to hint
about the possibility of suppl
On Thu, 2014-02-20 at 23:14 +0100, Peter Meerwald wrote:
> Must use one way to specify volumes consistently, e.g.
> +3dB +3dB, mixing different ways is not allowed, such as
> 40% 1000
>
> Signed-off-by: Peter Meerwald
> ---
> src/utils/pactl.c | 57
> +++-
On Thu, 2014-02-20 at 23:14 +0100, Peter Meerwald wrote:
> From: Parin Porecha
>
> Example: pactl set-sink-volume "sink_name" 32000 4
> If the number of volumes provided is different than the number of channels
> (excluding the case where a single volume is provided), an error message
> is di
BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=69535
---
po/TRANSLATORS_README.txt | 4
1 file changed, 4 insertions(+)
create mode 100644 po/TRANSLATORS_README.txt
diff --git a/po/TRANSLATORS_README.txt b/po/TRANSLATORS_README.txt
new file mode 100644
index 000..6217dd8
--- /dev
---
src/pulse/mainloop-api.h | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/pulse/mainloop-api.h b/src/pulse/mainloop-api.h
index b4eccb1..2e3e95e 100644
--- a/src/pulse/mainloop-api.h
+++ b/src/pulse/mainloop-api.h
@@ -114,9 +114,11 @@ struct pa_mainloop_api {
11 matches
Mail list logo
