Re: [pulseaudio-discuss] [PATCH] Added module-ofono-switch-on-voicecall

2014-03-26 Thread Tanu Kaskinen
On Tue, 2014-03-25 at 11:21 -0700, Felipe Tonello wrote: > Hi Tanu, > > On Tue, Mar 25, 2014 at 1:05 AM, Tanu Kaskinen > wrote: > > On Mon, 2014-03-24 at 14:32 -0700, Felipe Tonello wrote: > >> On Mon, Mar 24, 2014 at 1:18 AM, Tanu Kaskinen > >> > Why does this module have to be loaded before mod

[pulseaudio-discuss] [PATCH 1/2] direction: Add a couple of direction helper functions

2014-03-26 Thread Tanu Kaskinen
--- src/Makefile.am | 2 ++ src/map-file | 2 ++ src/pulse/direction.c | 46 ++ src/pulse/direction.h | 37 + 4 files changed, 87 insertions(+) create mode 100644 src/pulse/direction.c create mode 10

[pulseaudio-discuss] [PATCH 0/2] Helper functions for pa_direction_t

2014-03-26 Thread Tanu Kaskinen
I found pa_direction_valid() and pa_direction_to_string() useful in the Tizen volume API work, and I thought they might make sense in upstream too. I found one place in the current code base where pa_direction_valid() makes sense, but I didn't find any use for pa_direction_to_string() at this time

[pulseaudio-discuss] [PATCH 2/2] introspect: Use pa_direction_valid() to validate port direction

2014-03-26 Thread Tanu Kaskinen
There's no behavioral change, just nicer code. --- src/pulse/introspect.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/pulse/introspect.c b/src/pulse/introspect.c index 2d54fdb..d7696df 100644 --- a/src/pulse/introspect.c +++ b/src/pulse/introspect.c @@ -25,6 +25,7

[pulseaudio-discuss] [PATCH v2 0/2] Helper functions for pa_direction_t

2014-03-26 Thread Tanu Kaskinen
>From the original cover letter: I found pa_direction_valid() and pa_direction_to_string() useful in the Tizen volume API work, and I thought they might make sense in upstream too. I found one place in the current code base where pa_direction_valid() makes sense, but I didn't find any use for pa_

[pulseaudio-discuss] [PATCH v2 2/2] introspect: Use pa_direction_valid() to validate port direction

2014-03-26 Thread Tanu Kaskinen
There's no behavioral change, just nicer code. --- src/pulse/introspect.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/pulse/introspect.c b/src/pulse/introspect.c index 2d54fdb..d7696df 100644 --- a/src/pulse/introspect.c +++ b/src/pulse/introspect.c @@ -25,6 +25,7

[pulseaudio-discuss] [PATCH v2 1/2] direction: Add a couple of direction helper functions

2014-03-26 Thread Tanu Kaskinen
--- doxygen/doxygen.conf.in | 1 + src/Makefile.am | 2 ++ src/map-file| 2 ++ src/pulse/direction.c | 46 ++ src/pulse/direction.h | 37 + src/pulse/pulseaudio.h | 5 +++-- 6 files changed

[pulseaudio-discuss] [PATCH 0/2] pa_hashmap_remove_and_free()

2014-03-26 Thread Tanu Kaskinen
Tanu Kaskinen (2): hashmap: Add pa_hashmap_remove_and_free() Use pa_hashmap_remove_and_free() where appropriate src/modules/alsa/alsa-mixer.c | 18 ++ src/modules/gconf/module-gconf.c | 6 +- src/modules/module-console-kit.c | 8 +++- src/modules/mo

[pulseaudio-discuss] [PATCH 2/2] Use pa_hashmap_remove_and_free() where appropriate

2014-03-26 Thread Tanu Kaskinen
--- src/modules/alsa/alsa-mixer.c | 18 ++ src/modules/gconf/module-gconf.c | 6 +- src/modules/module-console-kit.c | 8 +++- src/modules/module-stream-restore.c | 7 +++ src/modules/module-suspend-on-idle.c | 5 + src/modules/module-zeroco

[pulseaudio-discuss] [PATCH 1/2] hashmap: Add pa_hashmap_remove_and_free()

2014-03-26 Thread Tanu Kaskinen
--- src/pulsecore/hashmap.c | 13 + src/pulsecore/hashmap.h | 7 +++ 2 files changed, 20 insertions(+) diff --git a/src/pulsecore/hashmap.c b/src/pulsecore/hashmap.c index acac1e0..2cc03cb 100644 --- a/src/pulsecore/hashmap.c +++ b/src/pulsecore/hashmap.c @@ -207,6 +207,19 @@ voi

Re: [pulseaudio-discuss] [PATCH] Added module-ofono-switch-on-voicecall

2014-03-26 Thread Felipe Tonello
Hi Tanu, On Wed, Mar 26, 2014 at 1:03 AM, Tanu Kaskinen wrote: > On Tue, 2014-03-25 at 11:21 -0700, Felipe Tonello wrote: >> Hi Tanu, >> >> On Tue, Mar 25, 2014 at 1:05 AM, Tanu Kaskinen >> wrote: >> > On Mon, 2014-03-24 at 14:32 -0700, Felipe Tonello wrote: >> >> On Mon, Mar 24, 2014 at 1:18 AM

[pulseaudio-discuss] pulse client implementation

2014-03-26 Thread Pete Beardmore
hi, i recently submitted a patch to an audio application which fixed what i saw as a failure to DTRT wrt its pulse implementation specifically, the scenario whereby a user has explicitly configured the app (via config file - read on initialisation) to use 'sinkX', and then at some point

Re: [pulseaudio-discuss] [PATCH v2 1/2] direction: Add a couple of direction helper functions

2014-03-26 Thread David Henningsson
On 03/26/2014 10:52 AM, Tanu Kaskinen wrote: > --- > doxygen/doxygen.conf.in | 1 + > src/Makefile.am | 2 ++ > src/map-file| 2 ++ > src/pulse/direction.c | 46 ++ > src/pulse/direction.h | 37 +