Re: [pulseaudio-discuss] RAOP2 trouble with Logitech UE Air Speaker

2014-04-15 Thread Martin Blanchard
Hello Toby, From what I can read here, the server is responding with '500 Internal Server Error' to the rtsp RECORD request sent by pulseaudio. We may find quite a lot of reasons to this, and I'm afraid pulseaudio's log won't be enough to debug the issue... Is it possible to you to dump the netwo

[pulseaudio-discuss] Routing to/from HE910 cell modem w/echo cancellation

2014-04-15 Thread Peter Barada
All, I'm a bit unclear on how to use paplay/parecord as replacements for aplay/arecord. On my dm3730-based system I have an HE910 modem hooked up and have created a snd-soc device for it (using the snd-soc-dummy-dai) to move data in/out of the HE910 PCM port. My alsa devices show up as: root@lv

[pulseaudio-discuss] [PATCH 2/2] fdsem: Use atomic.h

2014-04-15 Thread David Henningsson
The fdsem header uses pa_atomic_t, which is declared in atomic.h Signed-off-by: David Henningsson --- src/pulsecore/fdsem.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/pulsecore/fdsem.h b/src/pulsecore/fdsem.h index 3f1d9a1..1b1a5a5 100644 --- a/src/pulsecore/fdsem.h +++ b/src/puls

[pulseaudio-discuss] [PATCH 1/2] fdsem: remove superfluous parameter in call to pa_fdsem_new_shm

2014-04-15 Thread David Henningsson
This parameter was never assigned, so just remove it. Note that the only current user of this function is shmasyncq.c, which is unused - we don't even build it. But I fixed it up anyway. Signed-off-by: David Henningsson --- src/pulsecore/fdsem.c | 3 +-- src/pulsecore/fdsem.h | 2 +- sr

Re: [pulseaudio-discuss] [PATCH 09/15] sink, source: Assign to s->muted from only one place

2014-04-15 Thread Alexander E. Patrakov
15.04.2014 16:56, Tanu Kaskinen wrote: +typedef int (*pa_sink_get_mute_cb_t)(pa_sink *s, bool *mute); + struct pa_sink { pa_msgobject parent; @@ -191,14 +193,14 @@ struct pa_sink { * set this callback. */ pa_sink_cb_t write_volume; /* may be NULL */ -/* Called when

[pulseaudio-discuss] [PATCH] combine-sinks: add suport for DYNAMIC_LATENCY

2014-04-15 Thread Wim Taymans
Mark the sink as DYNAMIC_LATENCY and implement update_sink_latency_range on its sink-input to collect the combined latency range of all sinks. Implement update_requested_latency on the sink to configure the final latency by combining the sink-input requested latencies. This makes us honour the cli

[pulseaudio-discuss] [PATCH] dbus: Use correct initialization for source ports hashmap.

2014-04-15 Thread Juho Hämäläinen
Source ports hashmap is created without value freeing function, which results in (hashmap values) device ports not being freed when source ports are removed or module is unloaded. This results in memory leak during normal operation and during daemon shutdown dbus_protocol shared object isn't unrefe

[pulseaudio-discuss] [PATCH 01/15] sink-input, source-output: Fix mute saving

2014-04-15 Thread Tanu Kaskinen
"i->save_muted = i->save_muted || mute" makes no sense. The intention was most likely to use "save" instead of "mute" in the assignment. This line originates from reverting the volume ramping code, commit 8401572fd534f10e07ed6a418e1399b1294d5596. The idea of "i->save_muted |= save" is that even if

[pulseaudio-discuss] [PATCH 00/15] Volume and mute refactoring + new hooks

2014-04-15 Thread Tanu Kaskinen
I sent earlier a patch set with subject "Some volume refactoring + new hooks"[1]. That patch set is superseded by this one. This patch set incorporates the feedback from the previous patch set, and adds mute refactoring and mute hooks. As with the previous patch set, the refactoring is done to mak

[pulseaudio-discuss] [PATCH 05/15] sink-input, source-output: Add logging to set_mute()

2014-04-15 Thread Tanu Kaskinen
--- src/pulsecore/sink-input.c| 8 +++- src/pulsecore/source-output.c | 8 +++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/pulsecore/sink-input.c b/src/pulsecore/sink-input.c index a963a0c..3b50e60 100644 --- a/src/pulsecore/sink-input.c +++ b/src/pulsecore/sin

[pulseaudio-discuss] [PATCH 02/15] sink, source: Assign to reference_volume from only one place

2014-04-15 Thread Tanu Kaskinen
Forcing all reference volume changes to go through set_reference_volume_direct() makes it easier to check where the reference volume is changed, and it also allows us to have only one place where notifications for changed reference volume are sent. --- src/pulsecore/sink-input.c| 23 ++

[pulseaudio-discuss] [PATCH 10/15] sink-input, source-output: Remove redundant get_mute() functions

2014-04-15 Thread Tanu Kaskinen
The functions just return the muted value. Callers can as well read the struct field directly, it's simpler that way. --- src/modules/dbus/iface-stream.c | 4 ++-- src/modules/module-role-cork.c | 9 - src/modules/module-stream-restore.c | 4 ++-- src/pulsecore/cli-text.c

[pulseaudio-discuss] [PATCH 13/15] sink-input, source-output: Add hooks for volume changes

2014-04-15 Thread Tanu Kaskinen
--- src/pulsecore/core.h | 2 ++ src/pulsecore/sink-input.c| 1 + src/pulsecore/source-output.c | 1 + 3 files changed, 4 insertions(+) diff --git a/src/pulsecore/core.h b/src/pulsecore/core.h index d764ac4..2276fb9 100644 --- a/src/pulsecore/core.h +++ b/src/pulsecore/core.h @@ -97,

[pulseaudio-discuss] [PATCH 03/15] sink-input, source-output: Assign to volume from only one place

2014-04-15 Thread Tanu Kaskinen
Forcing all volume changes to go through set_volume_direct() makes it easier to check where the stream volume is changed, and it also allows us to have only one place where notifications for changed volume are sent. --- src/pulsecore/sink-input.c| 69 +--

[pulseaudio-discuss] [PATCH 06/15] sink, source: Allow calling set_mute() during initialization

2014-04-15 Thread Tanu Kaskinen
Currently the alsa sink and source write directly to s->muted during initialization, but I think it's better to avoid direct writes, and use the set_mute() function instead, because that makes it easier to figure out where s->muted is modified. This patch prevents the set_mute() call from crashing

[pulseaudio-discuss] [PATCH 04/15] sink, source: Return early from set_mute()

2014-04-15 Thread Tanu Kaskinen
This avoids redundant set_mute() callback calls. Some logging was added too. --- src/pulsecore/sink.c | 13 + src/pulsecore/source.c | 13 + 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/src/pulsecore/sink.c b/src/pulsecore/sink.c index 38b5052..c708774

[pulseaudio-discuss] [PATCH 15/15] sink-input, source-output: Add hooks for mute changes

2014-04-15 Thread Tanu Kaskinen
--- src/pulsecore/core.h | 2 ++ src/pulsecore/sink-input.c| 1 + src/pulsecore/source-output.c | 1 + 3 files changed, 4 insertions(+) diff --git a/src/pulsecore/core.h b/src/pulsecore/core.h index 762157e..b443ce4 100644 --- a/src/pulsecore/core.h +++ b/src/pulsecore/core.h @@ -100

[pulseaudio-discuss] [PATCH 12/15] sink, source: Add hooks for volume changes

2014-04-15 Thread Tanu Kaskinen
--- src/pulsecore/core.h | 2 ++ src/pulsecore/sink.c | 1 + src/pulsecore/source.c | 1 + 3 files changed, 4 insertions(+) diff --git a/src/pulsecore/core.h b/src/pulsecore/core.h index f268e42..d764ac4 100644 --- a/src/pulsecore/core.h +++ b/src/pulsecore/core.h @@ -76,6 +76,7 @@ typedef en

[pulseaudio-discuss] [PATCH 11/15] solaris, tunnel: Remove some redundant boolean conversions

2014-04-15 Thread Tanu Kaskinen
--- src/modules/module-solaris.c | 2 +- src/modules/module-tunnel.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/module-solaris.c b/src/modules/module-solaris.c index 71a98e9..4f11000 100644 --- a/src/modules/module-solaris.c +++ b/src/modules/module-solaris

[pulseaudio-discuss] [PATCH 07/15] echo-cancel: Remove redundant get_mute() callback

2014-04-15 Thread Tanu Kaskinen
The callback just called pa_source_output_get_mute(), which doesn't have any side effects, and the return value wasn't used either, so the callback was essentially a no-op. --- src/modules/echo-cancel/module-echo-cancel.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/src/modu

[pulseaudio-discuss] [PATCH 08/15] sink, source: Call set_mute() from mute_changed()

2014-04-15 Thread Tanu Kaskinen
This refactoring reduces duplication, as mute_changed() used to do the same things as set_mute(). Other benefits are improved logging (set_mute() logs the mute change, mute_changed() used to not do that) and the soft mute state is kept up to date, because set_mute() sends the SET_MUTE message to th

[pulseaudio-discuss] [PATCH 14/15] sink, source: Add hooks for mute changes

2014-04-15 Thread Tanu Kaskinen
--- src/pulsecore/core.h | 2 ++ src/pulsecore/sink.c | 1 + src/pulsecore/source.c | 1 + 3 files changed, 4 insertions(+) diff --git a/src/pulsecore/core.h b/src/pulsecore/core.h index 2276fb9..762157e 100644 --- a/src/pulsecore/core.h +++ b/src/pulsecore/core.h @@ -77,6 +77,7 @@ typedef en

[pulseaudio-discuss] [PATCH 09/15] sink, source: Assign to s->muted from only one place

2014-04-15 Thread Tanu Kaskinen
Forcing all mute changes to go through set_mute() makes it easier to check where the muted field is changed, and it also allows us to have only one place where notifications for changed mute are sent. --- src/modules/alsa/alsa-sink.c | 17 ++--- src/modules/alsa/alsa-source.c | 17 ++

Re: [pulseaudio-discuss] [PATCH] pstream: Use pa_xnew0 in initialization

2014-04-15 Thread David Henningsson
On 2014-04-15 11:58, Tanu Kaskinen wrote: On Tue, 2014-04-15 at 11:54 +0200, David Henningsson wrote: ...for simplicity. Signed-off-by: David Henningsson --- src/pulsecore/pstream.c | 30 +- 1 file changed, 1 insertion(+), 29 deletions(-) Looks good to me.

Re: [pulseaudio-discuss] [PATCH] pstream: Use pa_xnew0 in initialization

2014-04-15 Thread Tanu Kaskinen
On Tue, 2014-04-15 at 11:54 +0200, David Henningsson wrote: > ...for simplicity. > > Signed-off-by: David Henningsson > --- > src/pulsecore/pstream.c | 30 +- > 1 file changed, 1 insertion(+), 29 deletions(-) Looks good to me. -- Tanu _

[pulseaudio-discuss] [PATCH] pstream: Use pa_xnew0 in initialization

2014-04-15 Thread David Henningsson
...for simplicity. Signed-off-by: David Henningsson --- src/pulsecore/pstream.c | 30 +- 1 file changed, 1 insertion(+), 29 deletions(-) diff --git a/src/pulsecore/pstream.c b/src/pulsecore/pstream.c index 190fc9a..2c1444f 100644 --- a/src/pulsecore/pstream.c +++ b/s

Re: [pulseaudio-discuss] [PATCH 2/2] pactl: Stop parsing option when the first non-option is encountered

2014-04-15 Thread Tanu Kaskinen
On Tue, 2014-04-15 at 11:12 +0200, Peter Meerwald wrote: > From: Peter Meerwald > > fix bug > https://bugs.freedesktop.org/show_bug.cgi?id=77108 > > see getopt(3): > ""By default, getopt() permutes the contents of argv as it scans, so that > eventually all the nonoptions are at the end. Two o

[pulseaudio-discuss] [PATCH 1/2] man: Fix typos in pulse-daemon.conf.5.xml.in

2014-04-15 Thread Peter Meerwald
From: Peter Meerwald Signed-off-by: Peter Meerwald --- man/pulse-daemon.conf.5.xml.in |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/man/pulse-daemon.conf.5.xml.in b/man/pulse-daemon.conf.5.xml.in index 4aa5948..8bd076d 100644 --- a/man/pulse-daemon.conf.5.xml.in +++

[pulseaudio-discuss] [PATCH 2/2] pactl: Stop parsing option when the first non-option is encountered

2014-04-15 Thread Peter Meerwald
From: Peter Meerwald fix bug https://bugs.freedesktop.org/show_bug.cgi?id=77108 see getopt(3): ""By default, getopt() permutes the contents of argv as it scans, so that eventually all the nonoptions are at the end. Two other modes are also implemented. If the first character of optstring

[pulseaudio-discuss] [PATCH v2] sink-input, source-output: Fix mute saving

2014-04-15 Thread Tanu Kaskinen
"i->save_muted = i->save_muted || mute" makes no sense. The intention was most likely to use "save" instead of "mute" in the assignment. This line originates from reverting the volume ramping code, commit 8401572fd534f10e07ed6a418e1399b1294d5596. The idea of "i->save_muted |= save" is that even if

Re: [pulseaudio-discuss] [PATCH] sink-input, source-output: Fix mute saving

2014-04-15 Thread Tanu Kaskinen
On Tue, 2014-04-15 at 08:05 +0200, Peter Meerwald wrote: > Hello Tanu, > > some information that describes the bug would be good, such as how to > trigger, what the observed effect is, what goes wrong > > the fix is not obvious (to me at least) Sorry for being lazy, you're right, I should expla

Re: [pulseaudio-discuss] [PATCH v2] Name HDMI outputs uniquely

2014-04-15 Thread David Henningsson
On 2014-04-10 17:13, Alexander E. Patrakov wrote: On Haswell hardware, there are multiple HDMI outputs capable of digital sound output. As they were identically named, KDE's control center was unable to distinguish them, restored the wrong profile and thus routed sound to the wrong HDMI monitor