Re: [pulseaudio-discuss] [PATCH] modules: Disable timer scheduling for a2dp playback to reduce power consumption.

2014-08-04 Thread Sajeesh Sidharthan
Title: Samsung Enterprise Portal mySingle Hi, I have disabled timer scheduling for a2dp playback with this patch to reduce power consumption. Could you please review this change and let me know if it can cause any side effect. If its worth giving an option to disable timer scheduling similar

[pulseaudio-discuss] [PATCH] modules: Disable timer scheduling for a2dp playback to reduce power consumption.

2014-08-04 Thread Sajeesh Sidharthan
--- src/modules/bluetooth/module-bluez5-device.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/modules/bluetooth/module-bluez5-device.c b/src/modules/bluetooth/module-bluez5-device.c index 57b2791..eda7a9d 100644 --- a/src/modules/bluetooth/module-bluez5-devic

Re: [pulseaudio-discuss] [PATCH] core: Closing proper file descriptor when pipe creation fails.

2014-08-04 Thread Sajeesh Sidharthan
Title: Samsung Enterprise Portal mySingle Hi Arun, This is the first time I have submitted a patch to open source. Could you please let me know if I have to do anything further if the change is acceptable? Thank You. Sajeesh   --- Original Message --- Sender : Arun Raghavan Date

Re: [pulseaudio-discuss] Pulseaudio 5.0 compilation error: ./.libs/libpulse.so: undefined reference to `is_error'

2014-08-04 Thread Dâniel Fraga
On Mon, 4 Aug 2014 22:54:38 -0300 Dâniel Fraga wrote: > /home/fraga/src/pulseaudio-5.0/src/.libs/libpulse.so: undefined reference to > `is_error' Ok, it seems Pulseaudio 5.0 won't compile with latest Json-c, so I've to add a deprecated header file in src/pulse/format.c: #include

[pulseaudio-discuss] Pulseaudio 5.0 compilation error: ./.libs/libpulse.so: undefined reference to `is_error'

2014-08-04 Thread Dâniel Fraga
I'm trying to compile Pulseaudio 5.0 with gcc 4.9.1 and I get the following: libtool: link: gcc -std=gnu99 -pthread -DPA_SRCDIR=\"/home/fraga/src/pulseaudio-5.0/src\" -DPA_BUILDDIR=\"/home/fraga/src/pulseaudio-5.0/src\" -I/usr/local/include/dbus-1.0 -I/usr/local/lib/dbus-1.0/include -ma

[pulseaudio-discuss] [PATCH] sink-input, source-output: Assign to reference_ratio from a single place

2014-08-04 Thread Tanu Kaskinen
This makes it easy to log a message every time the reference ratio changes. I also need to add a hook for reference ratio changes, but that need will go away if the stream relative volume controls will be created by the core in the future. --- src/pulsecore/sink-input.c| 28 +++

Re: [pulseaudio-discuss] [PATCH 1/3] resampler: Split the resampler implementations into separate files

2014-08-04 Thread Alexander E. Patrakov
04.08.2014 18:40, Peter Meerwald wrote: static bool speex_is_fixed_point(void) { I am of the mixed opinion on the fact that this function is not moved to speex.c. The patch subjectively feels incomplete because of that - but this function is special due to the fact that it also has to exist

[pulseaudio-discuss] [PATCH] sconv: Use optimized conversion function for both directions

2014-08-04 Thread Peter Meerwald
From: Peter Meerwald for example, the conversion function for convert_from_float32ne(PA_SAMPLE_S16LE) can also be used for convert_to_s16ne(PA_SAMPLE_FLOAT32LE) v2: ARM can potentially be big- or little endian; only apply optimization on LE based on WORDS_BIGENDIAN #define (thanks, Tanu) Signed

[pulseaudio-discuss] [PATCH] remap: Add 4-channel to mono channel rearrangement

2014-08-04 Thread Peter Meerwald
From: Peter Meerwald Signed-off-by: Peter Meerwald --- src/pulsecore/remap.c | 36 +++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/src/pulsecore/remap.c b/src/pulsecore/remap.c index 37213d5..09d4837 100644 --- a/src/pulsecore/remap.c +++ b/s

Re: [pulseaudio-discuss] Pulseaudio test suite failures

2014-08-04 Thread Felipe Sateler
On Mon, Aug 4, 2014 at 11:55 AM, Peter Meerwald wrote: >> > posted here >> > http://lists.freedesktop.org/archives/pulseaudio-discuss/2014-August/021051.html >> >> Still failing on powerpc and s390x. > > do you have the link to the build bot? > that was rather helpful last time No, I don't. I ran

Re: [pulseaudio-discuss] Pulseaudio test suite failures

2014-08-04 Thread Peter Meerwald
> > posted here > > http://lists.freedesktop.org/archives/pulseaudio-discuss/2014-August/021051.html > > Still failing on powerpc and s390x. do you have the link to the build bot? that was rather helpful last time > > I'm also getting this (after disabling timeouts) on powerpc: > > tests/once-

Re: [pulseaudio-discuss] Pulseaudio test suite failures

2014-08-04 Thread Felipe Sateler
On Mon, Aug 4, 2014 at 9:10 AM, Peter Meerwald wrote: > Hello, > >> > I think pa_mix_s24_32re_c() is simply wrong, and has never worked; it >> > should advance m->ptr by sizeof(int32_t), not 3 -- will submit a fix and >> > update the test code >> >> I can test the patch, if you can send me one :)

Re: [pulseaudio-discuss] [PATCH] util: Fix pa_get_binary_name() on Debian/kFreeBSD

2014-08-04 Thread Peter Meerwald
> > Debian GNU/kFreeBSD uses a FreeBSD kernel and GLIBC, > > it #defines __FreeBSD_kernel__, but not __FreeBSD__ nor __linux__ > > Debian GNU/kFreeBSD does have a /proc/self/exe > > > > FreeBSD #defines __FreeBSD__ and __FreeBSD_kernel__ > > > > problem reporte here: > > http://lists.freedesktop.o

Re: [pulseaudio-discuss] [PATCH] mix: Fix mixing of S24 samples stored as S32RE

2014-08-04 Thread Felipe Sateler
On Mon, Aug 4, 2014 at 8:42 AM, Peter Meerwald wrote: > pa_mix_s24_32re_c() should advance m->ptr by sizeof(int32_t) > > http://lists.freedesktop.org/archives/pulseaudio-discuss/2014-July/020998.html > > Signed-off-by: Peter Meerwald Will test as soon as I can. -- Saludos, Felipe Sateler

Re: [pulseaudio-discuss] [PATCH] util: Fix pa_get_binary_name() on Debian/kFreeBSD

2014-08-04 Thread Felipe Sateler
On Mon, Aug 4, 2014 at 8:50 AM, Peter Meerwald wrote: > Debian GNU/kFreeBSD uses a FreeBSD kernel and GLIBC, > it #defines __FreeBSD_kernel__, but not __FreeBSD__ nor __linux__ > Debian GNU/kFreeBSD does have a /proc/self/exe > > FreeBSD #defines __FreeBSD__ and __FreeBSD_kernel__ > > problem repo

Re: [pulseaudio-discuss] [PATCH 0/3] resamplers

2014-08-04 Thread Peter Meerwald
Hello Arun, > > the work was mostly done by poljar (Damir Jelić) during GSoC'13, this is > > just > > a rebase > > > > my goal would be to establish libavresample as the new default resampler and > > drop the ffmpeg code copied into PA currently; don't worry, this would be > > further work bas

Re: [pulseaudio-discuss] [PATCH 0/3] resamplers

2014-08-04 Thread Arun Raghavan
On Mon, 2014-08-04 at 14:40 +0200, Peter Meerwald wrote: > Hello, > > this patch series splits up the resampler implementation found in pulsecore > into separate files and adds two new resampler implementations: soxr and > libavresample > > the work was mostly done by poljar (Damir Jelić) during

Re: [pulseaudio-discuss] [PATCH] mix: Fix mixing of S24 samples stored as S32RE

2014-08-04 Thread Arun Raghavan
On Mon, 2014-08-04 at 14:42 +0200, Peter Meerwald wrote: > pa_mix_s24_32re_c() should advance m->ptr by sizeof(int32_t) > > http://lists.freedesktop.org/archives/pulseaudio-discuss/2014-July/020998.html > > Signed-off-by: Peter Meerwald > --- > src/pulsecore/mix.c | 2 +- > src/tests/mix-test.

Re: [pulseaudio-discuss] [PATCH] util: Fix pa_get_binary_name() on Debian/kFreeBSD

2014-08-04 Thread Arun Raghavan
On Mon, 2014-08-04 at 14:50 +0200, Peter Meerwald wrote: > Debian GNU/kFreeBSD uses a FreeBSD kernel and GLIBC, > it #defines __FreeBSD_kernel__, but not __FreeBSD__ nor __linux__ > Debian GNU/kFreeBSD does have a /proc/self/exe > > FreeBSD #defines __FreeBSD__ and __FreeBSD_kernel__ > > problem

Re: [pulseaudio-discuss] [PATCH 0/3] resamplers

2014-08-04 Thread Alexander E. Patrakov
04.08.2014 19:05, Peter Meerwald wrote: Hello Alexander, my goal would be to establish libavresample as the new default resampler and drop the ffmpeg code copied into PA currently; don't worry, this would be further work based on the feedback received :) This conflicts with my goal of writin

Re: [pulseaudio-discuss] Pulseaudio test suite failures

2014-08-04 Thread Peter Meerwald
Hello, > > I think pa_mix_s24_32re_c() is simply wrong, and has never worked; it > > should advance m->ptr by sizeof(int32_t), not 3 -- will submit a fix and > > update the test code > > I can test the patch, if you can send me one :) posted here http://lists.freedesktop.org/archives/pulseaudio-

Re: [pulseaudio-discuss] [PATCH 0/3] resamplers

2014-08-04 Thread Peter Meerwald
Hello Alexander, > > my goal would be to establish libavresample as the new default resampler and > > drop the ffmpeg code copied into PA currently; don't worry, this would be > > further work based on the feedback received :) > This conflicts with my goal of writing and getting a rewindable >

[pulseaudio-discuss] [PATCH] util: Fix pa_get_binary_name() on Debian/kFreeBSD

2014-08-04 Thread Peter Meerwald
Debian GNU/kFreeBSD uses a FreeBSD kernel and GLIBC, it #defines __FreeBSD_kernel__, but not __FreeBSD__ nor __linux__ Debian GNU/kFreeBSD does have a /proc/self/exe FreeBSD #defines __FreeBSD__ and __FreeBSD_kernel__ problem reporte here: http://lists.freedesktop.org/archives/pulseaudio-discuss/

Re: [pulseaudio-discuss] [PATCH 0/3] resamplers

2014-08-04 Thread Alexander E. Patrakov
04.08.2014 18:40, Peter Meerwald wrote: Hello, this patch series splits up the resampler implementation found in pulsecore into separate files and adds two new resampler implementations: soxr and libavresample the work was mostly done by poljar (Damir Jelić) during GSoC'13, this is just a rebas

[pulseaudio-discuss] [PATCH] mix: Fix mixing of S24 samples stored as S32RE

2014-08-04 Thread Peter Meerwald
pa_mix_s24_32re_c() should advance m->ptr by sizeof(int32_t) http://lists.freedesktop.org/archives/pulseaudio-discuss/2014-July/020998.html Signed-off-by: Peter Meerwald --- src/pulsecore/mix.c | 2 +- src/tests/mix-test.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/

[pulseaudio-discuss] [PATCH 2/3] resampler: Add optional soxr resampler

2014-08-04 Thread Peter Meerwald
see http://sourceforge.net/p/soxr/wiki/Home/ Signed-off-by: Peter Meerwald Signed-off-by: poljar (Damir Jelić) -- rebased and leftover handling is external to _resample() now; this fixes a bug in the leftover_length computation since soxr supports s16 and float32, hence sizeof(float) is wrong

[pulseaudio-discuss] [PATCH 3/3] resampler: Add optional libavresample resampler

2014-08-04 Thread Peter Meerwald
see https://libav.org/doxygen/master/group__lavr.html Signed-off-by: Peter Meerwald Signed-off-by: poljar (Damir Jelić) --- configure.ac | 17 + src/Makefile.am| 6 ++ src/pulsecore/resampler.c | 14 +++- src/pulsecore/resampler.h | 2 + src

[pulseaudio-discuss] [PATCH 1/3] resampler: Split the resampler implementations into separate files

2014-08-04 Thread Peter Meerwald
Signed-off-by: Peter Meerwald Signed-off-by: poljar (Damir Jelić) -- changes over https://github.com/poljar/pulseaudio/commits/resampler_implementations_v2: rebased --- src/Makefile.am | 18 +- src/pulsecore/resampler.c | 634 ++--

[pulseaudio-discuss] [PATCH 0/3] resamplers

2014-08-04 Thread Peter Meerwald
Hello, this patch series splits up the resampler implementation found in pulsecore into separate files and adds two new resampler implementations: soxr and libavresample the work was mostly done by poljar (Damir Jelić) during GSoC'13, this is just a rebase my goal would be to establish libavresa

Re: [pulseaudio-discuss] Any master plan on equalizer/ladspa settings?

2014-08-04 Thread Tanu Kaskinen
On Mon, 2014-08-04 at 00:32 +0600, Alexander E. Patrakov wrote: > Hello. > > Is there any plan to replace the custom DBus-based volume-like APIs > currently used by module-equalizer-sink and module-ladspa-sink? Nobody has volunteered to work on that. That said, the new volume control API is desi

Re: [pulseaudio-discuss] RFC: New volume functionality for PulseAudio

2014-08-04 Thread Tanu Kaskinen
On Fri, 2014-08-01 at 12:30 +0200, David Henningsson wrote: > > On 2014-07-29 20:46, Tanu Kaskinen wrote: > >> The idea is that pa_cvolume is the "bare minimum" struct and the > >> pa_bvolume is the "extra everything" struct. Does that make sense? > > > > I don't really see the point of bundling a

Re: [pulseaudio-discuss] [PATCH] core: Closing proper file descriptor when pipe creation fails.

2014-08-04 Thread Arun Raghavan
On Mon, 2014-08-04 at 14:32 +0530, Sajeesh Sidharthan wrote: > --- > src/pulsecore/pipe.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/pulsecore/pipe.c b/src/pulsecore/pipe.c > index f873ef6..4e3c0c3 100644 > --- a/src/pulsecore/pipe.c > +++ b/src/pulsecore/pipe

[pulseaudio-discuss] [PATCH] core: Closing proper file descriptor when pipe creation fails.

2014-08-04 Thread Sajeesh Sidharthan
--- src/pulsecore/pipe.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pulsecore/pipe.c b/src/pulsecore/pipe.c index f873ef6..4e3c0c3 100644 --- a/src/pulsecore/pipe.c +++ b/src/pulsecore/pipe.c @@ -149,7 +149,7 @@ error: if (filedes[0] >= 0)

[pulseaudio-discuss] [PATCH] echo-cancel: Fix drift timer restart logic across suspend

2014-08-04 Thread Arun Raghavan
The IS_ACTIVE() macro does a pa_sink/source_get_state() on our sink and source, which does not work in the state change callback, since the state is not actually committed at that point. --- src/modules/echo-cancel/module-echo-cancel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) dif