[pulseaudio-discuss] Patch review status wiki page updated

2014-08-16 Thread Tanu Kaskinen
Patch review status updated: http://www.freedesktop.org/wiki/Software/PulseAudio/PatchStatus/ Statistics: * 2014-08-17 * 133 patches are pending review (not counting the "in a github branch" patches). * The oldest pending patch is 270 days old. * 2014-08-11 * 121 patches are pending rev

Re: [pulseaudio-discuss] [PATCH 4/6] shell-completion: zsh: Don't use multiple option sets for one command

2014-08-16 Thread Tanu Kaskinen
On Sat, 2014-08-16 at 20:15 +0200, Damir Jelić wrote: > On Sat, Aug 16, 2014 at 02:48:17PM +0300, Tanu Kaskinen wrote: > > Dividing the options to multiple sets was misguided (I don't know what > > the original motivation was). For example, with pacat the -s and > > --server options were specified

Re: [pulseaudio-discuss] On surround channel nomenclature and remixing

2014-08-16 Thread Alexander E. Patrakov
17.08.2014 10:50, Tanu Kaskinen wrote: On Fri, 2014-08-08 at 16:33 +0600, Alexander E. Patrakov wrote: Hello. [Note: the whole e-mail is purely theoretical. I still don't have any surround-sound system in my room. A salesman told me that I should buy 5.1 speakers, not 7.1, because the TV is cen

Re: [pulseaudio-discuss] [PATCH 4/8] srbchannel: pa_srbchannel_new() may fail

2014-08-16 Thread David Henningsson
On 2014-08-13 10:15, Peter Meerwald wrote: return from setup_srbchannel() when pa_srbchannel_new() fails pa_srbchannel_new() depends on HAVE_SYS_EVENTFD_H, e.g. Debian/kFreeBSD doesn't have it Signed-off-by: Peter Meerwald Cc: David Henningsson Looks good. Do we also need the same on the cl

Re: [pulseaudio-discuss] [PATCH 3/8] srbchannel: Cleanup when pa_fdsem_open_shm() fails

2014-08-16 Thread David Henningsson
Good catch. However the fail label could just call pa_srbchannel_free instead of copy-pasting, unless there is a good reason not to? On 2014-08-13 10:15, Peter Meerwald wrote: pa_fdsem_open_shm() returns NULL when HAVE_SYS_EVENTFD_H is #undefined pa_srbchannel_new() and pa_srbchannel_new_from_

Re: [pulseaudio-discuss] [PATCH] shell-completion: Install the Zsh completions

2014-08-16 Thread Tanu Kaskinen
On Sat, 2014-08-16 at 20:15 +0200, Damir Jelić wrote: > On Tue, Aug 12, 2014 at 12:41:55PM +0300, Tanu Kaskinen wrote: > > This makes the Zsh completions work out-of-the-box. I also moved > > pulseaudio-zsh-completion.zsh to zsh/_pulseaudio to be in line with > > the common naming convention of Zsh

Re: [pulseaudio-discuss] [PATCH] sink-input, source-output: Assign to reference_ratio from a single place

2014-08-16 Thread Tanu Kaskinen
On Mon, 2014-08-04 at 21:12 +0300, Tanu Kaskinen wrote: > This makes it easy to log a message every time the reference ratio > changes. I also need to add a hook for reference ratio changes, but > that need will go away if the stream relative volume controls will be > created by the core in the fut

Re: [pulseaudio-discuss] On surround channel nomenclature and remixing

2014-08-16 Thread Tanu Kaskinen
On Fri, 2014-08-08 at 16:33 +0600, Alexander E. Patrakov wrote: > Hello. > > [Note: the whole e-mail is purely theoretical. I still don't have any > surround-sound system in my room. A salesman told me that I should buy > 5.1 speakers, not 7.1, because the TV is centered on the long side of > t

Re: [pulseaudio-discuss] Need a way to check when start-pulseaudio-x11 fully initialized

2014-08-16 Thread Anton Lundin
On 16 August, 2014 - John wrote: > > > - Original Message - > > From: Tanu Kaskinen > > To: John > > Cc: "pulseaudio-discuss@lists.freedesktop.org" > > > > Sent: Friday, August 15, 2014 11:55 AM > > Subject: Re: [pulseaudio-discuss] Need a way to check when > > start-pulseaudio-x11

Re: [pulseaudio-discuss] Need a way to check when start-pulseaudio-x11 fully initialized

2014-08-16 Thread John
- Original Message - > From: Tanu Kaskinen > To: John > Cc: "pulseaudio-discuss@lists.freedesktop.org" > > Sent: Friday, August 15, 2014 11:55 AM > Subject: Re: [pulseaudio-discuss] Need a way to check when > start-pulseaudio-x11 fully initialized > The XBMC logs talk about "enumerat

Re: [pulseaudio-discuss] [PATCH] shell-completion: Install the Zsh completions

2014-08-16 Thread Damir Jelić
On Tue, Aug 12, 2014 at 12:41:55PM +0300, Tanu Kaskinen wrote: > This makes the Zsh completions work out-of-the-box. I also moved > pulseaudio-zsh-completion.zsh to zsh/_pulseaudio to be in line with > the common naming convention of Zsh completion files. systemd actually had the same structure th

Re: [pulseaudio-discuss] [PATCH 4/6] shell-completion: zsh: Don't use multiple option sets for one command

2014-08-16 Thread Damir Jelić
On Sat, Aug 16, 2014 at 02:48:17PM +0300, Tanu Kaskinen wrote: > Dividing the options to multiple sets was misguided (I don't know what > the original motivation was). For example, with pacat the -s and > --server options were specified as one set. It meant that after the > user had written "pactl

[pulseaudio-discuss] [PATCH 0/6] Zsh completion improvements

2014-08-16 Thread Tanu Kaskinen
Tanu Kaskinen (6): shell-completion: zsh: Move duplicated code into a function shell-completion: zsh: Support also --server in remote detection shell-completion: zsh: Don't say "this help" when it's a different help shell-completion: zsh: Don't use multiple option sets for one command

[pulseaudio-discuss] [PATCH 1/6] shell-completion: zsh: Move duplicated code into a function

2014-08-16 Thread Tanu Kaskinen
This is just refactoring, no functional changes. --- shell-completion/pulseaudio-zsh-completion.zsh | 88 ++ 1 file changed, 34 insertions(+), 54 deletions(-) diff --git a/shell-completion/pulseaudio-zsh-completion.zsh b/shell-completion/pulseaudio-zsh-completion.zsh inde

[pulseaudio-discuss] [PATCH 5/6] shell-completion: zsh: Use -S and -A with _arguments

2014-08-16 Thread Tanu Kaskinen
-S makes the option parser to not try parsing arguments as options after "--" has appeared in the command line. -A "-*" makes the option parser to not try parsing arguments as options after the first non-option argument. The "-*" pattern means that if there are unrecognized parameters that look li

[pulseaudio-discuss] [PATCH 4/6] shell-completion: zsh: Don't use multiple option sets for one command

2014-08-16 Thread Tanu Kaskinen
Dividing the options to multiple sets was misguided (I don't know what the original motivation was). For example, with pacat the -s and --server options were specified as one set. It meant that after the user had written "pactl --server foo", further completions stopped to work. The "server" option

[pulseaudio-discuss] [PATCH 6/6] shell-completion: zsh: Add "=" to the end of some command options

2014-08-16 Thread Tanu Kaskinen
Without the equals sign, only the "--server foo" form is recognized, so the "--server=foo" form doesn't get completion support. --- shell-completion/pulseaudio-zsh-completion.zsh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/shell-completion/pulseaudio-zsh-completion.zs

[pulseaudio-discuss] [PATCH 2/6] shell-completion: zsh: Support also --server in remote detection

2014-08-16 Thread Tanu Kaskinen
_set_remote() is supposed to find out if a remote server has been specified on the command line, but previously it only checked for -s and ignored --server, causing the completion code to connect to the local server instead when it should have connected to the remote server to get the data for the

[pulseaudio-discuss] [PATCH 3/6] shell-completion: zsh: Don't say "this help" when it's a different help

2014-08-16 Thread Tanu Kaskinen
The option descriptions that Zsh prints are not the same thing as the help text that pactl, pacmd etc. print when given --help. --- shell-completion/pulseaudio-zsh-completion.zsh | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/shell-completion/pulseaudio-zsh-completion.