Le 2014-08-14 07:44, Felipe Sateler a écrit :
+#ifdef HAVE_DLADDR
+extern int main(int, char*[]);
+#endif
So what exports the main symbol while linking the library? If nothing
does, then builds may fail due to undefined symbols, e.g. when using "-z
defs" flag to GNU/ld.
--
Rémi Denis-Courmo
> Signed-off-by: Peter Meerwald
> ---
> src/pulsecore/remap.c | 36 +++-
> 1 file changed, 35 insertions(+), 1 deletion(-)
>
> diff --git a/src/pulsecore/remap.c b/src/pulsecore/remap.c
> index 37213d5..09d4837 100644
> --- a/src/pulsecore/remap.c
> +++ b/src/p
Hi Felipe,
it would be good to describe what the patch is for;
I assume fixing hurd?
dladdr() is a GNU extension; the manpage does
#define _GNU_SOURCE
#include
p.
> ---
> configure.ac | 2 ++
> src/pulse/util.c | 18 ++
> 2 files changed, 20 insertions(+)
>
> diff --git
> OK, so it now seems that with the hurd we still are missing 1 test:
> once-test[1]. Looks like the autobuilder is killing the build after a
> timeout is reached.
>
> [1]
> https://buildd.debian.org/status/fetch.php?pkg=pulseaudio&arch=hurd-i386&ver=5.0-10&stamp=1408316471
daemon/pulseaudio-da
On Sun, 2014-08-17 at 21:03 +0600, Alexander E. Patrakov wrote:
> 2014-08-17 17:52 GMT+06:00 Tanu Kaskinen :
> > The analog-output path should be used only when more specific outputs
> > don't exist, so usually it should be suppressed, and currently that
> > doesn't happen. One practical problem ca
On Sun, 2014-08-17 at 21:03 +0600, Alexander E. Patrakov wrote:
> 2014-08-17 17:52 GMT+06:00 Tanu Kaskinen :
> > The analog-output path should be used only when more specific outputs
> > don't exist, so usually it should be suppressed, and currently that
> > doesn't happen. One practical problem ca
On Sun, 2014-08-17 at 21:43 +0600, Alexander E. Patrakov wrote:
> 2014-08-17 16:43 GMT+06:00 Tanu Kaskinen :
> > If there are unsaved changes, those need to be written to disk before
> > the module is unloaded, otherwise the changes are lost.
> > ---
> > src/modules/module-device-restore.c | 4 +++
On Mon, 2014-08-18 at 00:19 +0800, Raymond Yau wrote:
> >
> > The analog-output path should be used only when more specific
> outputs
> > don't exist, so usually it should be suppressed, and currently that
> > doesn't happen. One practical problem caused by that is that the
> > analog-output port m
From: Peter Meerwald
drop support for json 0.9 and require json-c 0.11 (this will also avoids
confusion
which json package is needed due to the upstream rename)
json 0.9 lacks json_object_object_get_ex()
json-c 0.11 was released 20130402
Signed-off-by: Peter Meerwald
---
configure.ac |3
From: Peter Meerwald
patch 1 uses json_object_object_get() according to documentation
(might be a bug fix)
patch 2 uses json_object_object_get_ex() instead of the deprecated
json_object_object_get() function (fixes compilation warnings for json-c 0.12)
patch 3 makes configure.ac drops support
From: Peter Meerwald
json-c documentation states that "No reference counts will be changed.
There is no need to manually adjust reference counts through the
json_object_put/json_object_get methods unless..."
hence fix pa_format_info_get_prop_type() and
pa_format_info_get_prop_int_range();
note
From: Peter Meerwald
json_tokener_parse() simply returns NULL on error these days
latest json-c (post 0.12) doesn't automatically include json-c/bits.h anymore
causing compilation errors
Signed-off-by: Peter Meerwald
---
src/pulse/format.c | 18 +-
1 file changed, 9 insertio
From: Peter Meerwald
pulse/format.c: In function 'pa_format_info_get_prop_type':
pulse/format.c:252:5: warning: implicit declaration of function 'is_error'
[-Wimplicit-function-declaration]
pulse/format.c:287:13: warning: 'json_object_object_get' is deprecated
(declared at /usr/local/include/js
Hi Tanu,
On Sun, Aug 17, 2014 at 1:04 PM, Tanu Kaskinen
wrote:
> On Wed, 2014-08-13 at 15:23 +0300, Luiz Augusto von Dentz wrote:
>> From: João Paulo Rechi Vita
>>
>> ---
>> configure.ac | 4 +-
>> src/modules/bluetooth/backend-ofono.c | 143
>> ++
On Mon, Aug 18, 2014 at 4:54 AM, Peter Meerwald wrote:
> Hi Felipe,
>
> it would be good to describe what the patch is for;
> I assume fixing hurd?
Yes, it also has the benefit that if someone crazy enough tries a new
Debian GNU/* it should just work as well. I remember someone tried a
Minix port
On Mon, Aug 18, 2014 at 3:07 AM, Rémi Denis-Courmont wrote:
> Le 2014-08-14 07:44, Felipe Sateler a écrit :
>
>> +#ifdef HAVE_DLADDR
>> +extern int main(int, char*[]);
>> +#endif
>
>
> So what exports the main symbol while linking the library? If nothing does,
> then builds may fail due to undefin
> patch 1 puts *.log and *.trs (which are created by running 'make check') into
> src/.gitignore
> patch 2 fixes spelling (canceler -> canceller)
> patch 3 add error handling code to pa_srbchannel_new() when
> pa_fdsem_open_shm() (which it does without HAVE_SYS_EVENTFD_H, e.g. on
> kFreeBSD)
>
On Mon, Aug 18, 2014 at 9:36 AM, Felipe Sateler wrote:
> On Mon, Aug 18, 2014 at 3:07 AM, Rémi Denis-Courmont wrote:
>> Le 2014-08-14 07:44, Felipe Sateler a écrit :
>>
>>> +#ifdef HAVE_DLADDR
>>> +extern int main(int, char*[]);
>>> +#endif
>>
>>
>> So what exports the main symbol while linking t
From: Peter Meerwald
Signed-off-by: Peter Meerwald
Cc: David Henningsson
---
src/pulse/context.c |4
1 file changed, 4 insertions(+)
diff --git a/src/pulse/context.c b/src/pulse/context.c
index b8ebced..ff94543 100644
--- a/src/pulse/context.c
+++ b/src/pulse/context.c
@@ -360,6 +360
return from setup_srbchannel() when pa_srbchannel_new() fails
pa_srbchannel_new() depends on HAVE_SYS_EVENTFD_H, e.g. Debian/kFreeBSD doesn't
have it
Signed-off-by: Peter Meerwald
Acked-by: David Henningsson
---
src/pulsecore/protocol-native.c |6 +-
1 file changed, 5 insertions(+), 1
From: Peter Meerwald
these patches supersede those in the "misc cleanups and bug fixes" series
posted August 13
patch 1 now uses pa_srbchannel_free() as suggested by David (v2)
patch 2 is unchanged
patch 3 actually stops handle_srbchannel_memblock() if the memblock sanity
checks fail
patch 4 c
pa_fdsem_open_shm() returns NULL when HAVE_SYS_EVENTFD_H is #undefined
pa_srbchannel_new() and pa_srbchannel_new_from_template() depend on
pa_fdsem_open_shm() and shall properly cleanup stuff, and return NULL as well;
otherwise, function pa_fdsem_get() will assert:
Assertion 'f' failed at pulseco
From: Peter Meerwald
handle_srbchannel_memblock() should return when memblock sanity checks fail
Signed-off-by: Peter Meerwald
Cc: David Henningsson
---
src/pulse/context.c |9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/pulse/context.c b/src/pulse/context.
The assertion problem was my fault. I kept missing the fact that my threaded
main loop start was one line earlier - bad paste job.
The hanging issue now shows up frequently even in the non-simple api. It may be
a configuration issue. Paplay hangs also if it is started after the hang occurs
and
On 2014-08-18 17:15, Peter Meerwald wrote:
From: Peter Meerwald
handle_srbchannel_memblock() should return when memblock sanity checks fail
Hmm, the reason I kept it on separate lines was for more specific error
checking, i e, you could tell which of the checks that failed from
looking in
> > handle_srbchannel_memblock() should return when memblock sanity checks fail
>
> Hmm, the reason I kept it on separate lines was for more specific error
> checking, i e, you could tell which of the checks that failed from looking in
> the debug log. IIRC, I'm not sure? But yeah, the early retu
On 2014-08-18 19:17, Peter Meerwald wrote:
handle_srbchannel_memblock() should return when memblock sanity checks fail
Hmm, the reason I kept it on separate lines was for more specific error
checking, i e, you could tell which of the checks that failed from looking in
the debug log. IIRC, I
> > > > handle_srbchannel_memblock() should return when memblock sanity checks
> > > > fail
> > >
> > > Hmm, the reason I kept it on separate lines was for more specific error
> > > checking, i e, you could tell which of the checks that failed from looking
> > > in
> > > the debug log. IIRC, I'm
On 2014-08-17 13:52, Tanu Kaskinen wrote:
The analog-output path should be suppressed when there are more
specific paths available. Currently that usually doesn't happen. The
suppression can be done with the path subset detection, and this patch
makes that work (another approach would be to mar
29 matches
Mail list logo
