Re: [pulseaudio-discuss] --check option seems not to work from su(1)

2014-08-22 Thread Felipe Sateler
On Fri, Aug 22, 2014 at 6:12 AM, Tanu Kaskinen wrote: > On Thu, 2014-08-21 at 16:55 -0600, Glenn Golden wrote: >> A side issue that I came across, related to the --check option, but not the >> doc issue itself: >> >> Suppose the root user wishes to use the --check option to see if user xyz >> has

Re: [pulseaudio-discuss] --check option seems not to work from su(1) as daemon user

2014-08-22 Thread Tanu Kaskinen
On Fri, 2014-08-22 at 05:55 -0600, Glenn Golden wrote: > Tanu Kaskinen [2014-08-21 15:31:13 +0300]: > > On Wed, 2014-08-20 at 06:15 -0600, Glenn Golden wrote: > > > Tanu Kaskinen [2014-08-20 13:26:19 +0300]: > > > > On Tue, 2014-08-19 at 16:26 -0600, Glenn Golden wrote: > > > > > This is complete

Re: [pulseaudio-discuss] RFC: New volume functionality for PulseAudio

2014-08-22 Thread David Henningsson
On 2014-08-04 11:49, Tanu Kaskinen wrote: On Fri, 2014-08-01 at 12:30 +0200, David Henningsson wrote: On 2014-07-29 20:46, Tanu Kaskinen wrote: The idea is that pa_cvolume is the "bare minimum" struct and the pa_bvolume is the "extra everything" struct. Does that make sense? I don't really

[pulseaudio-discuss] [PATCH 10/17] bluetooth: Handle CardRemoved signal

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita --- src/modules/bluetooth/backend-ofono.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c index e07db01..a499711 100644 --- a/src/modules/bluetooth/b

[pulseaudio-discuss] [PATCH 11/17] bluetooth: Implement org.ofono.HandsfreeAudioAgent.Release()

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita --- src/modules/bluetooth/backend-ofono.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c index a499711..1fd56a1 100644 --- a/src/modules/bluetooth/backend-ofo

[pulseaudio-discuss] [PATCH 14/17] bluetooth: Allow policy module to pick 'off' profile

2014-08-22 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz This allow 'off' profile to be choosen when no other profile is available which is considered better since it requires less resources than other profiles. --- src/modules/bluetooth/module-bluetooth-policy.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(

[pulseaudio-discuss] [PATCH 15/17] bluetooth: Add pa_bluetooth_transport_set_state

2014-08-22 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz --- src/modules/bluetooth/backend-ofono.c | 15 --- src/modules/bluetooth/bluez5-util.c | 10 +- src/modules/bluetooth/bluez5-util.h | 1 + 3 files changed, 10 insertions(+), 16 deletions(-) diff --git a/src/modules/bluetooth/backend-ofono.c

[pulseaudio-discuss] [PATCH 12/17] bluetooth: Implement org.ofono.HandsfreeAudioAgent.NewConnection()

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita --- src/modules/bluetooth/backend-ofono.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c index 1fd56a1..56a1944 100644 --- a/src/module

[pulseaudio-discuss] [PATCH 08/17] bluetooth: Track oFono service

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita --- src/modules/bluetooth/backend-ofono.c | 36 +++ 1 file changed, 36 insertions(+) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c index f9157e3..404a6b5 100644 --- a/src/modules/bluetooth/

[pulseaudio-discuss] [PATCH 17/17] bluetooth: Only create backend instance once objects are listed

2014-08-22 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz This makes sure the devices are discovered before the backend start creating new transports. --- src/modules/bluetooth/bluez5-util.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/modules/bluetooth/bluez5-util.c b/src/modules/bluetooth/bl

[pulseaudio-discuss] [PATCH 02/17] bluetooth: Create hf_dbus_send_and_add_to_pending() for oFono backend

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita --- src/modules/bluetooth/backend-ofono.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c index f5fe472..925b98b 100644 --- a/src/modules/bluetooth/backend-ofono.

[pulseaudio-discuss] [PATCH 05/17] bluetooth: Parse HandsfreeAudioCard properties

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita --- src/modules/bluetooth/backend-ofono.c | 110 +- 1 file changed, 108 insertions(+), 2 deletions(-) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c index 614df76..79765bb 100644 --- a/src/m

[pulseaudio-discuss] [PATCH 06/17] bluetooth: Implement transport acquire for hf_audio_agent transports

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita --- src/modules/bluetooth/backend-ofono.c | 66 ++- 1 file changed, 65 insertions(+), 1 deletion(-) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c index 79765bb..5fb99de 100644 --- a/src/mod

[pulseaudio-discuss] [PATCH 13/17] bluetooth: Suspend the source/sink the HFP-oFono stream fd HUP

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita --- src/modules/bluetooth/module-bluez5-device.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/modules/bluetooth/module-bluez5-device.c b/src/modules/bluetooth/module-bluez5-device.c index 5398a1b..7ea4b55 100644 --- a/src/modules/bluetooth/module-blu

[pulseaudio-discuss] [PATCH 04/17] bluetooth: List HandsfreeAudioCard objects from oFono

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita --- src/modules/bluetooth/backend-ofono.c | 54 ++- 1 file changed, 53 insertions(+), 1 deletion(-) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c index ced62a7..614df76 100644 --- a/src/mod

[pulseaudio-discuss] [PATCH 09/17] bluetooth: Handle CardAdded signal

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita --- src/modules/bluetooth/backend-ofono.c | 40 +-- 1 file changed, 29 insertions(+), 11 deletions(-) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c index 404a6b5..e07db01 100644 --- a/src/m

[pulseaudio-discuss] [PATCH 07/17] bluetooth: Implement transport release for hf_audio_agent transports

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita --- src/modules/bluetooth/backend-ofono.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c index 5fb99de..f9157e3 100644 --- a/src/modules/bluetooth/backend-ofono.c +

[pulseaudio-discuss] [PATCH 01/17] bluetooth: Monitor D-Bus signals

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita --- src/modules/bluetooth/backend-ofono.c | 49 --- 1 file changed, 45 insertions(+), 4 deletions(-) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c index bf0db47..f5fe472 100644 --- a/src/mo

[pulseaudio-discuss] [PATCH 03/17] bluetooth: Register/Unregister Handsfree Audio Agent with oFono

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita Register as a HandsfreeAudioAgent with oFono during backend initialization and unregiter during backend finalization. This commit also adds a check when receiving method calls or signals to make sure the sender matches with the D-Bus service we're registered with. ---

[pulseaudio-discuss] [PATCH 16/17] bluetooth: Fix crash while disconnecting

2014-08-22 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz Transport can be NULL in case the device could not be found. --- src/modules/bluetooth/backend-ofono.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c index 41810d4.

Re: [pulseaudio-discuss] [PATCH 4/4] format: Don't use deprecated json-c is_error() macro

2014-08-22 Thread Peter Meerwald
> > json_tokener_parse() simply returns NULL on error these days > > > > latest json-c (post 0.12) doesn't automatically include json-c/bits.h > > anymore > > causing compilation errors > > > > Signed-off-by: Peter Meerwald > > --- > > src/pulse/format.c | 18 +- > > 1 file

Re: [pulseaudio-discuss] --check option seems not to work from su(1) as daemon user

2014-08-22 Thread Glenn Golden
Tanu Kaskinen [2014-08-21 15:31:13 +0300]: > On Wed, 2014-08-20 at 06:15 -0600, Glenn Golden wrote: > > Tanu Kaskinen [2014-08-20 13:26:19 +0300]: > > > > > > (added pulseaudio-discuss back to CC) > > > > > Thx, I hit the wrong button on the reply earlier. > > > > > > > > On Tue, 2014-08-19 at

Re: [pulseaudio-discuss] [PATCH] conf-parser: Add debug print of parsed files

2014-08-22 Thread Tanu Kaskinen
On Fri, 2014-08-22 at 11:51 +0200, David Henningsson wrote: > This is useful for debugging. > > Signed-off-by: David Henningsson > --- > src/pulsecore/conf-parser.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/pulsecore/conf-parser.c b/src/pulsecore/conf-parser.c > index 200252b

Re: [pulseaudio-discuss] --check option seems not to work from su(1)

2014-08-22 Thread Tanu Kaskinen
On Thu, 2014-08-21 at 16:55 -0600, Glenn Golden wrote: > A side issue that I came across, related to the --check option, but not the > doc issue itself: > > Suppose the root user wishes to use the --check option to see if user xyz > has a PA daemon running. He does this: > > # XDG_RUNTIME_DI

Re: [pulseaudio-discuss] [PATCH 2/2] alsa-mixer: Ignore some elements in the analog-output path

2014-08-22 Thread David Henningsson
On 2014-08-20 12:17, Tanu Kaskinen wrote: On Tue, 2014-08-19 at 17:05 +0200, David Henningsson wrote: On 2014-08-19 12:09, Tanu Kaskinen wrote: On Tue, 2014-08-19 at 07:47 +0200, David Henningsson wrote: On 2014-08-17 13:52, Tanu Kaskinen wrote: The analog-output path should be suppressed

[pulseaudio-discuss] [PATCH] conf-parser: Add debug print of parsed files

2014-08-22 Thread David Henningsson
This is useful for debugging. Signed-off-by: David Henningsson --- src/pulsecore/conf-parser.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/pulsecore/conf-parser.c b/src/pulsecore/conf-parser.c index 200252b..1683d46 100644 --- a/src/pulsecore/conf-parser.c +++ b/src/pulsecore/conf-pa

Re: [pulseaudio-discuss] [PATCH] alsa: Add debug print of parsed profile set file

2014-08-22 Thread David Henningsson
On 2014-08-20 11:53, Tanu Kaskinen wrote: On Tue, 2014-08-19 at 14:38 +0200, David Henningsson wrote: This is useful for debugging. Signed-off-by: David Henningsson --- src/modules/alsa/alsa-mixer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/modules/alsa/alsa-mixer.c b/src/mo

Re: [pulseaudio-discuss] [PATCH v3 2/5] bluetoot: Assert transport has no matching profile

2014-08-22 Thread Tanu Kaskinen
On Fri, 2014-08-22 at 11:07 +0300, Luiz Augusto von Dentz wrote: > From: Luiz Augusto von Dentz > > It is an error if a transport has no matching profile. > --- > src/modules/bluetooth/module-bluez5-device.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/src/modules

Re: [pulseaudio-discuss] --check option seems not to work from su(1)

2014-08-22 Thread Glenn Golden
Felipe Sateler [2014-08-21 19:05:52 -0400]: > > I haven't had a chance to try to reproduce it yet, but this sounds a > lot like https://bugs.debian.org/758272 > Hm, yes I see what you mean. Well, the above --check as root provides a convenient way to reproduce it anyway. > > > > * What is yo

[pulseaudio-discuss] [PATCH v3 3/5] bluetooth: Add BlueZ 5 headset profile names in policy module

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita --- src/modules/bluetooth/module-bluetooth-policy.c | 27 - 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/src/modules/bluetooth/module-bluetooth-policy.c b/src/modules/bluetooth/module-bluetooth-policy.c index 6837f0d..8bbda3d

[pulseaudio-discuss] [PATCH v3 4/5] bluetooth: Create NULL backend

2014-08-22 Thread Luiz Augusto von Dentz
From: Jo??o Paulo Rechi Vita --- configure.ac | 16 src/Makefile.am | 3 ++- src/modules/bluetooth/backend-null.c | 37 src/modules/bluetooth/bluez5-util.c | 5 + src/modules/bluetooth/bluez

[pulseaudio-discuss] [PATCH v3 1/5] bluetooth: Add basic support for HEADSET profiles

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita This commit adds basic support for devices implementing HSP Headset Unit, HSP Audio Gateway, HFP Handsfree Unit, HFP Audio Gateway to the BlueZ 5 bluetooth audio devices driver module (module-bluez5-device). --- src/modules/bluetooth/bluez5-util.c | 4 + sr

[pulseaudio-discuss] [PATCH v3 5/5] bluetooth: Create oFono backend

2014-08-22 Thread Luiz Augusto von Dentz
From: Jo??o Paulo Rechi Vita --- configure.ac | 6 +- src/modules/bluetooth/backend-ofono.c | 143 ++ 2 files changed, 146 insertions(+), 3 deletions(-) create mode 100644 src/modules/bluetooth/backend-ofono.c diff --git a/configure.ac

[pulseaudio-discuss] [PATCH v3 2/5] bluetoot: Assert transport has no matching profile

2014-08-22 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz It is an error if a transport has no matching profile. --- src/modules/bluetooth/module-bluez5-device.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/modules/bluetooth/module-bluez5-device.c b/src/modules/bluetooth/module-bluez5-device.c