Re: [pulseaudio-discuss] [PATCH 7/8] launch: Disable autospawn by default when systemd daemon support is enabled.

2014-10-27 Thread Tanu Kaskinen
On Sun, 2014-10-26 at 19:55 +0200, Tanu Kaskinen wrote: On Fri, 2014-10-24 at 13:02 +0100, Colin Guthrie wrote: Tanu Kaskinen wrote on 24/10/14 12:08: On Fri, 2014-10-24 at 11:14 +0100, Colin Guthrie wrote: Tanu Kaskinen wrote on 24/10/14 10:42: Disable the manual override doesn't

Re: [pulseaudio-discuss] [PATCH RFC 04/17] tagstruct: Add type _APPENDED

2014-10-27 Thread Alexander E. Patrakov
25.10.2014 03:21, Peter Meerwald wrote: @@ -94,7 +99,13 @@ static void extend(pa_tagstruct*t, size_t l) { if (t-length+l = t-allocated) return; -t-data = pa_xrealloc(t-data, t-allocated = t-length+l+100); +if (t-type == PA_TAGSTRUCT_DYNAMIC) +t-data =

Re: [pulseaudio-discuss] [PATCH RFC 04/17] tagstruct: Add type _APPENDED

2014-10-27 Thread Peter Meerwald
@@ -94,7 +99,13 @@ static void extend(pa_tagstruct*t, size_t l) { if (t-length+l = t-allocated) return; -t-data = pa_xrealloc(t-data, t-allocated = t-length+l+100); +if (t-type == PA_TAGSTRUCT_DYNAMIC) +t-data = pa_xrealloc(t-data, t-allocated =

Re: [pulseaudio-discuss] [PATCH RFC 07/17] packet: Make pa_packet_new() create fixed-size packets

2014-10-27 Thread Peter Meerwald
25.10.2014 03:21, Peter Meerwald wrote: +#define MAX_APPENDED_SIZE 128 We have that #define both in packet.c and in tagstruct.c. Do I understand correctly that they are unrelated and everything will work correctly if the values in these two files are different? Other than that, the

Re: [pulseaudio-discuss] [PATCH RFC 08/17] packet: Introduce pa_packet_new_data() to copy data into a newly created packet

2014-10-27 Thread Alexander E. Patrakov
25.10.2014 03:21, Peter Meerwald wrote: From: Peter Meerwald p.meerw...@bct-electronic.com Signed-off-by: Peter Meerwald pme...@pmeerw.net --- src/pulsecore/packet.c | 9 + src/pulsecore/packet.h | 4 src/pulsecore/pstream-util.c | 2 +- 3 files changed, 14

Re: [pulseaudio-discuss] [PATCH 7/8] launch: Disable autospawn by default when systemd daemon support is enabled.

2014-10-27 Thread Colin Guthrie
Tanu Kaskinen wrote on 27/10/14 08:51: On Sun, 2014-10-26 at 19:55 +0200, Tanu Kaskinen wrote: On Fri, 2014-10-24 at 13:02 +0100, Colin Guthrie wrote: Tanu Kaskinen wrote on 24/10/14 12:08: On Fri, 2014-10-24 at 11:14 +0100, Colin Guthrie wrote: Tanu Kaskinen wrote on 24/10/14 10:42:

Re: [pulseaudio-discuss] [PATCH RFC 16/17] pstream: Use small minibuffer to combine several read()s if possible

2014-10-27 Thread David Henningsson
On 2014-10-24 23:21, Peter Meerwald wrote: From: Peter Meerwald p.meerw...@bct-electronic.com idea is similar to b4342845d, Optimize write of smaller packages, but for read IIRC, I tried this too, but never got it right, so if I posted a patch here for that, then I withdrew it later. Any

Re: [pulseaudio-discuss] [PATCH RFC 16/17] pstream: Use small minibuffer to combine several read()s if possible

2014-10-27 Thread Peter Meerwald
Hi, idea is similar to b4342845d, Optimize write of smaller packages, but for read IIRC, I tried this too, but never got it right, so if I posted a patch here for that, then I withdrew it later. thanks for taking a look; do you have pointer to those previous patches for the sake of

[pulseaudio-discuss] [PATCH] creds: Rename pa_ancil to pa_cmsg_ancil_data

2014-10-27 Thread Arun Raghavan
Makes the purpose of the structure clearear. --- src/modules/module-tunnel.c | 4 +-- src/pulse/context.c | 4 +-- src/pulsecore/creds.h | 10 +++ src/pulsecore/iochannel.c | 32 ++--- src/pulsecore/iochannel.h | 2 +-

[pulseaudio-discuss] [PATCH] alsa-mixer: Ignore some elements in the analog-output path

2014-10-27 Thread Tanu Kaskinen
The analog-output path should be suppressed when there are more specific paths available. Currently that usually doesn't happen. The suppression can be done with the path subset detection, and this patch makes that work (another approach would be to mark the elements as required-absent, like

[pulseaudio-discuss] [PATCH] alsa-mixer: Merge analog-output-desktop-speaker with analog-output-speaker(-always)

2014-10-27 Thread Tanu Kaskinen
According to David[1], it's unlikely that there are any sound cards that would have separate speaker and desktop speaker paths, so let's remove the unnecessary distinction. [1] http://thread.gmane.org/gmane.comp.audio.pulseaudio.general/20915/focus=21193 --- src/Makefile.am

Re: [pulseaudio-discuss] [PATCH RFC 16/17] pstream: Use small minibuffer to combine several read()s if possible

2014-10-27 Thread David Henningsson
On 2014-10-27 11:08, Peter Meerwald wrote: Hi, idea is similar to b4342845d, Optimize write of smaller packages, but for read IIRC, I tried this too, but never got it right, so if I posted a patch here for that, then I withdrew it later. thanks for taking a look; do you have pointer to

Re: [pulseaudio-discuss] [PATCH] alsa-mixer: Merge analog-output-desktop-speaker with analog-output-speaker(-always)

2014-10-27 Thread Tanu Kaskinen
On Mon, 2014-10-27 at 13:20 +0200, Tanu Kaskinen wrote: diff --git a/src/modules/alsa/mixer/paths/analog-output-speaker-always.conf b/src/modules/alsa/mixer/paths/analog-output-speaker-always.conf index c511813..9a74068 100644 ---

Re: [pulseaudio-discuss] PulseAudio, switch audio output on device connection

2014-10-27 Thread Mark Gaiser
On Sun, Oct 26, 2014 at 6:18 PM, Tanu Kaskinen tanu.kaski...@linux.intel.com wrote: On Sun, 2014-10-19 at 13:20 +0200, Mark Gaiser wrote: On Sun, Oct 19, 2014 at 12:01 PM, Tanu Kaskinen tanu.kaski...@linux.intel.com wrote: On Thu, 2014-10-09 at 00:39 +0200, Mark Gaiser wrote: Note the hdmi

Re: [pulseaudio-discuss] [PATCH] alsa-mixer: Merge analog-output-desktop-speaker with analog-output-speaker(-always)

2014-10-27 Thread David Henningsson
Looks good to me (with the proposed change below). On 2014-10-27 15:52, Tanu Kaskinen wrote: On Mon, 2014-10-27 at 13:20 +0200, Tanu Kaskinen wrote: diff --git a/src/modules/alsa/mixer/paths/analog-output-speaker-always.conf b/src/modules/alsa/mixer/paths/analog-output-speaker-always.conf

Re: [pulseaudio-discuss] [PATCH] Alsa: Correct port availability with multiple jacks

2014-10-27 Thread David Henningsson
On 2014-10-24 22:33, Sjoerd Simons wrote: In case there are two independent jacks for one port (e.g. Dock Headphone Jack and Headphone Jack), the availability ends up being incorrect for one of the first was _NO (not plugged) and the second gets _YES (plugged). Also pulse complains about the