Re: [pulseaudio-discuss] incomplete IPv6 support in pa_socket_client_new_string()

2014-11-05 Thread Tanu Kaskinen
On Wed, 2014-11-05 at 22:29 -0600, Hajime Fujita wrote: > Hi Tanu, > > Thank you for your comment and sorry for the late reply. > > Tanu Kaskinen wrote: > > On Tue, 2014-10-21 at 00:49 -0500, Hajime Fujita wrote: > >> Hello, > >> > >> I'm currently working on IPv6 support for the raop module [1].

Re: [pulseaudio-discuss] incomplete IPv6 support in pa_socket_client_new_string()

2014-11-05 Thread Hajime Fujita
Hi Tanu, Thank you for your comment and sorry for the late reply. Tanu Kaskinen wrote: On Tue, 2014-10-21 at 00:49 -0500, Hajime Fujita wrote: Hello, I'm currently working on IPv6 support for the raop module [1]. During the work I found a potential issue in pa_socket_client_new_string() (in

Re: [pulseaudio-discuss] [PATCH RFCv3 32/51] resampler: Drop pointless remix variable

2014-11-05 Thread David Henningsson
Ack On 2014-11-05 00:26, Peter Meerwald wrote: From: Peter Meerwald Signed-off-by: Peter Meerwald --- src/pulsecore/resampler.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/src/pulsecore/resampler.c b/src/pulsecore/resampler.c index 5e9dc39..8b30c24 100644 --- a/src/pulsecore/

Re: [pulseaudio-discuss] [PATCH v2] alsa-mixer: Add support for "Headphone+LO" and "Speaker+LO"

2014-11-05 Thread Raymond Yau
>>> >>> These two control names are currently being added to the HDA driver, >>> so let's support them in PulseAudio as well. >>> >>> Signed-off-by: David Henningsson >>> --- >>> >>> v2: Addressed comments by Tanu >>> >>> src/modules/alsa/mixer/paths/analog-output-headphones-2.conf | 8

Re: [pulseaudio-discuss] [PATCH RFCv3 00/51] optimizations

2014-11-05 Thread Alexander E. Patrakov
05.11.2014 04:25, Peter Meerwald wrote: this patch series aims to save memory allocations and some system calls related to PA's client/server protocol implementation Patches 49, 46, 41, 39, 35, 32, 24, 13, 12 are obviously correct. And I don't feel like looking at non-obvious patches after tod

Re: [pulseaudio-discuss] [PATCH 7/8] launch: Disable autospawn by default when systemd daemon support is enabled.

2014-11-05 Thread Felipe Sateler
On Tue, Nov 4, 2014 at 3:39 PM, Colin Guthrie wrote: > Felipe Sateler wrote on 03/11/14 20:28: >> On Mon, Nov 3, 2014 at 1:30 PM, Colin Guthrie wrote: >>> Felipe Sateler wrote on 03/11/14 12:55: Hi, I'm replying to this message but I the general question is a bit broader than

Re: [pulseaudio-discuss] [PATCH RFCv3 51/51] alsa: Remove redundant sample_spec parameter to reset_watermark() function

2014-11-05 Thread Peter Meerwald
On Wed, 5 Nov 2014, Alexander E. Patrakov wrote: > 05.11.2014 04:26, Peter Meerwald wrote: > > -/* work-around assert in pa_source_set_latency_within_thead, > > - keep track of min_latency and reuse it when > > - this routine is called from IO context */ > > +/*

Re: [pulseaudio-discuss] [PATCH RFCv3 51/51] alsa: Remove redundant sample_spec parameter to reset_watermark() function

2014-11-05 Thread Alexander E. Patrakov
05.11.2014 04:26, Peter Meerwald wrote: -/* work-around assert in pa_source_set_latency_within_thead, - keep track of min_latency and reuse it when - this routine is called from IO context */ +/* Work-around assert in pa_source_set_latency_within_thead, Typo

Re: [pulseaudio-discuss] [PATCH RFCv3 25/51] mainloop: Clear wakeup pipe only when necessary

2014-11-05 Thread Peter Meerwald
Hi, > > probably not in a measureable way; > > Hmm, but yet you listed this one as one of your "critical patches"...? ah, critical in the sense that it might break something, needs review... for most patches it is hard to say what the impact is (besides argueing that at malloc(), read(), etc.

Re: [pulseaudio-discuss] [PATCH RFCv3 25/51] mainloop: Clear wakeup pipe only when necessary

2014-11-05 Thread David Henningsson
On 2014-11-05 12:01, Peter Meerwald wrote: when the wakeup pipe became ready, and poll() returned just one descriptor, we can stop scanning io_events Eh, does this really make things faster? probably not in a measureable way; Hmm, but yet you listed this one as one of your "critical pat

Re: [pulseaudio-discuss] [PATCH v2] alsa-mixer: Add support for "Headphone+LO" and "Speaker+LO"

2014-11-05 Thread Tanu Kaskinen
On Wed, 2014-11-05 at 12:06 +0100, David Henningsson wrote: > > On 2014-11-04 11:53, Tanu Kaskinen wrote: > > On Mon, 2014-11-03 at 07:20 +0100, David Henningsson wrote: > >> diff --git a/src/modules/alsa/mixer/paths/analog-output-headphones-2.conf > >> b/src/modules/alsa/mixer/paths/analog-outpu

Re: [pulseaudio-discuss] [PATCH v2] alsa-mixer: Add support for "Headphone+LO" and "Speaker+LO"

2014-11-05 Thread David Henningsson
On 2014-11-04 11:53, Tanu Kaskinen wrote: On Mon, 2014-11-03 at 07:20 +0100, David Henningsson wrote: These two control names are currently being added to the HDA driver, so let's support them in PulseAudio as well. Signed-off-by: David Henningsson --- v2: Addressed comments by Tanu src/

Re: [pulseaudio-discuss] [PATCH RFCv3 25/51] mainloop: Clear wakeup pipe only when necessary

2014-11-05 Thread Peter Meerwald
> > when the wakeup pipe became ready, and poll() returned > > just one descriptor, we can stop scanning io_events > > Eh, does this really make things faster? probably not in a measureable way; I think the patch makes the codes more logical: * if we know that no io_event triggered, there is n

Re: [pulseaudio-discuss] [PATCH RFCv3 25/51] mainloop: Clear wakeup pipe only when necessary

2014-11-05 Thread David Henningsson
On 2014-11-05 00:26, Peter Meerwald wrote: From: Peter Meerwald when the wakeup pipe became ready, and poll() returned just one descriptor, we can stop scanning io_events Eh, does this really make things faster? Right now it seems to add another syscall - with the patch, we call clear_wak

Re: [pulseaudio-discuss] [PATCH RFCv3 00/51] optimizations

2014-11-05 Thread Peter Meerwald
Hi, > > > preliminary benchmarking on Intel i5-2400S, 64-bit, Linux 3.13: > > > > > > running 'paplay --latency-msec=10 stereo_48KHz.wav', output on internal > > > soundcard (Intel HDA), measuring the maximum CPU% in top for the > > > pulseaudio > > > and paplay > > > > > > code flags

Re: [pulseaudio-discuss] [PATCH RFCv3 21/51] pstream: Don't call defer_enable() on SHMRELEASE

2014-11-05 Thread Peter Meerwald
> > ... in order to increase the chance that SHMRELEASE will be combined > > with some other message; SHMRELEASE gets into the send queue, but > > the mainloop is not notified about it > > ...the idea being that shmrelease is not crucial to get any time soon, > it's just about reclaiming memory

Re: [pulseaudio-discuss] [PATCH RFCv3 21/51] pstream: Don't call defer_enable() on SHMRELEASE

2014-11-05 Thread David Henningsson
On 2014-11-05 00:26, Peter Meerwald wrote: From: Peter Meerwald ... in order to increase the chance that SHMRELEASE will be combined with some other message; SHMRELEASE gets into the send queue, but the mainloop is not notified about it ...the idea being that shmrelease is not crucial to ge

Re: [pulseaudio-discuss] Should corking be acknowledged by pa_sink_suspend()?

2014-11-05 Thread Ville Sundell
On 05.11.2014 11:57, Arun Raghavan wrote: On 5 November 2014 15:04, Ville Sundell wrote: Greetings everyone! I am having some problems with corking: pulseaudio policy enforcer will cork all the streams which belongs to a corked group. However, despite the fact corking itself happens correctly

Re: [pulseaudio-discuss] [PATCH RFCv3 00/51] optimizations

2014-11-05 Thread Peter Meerwald
Hi, > > preliminary benchmarking on Intel i5-2400S, 64-bit, Linux 3.13: > > > > running 'paplay --latency-msec=10 stereo_48KHz.wav', output on internal > > soundcard (Intel HDA), measuring the maximum CPU% in top for the pulseaudio > > and paplay > > > > code flags PA pa

Re: [pulseaudio-discuss] Should corking be acknowledged by pa_sink_suspend()?

2014-11-05 Thread Arun Raghavan
On 5 November 2014 15:04, Ville Sundell wrote: > Greetings everyone! > I am having some problems with corking: pulseaudio policy enforcer will cork > all the streams which belongs to a corked group. However, despite the fact > corking itself happens correctly (via pa_sink_input_cork() at > pulseau

Re: [pulseaudio-discuss] [PATCH RFCv3 00/51] optimizations

2014-11-05 Thread David Henningsson
On 2014-11-05 00:25, Peter Meerwald wrote: preliminary benchmarking on Intel i5-2400S, 64-bit, Linux 3.13: running 'paplay --latency-msec=10 stereo_48KHz.wav', output on internal soundcard (Intel HDA), measuring the maximum CPU% in top for the pulseaudio and paplay code flags

[pulseaudio-discuss] Should corking be acknowledged by pa_sink_suspend()?

2014-11-05 Thread Ville Sundell
Greetings everyone! I am having some problems with corking: pulseaudio policy enforcer will cork all the streams which belongs to a corked group. However, despite the fact corking itself happens correctly (via pa_sink_input_cork() at pulseaudio-policy-enforcement:src/policy-group.c) the stream