Re: [pulseaudio-discuss] LFE remixing

2014-11-06 Thread David Henningsson
On 2014-09-30 15:59, Alexander E. Patrakov wrote: 30.09.2014 19:07, David Henningsson wrote: On 2014-09-26 14:17, Tanu Kaskinen wrote: A summary of my proposal: To add LFE low-pass filtering, just hack the current remixer implementation, no need for interface changes anywhere. Actually,

Re: [pulseaudio-discuss] LFE remixing

2014-11-06 Thread Alexander E. Patrakov
06.11.2014 15:39, David Henningsson wrote: On 2014-09-30 15:59, Alexander E. Patrakov wrote: 30.09.2014 19:07, David Henningsson wrote: On 2014-09-26 14:17, Tanu Kaskinen wrote: A summary of my proposal: To add LFE low-pass filtering, just hack the current remixer implementation, no need

Re: [pulseaudio-discuss] [PATCH RFCv3 30/51] alsa: Make rtpoll_run() runtime measurement compile-time code, default off

2014-11-06 Thread David Henningsson
On 2014-11-05 00:26, Peter Meerwald wrote: safe two pa_rtclock_now() calls in ALSA thread function Signed-off-by: Peter Meerwald --- src/modules/alsa/alsa-sink.c | 9 ++--- src/modules/alsa/alsa-source.c | 9 ++--- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/

Re: [pulseaudio-discuss] [PATCH RFCv3 35/51] sample: Make pa_channels_valid() inlineable

2014-11-06 Thread David Henningsson
Uhm, doesn't this break the ABI? I e, the exported symbol "pa_channels_valid" will no longer exist in libpulse.so, causing existing apps to crash, unless they recompile against the new headers? On 2014-11-05 00:26, Peter Meerwald wrote: Signed-off-by: Peter Meerwald --- src/pulse/sample.c |

Re: [pulseaudio-discuss] [PATCH RFCv3 43/51] core: Add volume-util.h

2014-11-06 Thread David Henningsson
On 2014-11-05 00:26, Peter Meerwald wrote: implement inlineable functions PA_CVOLUME_VALID(), PA_CVOLUME_CHANNELS_EQUALS_TO(), PA_CVOLUME_IS_MUTED(), PA_CVOLUME_IS_NORM() that assume data is valid Why are these uppercase? AFAIK, we don't usually uppercase inline functions. Signed-off-by:

Re: [pulseaudio-discuss] [PATCH RFCv3 35/51] sample: Make pa_channels_valid() inlineable

2014-11-06 Thread Alexander E. Patrakov
Thanks for catching this! 06.11.2014 20:15, David Henningsson wrote: Uhm, doesn't this break the ABI? I e, the exported symbol "pa_channels_valid" will no longer exist in libpulse.so, causing existing apps to crash, unless they recompile against the new headers? On 2014-11-05 00:26, Peter Meerw

Re: [pulseaudio-discuss] [PATCH v2] alsa-mixer: Add support for "Headphone+LO" and "Speaker+LO"

2014-11-06 Thread David Henningsson
On 2014-11-05 12:33, Tanu Kaskinen wrote: On Wed, 2014-11-05 at 12:06 +0100, David Henningsson wrote: On 2014-11-04 11:53, Tanu Kaskinen wrote: On Mon, 2014-11-03 at 07:20 +0100, David Henningsson wrote: diff --git a/src/modules/alsa/mixer/paths/analog-output-headphones-2.conf b/src/module

Re: [pulseaudio-discuss] [PATCH RFCv3 43/51] core: Add volume-util.h

2014-11-06 Thread Peter Meerwald
> > implement inlineable functions PA_CVOLUME_VALID(), > > PA_CVOLUME_CHANNELS_EQUALS_TO(), PA_CVOLUME_IS_MUTED(), > > PA_CVOLUME_IS_NORM() that assume data is valid > > Why are these uppercase? AFAIK, we don't usually uppercase inline functions. I've modelled after e.g. PA_ALIGN_PTR() in pulsec

Re: [pulseaudio-discuss] [PATCH RFCv3 35/51] sample: Make pa_channels_valid() inlineable

2014-11-06 Thread Peter Meerwald
> Uhm, doesn't this break the ABI? I e, the exported symbol > "pa_channels_valid" will no longer exist in libpulse.so, causing > existing apps to crash, unless they recompile against the new headers? right; should add a PA_CHANNELS_VALID() to sample-util.h instead thanks, p. > On 2014-11-05

Re: [pulseaudio-discuss] [PATCH RFCv3 43/51] core: Add volume-util.h

2014-11-06 Thread Arun Raghavan
On 6 November 2014 21:07, Peter Meerwald wrote: > >> > implement inlineable functions PA_CVOLUME_VALID(), >> > PA_CVOLUME_CHANNELS_EQUALS_TO(), PA_CVOLUME_IS_MUTED(), >> > PA_CVOLUME_IS_NORM() that assume data is valid >> >> Why are these uppercase? AFAIK, we don't usually uppercase inline functio

Re: [pulseaudio-discuss] raop on gentoo+systemd

2014-11-06 Thread Martin Blanchard
Hello. On Thu, 2014-10-30 at 15:43 -0400, SGT. Garcia wrote: > hello, > i've got an airport express and i would like to use it as an output sound > device on this linux box. i read somewhere that pa would do this using its > raop module. i have added these lines in /etc/pulse/system.pa: What kind

Re: [pulseaudio-discuss] raop on gentoo+systemd

2014-11-06 Thread SGT. Garcia
On Nov 06 23:14 +0100, Martin Blanchard wrote: > Hello. > > On Thu, 2014-10-30 at 15:43 -0400, SGT. Garcia wrote: > > hello, > > i've got an airport express and i would like to use it as an output sound > > device on this linux box. i read somewhere that pa would do this using its > > raop module

Re: [pulseaudio-discuss] incomplete IPv6 support in pa_socket_client_new_string()

2014-11-06 Thread Hajime Fujita
Tanu Kaskinen wrote: On Wed, 2014-11-05 at 22:29 -0600, Hajime Fujita wrote: Hi Tanu, Thank you for your comment and sorry for the late reply. Tanu Kaskinen wrote: On Tue, 2014-10-21 at 00:49 -0500, Hajime Fujita wrote: Hello, I'm currently working on IPv6 support for the raop module [1].

Re: [pulseaudio-discuss] Should corking be acknowledged by pa_sink_suspend()?

2014-11-06 Thread Arun Raghavan
On 5 November 2014 15:44, Ville Sundell wrote: > > On 05.11.2014 11:57, Arun Raghavan wrote: >> >> On 5 November 2014 15:04, Ville Sundell wrote: >>> >>> Greetings everyone! >>> I am having some problems with corking: pulseaudio policy enforcer will >>> cork >>> all the streams which belongs to a