Re: [pulseaudio-discuss] [PATCH 0/4] Add support for libsoxr resampler

2014-11-12 Thread Andrey Semashev
On Thu, Nov 13, 2014 at 7:12 AM, Alexander E. Patrakov wrote: > 13.11.2014 01:16, Andrey Semashev пишет: >> >> However, the other three presets do have different performance and >> quality. In >> my test results [1] -mq is about 2 times faster than -vhq, and -hq is >> somewhere in between. Perform

Re: [pulseaudio-discuss] [PATCH 0/4] Add support for libsoxr resampler

2014-11-12 Thread Andrey Semashev
On Thu, Nov 13, 2014 at 8:33 AM, David Henningsson wrote: > > > On 2014-11-11 22:39, Andrey Semashev wrote: >> >> In short, libsoxr is almost always faster than speex, and introduces much >> less distortions. Its passband frequency is slightly lower than speex >> though, and it can add a delay up

Re: [pulseaudio-discuss] [PATCH 0/4] Add support for libsoxr resampler

2014-11-12 Thread David Henningsson
On 2014-11-11 22:39, Andrey Semashev wrote: In short, libsoxr is almost always faster than speex, and introduces much less distortions. Its passband frequency is slightly lower than speex though, and it can add a delay up to 20 ms in some cases. I'm interested in knowing more about the dela

Re: [pulseaudio-discuss] [PATCH 0/4] Add support for libsoxr resampler

2014-11-12 Thread Alexander E. Patrakov
13.11.2014 01:16, Andrey Semashev пишет: However, the other three presets do have different performance and quality. In my test results [1] -mq is about 2 times faster than -vhq, and -hq is somewhere in between. Performance wise, there should be no problem with -vhq on modern CPUs, but maybe the

Re: [pulseaudio-discuss] only ALAC! [Was: raop on gentoo+systemd]

2014-11-12 Thread SGT. Garcia
On Nov 12 21:23 +0100, Colin Leroy wrote: > On 12 November 2014 at 21h17, Martin Blanchard wrote: > > Hi, > > > RAOP has a ~2sec latency by design. Anyway, the current pulseaudio > > sink does not correctly report this latency. This results in > > synchronization problem between player (mpv her

Re: [pulseaudio-discuss] [PATCH 0/4] Add support for libsoxr resampler

2014-11-12 Thread Alexander E. Patrakov
13.11.2014 01:16, Andrey Semashev пишет: On Wednesday 12 November 2014 20:03:48 Alexander E. Patrakov wrote: 12.11.2014 14:26, Alexander E. Patrakov пишет: I will recheck the quality separately later today, in order to verify that it is still as good as in the previous tests. Please don't merge

Re: [pulseaudio-discuss] [PATCH] Fix sample_format_more_precise for the case of comparing two PA_SAMPLE_S32BE.

2014-11-12 Thread Peter Meerwald
> --- > src/pulsecore/resampler.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/pulsecore/resampler.c b/src/pulsecore/resampler.c > index 8b30c24..183d05f 100644 > --- a/src/pulsecore/resampler.c > +++ b/src/pulsecore/resampler.c > @@ -234,7 +234,7 @@ static bool s

Re: [pulseaudio-discuss] RAOP2 patch testing result

2014-11-12 Thread Martin Blanchard
On Tue, 2014-11-11 at 23:45 +0500, Alexander E. Patrakov wrote: > Hi. Hello Alexander! > I have cloned the raop2-v2 branch from > https://github.com/colinleroy/pulseaudio First, thanks for the testings. > The following test was applied. > > I have installed the "Android HiFi" application (als

[pulseaudio-discuss] [PATCH] Fix sample_format_more_precise for the case of comparing two PA_SAMPLE_S32BE.

2014-11-12 Thread Andrey Semashev
--- src/pulsecore/resampler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pulsecore/resampler.c b/src/pulsecore/resampler.c index 8b30c24..183d05f 100644 --- a/src/pulsecore/resampler.c +++ b/src/pulsecore/resampler.c @@ -234,7 +234,7 @@ static bool sample_format_more_p

Re: [pulseaudio-discuss] only ALAC! [Was: raop on gentoo+systemd]

2014-11-12 Thread Colin Leroy
On 12 November 2014 at 21h17, Martin Blanchard wrote: Hi, > RAOP has a ~2sec latency by design. Anyway, the current pulseaudio > sink does not correctly report this latency. This results in > synchronization problem between player (mpv here) and output stream. > This is a known issue; mpv is not

Re: [pulseaudio-discuss] only ALAC! [Was: raop on gentoo+systemd]

2014-11-12 Thread Martin Blanchard
On Wed, 2014-11-12 at 15:01 -0500, SGT. Garcia wrote: > > On Nov 12 20:43 +0100, Martin Blanchard wrote: > > > On Wed, 2014-11-12 at 10:30 -0500, SGT. Garcia wrote: > > > > > > thanks, it works now with "codec=ALAC". would it do FLAC? i mean what does > > > it entail to use ALAC? i also tried cod

Re: [pulseaudio-discuss] [PATCH 0/4] Add support for libsoxr resampler

2014-11-12 Thread Andrey Semashev
On Wednesday 12 November 2014 20:03:48 Alexander E. Patrakov wrote: > 12.11.2014 14:26, Alexander E. Patrakov пишет: > > I will recheck the quality separately later today, in order to verify > > that it is still as good as in the previous tests. Please don't merge > > the patches until this is done

Re: [pulseaudio-discuss] only ALAC! [Was: raop on gentoo+systemd]

2014-11-12 Thread SGT. Garcia
> On Nov 12 20:43 +0100, Martin Blanchard wrote: > > On Wed, 2014-11-12 at 10:30 -0500, SGT. Garcia wrote: > > > > thanks, it works now with "codec=ALAC". would it do FLAC? i mean what does > > it entail to use ALAC? i also tried codec=all which failed. > > Only ALAC is supported at the time. We

Re: [pulseaudio-discuss] only ALAC! [Was: raop on gentoo+systemd]

2014-11-12 Thread Martin Blanchard
On Wed, 2014-11-12 at 09:54 -0500, SGT. Garcia wrote: > On Nov 11 23:20 -0600, Hajime Fujita wrote: > > Hi, > > > > Probably you should supply more arguments to module-raop-sink. > > > > Here's a line from my log: > > ( 0.210| 0.000) I: [lt-pulseaudio] module.c: Loaded "module-raop-sink" > >

Re: [pulseaudio-discuss] only ALAC! [Was: raop on gentoo+systemd]

2014-11-12 Thread Martin Blanchard
On Wed, 2014-11-12 at 10:30 -0500, SGT. Garcia wrote: > On Nov 11 23:20 -0600, Hajime Fujita wrote: > > So at least you'll need "codec=ALAC", as well as other ones, maybe. > > > > Best, > > Hajime > > thanks, it works now with "codec=ALAC". would it do FLAC? i mean what does > it entail to use A

Re: [pulseaudio-discuss] only ALAC! [Was: raop on gentoo+systemd]

2014-11-12 Thread SGT. Garcia
On Nov 11 23:20 -0600, Hajime Fujita wrote: > So at least you'll need "codec=ALAC", as well as other ones, maybe. > > Best, > Hajime thanks, it works now with "codec=ALAC". would it do FLAC? i mean what does it entail to use ALAC? i also tried codec=all which failed.

Re: [pulseaudio-discuss] alternate-sample-rate and pavucontrol

2014-11-12 Thread Pierre-Louis Bossart
On 11/11/14, 4:06 PM, Marcus van Dam wrote: Hi, Today I ran into an issue regarding alternate-sample-rate. Hooking up my 16/48 DAC, I was hoping to play back some 48Khz FLAC files. With the defaults of: default-sample-rate = 44100 alternate-sample-rate = 48000 This should be possible, PA should

Re: [pulseaudio-discuss] [PATCH] alsa: Check respect return value of snd_pcm_mmap_commit()

2014-11-12 Thread Peter Meerwald
> > > > snd_pcm_mmap_commit() actually transfers the memory area prepared by > > > snd_pcm_mmap_begin(), > > > > it returns the 'count of transferred frames' which should be equal to > > > > the > > > number of frames > > > > returned by snd_pcm_mmap_begin() > > > > > > > > however, this identify

Re: [pulseaudio-discuss] [PATCH] alsa: Check respect return value of snd_pcm_mmap_commit()

2014-11-12 Thread David Henningsson
On 2014-11-12 14:31, Peter Meerwald wrote: Hi, snd_pcm_mmap_commit() actually transfers the memory area prepared by snd_pcm_mmap_begin(), it returns the 'count of transferred frames' which should be equal to the number of frames returned by snd_pcm_mmap_begin() however, this identify is

Re: [pulseaudio-discuss] only ALAC! [Was: raop on gentoo+systemd]

2014-11-12 Thread SGT. Garcia
On Nov 11 23:20 -0600, Hajime Fujita wrote: > Hi, > > Probably you should supply more arguments to module-raop-sink. > > Here's a line from my log: > ( 0.210| 0.000) I: [lt-pulseaudio] module.c: Loaded "module-raop-sink" > (index: #28; argument: "server=[192.168.1.130]:5000 > sink_name=raop_

Re: [pulseaudio-discuss] [PATCH] alsa: Check respect return value of snd_pcm_mmap_commit()

2014-11-12 Thread Peter Meerwald
Hi, > > snd_pcm_mmap_commit() actually transfers the memory area prepared by > snd_pcm_mmap_begin(), > > it returns the 'count of transferred frames' which should be equal to the > number of frames > > returned by snd_pcm_mmap_begin() > > > > however, this identify is not checked and the number of

Re: [pulseaudio-discuss] [PATCH] alsa: Check respect return value of snd_pcm_mmap_commit()

2014-11-12 Thread Alexander E. Patrakov
12.11.2014 18:25, David Henningsson wrote: On 2014-11-12 14:15, Peter Meerwald wrote: From: Peter Meerwald snd_pcm_mmap_commit() actually transfers the memory area prepared by snd_pcm_mmap_begin(), it returns the 'count of transferred frames' which should be equal to the number of frames ret

Re: [pulseaudio-discuss] [PATCH] alsa: Check respect return value of snd_pcm_mmap_commit()

2014-11-12 Thread David Henningsson
On 2014-11-12 14:15, Peter Meerwald wrote: From: Peter Meerwald snd_pcm_mmap_commit() actually transfers the memory area prepared by snd_pcm_mmap_begin(), it returns the 'count of transferred frames' which should be equal to the number of frames returned by snd_pcm_mmap_begin() however, th

[pulseaudio-discuss] [PATCH] alsa: Check respect return value of snd_pcm_mmap_commit()

2014-11-12 Thread Peter Meerwald
From: Peter Meerwald snd_pcm_mmap_commit() actually transfers the memory area prepared by snd_pcm_mmap_begin(), it returns the 'count of transferred frames' which should be equal to the number of frames returned by snd_pcm_mmap_begin() however, this identify is not checked and the number of fr

Re: [pulseaudio-discuss] [PATCH] build-sys: Fix a variable value check

2014-11-12 Thread Tanu Kaskinen
On Wed, 2014-11-12 at 17:53 +0530, Arun Raghavan wrote: > > On 12 Nov 2014 14:23, "Tanu Kaskinen" > wrote: > > diff --git a/configure.ac b/configure.ac > > index 26ebd8c..6b67dac 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -1468,7 +1468,7 @@ > AC_CONFIG_FILES([src/default.pa:src/d

Re: [pulseaudio-discuss] [PATCH 0/4] Add support for libsoxr resampler

2014-11-12 Thread Andrey Semashev
On Wed, Nov 12, 2014 at 2:30 PM, Alexander E. Patrakov wrote: > 12.11.2014 15:59, Andrey Semashev wrote: >> >> On Wed, Nov 12, 2014 at 12:26 PM, Alexander E. Patrakov >> wrote: >>> >>> >>> We generally don't need a zoo of resamplers. But you have definitely >>> changed >>> something important fro

Re: [pulseaudio-discuss] [PATCH] build-sys: Fix a variable value check

2014-11-12 Thread Arun Raghavan
On 12 Nov 2014 14:23, "Tanu Kaskinen" wrote: > > --- > > Can anyone explain why pulseaudio.service seems to get generated even > without this fix? Git master works fine for me also without this fix. > I only noticed this bug, because it stopped to work when I added a > system service file (make co

Re: [pulseaudio-discuss] [PATCH 2/4] Enabled libsoxr resampler backend.

2014-11-12 Thread Andrey Semashev
On Wed, Nov 12, 2014 at 1:03 PM, Peter Meerwald wrote: > >> Also fixed a bug in sample_format_more_precise for 32-bit integer sample >> formats. > > can you please split out the bug fix as a separate patch? > it can be readily applied Ok, will do. ___

Re: [pulseaudio-discuss] [PATCH 1/4] Added libsoxr resampler backend.

2014-11-12 Thread Andrey Semashev
On Wed, Nov 12, 2014 at 3:00 PM, Alexander E. Patrakov wrote: > 12.11.2014 16:57, Andrey Semashev wrote: >> >> It's a common approach for injecting a message into the assertion >> failure. The C runtime typically displays the condition that fails, >> and in this case it will include the message. I

Re: [pulseaudio-discuss] [PATCH 1/4] Added libsoxr resampler backend.

2014-11-12 Thread Alexander E. Patrakov
12.11.2014 16:57, Andrey Semashev wrote: It's a common approach for injecting a message into the assertion failure. The C runtime typically displays the condition that fails, and in this case it will include the message. It helps debugging. We have pa_assert_not_reached just for that. It doesn'

Re: [pulseaudio-discuss] [PATCH 1/4] Added libsoxr resampler backend.

2014-11-12 Thread Andrey Semashev
On Wed, Nov 12, 2014 at 1:15 PM, Peter Meerwald wrote: > >> +switch (r->work_format) { >> +case PA_SAMPLE_S16NE: >> +io_format = SOXR_INT16_I; >> +break; >> +case PA_SAMPLE_S32NE: >> +io_format = SOXR_INT32_I; >> +break; > > curre

Re: [pulseaudio-discuss] [PATCH 0/4] Add support for libsoxr resampler

2014-11-12 Thread Alexander E. Patrakov
12.11.2014 15:59, Andrey Semashev wrote: On Wed, Nov 12, 2014 at 12:26 PM, Alexander E. Patrakov wrote: We generally don't need a zoo of resamplers. But you have definitely changed something important from an earlier submission by Peter Meerwald so that the CPU figure became much better. I gue

Re: [pulseaudio-discuss] Patch review status wiki page updated

2014-11-12 Thread Tanu Kaskinen
On Wed, 2014-11-12 at 11:55 +0100, Peter Meerwald wrote: > > Patch review status updated: > > http://www.freedesktop.org/wiki/Software/PulseAudio/PatchStatus/ > > pactl: Remove deprecated 'stat' behaviour > has already been applied > > build-sys: Check for bluez package > is superceded by David's

Re: [pulseaudio-discuss] [PATCH 0/4] Add support for libsoxr resampler

2014-11-12 Thread Andrey Semashev
On Wed, Nov 12, 2014 at 12:26 PM, Alexander E. Patrakov wrote: > > We generally don't need a zoo of resamplers. But you have definitely changed > something important from an earlier submission by Peter Meerwald so that the > CPU figure became much better. I guess, that's SOXR_LINEAR_PHASE - that's

Re: [pulseaudio-discuss] Patch review status wiki page updated

2014-11-12 Thread Peter Meerwald
> Patch review status updated: > http://www.freedesktop.org/wiki/Software/PulseAudio/PatchStatus/ pactl: Remove deprecated 'stat' behaviour has already been applied build-sys: Check for bluez package is superceded by David's "Build both headsets" series, http://lists.freedesktop.org/archives/pu

Re: [pulseaudio-discuss] [PATCH 0/4] Add support for libsoxr resampler

2014-11-12 Thread Peter Meerwald
Hi, > > These patches add support for libsoxr resampler library to PulseAudio. The > resampler is exposed in four selectable quality presets: lq, mq, hq and vhq > (in the order of increasing quality). The patches update the code, build > system and docs. > > > > libsoxr[1] is a resampler library e

Re: [pulseaudio-discuss] [PATCH 2/2] system-tunnel-manager: New module for managing tunnels to remote servers

2014-11-12 Thread Tanu Kaskinen
On Wed, 2014-11-12 at 12:13 +0200, Tanu Kaskinen wrote: > Currently the module only supports creating tunnels for all devices in > the system instance, which is useful for implementing the "cascaded > setup" (user instances running on top of the system instance). In the > future it should be config

Re: [pulseaudio-discuss] [PATCH 1/4] Added libsoxr resampler backend.

2014-11-12 Thread Peter Meerwald
comments below > --- > src/pulsecore/resampler/soxr.c | 168 > + > 1 file changed, 168 insertions(+) > create mode 100644 src/pulsecore/resampler/soxr.c > > diff --git a/src/pulsecore/resampler/soxr.c b/src/pulsecore/resampler/soxr.c > new file mode 100

[pulseaudio-discuss] [PATCH 2/2] system-tunnel-manager: New module for managing tunnels to remote servers

2014-11-12 Thread Tanu Kaskinen
Currently the module only supports creating tunnels for all devices in the system instance, which is useful for implementing the "cascaded setup" (user instances running on top of the system instance). In the future it should be configurable which remote server(s) and which devices to use. --- src

[pulseaudio-discuss] [PATCH 1/2] module: Add PA_CORE_HOOK_MODULE_UNLOAD

2014-11-12 Thread Tanu Kaskinen
--- src/pulsecore/core.h | 1 + src/pulsecore/module.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/src/pulsecore/core.h b/src/pulsecore/core.h index 1f9df73..db7308c 100644 --- a/src/pulsecore/core.h +++ b/src/pulsecore/core.h @@ -128,6 +128,7 @@ typedef enum pa_core_hook { PA_CO

[pulseaudio-discuss] [PATCH 0/2] module-tunnel-manager

2014-11-12 Thread Tanu Kaskinen
This is the first version of module-tunnel-manager. It was created to help with the "cascaded setup" that we're building in Tizen IVI, i.e. we want to run a system instance to handle hardware that should be usable by multiple users simultaneously (or possibly even all hardware, and indeed currently

Re: [pulseaudio-discuss] [PATCH 1/4] Added libsoxr resampler backend.

2014-11-12 Thread Peter Meerwald
Hello Andrey, > The new backend supports 4 quality levels: lq, mq, hq and vhq; 16 and > 32-bit integer samples and 32-bit float samples. The libsoxr resampler > generally offers better quality and speed compared to speex. soxr support was proposed previously, http://lists.freedesktop.org/archiv

Re: [pulseaudio-discuss] [PATCH 2/4] Enabled libsoxr resampler backend.

2014-11-12 Thread Peter Meerwald
> Also fixed a bug in sample_format_more_precise for 32-bit integer sample > formats. can you please split out the bug fix as a separate patch? it can be readily applied thanks, p. > --- > src/pulsecore/resampler.c | 32 ++-- > src/pulsecore/resampler.h | 5 +

Re: [pulseaudio-discuss] [PATCH 0/4] Add support for libsoxr resampler

2014-11-12 Thread Alexander E. Patrakov
12.11.2014 02:39, Andrey Semashev пишет: Hi, These patches add support for libsoxr resampler library to PulseAudio. The resampler is exposed in four selectable quality presets: lq, mq, hq and vhq (in the order of increasing quality). The patches update the code, build system and docs. libsox

[pulseaudio-discuss] [PATCH] build-sys: Fix a variable value check

2014-11-12 Thread Tanu Kaskinen
--- Can anyone explain why pulseaudio.service seems to get generated even without this fix? Git master works fine for me also without this fix. I only noticed this bug, because it stopped to work when I added a system service file (make complained that there was no rule to make daemon/systemd/syst