Re: [pulseaudio-discuss] [PATCH] alsa-util: No logging when sound card only supports non-interleaved sample format

2014-11-15 Thread Raymond Yau
> > as suggested by > https://bugs.freedesktop.org/show_bug.cgi?id=84804 > > Signed-off-by: Peter Meerwald > --- > src/modules/alsa/alsa-util.c | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/src/modules/alsa/alsa-util.c b/src/modules/alsa/alsa-util.c > index 4131cff..e3

Re: [pulseaudio-discuss] Server string syntax ambiguity?

2014-11-15 Thread Glenn Golden
Peter Meerwald [2014-11-15 19:46:13 +0100]: > > > Is there an ambiguity issue with server strings containing unix domain > > socket paths that in turn contain embedded whitespace? Or are such > > whitespace-containing socket paths prohibited by some construction > > rule that I'm probably not awa

Re: [pulseaudio-discuss] Server string syntax ambiguity?

2014-11-15 Thread Peter Meerwald
> Is there an ambiguity issue with server strings containing unix domain socket > paths that in turn contain embedded whitespace? Or are such whitespace- > containing socket paths prohibited by some construction rule that I'm probably > not aware of? I think there is (haven't tried); this is a se

[pulseaudio-discuss] Server string syntax ambiguity?

2014-11-15 Thread Glenn Golden
Is there an ambiguity issue with server strings containing unix domain socket paths that in turn contain embedded whitespace? Or are such whitespace- containing socket paths prohibited by some construction rule that I'm probably not aware of? Here's what I'm getting at: The Wiki writeup on server

[pulseaudio-discuss] [PATCH] man: Describe optional prefix {string} in server address

2014-11-15 Thread Peter Meerwald
see https://bugs.freedesktop.org/show_bug.cgi?id=84024 Signed-off-by: Peter Meerwald --- man/pulseaudio.1.xml.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/man/pulseaudio.1.xml.in b/man/pulseaudio.1.xml.in index 7a97379..dd787bb 100644 --- a/man/pulseaudio.1.xml.in ++

[pulseaudio-discuss] [PATCH] alsa-util: No logging when sound card only supports non-interleaved sample format

2014-11-15 Thread Peter Meerwald
as suggested by https://bugs.freedesktop.org/show_bug.cgi?id=84804 Signed-off-by: Peter Meerwald --- src/modules/alsa/alsa-util.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/modules/alsa/alsa-util.c b/src/modules/alsa/alsa-util.c index 4131cff..e382d4f 100644 --- a/s

[pulseaudio-discuss] [PATCH] context: pa_context_connect() with PA_CONTEXT_NOFAIL should return 0 when waiting for PA on D-Dus

2014-11-15 Thread Peter Meerwald
see https://bugs.freedesktop.org/show_bug.cgi?id=85011 in case NOAUTOSPAWN is set and no server has been specified, PA starts listening on DBUS for a new server, and the state is PA_CONTEXT_CONNECTING, but pa_context_connect() returns -1; it should return 0. Signed-off-by: Peter Meerwald ---

[pulseaudio-discuss] [PATCH] dbus: Fix uninitialized new_active warning

2014-11-15 Thread Peter Meerwald
modules/dbus/iface-device.c: In function 'handle_set_active_port': modules/dbus/iface-device.c:765:34: warning: 'new_active' may be used uninitialized in this function [-Wmaybe-uninitialized] if ((r = pa_sink_set_port(d->sink, pa_dbusiface_device_port_get_name(new_active), true)) < 0) {