Re: [pulseaudio-discuss] [PATCH v2] memblock: Detect block ID collisions in pa_memimport_get

2014-12-09 Thread Peter Meerwald
> > Make sure we don't hand out the wrong block, in case we have the > > same block ID in different SHM segments. > > typo below, looks good otherwise maybe it doesn't look that good; the message triggers from time to time in testing and then crashes my application need to investigate, p. > >

[pulseaudio-discuss] Some more valgrind warnings

2014-12-09 Thread Alexander E. Patrakov
Found this series of valgrind warnings on today's master while working on unrelated task. The warnings can be triggered by pactl load-module module-null-sink. The first bad commit is: Author: David Henningsson Date: Fri Dec 5 11:54:39 2014 +0100 memblock: Avoid block ID collisions when

Re: [pulseaudio-discuss] System mode & SHM

2014-12-09 Thread Pali Rohár
On Sunday 07 December 2014 00:23:08 Tanu Kaskinen wrote: > On Sat, 2014-12-06 at 23:59 +0100, Pali Rohár wrote: > > On Saturday 06 December 2014 23:20:10 Tanu Kaskinen wrote: > > > On Sun, 2014-11-23 at 14:43 +0100, Pali Rohár wrote: > > > > On Sunday 23 November 2014 09:25:46 David Henningsson wr

[pulseaudio-discuss] [PATCH] memblock: Initialize mempool object to zero

2014-12-09 Thread David Henningsson
This fixes a "use of uninitialised value" error in previous memblock commit. Reported-by: Alexander Patrakov Signed-off-by: David Henningsson --- src/pulsecore/memblock.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/pulsecore/memblock.c b/src/pulsecore/memblock.c in

Re: [pulseaudio-discuss] [PATCH] memblock: Initialize mempool object to zero

2014-12-09 Thread Alexander E. Patrakov
10.12.2014 03:00, David Henningsson wrote: This fixes a "use of uninitialised value" error in previous memblock commit. I have just tested it - indeed, no more valgrind warnings :) Reported-by: Alexander Patrakov Signed-off-by: David Henningsson --- src/pulsecore/memblock.c | 3 +-- 1 f