Re: [pulseaudio-discuss] [PATCH] svolume.orc: avoid parameter loading undefined behaviour

On 7 January 2015 at 15:50, Wim Taymans wrote: > In some cases, depending on the instruction that performs the load, orc > ignores the size of the parameter when loading it for the first time. > Explicitly load the parameter into a temp to make sure it is loaded > correctly, like we do for the 2ch

Re: [pulseaudio-discuss] module-remap-sink not working for surround card

2015-01-09 12:59 GMT+01:00 Tanu Kaskinen : > It sounds like the surround51 alsa device isn't working as it should. > What if you try "speaker-test -D surround51:0 -c 6 -t wav"? Does it work > as expected? > This is working as expected (i.e. the from the rear output I hear "rear left, rear right" an

Re: [pulseaudio-discuss] [PATCH 2/4] Enabled libsoxr resampler backend.

> Added ID and names for the resampler presets and also updated the working > sample rate deduction to take the new resampler into account. what to do with PA_RESAMPLER_VARIABLE_RATE? resampler_soxr_update_rates() just recreates the context, I guess this will lead to crackling sound (not teste

[pulseaudio-discuss] [PATCH 1/3] alsa-util: fix parenthesis position in err assignment

Issue detected by CppCheck and PVS Studio --- src/modules/alsa/alsa-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/alsa/alsa-util.c b/src/modules/alsa/alsa-util.c index 4131cff..a9469c0 100644 --- a/src/modules/alsa/alsa-util.c +++ b/src/modules/alsa/alsa-ut

[pulseaudio-discuss] [PATCH 2/3] tunnel: use proper value for pa_source_state switch

pa_source_state_t can have value PA_SOURCE_INVALID_STATE, not PA_SINK_INVALID_STATE. It happens to be the same here, but it can break sometimes. Issue detected by PVS Studio. --- src/modules/module-tunnel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/module-tun

[pulseaudio-discuss] [PATCH 0/3] Fix few issues detected by static analysis

Hello folks. User maksqwe on Russian website habrahabr checked pulseuadio sources with PVS Studio static analyzer and found a few issues. I additionaly checked it with Cppcheck analyzer. Fixes follows. There are more issues, I try to make fixes for them too shortly. Boris Egorov (3): alsa-util

[pulseaudio-discuss] [PATCH 3/3] pacmd: add missing 'else' keyword

See code above for proper behavior. Issue detected by PVS Studio --- src/utils/pacmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/utils/pacmd.c b/src/utils/pacmd.c index 61b87a0..7e49296 100644 --- a/src/utils/pacmd.c +++ b/src/utils/pacmd.c @@ -333,7 +333,7 @@ int ma

[pulseaudio-discuss] Stream corruption using simple API after network lag

All, I've been trying to pin down the cause of an audio issue with pulseaudio and an application called Quisk.  This is a software defined radio application that uses I&Q sampling (L&R channels) via a sound card. The SDR radio has both audio in and out going to a Wolfson pi audio card attached t