Re: [pulseaudio-discuss] Revisiting raop2 patches

2016-11-05 Thread Hajime Fujita
Anton Lundin wrote: > On 30 October, 2016 - Hajime Fujita wrote: >> >>> On Oct 26, 2016, at 9:58 PM, Hajime Fujita wrote: >>> On Oct 25, 2016, at 3:47 PM, Anton Lundin wrote: >>> Also, value is set to NULL in some parsing blocks and not in others. Some blocks strdup(value), and let

Re: [pulseaudio-discuss] Revisiting raop2 patches

2016-11-05 Thread Hajime Fujita
So now I have a new set of patches which (hopefully) address all of Anton's following comments. Now the patches are rebased against `next`, as some of the raop patches have already been merged here. I think the standard practice is to rebase patches on top of master, but for this case can I sim

Re: [pulseaudio-discuss] [PATCH] Added fixed port (46400) option for rtp sender

2016-11-05 Thread NicoHood
On 11/05/2016 12:16 PM, Rémi Denis-Courmont wrote: > Le lauantaina 5. marraskuuta 2016, 8.24.57 EET NicoHood a écrit : >> From: NicoHood > The IETF standard RTP/RTCP ports number pair is 5004-5005, not 46400... > That is a good point. Pulseaudio uses random ports for rtp. So would you go for 5004

[pulseaudio-discuss] [PATCH] Added fixed port (46400) option for rtp sender

2016-11-05 Thread NicoHood
From: NicoHood --- src/paprefs.cc| 23 --- src/paprefs.glade | 56 ++- 2 files changed, 67 insertions(+), 12 deletions(-) diff --git a/src/paprefs.cc b/src/paprefs.cc index 9f3ad31..78c2730 100644 --- a/src/paprefs.cc +