[pulseaudio-discuss] [PATCH 1/4] roap: Fix double free

2017-02-22 Thread Peter Meerwald-Stadler
make nick variable local, fix double free Coverity CID: #1398162 Signed-off-by: Peter Meerwald-Stadler --- src/modules/raop/raop-sink.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/modules/raop/raop-sink.c b/src/modules/raop/raop-sink.c index 7d8fe36..d321a2d 100

[pulseaudio-discuss] [PATCH 2/4] roap-client: Fix loop searching for port number

2017-02-22 Thread Peter Meerwald-Stadler
do...while not reachable, loop should try different ports in case EADDRINUSE is returned Coverity ID: #1398161 Signed-off-by: Peter Meerwald-Stadler --- src/modules/raop/raop-client.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/modules/raop/raop-client.c

[pulseaudio-discuss] [PATCH 3/4] roap: Fix memleak

2017-02-22 Thread Peter Meerwald-Stadler
use local scope for trs variable simplifying cleanup Coverity ID: #1398160 Signed-off-by: Peter Meerwald-Stadler --- src/modules/raop/raop-client.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/modules/raop/raop-client.c b/src/modules/raop/raop-client.c index e39

[pulseaudio-discuss] [PATCH 4/4] raop: Fix resource leaks

2017-02-22 Thread Peter Meerwald-Stadler
Coverity ID: #1398158, #1398159 Signed-off-by: Peter Meerwald-Stadler --- src/modules/raop/raop-client.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/modules/raop/raop-client.c b/src/modules/raop/raop-client.c index 4c3083e..03558f6 100644 --- a/src/modu

Re: [pulseaudio-discuss] Coverity scan

2017-02-22 Thread Philip Withnall
Hi, On Wed, 2017-02-22 at 12:38 +0100, Peter Meerwald-Stadler wrote: > as written and discussed before ( > https://lists.freedesktop.org/archives/pulseaudio-discuss/2015-Septem > ber/024378.html > http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/19270 > http://pulseaudio-discuss.freed

Re: [pulseaudio-discuss] Coverity scan

2017-02-22 Thread Philip Withnall
Hi, On Wed, 2017-02-22 at 11:52 +, Philip Withnall wrote: > Apologies if this has been discussed before (I don’t follow > PulseAudio > development), but why not stick this in the server-side Coverity > modelling file? Does that not work? Having just tried it, apparently it doesn’t work. I gue

[pulseaudio-discuss] Coverity scan

2017-02-22 Thread Peter Meerwald-Stadler
Hi, as written and discussed before ( https://lists.freedesktop.org/archives/pulseaudio-discuss/2015-September/024378.html http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/19270 http://pulseaudio-discuss.freedesktop.narkive.com/RH83JeQl/coverity-and-pa-asser-se ) I think we need to te