Re: [pulseaudio-discuss] [PATCH v2 01/10] build: Add Coverity scan model

2017-03-07 Thread Peter Meerwald-Stadler
> Ack, go ahead and push this. Do we need to modify our Coverity project > settings? pushed, no need to modify server side Coverity settings Philip can re-enable the periodic scans thanks, p. -- Peter Meerwald-Stadler Mobile: +43 664 24 44 418 ___

Re: [pulseaudio-discuss] [PATCH v2 01/10] build: Add Coverity scan model

2017-03-07 Thread Philip Withnall
On Tue, 2017-03-07 at 10:02 +0100, Peter Meerwald-Stadler wrote: > > Ack, go ahead and push this. Do we need to modify our Coverity > > project > > settings? > > pushed, no need to modify server side Coverity settings > > Philip can re-enable the periodic scans Re-enabled, and I’ve queued a new

Re: [pulseaudio-discuss] module-echo-cancel microphone gain auto-adjust

2017-03-07 Thread Vasco Almeida
Às 05:08 de 2017-03-07, Arun Raghavan escreveu: The update to webrtc-audio-processing did make the AGC less quick to react to input energy level changes. We might need to update the code based on upstream again to see if things have gotten better. By default, is the level of your mic (without mo

Re: [pulseaudio-discuss] module-echo-cancel microphone gain auto-adjust

2017-03-07 Thread Arun Raghavan
On Tue, 7 Mar 2017, at 03:20 PM, Vasco Almeida wrote: > Às 05:08 de 2017-03-07, Arun Raghavan escreveu: > > The update to webrtc-audio-processing did make the AGC less quick to > > react to input energy level changes. We might need to update the code > > based on upstream again to see if things hav

Re: [pulseaudio-discuss] [PATCH v2 01/10] build: Add Coverity scan model

2017-03-07 Thread Tanu Kaskinen
On Tue, 2017-03-07 at 10:02 +0100, Peter Meerwald-Stadler wrote: > > Ack, go ahead and push this. Do we need to modify our Coverity project > > settings? > > pushed, no need to modify server side Coverity settings You seemed to push the whole patch set without responding to the issues that Hajime

Re: [pulseaudio-discuss] [PATCH] iochannel: don't use variable length array in union

2017-03-07 Thread Georg Chini
On 04.02.2017 13:19, Tanu Kaskinen wrote: Clang didn't like the variable length array: pulsecore/iochannel.c:358:17: error: fields must have a constant size: 'variable length array in structure' extension will never be supported uint8_t data[CMSG_SPACE(sizeof(int) * nfd)];

[pulseaudio-discuss] [PATCH 1/3 v2] backend-native: add support for the HSP Headset role

2017-03-07 Thread Georg Chini
From: Wim Taymans This is a rebase of Wim Taymans patch to support the HSP headset role that has somehow been forgotten. Original patch can be found at https://lists.freedesktop.org/archives/pulseaudio-discuss/2015-February/023242.html Rebase and minor changes by Georg Chini. In addition to the

[pulseaudio-discuss] New reviewer: Georg Chini

2017-03-07 Thread Tanu Kaskinen
Hi all, A small (or maybe big? or mid-sized?) announcement: Georg Chini kindly offered to help with reviewing patches, and we granted him commit rights too. This should reduce our problems with keeping up with the incoming patches. -- Tanu https://www.patreon.com/tanuk

Re: [pulseaudio-discuss] New reviewer: Georg Chini

2017-03-07 Thread Peter Meerwald-Stadler
> Georg Chini kindly offered to help with reviewing patches, and we > granted him commit rights too. This should reduce our problems with > keeping up with the incoming patches. great, welcome! -- Peter Meerwald-Stadler Mobile: +43 664 24 44 418 ___

Re: [pulseaudio-discuss] [PATCH 1/3 v2] backend-native: add support for the HSP Headset role

2017-03-07 Thread Tanu Kaskinen
On Tue, 2017-03-07 at 13:44 +0100, Georg Chini wrote: > From: Wim Taymans > > > This is a rebase of Wim Taymans patch to support the HSP headset role that has > somehow been forgotten. Original patch can be found at > https://lists.freedesktop.org/archives/pulseaudio-discuss/2015-February/023242

Re: [pulseaudio-discuss] New reviewer: Georg Chini

2017-03-07 Thread Felipe Sateler
On Tue, Mar 7, 2017 at 10:09 AM, Tanu Kaskinen wrote: > Hi all, > > A small (or maybe big? or mid-sized?) announcement: > > Georg Chini kindly offered to help with reviewing patches, and we > granted him commit rights too. This should reduce our problems with > keeping up with the incoming patches

Re: [pulseaudio-discuss] [PATCH] iochannel: don't use variable length array in union

2017-03-07 Thread Tanu Kaskinen
On Tue, 2017-03-07 at 13:42 +0100, Georg Chini wrote: > On 04.02.2017 13:19, Tanu Kaskinen wrote: > > Clang didn't like the variable length array: > > > > pulsecore/iochannel.c:358:17: error: fields must have a constant size: > > 'variable length array in structure' extension will never be support

Re: [pulseaudio-discuss] New reviewer: Georg Chini

2017-03-07 Thread Georg Chini
On 07.03.2017 14:09, Tanu Kaskinen wrote: Hi all, A small (or maybe big? or mid-sized?) announcement: Georg Chini kindly offered to help with reviewing patches, and we granted him commit rights too. This should reduce our problems with keeping up with the incoming patches. Thanks for the anno

[pulseaudio-discuss] [PATCH 1/3] build: Use #ifdef to check for #defines

2017-03-07 Thread Peter Meerwald-Stadler
for example, in case HAVE_MEMFD is #undef, checking with #if HAVE_MEMFD gives a warning (gcc 5.4.1, Ubuntu) pulsecore/shm.c: In function 'sharedmem_create': pulsecore/shm.c:208:5: warning: "HAVE_MEMFD" is not defined [-Wundef] #if HAVE_MEMFD use #ifdef or #if defined() to check for presence of a

[pulseaudio-discuss] [PATCH 2/3] core-util: Fix description of pa_split()

2017-03-07 Thread Peter Meerwald-Stadler
Signed-off-by: Peter Meerwald-Stadler --- src/pulsecore/core-util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pulsecore/core-util.c b/src/pulsecore/core-util.c index cd1c96d..d4cfa20 100644 --- a/src/pulsecore/core-util.c +++ b/src/pulsecore/core-util.c @@ -1062,

[pulseaudio-discuss] [PATCH 3/3] raop: Fix check for invalid file descriptor

2017-03-07 Thread Peter Meerwald-Stadler
file descriptor 0 is valid Signed-off-by: Peter Meerwald-Stadler --- src/modules/raop/raop-client.c | 30 +++--- src/modules/raop/raop-sink.c | 2 +- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/modules/raop/raop-client.c b/src/modules/raop/raop

[pulseaudio-discuss] [PATCH 0/3] misc cleanups

2017-03-07 Thread Peter Meerwald-Stadler
Peter Meerwald-Stadler (3): build: Use #ifdef to check for #defines core-util: Fix description of pa_split() raop: Fix check for invalid file descriptor src/modules/dbus/module-dbus-protocol.c | 4 ++-- src/modules/raop/raop-client.c | 30 +++--- src/module

Re: [pulseaudio-discuss] [PATCH v2 01/10] build: Add Coverity scan model

2017-03-07 Thread Peter Meerwald-Stadler
Hello, > > > Ack, go ahead and push this. Do we need to modify our Coverity project > > > settings? > > > > pushed, no need to modify server side Coverity settings > > You seemed to push the whole patch set without responding to the issues > that Hajime pointed out. Was this intentional? no, I

Re: [pulseaudio-discuss] [PATCH v2 1/2] Fix wrong input device in module-waveout

2017-03-07 Thread Tanu Kaskinen
On Wed, 2017-03-01 at 19:29 +0100, Moritz Bruder wrote: > Both input and output device were chosen with the same device number. > This is problematic as those numbers don't have to correspond. > Additionally the input device was named after the output device. This > commit adresses both issues by p

[pulseaudio-discuss] Fwd: HFP no audio

2017-03-07 Thread Sinthu Raja M
Hi all, I am currently working in Bluez5.43+Ofono+Pulseaduio9 to make HFP works. My target device doesn't have a microphone only a speaker. I am running the following daemons. bluetoothd ofonod pulseaudio Then I tried connecting to the mobile phone, it got connected. when I tried playing music

[pulseaudio-discuss] [PATCH] pulsecore: disable incompatible MMX and SSE code on x86 macOS.

2017-03-07 Thread Mihai Moldovan
We need the same workaround FreeBSD uses. --- src/pulsecore/svolume_mmx.c | 8 src/pulsecore/svolume_sse.c | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/pulsecore/svolume_mmx.c b/src/pulsecore/svolume_mmx.c index 1bf70bea..5d39234f 100644 --- a/src/pulse