Re: [pulseaudio-discuss] ifdef foo

2017-03-15 Thread Peter Meerwald-Stadler
> In src/modules/module-protocol-stub.c > I see the following comment > >449 #else /* USE_TCP_SOCKETS */ the comment relates to the #ifdef USE_TCP_SOCKETS likely above the idea is to show what the #else is for (this can become complicated in case of nested #ifdefs) >450 if (u->s

Re: [pulseaudio-discuss] ifdef foo

2017-03-15 Thread Timothy Hobbs
OK, next question. In src/modules/module-protocol-stub.c I see the following comment 449 #else /* USE_TCP_SOCKETS */ 450 if (u->socket_server_unix) 451 if (pa_socket_server_get_address(u->socket_server_unix, t, sizeof(t))) 452 pa_http_protocol_remove_server_string(

Re: [pulseaudio-discuss] ifdef foo

2017-03-15 Thread Tanu Kaskinen
On Wed, 2017-03-15 at 22:35 +0100, Timothy Hobbs wrote: > I thought that was what it was. I was just confused by the use of "foo", > which is usually used when prototyping something... Is it convention > just for PA or is it a wider C convention? I haven't seen it outside PulseAudio. -- Tanu

Re: [pulseaudio-discuss] ifdef foo

2017-03-15 Thread Timothy Hobbs
I thought that was what it was. I was just confused by the use of "foo", which is usually used when prototyping something... Is it convention just for PA or is it a wider C convention? On 03/15/2017 10:34 PM, Tanu Kaskinen wrote: On Wed, 2017-03-15 at 20:00 +0100, Timothy Hobbs wrote: I noti

Re: [pulseaudio-discuss] ifdef foo

2017-03-15 Thread Tanu Kaskinen
On Wed, 2017-03-15 at 20:00 +0100, Timothy Hobbs wrote: > I noticed when looking through the source to pulseaudio 5.0 as aquired > from debain that in file: > > src/module-simple-protocol-unix-symdef.h > > There are the following ifdef foo lines: > > 0 #ifndef foomodulesimpleprotocolunixsy

Re: [pulseaudio-discuss] pulseaudio-discuss Digest, Vol 71, Issue 30

2017-03-15 Thread Smurf En Drek
text/plain; charset="utf-8" > > What is the best way to get system wide audio dynamic range compression? I > have seen some very complicated solutions to this seemingly simple problem. > What currently is the best way of doing this? > -- next part -- >

[pulseaudio-discuss] ifdef foo

2017-03-15 Thread Timothy Hobbs
I noticed when looking through the source to pulseaudio 5.0 as aquired from debain that in file: src/module-simple-protocol-unix-symdef.h There are the following ifdef foo lines: 0 #ifndef foomodulesimpleprotocolunixsymdeffoo 1 #define foomodulesimpleprotocolunixsymdeffoo Is this inte

[pulseaudio-discuss] [PATCH] bluetooth-policy: retain backwards compatibility

2017-03-15 Thread Tanu Kaskinen
The auto_switch argument was added in PulseAudio 10.0. In that release the argument type was boolean. The type was changed to integer in commit 3397127f00. This patch adds backwards compatibility so that old configuration files won't break when upgrading PulseAudio to 11.0. --- src/modules/bluetoo