[pulseaudio-discuss] [PATCH 3/3] virtual sources and sinks: Don't double attach a sink input or source output on filter load

When a filter is loaded and module-switch-on-connect is present, switch-on-connect will make the filter the default sink or source and move streams from the old default to the filter. This is done from the sink/source put hook, therefore streams are moved to the filter before the module init

[pulseaudio-discuss] [PATCH 2/3] virtual sinks and sources: Revert commits

This patch reverts commit db4fbb0121a2577d786cda023a6a439a9734f152 and 3bb94c4e836ca765a36255e416fd8e6cf272ab44. They were the wrong approach to fix the bug (and did not fix it anyway). --- src/modules/echo-cancel/module-echo-cancel.c | 6 ++ src/modules/module-ladspa-sink.c | 3

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

On 06.05.2017 22:15, Georg Chini wrote: On 06.05.2017 22:06, Tanu Kaskinen wrote: On Sat, 2017-05-06 at 20:06 +0200, Georg Chini wrote: On 06.05.2017 18:36, Tanu Kaskinen wrote: On Fri, 2017-05-05 at 16:21 +0200, Georg Chini wrote: I agree with you that my patch is wrong, but I think there is

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

On 06.05.2017 22:06, Tanu Kaskinen wrote: On Sat, 2017-05-06 at 20:06 +0200, Georg Chini wrote: On 06.05.2017 18:36, Tanu Kaskinen wrote: On Fri, 2017-05-05 at 16:21 +0200, Georg Chini wrote: I agree with you that my patch is wrong, but I think there is a simpler solution than your patch. The

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

On Sat, 2017-05-06 at 20:06 +0200, Georg Chini wrote: > On 06.05.2017 18:36, Tanu Kaskinen wrote: > > On Fri, 2017-05-05 at 16:21 +0200, Georg Chini wrote: > > > I agree with you that my patch is wrong, but I think there is a simpler > > > solution than your patch. The reason why the move is

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

On 06.05.2017 18:36, Tanu Kaskinen wrote: On Fri, 2017-05-05 at 16:21 +0200, Georg Chini wrote: On 04.05.2017 20:11, Tanu Kaskinen wrote: On Wed, 2017-05-03 at 22:19 +0200, Georg Chini wrote: On 03.05.2017 21:58, Tanu Kaskinen wrote: On Tue, 2017-05-02 at 07:12 +0200, Georg Chini wrote: On

Re: [pulseaudio-discuss] Problems with loading the module-echo-cancel with webrtc

On Thu, 2017-05-04 at 15:35 +0200, Koenraad Verheyden wrote: > Hey all, > > I'm using the module-echo-cancel using webrtc. I'm having two problems > loading the module: > > 1) I can't figure out how to pass multiple aec_args. When I do > > $ pactl load-module module-echo-cancel

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

On Fri, 2017-05-05 at 16:21 +0200, Georg Chini wrote: > On 04.05.2017 20:11, Tanu Kaskinen wrote: > > On Wed, 2017-05-03 at 22:19 +0200, Georg Chini wrote: > > > On 03.05.2017 21:58, Tanu Kaskinen wrote: > > > > On Tue, 2017-05-02 at 07:12 +0200, Georg Chini wrote: > > > > > On 01.05.2017 22:10,

Re: [pulseaudio-discuss] [PATCH v5 5/7] bluetooth: Auto recover if profile is 'off'

On Fri, 2017-05-05 at 16:41 +0300, Luiz Augusto von Dentz wrote: > Hi Tanu, > > On Thu, May 4, 2017 at 3:29 PM, Tanu Kaskinen wrote: > > On Thu, 2017-05-04 at 12:58 +0300, Luiz Augusto von Dentz wrote: > > > From: Luiz Augusto von Dentz > > > > > > This