Re: [pulseaudio-discuss] [PATCH 0/2] module-card-restore fixes

2017-11-09 Thread Georg Chini
On 08.11.2017 13:20, Tanu Kaskinen wrote: Tanu Kaskinen (2): card-restore: log the correct profile name card-restore: don't restore unavailable profiles src/modules/module-card-restore.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) Look both good. ___

Re: [pulseaudio-discuss] [PATCH 0/2] module-echo-cancel fixes

2017-11-09 Thread Raman Gupta
On 09/11/17 07:12 AM, Tanu Kaskinen wrote: > Tanu Kaskinen (2): > echo-cancel: ignore remaining canceller messages after the module has > been unloaded > echo-cancel: fix a memory leak > > src/modules/echo-cancel/module-echo-cancel.c | 22 ++ > 1 file changed, 22 inser

Re: [pulseaudio-discuss] [PATCH 1/5] core: add simple message interface

2017-11-09 Thread Tanu Kaskinen
On Sun, 2017-10-29 at 20:51 +0100, Georg Chini wrote: > This patch adds a new feature to the core which allows to send messages > to objects. An object can register/unregister a message handler with > pa_message_handler_{register, unregister}() while a message can be sent > to the handler using the

[pulseaudio-discuss] some patches

2017-11-09 Thread jnqnfe
some patches for master attached 1) Constify a param in pa_cvolume_scale_mask 2) A small efficiency tweak to volume handling 3) A big collection of API documentation improvements Includes typo fixes; neatening; addition of more return info; and such 4) A patch merging and deduplicating some pa_buf

[pulseaudio-discuss] [PATCH] pulsecore: declaration/implementation mismatches

2017-11-09 Thread Constantine Kharlamov
Fixes the following compiler errors: ./pulsecore/sconv-s16be.h:41:6: warning: type of 'pa_sconv_s24_32be_from_float32ne' does not match original declaration [-Wlto-type-mismatch] void pa_sconv_s24_32be_from_float32ne(unsigned n, const float *a, uint8_t *b); ^ pulsecore/sconv-s16le.c:413:6

[pulseaudio-discuss] [PATCH 0/2] module-echo-cancel fixes

2017-11-09 Thread Tanu Kaskinen
Tanu Kaskinen (2): echo-cancel: ignore remaining canceller messages after the module has been unloaded echo-cancel: fix a memory leak src/modules/echo-cancel/module-echo-cancel.c | 22 ++ 1 file changed, 22 insertions(+) -- 2.14.2 ___

[pulseaudio-discuss] [PATCH 1/2] echo-cancel: ignore remaining canceller messages after the module has been unloaded

2017-11-09 Thread Tanu Kaskinen
Not ignoring the messages caused crashing due to accessing the userdata after it had been freed. BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=103528 --- src/modules/echo-cancel/module-echo-cancel.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/modules/echo-

[pulseaudio-discuss] [PATCH 2/2] echo-cancel: fix a memory leak

2017-11-09 Thread Tanu Kaskinen
The pa_echo_canceller_msg object was never unreffed. --- src/modules/echo-cancel/module-echo-cancel.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/modules/echo-cancel/module-echo-cancel.c b/src/modules/echo-cancel/module-echo-cancel.c index ee3725abd..4fc837d2a 1006

Re: [pulseaudio-discuss] How to check visually for XRUNs/drop-out/interruptions and similar in PulseAudio?

2017-11-09 Thread Tanu Kaskinen
On Wed, 2017-11-08 at 15:31 +0100, 21na...@gmail.com wrote: > Le 08/11/2017 à 12:43, Tanu Kaskinen a écrit : > > The issues with rewinds were about monitor sources and resampling. If I > > understood correctly, your source material is in 48000 Hz and Jack is > > configured with that rate too, so th