[pulseaudio-discuss] [PATCH] optimize set_state_in_io_thread() callbacks

2018-03-20 Thread Raman Shyshniou
Source and sink are passed in arguments to set_state_in_io_thread() callbacks. There is optimal to access them directly. --- src/modules/alsa/alsa-sink.c | 6 +++--- src/modules/alsa/alsa-source.c | 6 +++--- src/modules/bluetooth/module-bluez4-device.c | 8

[pulseaudio-discuss] [PATCH v10 2/3] pipe-source: respect frame boundaries

2018-03-20 Thread Raman Shyshniou
Currently pipe-source doesn't track frame boundaries while posting data. This can lead to assertion failure in source-output for any sample specs except s8/u8 mono. The simplest way to reproduce is to write s24le format to pipe: $ pacat -r -d null --format=s24le > /tmp/music.input E:

[pulseaudio-discuss] [PATCH v10 3/3] pipe-source: implement autosuspend option

2018-03-20 Thread Raman Shyshniou
This patch implements the autosuspend option. Setting autosuspend to false restores original pipe-source behaviour. --- src/modules/module-pipe-source.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/modules/module-pipe-source.c

[pulseaudio-discuss] [PATCH v10 1/3] pipe-source: implement autosuspend behavior

2018-03-20 Thread Raman Shyshniou
Currently the pipe-source will remain running even if no writer is connected and therefore no data is produced. This patch prevents this by auto-suspending source when all writers are disconnected. --- src/modules/module-pipe-source.c | 207 --- 1 file changed,

Re: [pulseaudio-discuss] [PATCH v2 4/4] bluetooth: Rename *bluez5 modules to bluetooth

2018-03-20 Thread Tanu Kaskinen
On Tue, 2018-03-20 at 11:24 +0200, Luiz Augusto von Dentz wrote: > Hi, > > On Mon, Mar 19, 2018 at 11:35 PM, Felipe Sateler wrote: > > > > > > On Mon, Mar 19, 2018 at 5:39 AM, Luiz Augusto von Dentz > > wrote: > > > > > > From: Luiz Augusto von

Re: [pulseaudio-discuss] [PATCH v2 4/4] bluetooth: Rename *bluez5 modules to bluetooth

2018-03-20 Thread Luiz Augusto von Dentz
Hi, On Mon, Mar 19, 2018 at 11:35 PM, Felipe Sateler wrote: > > > On Mon, Mar 19, 2018 at 5:39 AM, Luiz Augusto von Dentz > wrote: >> >> From: Luiz Augusto von Dentz >> >> Since there is no longer support for BlueZ 4 it makes

Re: [pulseaudio-discuss] [PATCH v3 0/2] State change refactoring, port change crash fix

2018-03-20 Thread Georg Chini
On 19.03.2018 22:11, Tanu Kaskinen wrote: Here are the last two patches that are required for fixing https://bugs.freedesktop.org/show_bug.cgi?id=104761 Changes in v3: - I simplified the variable assignments in sink/source_set_state() after a failed resume. - I reduced the