Re: [pulseaudio-discuss] License problem: LDAC codec & pulseaudio

2019-02-23 Thread Tanu Kaskinen
On Sat, 2019-02-23 at 16:06 +0100, Pali Rohár wrote: > Hello, > > I would like to discuss about licence problems with usage of LDAC > encoder libldac in pulseaudio. LDAC is a codec used by some Sony > bluetooth headsets and it would be nice to have support for it after my > patch series for

Re: [pulseaudio-discuss] Current status of wideband speech?

2019-02-23 Thread Ta-Lun Yen
Diego, Thanks for the info. Seems like I am missing something here, since it will error on entering HSP/HFP mode: I: [bluetooth] module-bluez5-device.c: Transport /org/bluez/hci0/dev_/fd45 resuming D: [bluetooth] module-bluez5-device.c: Stream properly set up, we're ready to roll! E:

[pulseaudio-discuss] License problem: LDAC codec & pulseaudio

2019-02-23 Thread Pali Rohár
Hello, I would like to discuss about licence problems with usage of LDAC encoder libldac in pulseaudio. LDAC is a codec used by some Sony bluetooth headsets and it would be nice to have support for it after my patch series for Modular API for A2DP codecs is merged. There is only one released

Re: [pulseaudio-discuss] [PATCH v6 00/11] New API for Bluetooth A2DP codecs

2019-02-23 Thread Pali Rohár
On Wednesday 13 February 2019 17:27:19 Tanu Kaskinen wrote: > On Sat, 2019-02-09 at 20:00 +0100, Pali Rohár wrote: > > Hello, as there is still open discussion about codec API and choosing > > codec, can you at least review first 4 patches which are independent of > > this problem? > > I can

[pulseaudio-discuss] [PATCH v7 12/13] bluetooth: Implement A2DP codec switching and backchannel support

2019-02-23 Thread Pali Rohár
Some A2DP codecs (like FastStream or aptX Low Latency) are bi-directional and can be used for both music playback and audio call. This patch implements usage of backchannel if A2DP codec provided by pulseaudio API supports it. A2DP codec switching needs new version of bluez as older version does

[pulseaudio-discuss] [PATCH v7 10/13] bluetooth: Add more variants of SBC codec

2019-02-23 Thread Pali Rohár
Specify configuration for Low, Middle, High and Ultra High Quality of SBC codec. SBC codec in Ultra High Quality has higher quality than aptX. Automatic Quality mode matches configuration of SBC codec which was used before this change. Which means that it accept configuration between Low and High

[pulseaudio-discuss] [PATCH v7 04/13] bluetooth: Modular API for A2DP codecs

2019-02-23 Thread Pali Rohár
This patch introduce new modular API for bluetooth A2DP codecs. Its benefits are: * bluez5-util and module-bluez5-device does not contain any codec specific code, they are codec independent. * For adding new A2DP codec it is needed just to adjust one table in a2dp-codec-util.c file. All

[pulseaudio-discuss] [PATCH v7 02/13] bluetooth: policy: Remove BlueZ 4 related code

2019-02-23 Thread Pali Rohár
--- src/modules/bluetooth/module-bluetooth-policy.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/modules/bluetooth/module-bluetooth-policy.c b/src/modules/bluetooth/module-bluetooth-policy.c index 4d3126f65..0a6d59d28 100644 ---

[pulseaudio-discuss] [PATCH v7 09/13] bluetooth: Add A2DP FastStream codec support

2019-02-23 Thread Pali Rohár
This patch provides support for FastStream codec in bluetooth A2DP profile. FastStream codec is bi-directional, which means that support both music playback and microphone voice at the same time. FastStream codec is just SBC codec with fixed parameters. For playback are used following parameters:

[pulseaudio-discuss] [PATCH v7 00/13] New API for Bluetooth A2DP codecs

2019-02-23 Thread Pali Rohár
This is 7th version of my patch series for modular A2DP codec API and aptX support. Main change for v7 version is splitting Modular API patch into two: first (4/13) which implements API and second (12/13) which implements codec switching via separate profiles. Main objections were for exporting

[pulseaudio-discuss] [PATCH v7 01/13] switch-on-port-available: Fix null pointer dereference

2019-02-23 Thread Pali Rohár
Sometimes on pulseaudio startup card->active_profile is NULL. --- src/modules/module-switch-on-port-available.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/module-switch-on-port-available.c b/src/modules/module-switch-on-port-available.c index

[pulseaudio-discuss] [PATCH v7 03/13] bluetooth: Update a2dp-codecs.h from upstream bluez project

2019-02-23 Thread Pali Rohár
--- src/modules/bluetooth/a2dp-codecs.h | 336 +++- src/modules/bluetooth/bluez5-util.c | 6 +- 2 files changed, 331 insertions(+), 11 deletions(-) diff --git a/src/modules/bluetooth/a2dp-codecs.h b/src/modules/bluetooth/a2dp-codecs.h index 8afcfcb24..93e9d3523

[pulseaudio-discuss] [PATCH v7 06/13] bluetooth: Clean up SBC bitpool calculation

2019-02-23 Thread Pali Rohár
Remove dead code and replace numeric bitpool values by macro definitions. Maximal bitpool value in fill_capabilities() was reduced from 64 to 53 (SBC_BITPOOL_HQ_JOINT_STEREO_44100) because default_bitpool() already set maximal value to 53. This patch does not change SBC behavior as maximal

[pulseaudio-discuss] [PATCH v7 13/13] bluetooth: policy: Treat bi-directional A2DP profiles as suitable for VOIP

2019-02-23 Thread Pali Rohár
Previously module-bluetooth-policy was switching from A2DP to HSP profile when VOIP application started recording of source. Now it switch to profile with the highest priority which has both sink and source. In most cases it is HSP profile, but it can be also bi-directional A2DP profile (e.g.

[pulseaudio-discuss] [PATCH v7 11/13] bluetooth: policy: Reflect a2dp profile names

2019-02-23 Thread Pali Rohár
In next patches, codec name is appended end the end of a2dp profile names. --- src/modules/bluetooth/module-bluetooth-policy.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/modules/bluetooth/module-bluetooth-policy.c

[pulseaudio-discuss] [PATCH v7 05/13] bluetooth: Add missing validations for SBC codec parameters

2019-02-23 Thread Pali Rohár
--- src/modules/bluetooth/a2dp-codec-sbc.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/modules/bluetooth/a2dp-codec-sbc.c b/src/modules/bluetooth/a2dp-codec-sbc.c index 3db827db3..170dfc39d 100644 --- a/src/modules/bluetooth/a2dp-codec-sbc.c +++

[pulseaudio-discuss] [PATCH v7 08/13] bluetooth: Add A2DP aptX and aptX HD codecs support

2019-02-23 Thread Pali Rohár
This patch provides support for aptX and aptX HD codecs in bluetooth A2DP profile. It uses open source LGPLv2.1+ licensed libopenaptx library which can be found at https://github.com/pali/libopenaptx. aptX for s24 stereo samples provides fixed 6:1 compression ratio and bitrate 352.8 kbit/s, aptX

[pulseaudio-discuss] [PATCH v7 07/13] bluetooth: Set correct endianity for SBC codec

2019-02-23 Thread Pali Rohár
In A2DP is SBC always in little endian. But libsbc library uses by default host endianity, so it was broken on big endian systems. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=91359 --- src/modules/bluetooth/a2dp-codec-sbc.c | 1 + 1 file changed, 1 insertion(+) diff --git