Re: [pulseaudio-discuss] pulseaudio master is frozen

2019-07-05 Thread Pali Rohár
On Tuesday 02 July 2019 08:56:08 Pali Rohár wrote: > On Tuesday 02 July 2019 08:56:29 Tanu Kaskinen wrote: > > On Mon, 2019-07-01 at 11:29 +0530, Arun Raghavan wrote: > > > Hi folks, > > > As we were discussing, 13.0 is a bit overdue, so we're freezing > > > master now. Release tracker issue is at:

Re: [pulseaudio-discuss] [PATCH v11 01/11] bluetooth: Fix A2DP codec API to provide information about data buffer

2019-07-05 Thread Pali Rohár
On Tuesday 18 June 2019 10:07:15 Tanu Kaskinen wrote: > On Mon, 2019-06-17 at 12:05 +0200, Pali Rohár wrote: > > On Saturday 15 June 2019 11:50:10 Tanu Kaskinen wrote: > > > Although I made that mistake, I think I'm right in saying that our > > > reading logic is broken at least with SBC. The sende

[pulseaudio-discuss] [PATCH v12 05/13] bluetooth: Print SO_TIMESTAMP warning for SCO source only once

2019-07-05 Thread Pali Rohár
--- src/modules/bluetooth/module-bluez5-device.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/modules/bluetooth/module-bluez5-device.c b/src/modules/bluetooth/module-bluez5-device.c index efb092089..a97c6c703 100644 --- a/src/modules/bluetooth/module-bluez5-device.c

[pulseaudio-discuss] [PATCH v12 02/13] bluetooth: Change A2DP codec API of reset() method to indicate failure

2019-07-05 Thread Pali Rohár
SBC codec reset() method may fail, so propagate this failure to caller. --- src/modules/bluetooth/a2dp-codec-api.h | 4 ++-- src/modules/bluetooth/a2dp-codec-sbc.c | 5 +++-- src/modules/bluetooth/module-bluez5-device.c | 18 -- 3 files changed, 17 insertions(+), 10 d

[pulseaudio-discuss] [PATCH v12 08/13] bluetooth: Add A2DP aptX and aptX HD codecs support

2019-07-05 Thread Pali Rohár
This patch provides support for aptX and aptX HD codecs in bluetooth A2DP profile. It uses open source LGPLv2.1+ licensed libopenaptx library which can be found at https://github.com/pali/libopenaptx. aptX for s24 stereo samples provides fixed 6:1 compression ratio and bitrate 352.8 kbit/s, aptX H

[pulseaudio-discuss] [PATCH v12 07/13] bluetooth: Set initial A2DP profile which bluez already activated

2019-07-05 Thread Pali Rohár
Bluez and remote device decide which A2DP codec would use. Use this selected A2DP codec as initial profile in pulseaudio. In most cases it is either last used codec or codec with higher priority by defined by remote device. To detect which A2DP profile was activated by bluez, look at bluez transp

[pulseaudio-discuss] [PATCH v12 03/13] bluetooth: Fix usage of RTP structures in SBC codec

2019-07-05 Thread Pali Rohár
Rename struct rtp_payload to rtp_sbc_payload as it is specific for SBC codec payload. Add proper checks for endianity in rtp.h header and use uint8_t type where appropriated. Field frame_count is only 4 bit number, so add checks to prevent overflow. And because is_fragmented field is not parsed

[pulseaudio-discuss] [PATCH v12 01/13] bluetooth: Fix usage of MTU, buffer sizes and return values of encode/decode methods

2019-07-05 Thread Pali Rohár
Add explanation why minimal bitpool value is used in SBC codec as initial bitpool value for A2DP source. Set buffer size for reading/writing from/to A2DP socket to exact link MTU value. This would ensure that A2DP codec does not produce larger packet as maximal possible size which can be sent. Be

[pulseaudio-discuss] [PATCH v12 11/13] bluetooth: policy: Reflect a2dp profile names

2019-07-05 Thread Pali Rohár
In next patches, codec name is appended end the end of a2dp profile names. --- src/modules/bluetooth/module-bluetooth-policy.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/modules/bluetooth/module-bluetooth-policy.c b/src/modules/bluetooth/module-bluetooth-

[pulseaudio-discuss] [PATCH v12 04/13] bluetooth: Implement reading SO_TIMESTAMP for A2DP source

2019-07-05 Thread Pali Rohár
--- src/modules/bluetooth/module-bluez5-device.c | 33 ++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/src/modules/bluetooth/module-bluez5-device.c b/src/modules/bluetooth/module-bluez5-device.c index 0b63cd44a..efb092089 100644 --- a/src/modules/blueto

[pulseaudio-discuss] [PATCH v12 09/13] bluetooth: Add A2DP FastStream codec support

2019-07-05 Thread Pali Rohár
This patch provides support for FastStream codec in bluetooth A2DP profile. FastStream codec is bi-directional, which means that support both music playback and microphone voice at the same time. FastStream codec is just SBC codec with fixed parameters. For playback are used following parameters:

[pulseaudio-discuss] [PATCH v12 12/13] bluetooth: Implement A2DP codec switching and backchannel support

2019-07-05 Thread Pali Rohár
Some A2DP codecs (like FastStream or aptX Low Latency) are bi-directional and can be used for both music playback and audio call. This patch implements usage of backchannel if A2DP codec provided by pulseaudio API supports it. A2DP codec switching needs new version of bluez as older version does n

[pulseaudio-discuss] [PATCH v12 10/13] bluetooth: Add more variants of SBC codec

2019-07-05 Thread Pali Rohár
Specify configuration for Low, Middle, High and eXtreme Quality of SBC codec. SBC codec in eXtreme Quality has higher quality than aptX. Automatic Quality mode matches configuration of SBC codec which was used before this change. Which means that it accept configuration between Low and High qualit

[pulseaudio-discuss] [PATCH v12 13/13] bluetooth: policy: Treat bi-directional A2DP profiles as suitable for VOIP

2019-07-05 Thread Pali Rohár
Previously module-bluetooth-policy was switching from A2DP to HSP profile when VOIP application started recording of source. Now it switch to profile with the highest priority which has both sink and source. In most cases it is HSP profile, but it can be also bi-directional A2DP profile (e.g. FastS

[pulseaudio-discuss] [PATCH v12 00/13] Bluetooth A2DP codecs

2019-07-05 Thread Pali Rohár
Changes in v12: * Renamed SBC UHQ to SBC XQ to match naming convention from http://soundexpert.org/articles/-/blogs/audio-quality-of-sbc-xq-bluetooth-audio-codec * Throw error when PA receive fragmented SBC frame * Log "Couldn't find SO_TIMESTAMP" warning message only once * Update comment for S

[pulseaudio-discuss] [PATCH v12 06/13] bluetooth: Parse remote timestamp from A2DP RTP packets when available

2019-07-05 Thread Pali Rohár
Some A2DP codecs (e.g. SBC or aptX-HD) use RTP packets. For sources use timestamps from RTP packets to calculate read index and therefore remote timestamp for synchronization. --- src/modules/bluetooth/a2dp-codec-api.h | 4 ++-- src/modules/bluetooth/a2dp-codec-sbc.c | 3 ++- src/mod

Re: [pulseaudio-discuss] [PATCH v2 4/8] core: move sink-inputs conditionally when update default_sink

2019-07-05 Thread Georg Chini
On 05.07.19 10:57, Georg Chini wrote: On 05.07.19 09:41, Tanu Kaskinen wrote: On Tue, 2019-07-02 at 09:08 +0200, Georg Chini wrote: On 02.07.19 08:43, Tanu Kaskinen wrote: On Mon, 2019-07-01 at 08:03 +0200, Georg Chini wrote: On 01.07.19 07:08, Tanu Kaskinen wrote: On Sun, 2019-06-30 at 13:5

Re: [pulseaudio-discuss] [PATCH v2 4/8] core: move sink-inputs conditionally when update default_sink

2019-07-05 Thread Georg Chini
On 05.07.19 09:56, Tanu Kaskinen wrote: On Tue, 2019-07-02 at 10:25 +0200, Georg Chini wrote: On 02.07.19 06:49, Tanu Kaskinen wrote: On Mon, 2019-07-01 at 08:48 +0200, Georg Chini wrote: On 01.07.19 08:03, Georg Chini wrote: On 01.07.19 07:08, Tanu Kaskinen wrote: On Sun, 2019-06-30 at 13:5

Re: [pulseaudio-discuss] [PATCH v2 4/8] core: move sink-inputs conditionally when update default_sink

2019-07-05 Thread Georg Chini
On 05.07.19 09:41, Tanu Kaskinen wrote: On Tue, 2019-07-02 at 09:08 +0200, Georg Chini wrote: On 02.07.19 08:43, Tanu Kaskinen wrote: On Mon, 2019-07-01 at 08:03 +0200, Georg Chini wrote: On 01.07.19 07:08, Tanu Kaskinen wrote: On Sun, 2019-06-30 at 13:52 +0200, Georg Chini wrote: On 17.01.1

Re: [pulseaudio-discuss] [PATCH v2 4/8] core: move sink-inputs conditionally when update default_sink

2019-07-05 Thread Tanu Kaskinen
On Tue, 2019-07-02 at 10:25 +0200, Georg Chini wrote: > On 02.07.19 06:49, Tanu Kaskinen wrote: > > On Mon, 2019-07-01 at 08:48 +0200, Georg Chini wrote: > > > On 01.07.19 08:03, Georg Chini wrote: > > > > On 01.07.19 07:08, Tanu Kaskinen wrote: > > > > > On Sun, 2019-06-30 at 13:52 +0200, Georg Ch

Re: [pulseaudio-discuss] [PATCH v2 4/8] core: move sink-inputs conditionally when update default_sink

2019-07-05 Thread Tanu Kaskinen
On Tue, 2019-07-02 at 09:08 +0200, Georg Chini wrote: > On 02.07.19 08:43, Tanu Kaskinen wrote: > > On Mon, 2019-07-01 at 08:03 +0200, Georg Chini wrote: > > > On 01.07.19 07:08, Tanu Kaskinen wrote: > > > > On Sun, 2019-06-30 at 13:52 +0200, Georg Chini wrote: > > > > > On 17.01.19 07:53, Hui Wang