[pulseaudio-discuss] [PATCH 1/3] alsa-util: fix parenthesis position in err assignment

Issue detected by CppCheck and PVS Studio --- src/modules/alsa/alsa-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/alsa/alsa-util.c b/src/modules/alsa/alsa-util.c index 4131cff..a9469c0 100644 --- a/src/modules/alsa/alsa-util.c +++ b/src/modules/alsa/alsa-ut

[pulseaudio-discuss] [PATCH 2/3] tunnel: use proper value for pa_source_state switch

pa_source_state_t can have value PA_SOURCE_INVALID_STATE, not PA_SINK_INVALID_STATE. It happens to be the same here, but it can break sometimes. Issue detected by PVS Studio. --- src/modules/module-tunnel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/module-tun

[pulseaudio-discuss] [PATCH 0/3] Fix few issues detected by static analysis

Hello folks. User maksqwe on Russian website habrahabr checked pulseuadio sources with PVS Studio static analyzer and found a few issues. I additionaly checked it with Cppcheck analyzer. Fixes follows. There are more issues, I try to make fixes for them too shortly. Boris Egorov (3): alsa

[pulseaudio-discuss] [PATCH 3/3] pacmd: add missing 'else' keyword

See code above for proper behavior. Issue detected by PVS Studio --- src/utils/pacmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/utils/pacmd.c b/src/utils/pacmd.c index 61b87a0..7e49296 100644 --- a/src/utils/pacmd.c +++ b/src/utils/pacmd.c @@ -333,7 +333,7 @@ int ma

Re: [pulseaudio-discuss] [PATCH 0/3] Fix few issues detected by static analysis

and found that some of them starts with uppercase letter and another with lowercase. I'll remember that. -- Best regards, Boris Egorov ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

[pulseaudio-discuss] [PATCH] sink-input: Fix logical error in condition

RUNNING. Issue detected by PVS Studio and Cppcheck. Signed-off-by: Boris Egorov --- src/pulsecore/sink-input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pulsecore/sink-input.c b/src/pulsecore/sink-input.c index d95a93e..29beca6 100644 --- a/src/pulsecore/sink