Apologies, but I had an error in my previous patch. The #if test
was reversed. Sorry about this. The attached patch is correct.
Brian
On 05/22/12 08:55 PM, Brian Cameron wrote:
I am attaching 3 patches for consideration upstream:
- pulseaudio-05-shm.diff
The shm files on Solaris end up
Maarten:
1024*1024*16 or 16,777,216 (or 16M) is a very common number in
computer programs. Why not just define and use something like
SIXTEEN_MB in a common header file instead of hardcoding 1024*1024*16
in different places where it needs to be kept in sync. This should
not be so complicated.
Cameron wrote:
Oops, I just realized that I didn't attach the debug log attachment.
Now attached.
Brian
On 11/ 2/11 03:02 PM, Brian Cameron wrote:
I notice that PulseAudio version 1.1 seems to leave behind shared
memory files when my GNOME session exits, or when I kill the pulseaudio
daemon
Oops, I just realized that I didn't attach the debug log attachment.
Now attached.
Brian
On 11/ 2/11 03:02 PM, Brian Cameron wrote:
I notice that PulseAudio version 1.1 seems to leave behind shared
memory files when my GNOME session exits, or when I kill the pulseaudio
daemon from within my
I notice that PulseAudio version 1.1 seems to leave behind shared
memory files when my GNOME session exits, or when I kill the pulseaudio
daemon from within my GNOME session.
For example, when my session is running I see 3 shared memory files,
associated with the following processes:
- The
Maarten:
I updated the patch as attached to address your comments. This
has #ifdef __sun used more properly and a comment.
Also note that I added a comment to the bug to answer your question
that LOG_INFO and LOG_WARNING are defined in the system syslog.h
header, not in PulseAudio.
Brian
Maarten:
Thanks for the pointers, you helped me figure out how to get PulseAudio
building on Solaris without libpulsecommon needing to link against
libpulsecore.
The issue seems to be caused by the fact that libpulsecommon includes
pulsecore/pstream.c, which includes pulsecore/core-scache.h to
Maarten:
Do I conclude correctly from the bug that in pulse 1.0 it isn't true
anymore that the library dependencies are:
libpulse - libpulsecommon
libpulsecore - libpulsecommon
I am not familiar enough with PulseAudio to be able to describe the
library dependencies. I just know that
Maarten:
Your proposed patch clashes with pa_module_info in src/pulse/introspect.h.
Perhaps not on the compiler level, but at least it's very confusing
for the reader.
My patch just shows how to fix the problem. Feel free to rename the
variables to whatever makes most sense. If you tell me
