Hi Arun,
On Fri, Oct 26, 2012 at 5:48 AM, Arun Raghavan
wrote:
> I just pushed out a fix for this (commit 4171df301).
It is ok,
Thank you,
Frédéric
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedesktop.o
Hi folks,
This patch triggers the following error on my computer :
./.libs/libpulsecommon-2.98.so: undefined reference to `pa_sw_volume_from_dB'
Build is fine at previous commit.
Regards,
Frédéric
On Thu, Oct 25, 2012 at 11:13 AM, Tanu Kaskinen wrote:
> On Wed, 2012-10-24 at 17:29 -0200, Flavio
Hi Tanu,
On Fri, Sep 21, 2012 at 10:01 AM, Tanu Kaskinen wrote:
> On Thu, 2012-09-20 at 17:41 +0200, Dalleau, Frederic wrote:
>> Note that there is still the problem that module-suspend-on-idle do
>> not suspend the source.
>> I'm wondering if the source-output can b
Hi Mikel,
On Thu, Sep 20, 2012 at 2:28 PM, Mikel Astiz wrote:
> From: Mikel Astiz
>
> v2 modifies previous patches as suggested by Tanu:
>
> - Sink-inputs and source-outputs are created corked, and immediately
> afterwards uncorked if audio not suspended.
>
> - Patch v2 3/3 stops the rate adjus
Hi Mikel,
On Wed, Sep 12, 2012 at 5:42 PM, Mikel Astiz wrote:
> Hi,
>
> On Thu, May 3, 2012 at 6:17 PM, Frédéric Dalleau
> wrote:
>> Hi,
>>
>> This is follow up to the previous patch, using Tanu's comment.
>> http://lists.freedesktop.org/archives/pulseaudio-discuss/2012-May/013454.html
>>
>> So
Hi Mikel,
I see why you did patch 5 now so i'll put the style aside.
Regarding unloading the module on suspend, my only concern is about
how fast it happens. Is it quick? I'm just wondering if there is a way
to suspend the loopback processing without unloading it.
And haven't you seen any crashes
Hi Arun,
On Wed, Aug 22, 2012 at 4:01 PM, Arun Raghavan
wrote:
> On Wed, 2012-08-22 at 15:42 +0200, Frédéric Dalleau wrote:
> [...]
>> diff --git a/src/pulsecore/resampler.c b/src/pulsecore/resampler.c
>> index 17f1783..8199bc4 100644
>> --- a/src/pulsecore/resampler.c
>> +++ b/src/pulsecore/resa
Hi Mikel,
On Wed, Aug 22, 2012 at 10:08 AM, Mikel Astiz wrote:
> From: Mikel Astiz
>
> Merge hooks into a single callback to avoid duplicated code.
I'm no fan of this one, the idea of parsing a list to know the pointer
type doesn't seem natural to me.
Instead you can keep get_bluetooth_protocol
Hi Mikel
On Fri, Aug 17, 2012 at 8:12 AM, Mikel Astiz wrote:
> From: Mikel Astiz
>
> Add support for hfgw card profile in module-bluetooth-policy, just like
> a2dp_source in handled.
>
> In this case also the sink needs to be connected using module-loopback.
I'm ok with this one!
Frédéric
Hi Mikel,
On Thu, Aug 16, 2012 at 1:21 PM, Mikel Astiz wrote:
> From: Mikel Astiz
>
> Instead of focusing on a2dp_source only, prepare the module to support
> several profiles. It will be possible to enable/disable each of them
> using module arguments.
>
Aren't you missing pa_modargs_free?
BR
Hi Tanu,
On Mon, Aug 6, 2012 at 2:07 PM, Tanu Kaskinen wrote:
> Fixes this:
> /usr/bin/ld: utf8_test-utf8-test.o: undefined reference to symbol
> 'pa_log_set_level'
> /usr/bin/ld: note: 'pa_log_set_level' is defined in DSO
> /home/takaskin/dev/pulseaudio/src/.libs/libpulsecommon-2.98.so so try
Hi Rong Deng,
On Wed, Jul 11, 2012 at 4:56 PM, rong deng wrote:
> Hi Frederic,
>
> I should have CC-ed you for this patch. Please review!
>
> Thanks!
>
Ack'ed of course, don't be so nervous, you'll breakdown ;)
Regards,
Frédéric
___
pulseaudio-discuss
Hi Mikel,
On Fri, Jul 6, 2012 at 11:19 AM, Mikel Astiz wrote:
> From: Mikel Astiz
>
> Previous implementation assumes these values are equal, but this doesn't
> necessarily have to be so.
I have given a try to your patches (on top of upstream + Luiz
patches), and they have been
generally fine,
Tanu,
On Wed, Jul 4, 2012 at 10:08 PM, Dalleau, Frederic
wrote:
> Hi Tanu,
>
>> Can you explain how o->source can be NULL? It can't be just because it's
>> "already in the process of being moved". The only places that I found
>> w
Hi Tanu,
On Wed, Jul 4, 2012 at 8:14 PM, Tanu Kaskinen wrote:
> On Thu, 2012-03-22 at 17:36 +0100, Frédéric Dalleau wrote:
>> Hi,
>>
>> This is the v2 of the work on A2DP MPEG and media API.
>> v1 tried to send MP3 using A2DP source role.
>> v2 adds a sink to receive the MP3 data and restores SBC
Hi Tanu,
> Can you explain how o->source can be NULL? It can't be just because it's
> "already in the process of being moved". The only places that I found
> where pa_source_output.source is set to NULL are
> pa_source_output_start_move() and pa_source_output_unlink(). Of those,
> pa_source_output
Hi Tanu,
On Wed, May 30, 2012 at 6:06 PM, Tanu Kaskinen wrote:
> Ok. Given what I wrote in the previous mail (i.e. you don't need to
> modify pa_sink_input_new(), you only need to initialize the sample spec
> to be valid to avoid the assertion crash), do you agree that it still
> makes sense to
Tanu,
On Wed, May 30, 2012 at 4:03 PM, Tanu Kaskinen wrote:
> On Wed, 2012-05-30 at 11:36 +0300, Dalleau, Frederic wrote:
>> At first I considered that loading module loopback with specifying
>> anything is not really a frequent use case. That make a lot of changes
>> to add
Hi Tanu,
Thanks for this review !
On Tue, May 29, 2012 at 2:24 PM, Tanu Kaskinen wrote:
> > +sink = pa_namereg_get_default_sink(m->core);
>
> This still overrides the routing modules, right?
>
> I guess this is done, because otherwise you don't know how to initialize
> ss and map? I thi
Hi Rong Deng,
This helps to change log target on the fly.
>
>
>
You don't need to copy and truncate file_path as a truncated file path is
useless !
Instead you can use directly m+5. If the path is too long, open() will
simply fail.
Regards,
Frédéric
__
Tanu,
On Wed, May 9, 2012 at 1:16 PM, Tanu Kaskinen wrote:
> On Wed, 2012-05-09 at 11:02 +0200, Frédéric Dalleau wrote:
>> Hi Tanu,
>>
>> In general, your mail sounds ok but the last sentence sounds strange :
>>
>> On 05/09/2012 09:19 AM, Tanu Kaskinen wrote:
>> > I think it should be
>> > OK to
Hi Tanu,
On Fri, May 4, 2012 at 11:33 AM, Tanu Kaskinen wrote:
> On Fri, 2012-05-04 at 11:11 +0200, Dalleau, Frederic wrote:
>> Hi Tanu,
>>
>> On Fri, May 4, 2012 at 6:23 AM, Tanu Kaskinen wrote:
>> > On Thu, 2012-05-03 at 18:17 +0200, Frédéric Dalleau wrote:
>&
Hi Tanu,
On Fri, May 4, 2012 at 6:23 AM, Tanu Kaskinen wrote:
> On Thu, 2012-05-03 at 18:17 +0200, Frédéric Dalleau wrote:
> About the third patch - do you have module-suspend-on-idle loaded? If
> so, why doesn't it suspend the source? If the source doesn't go to the
> IDLE state when all its out
Hi Tanu,
On Wed, May 2, 2012 at 6:12 PM, Tanu Kaskinen wrote:
> On Wed, 2012-05-02 at 17:41 +0200, Frédéric Dalleau wrote:
>> This trace is not often displayed but when it is, there is a lot of it!
>> This can happen when the source stream used in a loopback has been suspended.
>
> If the source
> Right, so it's a trade-off between keeping a mutex allocated for my version,
> and three extra atomic ops for your version. Maybe it doesn't matter much
> and we're essentially bikeshedding?
Good question, but I don't like to let an issue pending. This is haunting me and
I can't find how to slee
Hi again,
On Wed, Apr 25, 2012 at 1:09 PM, Dalleau, Frederic
wrote:
> Hi David,
>
> On Tue, Apr 24, 2012 at 3:01 PM, David Henningsson
> wrote:
>> On 04/23/2012 05:03 PM, Dalleau, Frederic wrote:
>>>
>>> Hi David,
>>>
>>> On Fri,
Hi David,
On Tue, Apr 24, 2012 at 3:01 PM, David Henningsson
wrote:
> On 04/23/2012 05:03 PM, Dalleau, Frederic wrote:
>>
>> Hi David,
>>
>> On Fri, Apr 20, 2012 at 4:44 PM, David Henningsson
>> wrote:
>>>
>>> While researching a bug I c
Hi David,
On Fri, Apr 20, 2012 at 4:44 PM, David Henningsson
wrote:
> While researching a bug I came across something that might be a bug in the
> pa_once logic, but this stuff is tricky, so I might also be missing
> something.
>
> Imagine this:
>
> * Thread 1 runs pa_once_begin, succeeds and st
Hi,
On Fri, Apr 20, 2012 at 10:04 AM, Diogo F. S. Ramos wrote:
> I'm trying to write a very simple volume control for pulseaudio but I'm
> having a really hard time figuring out the API. Is there some kind of
> "hello, world"? Something that just mute a sink and exit would be great.
There is a s
Hi David,
On Thu, Apr 19, 2012 at 10:54 AM, David Henningsson
wrote:
> Nowadays, we are using more hashmaps and other things, than we did
> before. Therefore, I often get the "flist is full (don't worry)"
> message. This change should avoid that message. I was unable to find
> any significance in
Hi Todor,
On Sat, Apr 7, 2012 at 11:34 AM, Todor Gyumyushev wrote:
> Hi All,
>
> I really want to use the autoloading of loopback
> when bluetooth sink is connected.
> Is the patch already applied in current pulseaudio ?
> Now I always have to use this to connect
> pacmd load-module module-loopba
Hi David,
On Tue, Apr 3, 2012 at 6:37 PM, David Henningsson
wrote:
> On 04/03/2012 05:18 PM, Frédéric Dalleau wrote:
>>
>> This is a basic module for enabling loopback as soon as a new bluetooth
>> A2DP
>> source is created.
>
> I guess I won't question why you want to do this, as that will only
For example, this would crash pa an is fixed by the patch :
pacmd load-module module-loopback sink_input_properties=dummy
2012/4/2 Frédéric Dalleau :
> If an error during pa__init() causes a jump to fail: u->asyncmsgq is not
> initialized.
Frédéric
___
Hi,
>
> No, I just saw the crash report on launchpad and tried to figure out the
> likely cause for it. The person in question had combined module-null-sink
> with module-loopback and got a segfault from sink_input_update_max_request
> calling adjust_rates with a null u->source.
>
> For reference,
Hi David,
> No, I just saw the crash report on launchpad and tried to figure out the
> likely cause for it. The person in question had combined module-null-sink
> with module-loopback and got a segfault from sink_input_update_max_request
> calling adjust_rates with a null u->source.
It is likely
Hi Tanu,
> - unsigned frame_count;
> + unsigned frame_count = 0;
Looks like frame_count is unused in this function, maybe it can be
simply removed?
Regards,
Frédéric
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop
Hi David,
On Tue, Mar 20, 2012 at 4:06 PM, David Henningsson
wrote:
> On 02/10/2012 05:39 PM, Frédéric Dalleau wrote:
>>
>> Module-bluetooth-policy can load and unload module-loopback on demand.
>> Sometimes if there is an error, module-loopback can be unloaded early.
>> When module-loopback is l
Hi Arun,
On Tue, Feb 21, 2012 at 4:13 AM, Arun Raghavan
wrote:
> On Fri, 2012-02-10 at 17:39 +0100, Frédéric Dalleau wrote:
>> Module-bluetooth-policy can load and unload module-loopback on demand.
>> Sometimes if there is an error, module-loopback can be unloaded early.
>> When module-loopback i
Hi Luiz,
On Thu, Feb 16, 2012 at 10:49 AM, Luiz Augusto von Dentz
wrote:
> Hi Frédéric,
>
> 2012/2/6 Frédéric Dalleau :
>> From: Pierre-Louis Bossart
>>
>> Second version of patch to enable MP3 passthrough over A2DP, with
>> the decoding taking place on the headset to reduce power consumption.
>
Hi Pierre,
On Wed, Feb 8, 2012 at 9:07 PM, Pierre-Louis Bossart
wrote:
>
>> + static const a2dp_mpeg_t source_caps = {
>> + .channel_mode = BT_A2DP_CHANNEL_MODE_MONO |
>> BT_A2DP_CHANNEL_MODE_STEREO |
>> + BT_A2DP_CHANNEL_MODE_DUAL_CHANNEL |
>> BT_A2DP_CHANNEL_MOD
Hi Xingchao,
On Tue, Feb 7, 2012 at 4:02 PM, Wang Xingchao wrote:
> 在 2012年2月6日 下午7:54，Frédéric Dalleau 写道：
> > Hello,
> >
> > I'm spent some time trying to revive the patch series
> > originally written by Pierre-Louis Bossart and
> > Arun Raghavan to enable MP3 passthrough over A2DP.
> > I add
Hi Luiz, Tanu,
On Wed, Jan 25, 2012 at 5:42 PM, Luiz Augusto von Dentz <
luiz.de...@gmail.com> wrote:
> Hi Frederic,
>
> On Tue, Jan 24, 2012 at 3:31 PM, Dalleau, Frederic
> wrote:
> > This is good question.
> >
> > Current patch include a configuration, s
Hi Luiz,
Overall Im fine with the changes, but how would we could dynamically
> control the auto loading? Im not sure this will always be static which
> apparently is what it implicates by being in
> module-bluetooth-discover, lets say in some conditions the audio
> should not be send back to loo
Hi Pali,
On Sun, Jan 22, 2012 at 2:35 PM, Pali Rohár wrote:
> Frédéric Dalleau linux.intel.com> writes:
> >
> > Hi guys,
> >
> > This patch series tries to automatically enable loopback on bluetooth
> sources
> > and sinks. This is useful when listening music from the phone or to
> answer
> > p
Hi Tanu,
On Mon, Jan 16, 2012 at 8:22 PM, Tanu Kaskinen wrote:
>
> Do you think it would be a lot of work to move this logic to a separate
> module? As discussed before[1], I'd prefer there to be
> "module-bluetooth-policy" that would take care of choosing profiles
> automatically etc. Autoloadi
Hi Jeetendra and all,
During some testing I've reproduced this bug and confirm that the
proposed patch fixed it.
However I've seen that it is not integrated.
On Wed, Jan 4, 2012 at 8:49 AM, Jeetendra Bhattad
wrote:
>
> I am ready to implement it voluntarily.
>
> Please provide me some pointers w
Hi Vinod,
On Wed, Dec 21, 2011 at 7:17 AM, Vinod wrote:
> Thanks Frederic. I pulled the sources from git. The issue was resolved
> on x86 machine.
Glad to see it helped!
> When I used the same patches for my IMX53 evaluation board(QSB), it didnt
> work.
> I get "bt_audio_service_open: connect(
Hi Jeffrey,
On Thu, Dec 15, 2011 at 5:28 AM, Jeffrey Barish
wrote:
> Actually, the udev rule that I described will not run, so it seems that I
> don't have a possible solution. Any suggestions welcome.
>
Maybe module-switch-on-connect can help you
http://pulseaudio.org/wiki/Modules#module-switc
Hi Colin,
On Fri, Dec 9, 2011 at 5:05 PM, Colin Guthrie wrote:
> At the moment there are some DONT_MOVE flags added when some arguments
> are passed to the loopback module: sink_dont_move=true etc.
> 1. rather than defaulting to FALSE, the value of sink_dont_move should
> be dependent on whether
Hi Tanu,
>> Im fine with the changes except with this thing with
>> org.bluez.FMRadio, IMO that should belong to the module that requires
>> it
>
> It's a valid argument that "special" stuff like the FMRadio interface
> adds clutter in the generic bluetooth-util.h API. But if it's
> implemented se
Hi Peter,
Your patch contains the following :
PA_ECHO_CANCELLER_SPEEX = 0,
+#ifdef HAVE_SPEEX
+PA_ECHO_CANCELLER_SPEEX,
+#endif
+#ifdef HAVE_ADRIAN_EC
PA_ECHO_CANCELLER_ADRIAN,
This will lead to a bug if Speex is disabled and Adrian
or WRT is enabled, since ec_table will contain Adr
Hi Vinod,
> 3) Bluez 4.95 is already running.
Please try latest bluez from git since this issue has been
fixed a while ago, but not released yet.
That's always a good idea !
Regards,
Frédéric
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists
Hi Tanu,
>> module-bluetooth-discover already knows what profiles are connected
>> and can hint module-bluetooth-device into what profile to use
>> thus saving some ipc at loading.
>
> If module-bluetooth-discovery already knows that, I don't see why there
> needs to be any extra ipc. The device i
Hi Tanu,
> So, does this sound like correct behavior:
>
> module-bluetooth-discover loads module-bluetooth-device whenever
> anything is CONNECTED. module-bluetooth-discover never sets any
> particular profile explicitly.
module-bluetooth-discover already knows what profiles are connected
and can
Hi Chan-yeol,
On Wed, Nov 2, 2011 at 1:05 PM, Chan-yeol Park
wrote:
> In case we change profile, we should release the previous transport
> in order to suspend headset connection.
Luiz just replied to you while I was writing this mail.
You probably met the same issue that I did.
I sent a similar
Hi Arun,
Thanks for review,
>> -struct userdata {
>> +struct bluetooth_device {
>
> What's the rationale behind this? While the whole "struct userdata"
> business makes code navigation just a bit hard sometimes, broadly it's
> handy as a convention across modules.
I don't know why but that made
Hi Luiz,
>> An HandsfreeGateway connects RFCOMM and then SCO. A card appears in
>> PA and can be used. If for some reason, SCO is disconnected,
>> module-bluetooth-device is unloaded. The card will disappear, even
>> if RFCOMM is still connected. After that, it is not possible to
>> connect SCO ag
Hi Colin
> I'm trying to evaluate as to wheter or not it is good for 1.0 or if we
> should wait seeing as we're trying to stabilise now rather than add
> features.
As of today, looking at the code. Patch 1/2 does not seems too risky to
integrate, however patch 2/2 could have side effects. And
Lui
Hi Luiz,
> Looks good, now about the issue with card disappearing, try the following:
Thanks you very much for input, I'll try it asap !!
Regards
Frédéric
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedes
59 matches
Mail list logo
