[pulseaudio-discuss] [PATCH 2/3] pactl, pacmd, cli-command: Add send-message command

--- man/pactl.1.xml.in | 6 ++ man/pulse-cli-syntax.5.xml.in| 6 ++ shell-completion/bash/pulseaudio | 4 ++-- shell-completion/zsh/_pulseaudio | 2 ++ src/pulsecore/cli-command.c | 44 src/utils/pacmd.c|

[pulseaudio-discuss] [PATCH 1/3] core: add generic message interface

This patch adds a new feature to the core which allows to exchange messages between objects. An object can register/unregister a message handler with pa_core_message_handler_{register, unregister}() while any other object can send a message to the handler using the pa_core_send_message() function.

[pulseaudio-discuss] [PATCH 3/3] pactl: Add signal receiver

--- man/pactl.1.xml.in | 5 + shell-completion/bash/pulseaudio | 3 ++- shell-completion/zsh/_pulseaudio | 1 + src/utils/pactl.c| 25 - 4 files changed, 32 insertions(+), 2 deletions(-) diff --git a/man/pactl.1.xml.in

[pulseaudio-discuss] [PATCH 2/3] protocol-native: Add signal receiving capability

This patch extends the client subscription API, so that signals sent from PulseAudio can be processed. Within PulseAudio, a signal can be emitted using pa_signal_post(). The interface can be used to notify the client of events that are not covered by the subscription API (for example a button

Re: [pulseaudio-discuss] [PATCH 1/4] core: Add generic message interface

On 27.07.2017 07:17, Tanu Kaskinen wrote: On Fri, 2017-07-21 at 21:25 +0200, Georg Chini wrote: This patch adds a new feature to the core which allows to exchange messages between objects. An object can register/unregister a message handler with pa_core_{register, unregister}_message_handler

Re: [pulseaudio-discuss] [PATCH 1/2] subscription: Add signal receiving capability

On 26.07.2017 20:34, Tanu Kaskinen wrote: On Wed, 2017-07-26 at 08:33 +0200, Georg Chini wrote: On 26.07.2017 02:21, Tanu Kaskinen wrote: On Mon, 2017-07-24 at 14:19 +0200, Georg Chini wrote: This patch extends the subscription API, so that signals sent from PulseAudio can be processed

Re: [pulseaudio-discuss] [PATCH 1/2] subscription: Add signal receiving capability

On 26.07.2017 02:21, Tanu Kaskinen wrote: On Mon, 2017-07-24 at 14:19 +0200, Georg Chini wrote: This patch extends the subscription API, so that signals sent from PulseAudio can be processed. A signal can be emitted using pa_signal_post(). A client can subscribe to signals by specifying

Re: [pulseaudio-discuss] [PATCH] tunnel-{sink, source}-new: Fix assertion when used with module-loopback

On 24.07.2017 18:58, Tanu Kaskinen wrote: On Sat, 2017-07-22 at 10:21 +0200, Georg Chini wrote: On 20.07.2017 15:48, Tanu Kaskinen wrote: On Mon, 2017-07-17 at 19:53 +0200, Georg Chini wrote: On 17.07.2017 19:32, Tanu Kaskinen wrote: On Sun, 2017-07-16 at 11:42 +0200, Georg Chini wrote

[pulseaudio-discuss] [PATCH 2/2] pactl: Add signal receiver to pactl

--- src/utils/pactl.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/src/utils/pactl.c b/src/utils/pactl.c index e9bf005b..8ec76d53 100644 --- a/src/utils/pactl.c +++ b/src/utils/pactl.c @@ -1184,6 +1184,17 @@ static void context_subscribe_callback(pa_context

[pulseaudio-discuss] [PATCH 1/2] subscription: Add signal receiving capability

This patch extends the subscription API, so that signals sent from PulseAudio can be processed. A signal can be emitted using pa_signal_post(). A client can subscribe to signals by specifying PA_SUBSCRIPTION_MASK_SIGNAL as one of the subscription mask flags in pa_context_subscribe(). It then

Re: [pulseaudio-discuss] User-hostile obfuscation in PulseAudio Volume Control is a real pain.

On 22.07.2017 11:59, Georg Chini wrote: On 22.07.2017 11:37, Erik Christiansen wrote: Hi, Debian 9.0.0 comes with pulseaudio 10.0, so it's not likely that fixes for the problem are in the wild yet, I figure. Even when a Debian 9.0.0 box is connected to a HDMI monitor, PulseAudio Volume

Re: [pulseaudio-discuss] User-hostile obfuscation in PulseAudio Volume Control is a real pain.

On 22.07.2017 11:37, Erik Christiansen wrote: Hi, Debian 9.0.0 comes with pulseaudio 10.0, so it's not likely that fixes for the problem are in the wild yet, I figure. Even when a Debian 9.0.0 box is connected to a HDMI monitor, PulseAudio Volume Control displays only 3 of its 5 tabs,

Re: [pulseaudio-discuss] [PATCH] tunnel-{sink, source}-new: Fix assertion when used with module-loopback

On 20.07.2017 15:48, Tanu Kaskinen wrote: On Mon, 2017-07-17 at 19:53 +0200, Georg Chini wrote: On 17.07.2017 19:32, Tanu Kaskinen wrote: On Sun, 2017-07-16 at 11:42 +0200, Georg Chini wrote: Currently pulseaudio crashes with an assertion in pa_rtpoll_item_new_asyncmsgq_read() if a loopback

Re: [pulseaudio-discuss] [PATCH v3 1/3] bluetooth: ofono: Use Acquire method if available

On 21.07.2017 20:26, Tanu Kaskinen wrote: On Fri, 2017-07-21 at 20:58 +0300, Tanu Kaskinen wrote: On Thu, 2017-07-20 at 18:50 +0200, Georg Chini wrote: On 20.07.2017 16:23, Tanu Kaskinen wrote: On Tue, 2017-07-18 at 20:16 +0200, Georg Chini wrote: On 17.07.2017 19:44, Tanu Kaskinen wrote

[pulseaudio-discuss] [PATCH 2/4] protocol-native: add message sending capability

This patch adds the PA_COMMAND_SEND_OBJECT_MESSAGE command to protocol-native so that clients can use the messaging feature introduced in the previous patch. Sending messages can in effect replace the extension system for modules. The approach is more flexible than the extension interface because

[pulseaudio-discuss] [PATCH 1/4] core: Add generic message interface

This patch adds a new feature to the core which allows to exchange messages between objects. An object can register/unregister a message handler with pa_core_{register, unregister}_message_handler() while any other object can check if a handler is registered for some name with

[pulseaudio-discuss] [PATCH 4/4] core: add message handler

This patch adds a small message handler to the core which enables clients to list available handlers via the list-handlers message. Command: pacmd send-message /core list-handlers pactl can be used with the same parameters. --- src/pulsecore/core.c | 37 + 1

[pulseaudio-discuss] [PATCH 3/4] pactl, pacmd, cli-command: Add send-message command

--- man/pactl.1.xml.in | 6 ++ man/pulse-cli-syntax.5.xml.in| 6 ++ shell-completion/bash/pulseaudio | 5 +++-- shell-completion/zsh/_pulseaudio | 2 ++ src/pulsecore/cli-command.c | 44 src/utils/pacmd.c|

Re: [pulseaudio-discuss] [PATCH v3 1/3] bluetooth: ofono: Use Acquire method if available

On 20.07.2017 16:23, Tanu Kaskinen wrote: On Tue, 2017-07-18 at 20:16 +0200, Georg Chini wrote: On 17.07.2017 19:44, Tanu Kaskinen wrote: On Sun, 2017-07-16 at 14:35 +0200, Georg Chini wrote: On 04.07.2017 15:38, Tanu Kaskinen wrote: It looks racy indeed, so some check should be added as you

Re: [pulseaudio-discuss] [PATCH v3 1/3] bluetooth: ofono: Use Acquire method if available

On 17.07.2017 19:44, Tanu Kaskinen wrote: On Sun, 2017-07-16 at 14:35 +0200, Georg Chini wrote: On 04.07.2017 15:38, Tanu Kaskinen wrote: On Mon, 2017-07-03 at 21:01 +0300, Luiz Augusto von Dentz wrote: Hi Georg, On Mon, Jul 3, 2017 at 8:32 PM, Georg Chini <ge...@chini.tk>

Re: [pulseaudio-discuss] [PATCH] tunnel-{sink, source}-new: Fix assertion when used with module-loopback

On 17.07.2017 19:32, Tanu Kaskinen wrote: On Sun, 2017-07-16 at 11:42 +0200, Georg Chini wrote: Currently pulseaudio crashes with an assertion in pa_rtpoll_item_new_asyncmsgq_read() if a loopback is applied to a tunnel-new sink/source because tunnel-{sink,source}-new do not set

Re: [pulseaudio-discuss] [PATCH v3 1/3] bluetooth: ofono: Use Acquire method if available

On 04.07.2017 15:38, Tanu Kaskinen wrote: On Mon, 2017-07-03 at 21:01 +0300, Luiz Augusto von Dentz wrote: Hi Georg, On Mon, Jul 3, 2017 at 8:32 PM, Georg Chini <ge...@chini.tk> wrote: On 03.07.2017 17:51, Luiz Augusto von Dentz wrote: Hi Tanu, On Mon, Jul 3, 2017 at 5:05 PM, Tanu Ka

[pulseaudio-discuss] [PATCH] tunnel-{sink, source}-new: Fix assertion when used with module-loopback

Currently pulseaudio crashes with an assertion in pa_rtpoll_item_new_asyncmsgq_read() if a loopback is applied to a tunnel-new sink/source because tunnel-{sink,source}-new do not set thread_info.rtpoll. Bug was reported on IRC. This patch fixes the problem by initializing thread_info.rtpoll

Re: [pulseaudio-discuss] [PATCH 1/2] protocol-native: Add commands for communication with modules

On 10.07.2017 17:15, Tanu Kaskinen wrote: On Sat, 2017-07-08 at 22:40 +0200, Georg Chini wrote: On 07.07.2017 16:12, Tanu Kaskinen wrote: On Thu, 2017-07-06 at 21:35 +0200, Georg Chini wrote: Looks good but does not really answer my intended question. Let me ask differently: How should

Re: [pulseaudio-discuss] [PATCH 1/2] protocol-native: Add commands for communication with modules

On 07.07.2017 16:12, Tanu Kaskinen wrote: On Thu, 2017-07-06 at 21:35 +0200, Georg Chini wrote: On 06.07.2017 15:25, Tanu Kaskinen wrote: On Wed, 2017-07-05 at 08:56 +0200, Georg Chini wrote: On 04.07.2017 18:15, Tanu Kaskinen wrote: On Sun, 2017-05-21 at 14:56 +0200, Georg Chini wrote

Re: [pulseaudio-discuss] [PATCH 1/2] protocol-native: Add commands for communication with modules

On 06.07.2017 15:25, Tanu Kaskinen wrote: On Wed, 2017-07-05 at 08:56 +0200, Georg Chini wrote: On 04.07.2017 18:15, Tanu Kaskinen wrote: On Sun, 2017-05-21 at 14:56 +0200, Georg Chini wrote: This patch adds two new commands to the native protocol that enable direct communication with modules

Re: [pulseaudio-discuss] [PATCH 1/2] protocol-native: Add commands for communication with modules

On 04.07.2017 18:15, Tanu Kaskinen wrote: On Sun, 2017-05-21 at 14:56 +0200, Georg Chini wrote: This patch adds two new commands to the native protocol that enable direct communication with modules during run time. SEND_MODULE_COMMAND is used to send a command string to a module if no reply

Re: [pulseaudio-discuss] [PATCH v3 1/3] bluetooth: ofono: Use Acquire method if available

On 03.07.2017 17:51, Luiz Augusto von Dentz wrote: Hi Tanu, On Mon, Jul 3, 2017 at 5:05 PM, Tanu Kaskinen wrote: On Mon, 2017-07-03 at 16:09 +0300, Luiz Augusto von Dentz wrote: Hi Tanu, On Mon, Jun 19, 2017 at 4:29 PM, Tanu Kaskinen wrote: On Thu, 2017-05-25

Re: [pulseaudio-discuss] lots of [null-sink] memblock.c: Pool full

On 27.06.2017 16:47, wellington wallace wrote: >Tanu wrote: > You can check with "pactl list source-outputs" how big the "buffer > latency" of your recording stream is. If it's small, then I don't think > the problem is in your application. Hi, thank you for your answer. Buffer latency and

Re: [pulseaudio-discuss] [PATCH] Revert "bluetooth: Auto recover if profile is 'off'"

On 13.06.2017 18:02, Tanu Kaskinen wrote: This reverts commit 69c212f8c13794f70899d1fe6baec1b6e3c92032. Reasons: The original reason for the patch was to work around some issue regarding the profile not connecting immediately (sorry, I don't really know the details), but that issue was fixed

Re: [pulseaudio-discuss] [PATCH] stream-restore: Ignore sink-inputs/source-outputs that connect a filter to the master

On 31.05.2017 08:22, Arun Raghavan wrote: On Fri, 26 May 2017, at 01:10 AM, Georg Chini wrote: module-stream-restore primarily uses the role of a stream for restoring. The sink-inputs and source-outputs of filters all have role "filter", therefore currently all filters are treat

Re: [pulseaudio-discuss] Detecting when data source disappears?

On 23.05.2017 03:44, Steven Wawryk wrote: Sorry about reposting. I botched up the subject line, messing up the threading. I've been reading up and experimenting on both the simple and async APIs. In one experiment, I used a CLI file that sets up a set of module-sine modules with output

[pulseaudio-discuss] [PATCH] stream-restore: Ignore sink-inputs/source-outputs that connect a filter to the master

module-stream-restore primarily uses the role of a stream for restoring. The sink-inputs and source-outputs of filters all have role "filter", therefore currently all filters are treated equally and are restored to the same device and volume. This patch lets module-stream-restore ignore the

[pulseaudio-discuss] [PATCH 1/2] protocol-native: Add commands for communication with modules

This patch adds two new commands to the native protocol that enable direct communication with modules during run time. SEND_MODULE_COMMAND is used to send a command string to a module if no reply is needed. This can for example be employed to change parameters on the fly. SEND_MODULE_QUERY is

[pulseaudio-discuss] [PATCH 2/2] pactl, pacmd, cli-command: Add send-module-command and send-module-query commands

This patch adds cli commands to pacmd and pactl to make use of the new SEND_MODULE_{COMMAND,QUERY} commands in protocol-native. Now module parameters can be changed and queried from the command line if the module implements the feature. There is no default syntax for the strings passed to a

Re: [pulseaudio-discuss] Detecting when data source disappears?

On 19.05.2017 06:02, Steven Wawryk wrote: I've been reading up and experimenting on both the simple and async APIs. In one experiment, I used a CLI file that sets up a set of module-sine modules with output remapped by module-remap-sink modules to a stream fed to a module-null-sink module.

Re: [pulseaudio-discuss] Detecting when data source disappears?

On 17.05.2017 04:28, Steven Wawryk wrote: Hello, I've been reading up and experimenting on both the simple and async APIs. In one experiment, I used a CLI file that sets up a set of module-sine modules with output remapped by module-remap-sink modules to a stream fed to a module-null-sink

[pulseaudio-discuss] [PATCH] virtual sources and sinks: Don't double attach a sink input or source output on filter load

When a filter is loaded and module-switch-on-connect is present, switch-on-connect will make the filter the default sink or source and move streams from the old default to the filter. This is done from the sink/source put hook, therefore streams are moved to the filter before the module init

Re: [pulseaudio-discuss] [PATCH] sink, source: update the default sink/source on port switches

On 07.05.2017 11:12, Tanu Kaskinen wrote: When sinks are compared during the default sink selection, the active port's availability is inspected. Therefore, the default sink should be updated when the active port changes, because the new port may have different availability status than the old

[pulseaudio-discuss] [PATCH] bluez5-device: Set transport state correctly for AG role

When connecting a headset via the native backend, the transport state was not updated correctly. This patch sets the state to PLAYING in transport_acquire() if necessary. --- src/modules/bluetooth/module-bluez5-device.c | 13 + 1 file changed, 13 insertions(+) diff --git

Re: [pulseaudio-discuss] [PATCH v5 5/7] bluetooth: Auto recover if profile is 'off'

On 11.05.2017 11:55, Tanu Kaskinen wrote: On Mon, 2017-05-08 at 13:09 +0300, Luiz Augusto von Dentz wrote: Hi Tanu, On Mon, May 8, 2017 at 11:53 AM, Tanu Kaskinen wrote: On Mon, 2017-05-08 at 11:26 +0300, Luiz Augusto von Dentz wrote: Hi Tanu, On Sat, May 6, 2017 at 7:20 PM,

Re: [pulseaudio-discuss] [PATCH v2] bluetooth: ofono: Use Acquire method if available

On 10.05.2017 15:35, Georg Chini wrote: On 10.05.2017 15:08, Luiz Augusto von Dentz wrote: Hi Georg, On Mon, May 8, 2017 at 9:28 PM, Georg Chini <ge...@chini.tk> wrote: On 08.05.2017 10:37, Luiz Augusto von Dentz wrote: From: Luiz Augusto von Dentz <luiz.von.de...@intel.com> At

Re: [pulseaudio-discuss] [PATCH v5 5/7] bluetooth: Auto recover if profile is 'off'

On 10.05.2017 15:17, Luiz Augusto von Dentz wrote: Hi Georg, On Mon, May 8, 2017 at 8:56 PM, Georg Chini <ge...@chini.tk> wrote: On 08.05.2017 12:09, Luiz Augusto von Dentz wrote: Hi Tanu, On Mon, May 8, 2017 at 11:53 AM, Tanu Kaskinen <ta...@iki.fi> wrote: On Mon, 2017-05-08 at

Re: [pulseaudio-discuss] [PATCH v2] bluetooth: ofono: Use Acquire method if available

On 10.05.2017 15:08, Luiz Augusto von Dentz wrote: Hi Georg, On Mon, May 8, 2017 at 9:28 PM, Georg Chini <ge...@chini.tk> wrote: On 08.05.2017 10:37, Luiz Augusto von Dentz wrote: From: Luiz Augusto von Dentz <luiz.von.de...@intel.com> Attempt to use Acquire method if available

[pulseaudio-discuss] [PATCH] sink/source: Don't update default sink/source before calling PA_CORE_HOOK_{SINK, SOURCE}_PUT

In sink_put() and source_put(), pa_core_update_default_{sink,source}() was called before the PA_CORE_HOOK_{SINK,SOURCE}_PUT hook. Therefore module-switch-on-connect could not correctly determine the old default sink/source if no user default was set and a sink/source with higher priority than

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

On 07.05.2017 13:23, Tanu Kaskinen wrote: On Sun, 2017-05-07 at 12:37 +0200, Georg Chini wrote: On 07.05.2017 11:16, Tanu Kaskinen wrote: On Sat, 2017-05-06 at 22:15 +0200, Georg Chini wrote: On 06.05.2017 22:06, Tanu Kaskinen wrote: I made a strange interpretation, because what you really

[pulseaudio-discuss] [PATCH] virtual sources and sinks: Don't double attach a sink input or source output on filter load

When a filter is loaded and module-switch-on-connect is present, switch-on-connect will make the filter the default sink or source and move streams from the old default to the filter. This is done from the sink/source put hook, therefore streams are moved to the filter before the module init

Re: [pulseaudio-discuss] [PATCH v2] bluetooth: ofono: Use Acquire method if available

On 08.05.2017 10:37, Luiz Augusto von Dentz wrote: From: Luiz Augusto von Dentz Attempt to use Acquire method if available falling back to Connect in case it fails. --- src/modules/bluetooth/backend-ofono.c | 59 +-- 1 file changed,

Re: [pulseaudio-discuss] [PATCH v5 5/7] bluetooth: Auto recover if profile is 'off'

On 08.05.2017 12:09, Luiz Augusto von Dentz wrote: Hi Tanu, On Mon, May 8, 2017 at 11:53 AM, Tanu Kaskinen wrote: On Mon, 2017-05-08 at 11:26 +0300, Luiz Augusto von Dentz wrote: Hi Tanu, On Sat, May 6, 2017 at 7:20 PM, Tanu Kaskinen wrote: On Fri, 2017-05-05

[pulseaudio-discuss] [PATCH] virtual sources and sinks: Don't double attach a sink input or source output on filter load

When a filter is loaded and module-switch-on-connect is present, switch-on-connect will make the filter the default sink or source and move streams from the old default to the filter. This is done from the sink/source put hook, therefore streams are moved to the filter before the module init

[pulseaudio-discuss] [PATCH] core: Don't let moving filter sources/sinks become the default source/sink

When a virtual sink is loaded and there is only one sound card, then during a profile switch, all sinks and sources can become temporarily unavailable. In that situation, the virtual sink will become the default sink, although it is not connected to a master sink due to the move operation

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

On 07.05.2017 09:33, Tanu Kaskinen wrote: On Sat, 2017-05-06 at 22:38 +0200, Georg Chini wrote: On 06.05.2017 22:15, Georg Chini wrote: On 06.05.2017 22:06, Tanu Kaskinen wrote: On Sat, 2017-05-06 at 20:06 +0200, Georg Chini wrote: On 06.05.2017 18:36, Tanu Kaskinen wrote: On Fri, 2017-05

[pulseaudio-discuss] [PATCH] virtual sources and sinks: Don't double attach a sink input or source output on filter load

When a filter is loaded and module-switch-on-connect is present, switch-on-connect will make the filter the default sink or source and move streams from the old default to the filter. This is done from the sink/source put hook, therefore streams are moved to the filter before the module init

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

On 07.05.2017 13:44, Tanu Kaskinen wrote: On Sun, 2017-05-07 at 12:32 +0200, Georg Chini wrote: On 07.05.2017 09:33, Tanu Kaskinen wrote: On Sat, 2017-05-06 at 22:38 +0200, Georg Chini wrote: On 06.05.2017 22:15, Georg Chini wrote: On 06.05.2017 22:06, Tanu Kaskinen wrote: I made a strange

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

On 07.05.2017 11:16, Tanu Kaskinen wrote: On Sat, 2017-05-06 at 22:15 +0200, Georg Chini wrote: On 06.05.2017 22:06, Tanu Kaskinen wrote: I made a strange interpretation, because what you really meant seemed even more crazy. I forgot that module-switch-on-connect only moves streams

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

On 07.05.2017 09:33, Tanu Kaskinen wrote: On Sat, 2017-05-06 at 22:38 +0200, Georg Chini wrote: On 06.05.2017 22:15, Georg Chini wrote: On 06.05.2017 22:06, Tanu Kaskinen wrote: On Sat, 2017-05-06 at 20:06 +0200, Georg Chini wrote: On 06.05.2017 18:36, Tanu Kaskinen wrote: On Fri, 2017-05

[pulseaudio-discuss] [PATCH 3/3] virtual sources and sinks: Don't double attach a sink input or source output on filter load

When a filter is loaded and module-switch-on-connect is present, switch-on-connect will make the filter the default sink or source and move streams from the old default to the filter. This is done from the sink/source put hook, therefore streams are moved to the filter before the module init

[pulseaudio-discuss] [PATCH 2/3] virtual sinks and sources: Revert commits

This patch reverts commit db4fbb0121a2577d786cda023a6a439a9734f152 and 3bb94c4e836ca765a36255e416fd8e6cf272ab44. They were the wrong approach to fix the bug (and did not fix it anyway). --- src/modules/echo-cancel/module-echo-cancel.c | 6 ++ src/modules/module-ladspa-sink.c | 3

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

On 06.05.2017 22:15, Georg Chini wrote: On 06.05.2017 22:06, Tanu Kaskinen wrote: On Sat, 2017-05-06 at 20:06 +0200, Georg Chini wrote: On 06.05.2017 18:36, Tanu Kaskinen wrote: On Fri, 2017-05-05 at 16:21 +0200, Georg Chini wrote: I agree with you that my patch is wrong, but I think

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

On 06.05.2017 22:06, Tanu Kaskinen wrote: On Sat, 2017-05-06 at 20:06 +0200, Georg Chini wrote: On 06.05.2017 18:36, Tanu Kaskinen wrote: On Fri, 2017-05-05 at 16:21 +0200, Georg Chini wrote: I agree with you that my patch is wrong, but I think there is a simpler solution than your patch

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

On 06.05.2017 18:36, Tanu Kaskinen wrote: On Fri, 2017-05-05 at 16:21 +0200, Georg Chini wrote: On 04.05.2017 20:11, Tanu Kaskinen wrote: On Wed, 2017-05-03 at 22:19 +0200, Georg Chini wrote: On 03.05.2017 21:58, Tanu Kaskinen wrote: On Tue, 2017-05-02 at 07:12 +0200, Georg Chini wrote

Re: [pulseaudio-discuss] [PATCH] switch-on-port-available: check and change default sink or source

On 05.05.2017 16:43, Georg Chini wrote: On 03.05.2017 12:51, Tanu Kaskinen wrote: On Wed, 2017-05-03 at 11:23 +0800, Hui Wang wrote: Today I tested the latest master branch (already including your two patches), seems it did not fix the problem. Below is my testing detail: Install ubuntu 16.04

Re: [pulseaudio-discuss] [PATCH] switch-on-port-available: check and change default sink or source

On 03.05.2017 12:51, Tanu Kaskinen wrote: On Wed, 2017-05-03 at 11:23 +0800, Hui Wang wrote: Today I tested the latest master branch (already including your two patches), seems it did not fix the problem. Below is my testing detail: Install ubuntu 16.04 on my laptop. clone the latest

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

On 04.05.2017 20:11, Tanu Kaskinen wrote: On Wed, 2017-05-03 at 22:19 +0200, Georg Chini wrote: On 03.05.2017 21:58, Tanu Kaskinen wrote: On Tue, 2017-05-02 at 07:12 +0200, Georg Chini wrote: On 01.05.2017 22:10, Tanu Kaskinen wrote: On Mon, 2017-04-24 at 19:33 +0200, Georg Chini wrote

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

On 03.05.2017 21:58, Tanu Kaskinen wrote: On Tue, 2017-05-02 at 07:12 +0200, Georg Chini wrote: On 01.05.2017 22:10, Tanu Kaskinen wrote: On Mon, 2017-04-24 at 19:33 +0200, Georg Chini wrote: There are several places in module-echo-cancel where a segfault is possible when the master sink

Re: [pulseaudio-discuss] [PATCH v4 5/8] bluetooth: Auto recover if profile is 'off'

On 03.05.2017 19:20, Luiz Augusto von Dentz wrote: Hi Georg, On Sat, Apr 29, 2017 at 2:40 PM, Georg Chini <ge...@chini.tk> wrote: On 26.04.2017 14:19, Luiz Augusto von Dentz wrote: From: Luiz Augusto von Dentz <luiz.von.de...@intel.com> This means something went wrong, which in c

Re: [pulseaudio-discuss] [PATCH v4 3/8] bluetooth: ofono: Detect if Connect has been called

On 03.05.2017 19:18, Luiz Augusto von Dentz wrote: Hi Georg, On Sat, Apr 29, 2017 at 4:01 PM, Georg Chini <ge...@chini.tk> wrote: On 29.04.2017 13:28, Georg Chini wrote: On 26.04.2017 14:19, Luiz Augusto von Dentz wrote: From: Luiz Augusto von Dentz <luiz.von.de...@intel.com>

Re: [pulseaudio-discuss] [PATCH] jack-sink: fix latency calculation

On 02.05.2017 15:44, Tanu Kaskinen wrote: The compiler warned about number_of_frames being possibly used uninitialized, and on closer inspection I found that it was indeed not initialized if saved_frame_time_valid is false. In commit fe70b9e11a "source/sink: Allow pa_{source,

[pulseaudio-discuss] [PATCH] virtual sources and sinks: Fix possible segfault due to invalid master sink or source

There are several places in the virtual sinks and sources code where a segfault is possible when the master sink or source is invalid. The master may become invalid during a profile switching situation when only one sound card is available or when all real sinks or sources have been removed from

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

On 01.05.2017 22:10, Tanu Kaskinen wrote: On Mon, 2017-04-24 at 19:33 +0200, Georg Chini wrote: There are several places in module-echo-cancel where a segfault is possible when the master sink or source is invalid. I don't think the rewind, volume and mute callbacks are ever called during

[pulseaudio-discuss] HFP headset support via ofono backend

Hi, once the patches from Luiz are accepted, this is what you need to do to make your HFP headest available to pulseaudio via the ofono backend: 1) Get ofono source: git clone git://git.kernel.org/pub/scm/network/ofono/ofono.git 2) Install ofono: ./bootstrap ./configure --enable-threads

Re: [pulseaudio-discuss] [PATCH v4 8/8] Bluetooth: Add optional argument to release callback

On 26.04.2017 14:20, Luiz Augusto von Dentz wrote: From: Luiz Augusto von Dentz This adds optional argument which indicates a suspend from IO thread so the callback can choose to close the fd or leave it open. --- I still don't like that approach. I'll send you a

Re: [pulseaudio-discuss] [PATCH] switch-on-port-available: check and change default sink or source

On 29.04.2017 15:04, Tanu Kaskinen wrote: On Fri, 2017-04-28 at 12:21 +0800, Hui Wang wrote: Hello Tanu, Could you please take a look at this patch, you are the maintainer and recently contributed couple of commits to module-switch-on-port-available.c. :-) Well, I'm trying to concentrate on

Re: [pulseaudio-discuss] [PATCH v4 3/8] bluetooth: ofono: Detect if Connect has been called

On 29.04.2017 13:28, Georg Chini wrote: On 26.04.2017 14:19, Luiz Augusto von Dentz wrote: From: Luiz Augusto von Dentz <luiz.von.de...@intel.com> This detects if profile has already been called and we are waiting the response. --- src/modules/bluetooth/backend-ofono.

Re: [pulseaudio-discuss] [PATCH v4 2/8] bluetooth: ofono: Fix asserting when connecting as AG

On 26.04.2017 14:19, Luiz Augusto von Dentz wrote: From: Luiz Augusto von Dentz Check the card Type property instead of assuming ofono would only be used for HF role. --- src/modules/bluetooth/backend-ofono.c | 10 -- 1 file changed, 8 insertions(+), 2

Re: [pulseaudio-discuss] [PATCH v4 5/8] bluetooth: Auto recover if profile is 'off'

On 26.04.2017 14:19, Luiz Augusto von Dentz wrote: From: Luiz Augusto von Dentz This means something went wrong, which in case of ofono backend it is probably due to the profile not connecting immediately but it can be safely in that case. Is there something missing

Re: [pulseaudio-discuss] [PATCH v4 3/8] bluetooth: ofono: Detect if Connect has been called

On 26.04.2017 14:19, Luiz Augusto von Dentz wrote: From: Luiz Augusto von Dentz This detects if profile has already been called and we are waiting the response. --- src/modules/bluetooth/backend-ofono.c | 19 --- 1 file changed, 16 insertions(+), 3

Re: [pulseaudio-discuss] [PATCH v4 2/8] bluetooth: ofono: Fix asserting when connecting as AG

On 26.04.2017 14:19, Luiz Augusto von Dentz wrote: From: Luiz Augusto von Dentz Check the card Type property instead of assuming ofono would only be used for HF role. --- src/modules/bluetooth/backend-ofono.c | 10 -- 1 file changed, 8 insertions(+), 2

Re: [pulseaudio-discuss] [PATCH 3/3] volume: Fix overflow in percent calculation of pa_*volume_snprint*()

On 29.04.2017 10:27, Tanu Kaskinen wrote: On Fri, 2017-04-28 at 11:13 +0200, Georg Chini wrote: The percent calculation could overflow in the pa_*volume_snprint*() functions. For large volumes, volume * 100 can exceed UINT32_MAX. This patch adds appropriate type casts. --- src/pulse/volume.c

[pulseaudio-discuss] [PATCH 3/3] volume: Fix overflow in percent calculation of pa_*volume_snprint*()

The percent calculation could overflow in the pa_*volume_snprint*() functions. For large volumes, volume * 100 can exceed UINT32_MAX. This patch adds appropriate type casts. --- src/pulse/volume.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/pulse/volume.c

[pulseaudio-discuss] [PATCH 1/3] source/sink: Fix wrong calculation of thread_info.current_hw_volume

In pa_{source,sink}_new() and pa_{source,sink}_put() the current hardware volume was miscalculated: hw volume (dB) = real volume (dB) + soft volume (dB) was used instead of hw volume (dB) = real volume (dB) - soft volume (dB) This lead to a crash in pa_alsa_path_set_volume() if high volumes were

[pulseaudio-discuss] [PATCH 2/3] volume: Print a warning when volume is clipped in pa_sw_volume_multiply/divide()

When the volume exceeds PA_VOLUME_MAX in pa_sw_volume_multiply() or pa_sw_volume_divide(), volume settings are insanely high and the user should be notified about it. This patch adds volume clamping to pa_sw_volume_divide() and prints a warning when the volume is clipped in both functions. ---

Re: [pulseaudio-discuss] Freezing master, release notes, blocker bugs

On 24.04.2017 15:58, Tanu Kaskinen wrote: On Sat, 2017-04-22 at 20:37 +0200, Georg Chini wrote: On 21.04.2017 15:32, Tanu Kaskinen wrote: Hi all, It's been three months since the last release, which means that it's time to freeze the master branch in preparation for the next release. Here's

[pulseaudio-discuss] [PATCH] virtual sources and sinks: Fix possible segfault due to invalid master sink or source

There are several places in the virtual sinks and sources where a segfault is possible when the master sink or source is invalid. This patch checks for the validity of master source or sink and lets the functions just return if it is invalid. --- src/modules/module-ladspa-sink.c | 11

[pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

There are several places in module-echo-cancel where a segfault is possible when the master sink or source is invalid. This patch checks for the validity of master source or sink and lets the functions just return if it is invalid. Other virtual sinks and sources will be fixed in a separate

[pulseaudio-discuss] [PATCH] echo-cancel: fix another segfault during sink-input move

When a sink input is moved away from the echo cancel sink while the master sink of module-echo-cancel is invalid, pa_sink_input_set_requested_latency_within_thread() called from sink_update_requested_latency_cb() would segfault due to the invalid sink. The same applies for the source side. This

[pulseaudio-discuss] [PATCH] virtual sources and sinks: Fix possible segfault

Several virtual sources and sinks apart from module-echo-cancel also query the master sink or source to estimate the current latency. Those modules might potentially show the bug that is described for module-echo-cancel in bug 100277. This patch checks in the message handlers for the

[pulseaudio-discuss] [PATCH] echo-cancel: Fix segfault during profile switch

When module-echo-cancel is loaded and there is only one sound card, then during a profile switch, all sinks and sources can become temporarily unavailable. If module-always sink is loaded, it will load a null-sink in that situation. If also module-switch-on-connect is loaded, it will try to move

Re: [pulseaudio-discuss] Freezing master, release notes, blocker bugs

On 21.04.2017 15:32, Tanu Kaskinen wrote: Hi all, It's been three months since the last release, which means that it's time to freeze the master branch in preparation for the next release. Here's a review of the current blockers: frequent crash in pa_alsa_path_set_volume

Re: [pulseaudio-discuss] [PATCH v6] filter-apply: Fixed a stream moves to wrong sink or source.

On 21.04.2017 00:38, KimJeongYeon wrote: 2017. 4. 21. 오전 3:28에 "Georg Chini" <ge...@chini.tk <mailto:ge...@chini.tk>>님이 작성: Still found a few issues, but I think the next version will be final. + +trigger_housekeeping(u);

Re: [pulseaudio-discuss] [PATCH v6] filter-apply: Fixed a stream moves to wrong sink or source.

On 20.04.2017 16:35, KimJeongYeon wrote: For example, a normal stream tried to attach to filter sink or source, which filter loaded and managed by filter-apply. But, the stream goes to filter's ***master sink or source*** due to unexpected restoring operation. It should attached to filter sink

Re: [pulseaudio-discuss] [PATCH v6] filter-apply: Fixed a stream moves to wrong sink or source.

On 20.04.2017 16:52, KimJeongYeon wrote: Dear Georg, This patch v6 applied all of your suggestions. https://lists.freedesktop.org/archives/pulseaudio-discuss/2017-April/028037.html I hope you don't mind if I change the commit message like I did for your other patches and add a few more

Re: [pulseaudio-discuss] [PATCH v5] filter-apply: Fixed a stream moves to wrong sink or source.

On 19.04.2017 19:46, Georg Chini wrote: On 19.04.2017 11:03, KimJeongYeon wrote: For example, a normal stream tried to attach to filter sink or source, which filter loaded and managed by filter-apply. But, the stream goes to filter's ***master sink or source*** due to unexpected restoring

Re: [pulseaudio-discuss] [PATCH v5] filter-apply: Fixed a stream moves to wrong sink or source.

On 19.04.2017 11:03, KimJeongYeon wrote: For example, a normal stream tried to attach to filter sink or source, which filter loaded and managed by filter-apply. But, the stream goes to filter's ***master sink or source*** due to unexpected restoring operation. It should attached to filter sink

Re: [pulseaudio-discuss] [PATCH v4] filter-apply: Fixed a stream moves to wrong sink or source.

On 19.04.2017 10:24, KimJeongYeon wrote: 2017. 4. 19. 오전 5:10에 "Georg Chini" <ge...@chini.tk <mailto:ge...@chini.tk>>님이 작성: On 18.04.2017 21:45, Georg Chini wrote: On 18.04.2017 14:36, KimJeongYeon wrote: For example, a normal stream tri

Re: [pulseaudio-discuss] [PATCH] allow-passthrough: Change the name of null-sink

On 19.04.2017 09:36, Manuel Amador (Rudd-O) wrote: On 04/19/2017 02:36 AM, Jungsup Lee wrote: Sink's "media.name" property is mostly NULL, therefore using sink's name instead of sink's "media.name" property. --- src/modules/module-allow-passthrough.c | 5 + 1 file changed, 1

Re: [pulseaudio-discuss] [PATCH v4] filter-apply: Fixed a stream moves to wrong sink or source.

On 18.04.2017 21:45, Georg Chini wrote: On 18.04.2017 14:36, KimJeongYeon wrote: For example, a normal stream tried to attach to filter sink or source, which filter loaded and managed by filter-apply. But, the stream goes to filter's ***master sink or source*** due to unexpected restoring

Re: [pulseaudio-discuss] [PATCH v4] filter-apply: Fixed a stream moves to wrong sink or source.

On 18.04.2017 14:36, KimJeongYeon wrote: For example, a normal stream tried to attach to filter sink or source, which filter loaded and managed by filter-apply. But, the stream goes to filter's ***master sink or source*** due to unexpected restoring operation. It should attached to filter sink

[pulseaudio-discuss] [PATCH 2/2] loopback: Track and use average adjust time

The configured adjust time does not match exactly the real adjust time. Also the adjust time varies. To improve latency estimation use an average of the measured adjust times instead of the configured value in all calculations. --- src/modules/module-loopback.c | 36

[pulseaudio-discuss] [PATCH 1/2] loopback: Use new allow_negative flag of pa_{source, sink}_get_latency_within_thread()

Setting the allow_negative flag of pa_{source,sink}_get_latency_within_thread() to true leads to improved end to end latency estimation and to correct handling of negative port latency offsets. --- src/modules/module-loopback.c | 49 +++ 1 file changed,

<    1   2   3   4   5   6   7   8   9   10   >