Re: [pulseaudio-discuss] [PATCH] raop: silence a Coverity complaint

I thought I added this fix before but apparently not. Looks good to me. Thank you for bringing this up. Hajime > On Jul 27, 2017, at 8:07 PM, Tanu Kaskinen wrote: > > CID: 1398155 > --- > src/modules/raop/raop-sink.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git

Re: [pulseaudio-discuss] [RAOP] [PATCH] Fix audio synchronisation

Hi Colin, Thank you for working on this! I haven’t had a chance to actually test the patch, but just skimmed it. The idea seems reasonable. Will try to see if I can test it this weekend. > -c->rtptime += length / 4; > +c->rtpdiff = length / 4; > +c->rtptime += c->rtpdiff; Could

Re: [pulseaudio-discuss] [PATCH 0/8] more Coverity fixes and cleanups

Hi Peter, Thank you for the fix; raop patches look good to me. Best, Hajime > On Mar 8, 2017, at 9:09 AM, Peter Meerwald-Stadler wrote: > > some more Coverity fixes and cleanups > also addresses Hajime Fujita's earlier review comments > > Peter Meerwald-Stadler (8): >

Re: [pulseaudio-discuss] [PATCH v2 10/10] raop: Fix potential NULL dereference

> On Mar 8, 2017, at 9:11 AM, Peter Meerwald-Stadler wrote: > > >>> diff --git a/src/modules/raop/raop-client.c b/src/modules/raop/raop-client.c >>> index d329a09..5248691 100644 >>> --- a/src/modules/raop/raop-client.c >>> +++ b/src/modules/raop/raop-client.c >>> @@

Re: [pulseaudio-discuss] [PATCH v2 00/10] Coverity fixes, raop

Hi Peter, Thank you for taking care of this! Actually I also started working on this but haven’t had a chance to cleanup the patches. Patches look good except where I made comments on each message. Thanks, Hajime > On Mar 6, 2017, at 1:43 AM, Peter Meerwald-Stadler wrote:

Re: [pulseaudio-discuss] [PATCH v2 08/10] raop: Silence unchecked return value warnings

> On Mar 6, 2017, at 1:43 AM, Peter Meerwald-Stadler wrote: > > Signed-off-by: Peter Meerwald-Stadler > --- > src/modules/raop/raop-client.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/modules/raop/raop-client.c

Re: [pulseaudio-discuss] [PATCH v2 05/10] raop: Fix resource leaks

> On Mar 6, 2017, at 1:43 AM, Peter Meerwald-Stadler wrote: > > Coverity ID: #1398158, #1398159 > > Signed-off-by: Peter Meerwald-Stadler > --- > src/modules/raop/raop-client.c | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(-) > >

Re: [pulseaudio-discuss] [PATCH v2 10/10] raop: Fix potential NULL dereference

> On Mar 6, 2017, at 1:43 AM, Peter Meerwald-Stadler wrote: > > 'realm' is mandatory > > Signed-off-by: Peter Meerwald-Stadler > --- > src/modules/raop/raop-client.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [pulseaudio-discuss] [PATCH v7 00/33] raop2 support for module-raop-sink

Hi Tanu and Anton, > On Jan 10, 2017, at 5:57 PM, Tanu Kaskinen <ta...@iki.fi> wrote: > > On Thu, 2017-01-05 at 22:34 +0100, Anton Lundin wrote: >> On 06 November, 2016 - Hajime Fujita wrote: >> >>> This patch set adds a support for UDP version of RAOP (so

[pulseaudio-discuss] [PATCH v7 32/33] raop: Fix #36: invalid access to freed object

From: ced2c The RTSP client is not waiting anymore a new header after the previous one (which can never occurs if RAOP is disconnected) but after sending a command. This patch fixes Issue #36. https://github.com/hfujita/pulseaudio-raop2/issues/36 ---

[pulseaudio-discuss] [PATCH v7 31/33] raop: Fix memory leaks

From: Hajime Fujita <crisp.fuj...@nifty.com> This patch fixes several memory leaks, and thereby fixes Issue #35. (https://github.com/hfujita/pulseaudio-raop2/issues/35) --- src/modules/raop/raop-client.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/m

[pulseaudio-discuss] [PATCH v7 28/33] raop: Stop recording when RTSP FLUSH is issued

From: Hajime Fujita <crisp.fuj...@nifty.com> This patch fixes the issue #31. https://github.com/hfujita/pulseaudio-raop2/issues/31 This patch sets c->is_recording = false when the RTSP FLUSH command is issued. This avoids a race between the server response and the record activation in s

[pulseaudio-discuss] [PATCH v7 25/33] raop: Correctly wrap RTP packet sequence number

From: Martin Blanchard --- src/modules/raop/raop-client.c| 27 +++--- src/modules/raop/raop-packet-buffer.c | 70 --- src/modules/raop/raop-packet-buffer.h | 5 ++- 3 files changed, 65 insertions(+), 37 deletions(-) diff --git

[pulseaudio-discuss] [PATCH v7 29/33] raop: Disable is_recording flag when tearing down the connection

From: Hajime Fujita <crisp.fuj...@nifty.com> This patch is based on a similar idea as the previous one -- disabling the flag right after the session is getting closed, rather than waiting for a response from the server. --- src/modules/raop/raop-client.c | 4 ++-- 1 file changed, 2 inse

[pulseaudio-discuss] [PATCH v7 30/33] raop: Discard data upon getting EAGAIN on a socket

From: Hajime Fujita <crisp.fuj...@nifty.com> This patch discards audio data when a socket returns EAGAIN. This was made based on a suggestion by karlstav (https://github.com/karlstav), and is supposed to solve Issue #32. (https://github.com/hfujita/pulseaudio-raop2/issues/32) --- src/m

[pulseaudio-discuss] [PATCH v7 27/33] raop: Add back initial volume RTSP SET_PARAMETER request on connect

From: Martin Blanchard Regression introduced in commit 8c6407f: raop: Merge TCP and UDP code paths + refactoring Anyway, we need to determine if initial volume has to be setup before sending RECORD or after: - Setting it up *before* shouldn't be a problem: sink.c waits for

[pulseaudio-discuss] [PATCH v7 24/33] raop: Add IPv6 support

From: Hajime Fujita <crisp.fuj...@nifty.com> --- src/modules/raop/raop-client.c | 23 --- src/modules/rtp/rtsp_client.c | 2 +- 2 files changed, 17 insertions(+), 8 deletions(-) diff --git a/src/modules/raop/raop-client.c b/src/modules/raop/raop-client.c index c

[pulseaudio-discuss] [PATCH v7 22/33] raop: Do not flush when RTSP object is not ready

From: Stephen Paul Weber This patch fixes a crash issue reported at https://github.com/hfujita/pulseaudio-raop2/issues/9 --- src/modules/raop/raop-client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/raop/raop-client.c

[pulseaudio-discuss] [PATCH v7 20/33] raop: fix typos

From: Colin Leroy --- src/modules/raop/raop-client.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/modules/raop/raop-client.c b/src/modules/raop/raop-client.c index 8dc05a4..8a43a19 100644 --- a/src/modules/raop/raop-client.c +++

[pulseaudio-discuss] [PATCH v7 23/33] raop: Add address to RAOP device description

From: Hajime Fujita <crisp.fuj...@nifty.com> Some time one device announces multiple addresses (e.g. IPv4 one and IPv6 one). Or some user may own multiple RAOP devices with the same model name. This patch adds device port to device description so that users can distinguish appropriate RAO

[pulseaudio-discuss] [PATCH v7 26/33] raop: Silently drop out-of-history retransmission request

From: Hajime Fujita <crisp.fuj...@nifty.com> --- src/modules/raop/raop-packet-buffer.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/modules/raop/raop-packet-buffer.c b/src/modules/raop/raop-packet-buffer.c index 05f9592..72fd729 100644 --- a/src/module

[pulseaudio-discuss] [PATCH v7 11/33] raop: Add a MD5 hashing fuction

From: Martin Blanchard <tch...@gmx.com> MD5 hashing will be needed during the authentication process. Original patch by Martin Blanchard. Patch splitted by Hajime Fujita <crisp.fuj...@nifty.com>. --- src/modules/raop/raop_util.c | 27 +++ src/modules/raop

[pulseaudio-discuss] [PATCH v7 16/33] raop: Rework packet's store memory management

From: Martin Blanchard This patch switch the packet-buffer to use core memory pool instead of manually allocating the room required for storing TCP/UDP packets. Packets are now stored using pa_memchunk instead of internal struct. Quite a few malloc saved compare to previous

[pulseaudio-discuss] [PATCH v7 15/33] raop: Update and standardise source file headers

eAudio. Copyright 2008 Colin Guthrie + Copyright 2013 Hajime Fujita + Copyright 2013 Martin Blanchard PulseAudio is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published diff --git a/src/modules/raop/raop-packet-buffer.c

[pulseaudio-discuss] [PATCH v7 18/33] raop: Fix sink getting destroyed after one use

From: Colin Leroy It is expected to get disconnected after switching back to a different sink. --- src/modules/raop/raop-sink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/raop/raop-sink.c b/src/modules/raop/raop-sink.c index

[pulseaudio-discuss] [PATCH v7 17/33] raop: Remove unimplemented code (PCM and AAC)

From: Martin Blanchard --- src/modules/raop/raop-client.c | 44 ++ 1 file changed, 14 insertions(+), 30 deletions(-) diff --git a/src/modules/raop/raop-client.c b/src/modules/raop/raop-client.c index 195b00c..81a68a0 100644 ---

[pulseaudio-discuss] [PATCH v7 21/33] raop: Fix packet retransmission

From: Colin Leroy Fix UDP header decoding (sequence number and number of packets); Fix missing pa_memblock_release() causing assertions after retransmission. --- src/modules/raop/raop-client.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[pulseaudio-discuss] [PATCH v7 09/33] raop: Extract encryption related code into a separate file

From: Martin Blanchard That makes the raop_client.c code smaller/cleaner and will simplify addition of more crypto related stuffs like authentication. --- src/Makefile.am| 1 + src/modules/raop/raop_client.c | 116 +---

[pulseaudio-discuss] [PATCH v7 14/33] raop: Prefer ALAC encoding to raw PCM if supported by server

From: Martin Blanchard ALAC encoding is to be prefered simply because ALAC audio packet reverse- engineering and implementation is in better shape than raw PCM. Sending ALAC audio does not mean compressing audio and thus linking an external library to do so. ALAC packets has the

[pulseaudio-discuss] [PATCH v7 10/33] raop: Move base64 implementation to a util file

From: Martin Blanchard <tch...@gmx.com> Base64 implementation is now in a common file called raop_util.c. Old Base64 files are removed but copyright is preserved. Original patch by Martin Blanchard, patch splitted by Hajime Fujita <crisp.fuj...@nifty.com>. --- src

[pulseaudio-discuss] [PATCH v7 12/33] raop: Add BA (Basic) and DA (Digest) HTTP authentication helpers

From: Martin Blanchard RAOP authentication is using standard HTTP challenge-response authentication scheme. This patch adds two helper functions that generate the proper hash (for both techniques) given a username, a password and session related tokens. ---

[pulseaudio-discuss] [PATCH v7 08/33] raop: Better playback resume handling

From: Martin Blanchard When playback stops, a FLUSH command is send to the server and the sink goes to IDLE. If playback resumes quickly, sink goes back to RUNNING (without being SUSPENDED) and the sink should just start streaming again. This patch implements this behaviour. ---

[pulseaudio-discuss] [PATCH v7 07/33] raop: Do not send audio before RECORD response

From: Martin Blanchard This patch prevents audio packets to be sent before the server respond to the RECORD command. --- src/modules/raop/module-raop-sink.c | 6 +++--- src/modules/raop/raop_client.c | 25 - src/modules/raop/raop_client.h | 1

[pulseaudio-discuss] [PATCH v7 01/33] pulsecore: Add pa_strneq macro

From: Hajime Fujita <crisp.fuj...@nifty.com> This macro compares if the given two strings, with the maximum length of n, are equal. Useful for strings that are not NULL-terminated. --- src/pulsecore/core-util.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/pulsecore/core-util.h

[pulseaudio-discuss] [PATCH v7 05/33] raop: Parse server capabilities on discovery

From: Martin Blanchard <tin...@gmx.fr> During the discovery phase, raop servers send their capabilities (supported encryption, audio codec...). These should be passed to the raop sink via module's arguments. Original patch written by Martin Blanchard, then modified by Hajime Fujita <

[pulseaudio-discuss] [PATCH v7 04/33] raop: Add UDP protocol handling

From: Hajime Fujita <crisp.fuj...@nifty.com> There are two versions in the RAOP protocol; one uses TCP and the other uses UDP. Current raop implementation only supports TCP version. This patch adds an initial UDP protocol support for RAOP. It is based on Martin Blanchard's work

[pulseaudio-discuss] [PATCH v7 02/33] pulsecore: Add pa_split_space_in_place function

From: Hajime Fujita <crisp.fuj...@nifty.com> --- src/pulsecore/core-util.c | 19 +++ src/pulsecore/core-util.h | 1 + 2 files changed, 20 insertions(+) diff --git a/src/pulsecore/core-util.c b/src/pulsecore/core-util.c index f2999b2..9d571b8 100644 --- a/src/pulsecor

[pulseaudio-discuss] [PATCH v7 06/33] raop: Packet retransmission support for UDP

From: Matthias Wabersich <pulseau...@niafc.de> This patch adds an RTP audio packet retransmission support and a circular buffer implementation for it. This patch was originally written by Matthias Wabersich [1] and later debugged and integrated into the latest tree by Hajime Fujita [1]:

[pulseaudio-discuss] [PATCH v7 00/33] raop2 support for module-raop-sink

etting destroyed after one use raop: fix sequence number overflow raop: fix typos raop: Fix packet retransmission Hajime Fujita (11): pulsecore: Add pa_strneq macro pulsecore: Add pa_split_space_in_place function pulsecore: Do in-place search in pa_str_in_list_spaces raop: Add UDP

Re: [pulseaudio-discuss] Revisiting raop2 patches

Anton Lundin wrote: > On 30 October, 2016 - Hajime Fujita wrote: >> >>> On Oct 26, 2016, at 9:58 PM, Hajime Fujita <crisp.fuj...@nifty.com> wrote: >>> >>>> On Oct 25, 2016, at 3:47 PM, Anton Lundin <gla...@acc.umu.se> wrote: >>

Re: [pulseaudio-discuss] Revisiting raop2 patches

simply push the patches on top of next? Thanks, Hajime Anton Lundin wrote: > On 25 October, 2016 - Tanu Kaskinen wrote: > >> On Mon, 2016-10-24 at 22:09 -0500, Hajime Fujita wrote: >>> On Oct 24, 2016, at 4:05 PM, Anton Lundin <gla...@acc.umu.se> wrote: >>>>

Re: [pulseaudio-discuss] Revisiting raop2 patches

Hi Anton, > On Oct 26, 2016, at 9:58 PM, Hajime Fujita <crisp.fuj...@nifty.com> wrote: > > Hi Anton, > > Thank you for your effort on taking a look at the patches! > >> On Oct 25, 2016, at 3:47 PM, Anton Lundin <gla...@acc.umu.se> wrote: >> &g

Re: [pulseaudio-discuss] Revisiting raop2 patches

Corin, Tanu, and Anton, Thank you folks for your responses! > On Oct 24, 2016, at 4:05 PM, Anton Lundin wrote: > > On 24 October, 2016 - Colin Leroy wrote: > >> On 24 October 2016 at 20h58, Tanu Kaskinen wrote: >> >> Hi, >> >>> It would be great to have more people

Re: [pulseaudio-discuss] [PATCH v6 00/37] raop2 support for module-raop-sink

Hi Arun, > On Feb 15, 2016, at 3:32 AM, Arun Raghavan <a...@accosted.net> wrote: > > On 12 February 2016 at 12:03, Hajime Fujita <crisp.fuj...@nifty.com> wrote: >> Hi Arun, >> >> Arun Raghavan wrote: >>> Hi Hajime, >>> I'm still w

Re: [pulseaudio-discuss] [PATCH v6 00/37] raop2 support for module-raop-sink

rrently don't have that one so it'll be a bit hard to debug... let me check the price :) > > Will reply again once I'm through the patch set. > > Regards, > Arun > > On Wed, 2016-02-10 at 18:50 -0600, Hajime Fujita wrote: >> Hi Arun, >> >> Are yo

Re: [pulseaudio-discuss] [PATCH v6 00/37] raop2 support for module-raop-sink

Hi Arun, Are you still going through the patches? If you are done, I'll submit a new series of patches that address your comments. Thanks, Hajime Hajime Fujita wrote: > Arun Raghavan wrote: >> On Sun, 2016-01-31 at 22:15 -0600, Hajime Fujita wrote: >>> From: Hajime

Re: [pulseaudio-discuss] [PATCH v6 00/37] raop2 support for module-raop-sink

Arun Raghavan wrote: > On Sun, 2016-01-31 at 22:15 -0600, Hajime Fujita wrote: >> From: Hajime Fujita <crisp.fuj...@nifty.com> >> >> This is basically same as the previous patch series, >> with several patches squashed for conciseness, rebased

Re: [pulseaudio-discuss] [PATCH v6 04/37] raop: Add pulsecore/core-utils a pa_str_in_list function

Arun Raghavan wrote: > On Sun, 2016-01-31 at 22:16 -0600, Hajime Fujita wrote: >> From: Martin Blanchard <tin...@gmx.fr> >> >> --- >> src/pulsecore/core-util.c | 20 >> src/pulsecore/core-util.h | 5 +++-- >> 2 files changed, 23 i

Re: [pulseaudio-discuss] [PATCH v6 16/37] raop: Add the core implementation of RAOP authentication

Arun Raghavan wrote: > On Sun, 2016-01-31 at 22:16 -0600, Hajime Fujita wrote: >> From: Martin Blanchard <tch...@gmx.com> >> >> RAOP authentication (password) is based on BA and DA HTTP authentication >> schemes. This patch adds the RSTP client the ability t

Re: [pulseaudio-discuss] [PATCH v6 09/37] raop: Add UDP protocol handling

Arun Raghavan wrote: > On Sun, 2016-01-31 at 22:16 -0600, Hajime Fujita wrote: >> From: Hajime Fujita <crisp.fuj...@nifty.com> >> >> There are two versions in the RAOP protocol; one uses TCP and the >> other uses UDP. Current raop implementation only supports TCP

Re: [pulseaudio-discuss] [PATCH v6 05/37] raop: Parse server capabilities on discovery

Arun Raghavan wrote: > On Sun, 2016-01-31 at 22:16 -0600, Hajime Fujita wrote: >> From: Martin Blanchard <tin...@gmx.fr> >> >> During the discovery phase, raop servers send theirs capabilities >> (supported encryption, audio codec...). These should be passed

[pulseaudio-discuss] [PATCH v6 13/37] raop: Extract encryption related code into a separate file

From: Martin Blanchard That makes the raop_client.c code smaller/cleaner and will simplify addition of more crypto related stuffs like authentication. --- src/Makefile.am| 1 + src/modules/raop/raop_client.c | 116 +---

[pulseaudio-discuss] [PATCH v6 22/37] raop: Fix sink getting destroyed after one use

From: Colin Leroy It is expected to get disconnected after switching back to a different sink. --- src/modules/raop/raop-sink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/raop/raop-sink.c b/src/modules/raop/raop-sink.c index

[pulseaudio-discuss] [PATCH v6 04/37] raop: Add pulsecore/core-utils a pa_str_in_list function

From: Martin Blanchard --- src/pulsecore/core-util.c | 20 src/pulsecore/core-util.h | 5 +++-- 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/src/pulsecore/core-util.c b/src/pulsecore/core-util.c index 19c89a9..9fd4301 100644 ---

[pulseaudio-discuss] [PATCH v6 19/37] raop: Update and standardise source file headers

eAudio. Copyright 2008 Colin Guthrie + Copyright 2013 Hajime Fujita + Copyright 2013 Martin Blanchard PulseAudio is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published diff --git a/src/modules/raop/raop-packet-buffer.c

[pulseaudio-discuss] [PATCH v6 31/37] raop: Add back initial volume RTSP SET_PARAMETER request on connect

From: Martin Blanchard Regression introduced in commit 8c6407f: raop: Merge TCP and UDP code paths + refactoring Anyway, we need to determine if initial volume has to be setup before sending RECORD or after: - Setting it up *before* shouldn't be a problem: sink.c waits for

[pulseaudio-discuss] [PATCH v6 25/37] raop: Fix packet retransmission

From: Colin Leroy Fix UDP header decoding (sequence number and number of packets); Fix missing pa_memblock_release() causing assertions after retransmission. --- src/modules/raop/raop-client.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[pulseaudio-discuss] [PATCH v6 09/37] raop: Add UDP protocol handling

From: Hajime Fujita <crisp.fuj...@nifty.com> There are two versions in the RAOP protocol; one uses TCP and the other uses UDP. Current raop implementation only supports TCP version. This patch adds an initial UDP protocol support for RAOP. It is based on Martin Blanchard's work

[pulseaudio-discuss] [PATCH v6 06/37] rtp: New pa_rtsp_options function

From: Colin Leroy Add a function performing a call to the OPTIONS request; also, in some special cases, tuning transport parameters is required (default: "RTP/AVP/TCP;unicast;interleaved=0-1;mode=record") ! The RAOP client for example needs to overwrite them. ---

[pulseaudio-discuss] [PATCH v6 21/37] raop: Remove unimplemented code (PCM and AAC)

From: Martin Blanchard --- src/modules/raop/raop-client.c | 44 ++ 1 file changed, 14 insertions(+), 30 deletions(-) diff --git a/src/modules/raop/raop-client.c b/src/modules/raop/raop-client.c index 4e73d12..a1c282f 100644 ---

[pulseaudio-discuss] [PATCH v6 12/37] raop: Better playback resume handling

From: Martin Blanchard When playback stops, a FLUSH command is send to the server and the sink goes to IDLE. If playback resumes quickly, sink goes back to RUNNING (without being SUSPENDED) and the sink should just start streaming again. This patch implements this behaviour. ---

[pulseaudio-discuss] [PATCH v6 29/37] raop: Correctly wrap RTP packet sequence number

From: Martin Blanchard --- src/modules/raop/raop-client.c| 27 +++--- src/modules/raop/raop-packet-buffer.c | 70 --- src/modules/raop/raop-packet-buffer.h | 5 ++- 3 files changed, 65 insertions(+), 37 deletions(-) diff --git

[pulseaudio-discuss] [PATCH v6 02/37] rtp: Freeing ioline when disconnecting

From: Hajime Fujita <crisp.fuj...@nifty.com> pa_ioline_close does not free the ioline structure itself, so we have to unref the structure if we want to free it. --- src/modules/rtp/rtsp_client.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/modules/rtp/rtsp_cl

[pulseaudio-discuss] [PATCH v6 16/37] raop: Add the core implementation of RAOP authentication

From: Martin Blanchard RAOP authentication (password) is based on BA and DA HTTP authentication schemes. This patch adds the RSTP client the ability to specify the caller of server response status. Tracking the '401 Unauthorized' status allow the RAOP client to respond the server

[pulseaudio-discuss] [PATCH v6 36/37] raop: Fix #36: invalid access to freed object

From: ced2c The RTSP client is not waiting anymore a new header after the previous one (which can never occurs if RAOP is disconnected) but after sending a command. This patch fixes Issue #36. https://github.com/hfujita/pulseaudio-raop2/issues/36 ---

[pulseaudio-discuss] [PATCH v6 20/37] raop: Rework packet's store memory management

From: Martin Blanchard This patch switch the packet-buffer to use core memory pool instead of manually allocating the room required for storing TCP/UDP packets. Packets are now stored using pa_memchunk instead of internal struct. Quite a few malloc saved compare to previous

[pulseaudio-discuss] [PATCH v6 23/37] raop: fix sequence number overflow

From: Colin Leroy Wrap sequence number when we reach uint16_t's max 0x. --- src/modules/raop/raop-client.c| 14 -- src/modules/raop/raop-packet-buffer.c | 17 - src/modules/raop/raop-packet-buffer.h | 1 + 3 files changed, 29

[pulseaudio-discuss] [PATCH v6 11/37] raop: Do not send audio before RECORD response

From: Martin Blanchard This patch prevents audio packets to be sent before the server respond to the RECORD command. --- src/modules/raop/module-raop-sink.c | 6 +++--- src/modules/raop/raop_client.c | 25 - src/modules/raop/raop_client.h | 1

[pulseaudio-discuss] [PATCH v6 00/37] raop2 support for module-raop-sink

From: Hajime Fujita <crisp.fuj...@nifty.com> This is basically same as the previous patch series, with several patches squashed for conciseness, rebased on the latest master. http://lists.freedesktop.org/archives/pulseaudio-discuss/2015-October/024547.html This patch set adds a support f

[pulseaudio-discuss] [PATCH v6 01/37] Support IPv6 address in pa_socket_client_new_string()

From: Hajime Fujita <crisp.fuj...@nifty.com> pa_socket_client_new_string() did not work as expected when an IPv6 address string like "2001:db8::1" is passed as the "name" parameter. This is because the name parameter is then passed to pa_parse_address(), which thinks the

[pulseaudio-discuss] [PATCH v6 14/37] raop: Add a MD5 hashing fuction

From: Martin Blanchard MD5 hashing will be needed during the authentication process. Base64 and MD5 code is now in a commun file called raop_util.c. Old Base64 files are removed but copyright is preserved. --- src/Makefile.am| 4 +- src/modules/raop/base64.c

[pulseaudio-discuss] [PATCH v6 15/37] raop: Add BA (Basic) and DA (Digest) HTTP authentication helpers

From: Martin Blanchard RAOP authentication is using standard HTTP challenge-response authentication scheme. This patch adds two helper functions that generate the proper hash (for both techniques) given a username, a password and session related tokens. ---

[pulseaudio-discuss] [PATCH v6 10/37] raop: Packet retransmission support for UDP

From: Matthias Wabersich <pulseau...@niafc.de> This patch adds an RTP audio packet retransmission support and a circular buffer implementation for it. This patch was originally written by Matthias Wabersich [1] and later debugged and integrated into the latest tree by Hajime Fujita [1]:

[pulseaudio-discuss] [PATCH v6 32/37] raop: Stop recording when RTSP FLUSH is issued

From: Hajime Fujita <crisp.fuj...@nifty.com> This patch fixes the issue #31. https://github.com/hfujita/pulseaudio-raop2/issues/31 This patch sets c->is_recording = false when the RTSP FLUSH command is issued. This avoids a race between the server response and the record activation in s

[pulseaudio-discuss] [PATCH v6 34/37] raop: Discard data upon getting EAGAIN on a socket

From: Hajime Fujita <crisp.fuj...@nifty.com> This patch discards audio data when a socket returns EAGAIN. This was made based on a suggestion by karlstav (https://github.com/karlstav), and is supposed to solve Issue #32. (https://github.com/hfujita/pulseaudio-raop2/issues/32) --- src/m

[pulseaudio-discuss] [PATCH v6 03/37] raop: Cosmetic fixes / Match coding style

From: Martin Blanchard --- src/modules/raop/base64.c | 28 -- src/modules/raop/base64.h | 6 +- src/modules/raop/module-raop-discover.c | 169 src/modules/raop/module-raop-sink.c | 56 +--

[pulseaudio-discuss] [PATCH v6 27/37] raop: Add address to RAOP device description

From: Hajime Fujita <crisp.fuj...@nifty.com> Some time one device announces multiple addresses (e.g. IPv4 one and IPv6 one). Or some user may own multiple RAOP devices with the same model name. This patch adds device port to device description so that users can distinguish appropriate RAO

[pulseaudio-discuss] [PATCH v6 07/37] rtp: Random seq number at the beginning of the session

From: Martin Blanchard --- src/modules/rtp/rtsp_client.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/modules/rtp/rtsp_client.c b/src/modules/rtp/rtsp_client.c index aa0217d..6e65860 100644 --- a/src/modules/rtp/rtsp_client.c +++

[pulseaudio-discuss] [PATCH v6 33/37] raop: Disable is_recording flag when tearing down the connection

From: Hajime Fujita <crisp.fuj...@nifty.com> This patch is based on a similar idea as the previous one -- disabling the flag right after the session is getting closed, rather than waiting for a response from the server. --- src/modules/raop/raop-client.c | 4 ++-- 1 file changed, 2 inse

[pulseaudio-discuss] [PATCH v6 18/37] raop: Prefer ALAC encoding to raw PCM if supported by server

From: Martin Blanchard ALAC encoding is to be prefered simply because ALAC audio packet reverse- engineering and implementation is in better shape than raw PCM. Sending ALAC audio does not mean compressing audio and thus linking an external library to do so. ALAC packets has the

[pulseaudio-discuss] [PATCH v6 08/37] rtp: Introduce pa_rtsp_exec_ready()

From: Hajime Fujita <crisp.fuj...@nifty.com> In the current RTSP implementation, there is a vulnerable window between the RTSP object creation and the URL initialization. If any RTSP command is issued during this period, it will lead to crash by assertion violation. This patch intr

[pulseaudio-discuss] raop2 support for module-raop-sink (v5)

Hello, I'd like to ask for reviewing a set of patches on raop2 support again. After a long period we finally resolved the memory corruption issue that was pointed out by Alexander [1]. The latest patches are here, rebased onto master as of today.

Re: [pulseaudio-discuss] Patch review status wiki page updated

Hi Tanu, It is correct. And I checked out the Wiki page. Thank you for the updates! Best, Hajime On Jan 19, 2015, at 07:59, Tanu Kaskinen tanu.kaski...@linux.intel.com wrote: On Sun, 2015-01-18 at 18:46 -0600, Hajime Fujita wrote: Hi Tanu, Could you update the location of the raop2

Re: [pulseaudio-discuss] RAOP2 patch testing result

please let me know. $ valgrind --leak-check=yes ./src/.libs/pulseaudio ... Detailed output from valgrind can be found here: https://github.com/hfujita/pulseaudio-raop2/issues/35 Thank you, Hajime Alexander E. Patrakov wrote: 05.01.2015 08:57, Hajime Fujita wrote: Hello Alexander, Then I

Re: [pulseaudio-discuss] Patch review status wiki page updated

Hi Tanu, Could you update the location of the raop2 patch series to https://github.com/hfujita/pulseaudio-raop2/compare/29a20c7541845798c1367ad538126a7a19129139...hf/raop2-v2-v5.99.2 This is our latest patches and already rebased against PA 6.0 RC2. Thanks, Hajime Tanu Kaskinen wrote: Patch

Re: [pulseaudio-discuss] RAOP2 patch testing result

Hello Alexander, Alexander E. Patrakov wrote: 13.11.2014 02:13, Martin Blanchard wrote: On Tue, 2014-11-11 at 23:45 +0500, Alexander E. Patrakov wrote: Hi. Hello Alexander! I have cloned the raop2-v2 branch from https://github.com/colinleroy/pulseaudio First, thanks for the testings.

Re: [pulseaudio-discuss] only ALAC! [Was: raop on gentoo+systemd]

Hi, Probably you should supply more arguments to module-raop-sink. Here's a line from my log: ( 0.210| 0.000) I: [lt-pulseaudio] module.c: Loaded module-raop-sink (index: #28; argument: server=[192.168.1.130]:5000 sink_name=raop_output.Apple-TV.local

Re: [pulseaudio-discuss] incomplete IPv6 support in pa_socket_client_new_string()

Tanu Kaskinen wrote: On Thu, 2014-11-06 at 22:26 -0600, Hajime Fujita wrote: Tanu Kaskinen wrote: On Wed, 2014-11-05 at 22:29 -0600, Hajime Fujita wrote: Hi Tanu, Thank you for your comment and sorry for the late reply. Tanu Kaskinen wrote: On Tue, 2014-10-21 at 00:49 -0500, Hajime Fujita

[pulseaudio-discuss] Support IPv6 address in pa_socket_client_new_string()

These patches address an issue that pa_socket_client_new_string() cannot handle IPv6 address correctly [1]. [1]: http://lists.freedesktop.org/archives/pulseaudio-discuss/2014-October/0 22010.html ___ pulseaudio-discuss mailing list

[pulseaudio-discuss] [PATCH 1/2] parseaddr: Add new call pa_is_ip6_address()

--- src/pulsecore/parseaddr.c | 11 +++ src/pulsecore/parseaddr.h | 2 ++ 2 files changed, 13 insertions(+) diff --git a/src/pulsecore/parseaddr.c b/src/pulsecore/parseaddr.c index d31e68c..f49c81c 100644 --- a/src/pulsecore/parseaddr.c +++ b/src/pulsecore/parseaddr.c @@ -145,3 +145,14

[pulseaudio-discuss] [PATCH 1/2] parseaddr: Add new call pa_is_ip6_address()

--- src/pulsecore/parseaddr.c | 11 +++ src/pulsecore/parseaddr.h | 2 ++ 2 files changed, 13 insertions(+) diff --git a/src/pulsecore/parseaddr.c b/src/pulsecore/parseaddr.c index d31e68c..f49c81c 100644 --- a/src/pulsecore/parseaddr.c +++ b/src/pulsecore/parseaddr.c @@ -145,3 +145,14

[pulseaudio-discuss] [PATCH] Support IPv6 address in pa_socket_client_new_string()

pa_socket_client_new_string() did not work as expected when an IPv6 address string like 2001:db8::1 is passed as the name parameter. This is because the name parameter is then passed to pa_parse_address(), which thinks the last colon as a separator between hostname (or address) and a port number.

Re: [pulseaudio-discuss] Support IPv6 address in pa_socket_client_new_string()

Sorry, git send-email did not work well for some reason... I wanted to submit these two patches in the following order. [PATCH 1/2] parseaddr: Add new call pa_is_ip6_address() [PATCH] Support IPv6 address in pa_socket_client_new_string() Thanks, Hajime Hajime Fujita wrote: These patches

Re: [pulseaudio-discuss] incomplete IPv6 support in pa_socket_client_new_string()

Tanu Kaskinen wrote: On Wed, 2014-11-05 at 22:29 -0600, Hajime Fujita wrote: Hi Tanu, Thank you for your comment and sorry for the late reply. Tanu Kaskinen wrote: On Tue, 2014-10-21 at 00:49 -0500, Hajime Fujita wrote: Hello, I'm currently working on IPv6 support for the raop module [1

Re: [pulseaudio-discuss] incomplete IPv6 support in pa_socket_client_new_string()

Hi Tanu, Thank you for your comment and sorry for the late reply. Tanu Kaskinen wrote: On Tue, 2014-10-21 at 00:49 -0500, Hajime Fujita wrote: Hello, I'm currently working on IPv6 support for the raop module [1]. During the work I found a potential issue in pa_socket_client_new_string

Re: [pulseaudio-discuss] raop no sound

Hmm, you are right. Your device seems to understand the TCP version. I suppose the current stable pulseaudio should support your device. Unfortunately I don't have any experience with TCP version of the protocol, so I don't have a clue at this moment. A few things that came up to my mind... -

Re: [pulseaudio-discuss] [PATCH 00/25] raop2 support for module-raop-sink

, On jeu., 2013-12-05 at 11:29 +0200, Tanu Kaskinen wrote: On Sat, 2013-09-07 at 11:34 -0500, Hajime Fujita wrote: This patch set adds a support for UDP version of RAOP (so called raop2). Most of the RAOP devices (e.g. AppleTV, AirportExpress, third party AV receivers) today use UDP version, so

Re: [pulseaudio-discuss] How to control playback start timing (RAOP)

Hi Tanu, Thank you for the message. Tanu Kaskinen wrote: On Wed, 2013-10-16 at 22:04 -0500, Hajime Fujita wrote: Hi, I've been working on raop2 support for the raop module. Currently when starting playback through RAOP, there is a huge delay in sound. 2-3 sec after starting music from

[pulseaudio-discuss] How to control playback start timing (RAOP)

Hi, I've been working on raop2 support for the raop module. Currently when starting playback through RAOP, there is a huge delay in sound. 2-3 sec after starting music from a player software, actual sound starts being heard from the speaker. And as a result, there is a gap between a screen and

Re: [pulseaudio-discuss] An raop2 support

Hi Tanu, Tanu Kaskinen wrote: On Wed, 2013-09-18 at 23:09 -0500, Hajime Fujita wrote: Hi Tanu, Thank you so much for your advice. Tanu Kaskinen wrote: On Sun, 2013-09-15 at 00:24 -0500, Hajime Fujita wrote: For those who are interested in raop2 experiments, As Matthias pointed out [1

  1   2   >