Re: [pulseaudio-discuss] [PATCH v3] Add configurable RTP stream name

2018-07-05 Thread Tanu Kaskinen
On Wed, 2018-07-04 at 13:12 +0200, Ing. Jaroslav Safka wrote: > Path add configuration option 'stream_name' for stream/session name > So user will see it on receiver side as RTP Strean ($stream_name) > > ex: load-module module-rtp-send source=rtp.monitor stream_name=MyServerMedia > --- >

Re: [pulseaudio-discuss] [PATCH 2/8] protocol-native: add message sending capability

2018-07-04 Thread Tanu Kaskinen
On Mon, 2018-04-09 at 19:35 +0200, Georg Chini wrote: > This patch adds the PA_COMMAND_SEND_OBJECT_MESSAGE command to protocol-native > so that clients can use the messaging feature introduced in the previous > patch. > > Sending messages can in effect replace the extension system for modules.

Re: [pulseaudio-discuss] [PATCH 1/8] core: add simple message interface

2018-07-04 Thread Tanu Kaskinen
On Mon, 2018-04-09 at 19:35 +0200, Georg Chini wrote: > This patch adds a new feature to the core which allows to send messages > to objects. An object can register/unregister a message handler with > pa_message_handler_{register, unregister}() while a message can be sent > to the handler using

[pulseaudio-discuss] [PATCH] ladspa-sink: fix search path

2018-07-04 Thread Tanu Kaskinen
Having a single level macro for stringizing LADSPA_PATH doesn't work, because the '#' preprocessor operator doesn't expand any macros in its parameter. As a result, we used the string "LADSPA_PATH" as the search path, and obviously no plugins were ever found. This adds a two-level macro in

[pulseaudio-discuss] [PATCH] pipe-sink, pipe-source: fix file permissions

2018-07-04 Thread Tanu Kaskinen
We recently changed the umask of the daemon from 022 to 077, which broke module-pipe-sink in the system mode, because nobody was allowed to read from the pipe. module-pipe-source in the system mode was probably always broken, because the old umask of 022 should prevent anyone from writing to the

Re: [pulseaudio-discuss] [PATCH] Add configurable RTP stream name

2018-07-04 Thread Tanu Kaskinen
On Wed, 2018-07-04 at 11:10 +0200, Ing. Jaroslav Šafka wrote: > On středa 4. července 2018 11:00:08 CEST Tanu Kaskinen wrote: > > On Thu, 2018-06-28 at 22:16 +0200, Ing. Jaroslav Safka wrote: > > > Path add configuration option 'stream_name' for stream/session name >

Re: [pulseaudio-discuss] [PATCH 1/3] alsa-util/sink/source: Add infrastructure for supported sample formats

2018-07-04 Thread Tanu Kaskinen
On Fri, 2018-06-29 at 04:57 +0900, Sangchul Lee wrote: > +static snd_pcm_format_t all_formats[] = { I changed the values to be const. Otherwise this patch looks good, applied. -- Tanu https://liberapay.com/tanuk https://www.patreon.com/tanuk ___

Re: [pulseaudio-discuss] [PATCH] i18n: Update the Korean translation

2018-07-04 Thread Tanu Kaskinen
On Fri, 2018-06-29 at 02:59 +0900, Sangchul Lee wrote: > Translate argument of module-filter-apply and fix words which are > not in common usage. > > Signed-off-by: Sangchul Lee > --- > po/ko.po | 17 + > 1 file changed, 9 insertions(+), 8 deletions(-) Thanks! Applied. --

Re: [pulseaudio-discuss] jack module cannot use real-time scheduling errors

2018-07-04 Thread Tanu Kaskinen
On Thu, 2018-06-28 at 11:25 -0500, dag dg wrote: > Changing the rlimit-rtprio doesn't cause it to change the priority it > attempts to run as, Yes, but it changes the allowed priority limit of the process. The default limit is 9, so that would explain why libjack can't set the priority to 15.

Re: [pulseaudio-discuss] [PATCH] Add configurable RTP stream name

2018-07-04 Thread Tanu Kaskinen
On Thu, 2018-06-28 at 22:16 +0200, Ing. Jaroslav Safka wrote: > Path add configuration option 'stream_name' for stream/session name > So user will see it on receiver side as RTP Strean ($stream_name) > > ex: load-module module-rtp-send source=rtp.monitor stream_name=MyServerMedia > --- >

Re: [pulseaudio-discuss] [patches] constification round #4 (pa_mainloop_api)

2018-07-04 Thread Tanu Kaskinen
On Mon, 2018-07-02 at 17:58 +0100, jnq...@gmail.com wrote: > On Fri, 2018-06-29 at 16:06 +0300, Tanu Kaskinen wrote: > > On Thu, 2018-06-28 at 04:08 +0100, jnq...@gmail.com wrote: > > > It's possible for patches #21, #23 and #24 to be bumped down before > > >

Re: [pulseaudio-discuss] [PATCH] Added loopback module option (gtk3 version)

2018-07-03 Thread Tanu Kaskinen
On Sun, 2018-07-01 at 19:25 +0200, NicoHood wrote: > On 05/23/2018 11:01 AM, Tanu Kaskinen wrote: > > On Sun, 2018-05-13 at 10:42 +0200, archli...@nicohood.de wrote: > > > From: NicoHood > > > > > > --- > > > src/paprefs.cc| 32 +

Re: [pulseaudio-discuss] [PATCH] stream-interaction: Don't reset interaction state when ducking

2018-07-02 Thread Tanu Kaskinen
On Mon, 2018-07-02 at 15:22 +0300, Juho Hämäläinen wrote: > If the interaction state would be reset when ducking, it could happen > that we apply volume factor to a sink-input that already has volume > factor applied by us. For example when volume factor is applied while > a sink-input is running

Re: [pulseaudio-discuss] [PATCH] bluetooth: Free backends before devices and adapters.

2018-06-29 Thread Tanu Kaskinen
On Thu, 2018-06-28 at 14:58 +0300, Juho Hämäläinen wrote: > When bluetooth daemon disappears gracefully transports are freed before > the daemon disappears from DBus bus. However if bluetooth daemon > segfaults or is killed abruptly the daemon disappears from the bus > before PulseAudio is able to

Re: [pulseaudio-discuss] [patches] constification round #4 (pa_mainloop_api)

2018-06-29 Thread Tanu Kaskinen
On Thu, 2018-06-28 at 04:08 +0100, jnq...@gmail.com wrote: > constification round #4 (pa_mainloop_api) > > 26 patches in total. I attached a zipped copy also. > > The first 19 avoid (client) API change; the final 7 do not and will > have to wait until ready and happy to do an API bump. > > I'm

Re: [pulseaudio-discuss] [PATCH] card: Log availability status when choosing initial profile

2018-06-29 Thread Tanu Kaskinen
On Wed, 2018-06-27 at 15:01 -0700, João Paulo Rechi Vita wrote: > --- > src/pulsecore/card.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/pulsecore/card.c b/src/pulsecore/card.c > index 0112cffb1..4ead3a606 100644 > --- a/src/pulsecore/card.c > +++ b/src/pulsecore/card.c >

[pulseaudio-discuss] [PATCH] switch-on-port-available: ignore bluetooth cards

2018-06-29 Thread Tanu Kaskinen
When the user manually switches the profile of a bluetooth headset from "off" to "a2dp_sink", the port availability changes from "unknown" to "yes", which triggered a recursive profile change in module-switch-on-port-available. Such recursivity isn't (and possibly can't) be handled well (that is,

[pulseaudio-discuss] [PATCH v2] udev-detect: warn when a sound card is busy

2018-06-29 Thread Tanu Kaskinen
Having a warning in the syslog should make it a bit easier to debug situations where some other program is hogging the sound card. --- Changes in v2: - Got rid of path_get_card_id() repetition by adding the id variable. - More informative log message (includes the alsa card index and a

Re: [pulseaudio-discuss] [PATCH] udev-detect: warn when a sound card is busy

2018-06-29 Thread Tanu Kaskinen
On Wed, 2018-06-27 at 15:11 -0400, Felipe Sateler wrote: > On Wed, Jun 27, 2018 at 2:19 PM Tanu Kaskinen wrote: > > > Having a warning in the syslog should make it a bit easier to debug > > situations where some other program is hogging the sound card. > > > >

Re: [pulseaudio-discuss] Sound input problem on chtrt5645 device

2018-06-28 Thread Tanu Kaskinen
On Wed, 2018-06-27 at 10:10 -0300, Gustavo Duarte wrote: > On Fri, 2018-06-15 at 12:56 -0300, Gustavo Duarte wrote: > >* Hi all, > *> >* The input sound isn't working. No sound is detected. > *> >* Environment: > *> >* Laptop brand: JP Couto model EF20EA > *> >* Distributor ID: Ubuntu > *>*

Re: [pulseaudio-discuss] [PATCH] bluetooth: backend-ofono: Demote registration failure to info

2018-06-28 Thread Tanu Kaskinen
On Tue, 2018-06-26 at 15:26 -0700, João Paulo Rechi Vita wrote: > Now that both backend-native and backend-ofono can coexist and > backend-ofono is always loaded, even on systems without oFono, failing > to register with org.ofono is not necessarily an error. > > This lowers the failure message

[pulseaudio-discuss] [PATCH] udev-detect: warn when a sound card is busy

2018-06-27 Thread Tanu Kaskinen
Having a warning in the syslog should make it a bit easier to debug situations where some other program is hogging the sound card. --- src/modules/module-udev-detect.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/modules/module-udev-detect.c

Re: [pulseaudio-discuss] [ANNOUNCE] PulseAudio 12.0

2018-06-27 Thread Tanu Kaskinen
On Thu, 2018-06-21 at 12:52 -0400, Felipe Sateler wrote: > On Wed, Jun 20, 2018 at 5:25 PM Tanu Kaskinen wrote: > > > May I have your attention, please? > > > > PulseAudio 12.0 has entered our world, and it claims to be superior to > > its predecessors

Re: [pulseaudio-discuss] jack module cannot use real-time scheduling errors

2018-06-27 Thread Tanu Kaskinen
On Thu, 2018-06-21 at 09:58 -0500, dag dg wrote: > I use pulse with jack via jackdbus. I've been trying to narrow down > the cause of a series of errors I've been seeing in my pulseaudio logs > for some time: > > Jun 21 08:43:46 localhost pulseaudio[1988]: W: [pulseaudio] > module-jack-sink.c:

Re: [pulseaudio-discuss] Failure to connect Sony headsets

2018-06-27 Thread Tanu Kaskinen
ity" stream playing if module-card-restore initially set the > profile to headset_head_sink. Maybe this is more of a UI bug and a > user-focused UI should not expose means for the user to manually > select the profile, which is aligned with a previous comment from > Tanu: > &

[pulseaudio-discuss] [PATCH 0/3] Various state related cleanups

2018-06-26 Thread Tanu Kaskinen
://bugs.freedesktop.org/show_bug.cgi?id=106982 Tanu Kaskinen (3): sink-input: remove the DRAINED state sink-input, source-output: remove the state getters sink, source: remove the state getters src/modules/alsa/alsa-sink.c | 2 +- src/modules/alsa/alsa-source.c | 2 +- src

[pulseaudio-discuss] [PATCH 3/3] sink, source: remove the state getters

2018-06-26 Thread Tanu Kaskinen
pa_sink_get_state() and pa_source_get_state() just return the state variable. We can as well access the state variable directly. There are no behaviour changes, except that module-virtual-source accessed the main thread's sink state variable from its push() callback. I fixed the module so that it

[pulseaudio-discuss] [PATCH 1/3] sink-input: remove the DRAINED state

2018-06-26 Thread Tanu Kaskinen
The only thing that the drained state was being used for was "pacmd list-sink-inputs". In all other cases the drained and running states were treated as equivalent. IMHO, this usage doesn't justify the complexity that the additional state brings. This patch was inspired by a bug report[1] that

[pulseaudio-discuss] [PATCH 2/3] sink-input, source-output: remove the state getters

2018-06-26 Thread Tanu Kaskinen
pa_sink_input_get_state() and pa_source_output_get_state() just return the state variable. We can as well access the state variable directly. There are no behaviour changes, except that some filter sources accessed the main thread's state variable from their push() callbacks. I fixed them so that

Re: [pulseaudio-discuss] Enabling HSP profie in Pulseaudio

2018-06-26 Thread Tanu Kaskinen
On Wed, 2018-06-20 at 11:40 +, Chinthamol CS. wrote: > Hi Tanu, > > I tested regular bluetooth headset connected to Android phone . I > tested with Google's "Voice Search" application. I routed BT audio > as input to this application ( Google App > Settings > Search > Voice > and enable the

Re: [pulseaudio-discuss] [patches] constification round #3

2018-06-26 Thread Tanu Kaskinen
On Tue, 2018-06-19 at 17:39 +0100, jnq...@gmail.com wrote: > On Mon, 2018-06-18 at 10:47 +0300, Tanu Kaskinen wrote: > > Your patches are based on the view that setting the error code isn't > > considered mutating the context object. I think constifying > > pa_context_set_err

Re: [pulseaudio-discuss] Enabling HSP profie in Pulseaudio

2018-06-26 Thread Tanu Kaskinen
On Wed, 2018-06-20 at 07:07 +, Chinthamol CS. wrote: > Hi Tanu, > > Yes. I am getting audio from the phone's internal microphone not from > board's microphone. > I am using "Voice Recorder" Application in Android phone to record > audio. Whether I need to do any configuration setting at the

Re: [pulseaudio-discuss] question: is the mainloop api vtable mutable?

2018-06-25 Thread Tanu Kaskinen
On Sat, 2018-06-16 at 20:01 +0100, jnq...@gmail.com wrote: > Is it intended that the mainloop API vtable be mutable, allowing users > to hijack it with their own (proxy) methods, or should it and the > 'get_api' functions really be constified? > > I held off on constifying this thus far (in both

[pulseaudio-discuss] [ANNOUNCE] PulseAudio 12.0

2018-06-20 Thread Tanu Kaskinen
May I have your attention, please? PulseAudio 12.0 has entered our world, and it claims to be superior to its predecessors at least in the following ways: * Better latency reporting (and hence better A/V sync) with the A2DP bluetooth profile * Much more accurate latency reporting for

Re: [pulseaudio-discuss] Enabling HSP profie in Pulseaudio

2018-06-19 Thread Tanu Kaskinen
On Tue, 2018-06-19 at 10:28 +, Chinthamol CS. wrote: > Hi Tanu, > > Thankyou for your reply. > I updated pulseaudio to 11.1 > Now ofono is not running in my setup. Still i couldn't enable HSP profile in > pulseaudio. > Also I tried with headset=native to module- bluetooth-discover . But No

Re: [pulseaudio-discuss] Sound input problem on chtrt5645 device.

2018-06-18 Thread Tanu Kaskinen
On Fri, 2018-06-15 at 12:56 -0300, Gustavo Duarte wrote: > Hi all, > > The input sound isn't working. No sound is detected. > > Environment: > > Laptop brand: JP Couto model EF20EA > > Distributor ID: Ubuntu > Description: Ubuntu 16.04.4 LTS > Release: 16.04 > Codename: xenial > > Linux

Re: [pulseaudio-discuss] [patch] purge autoload API

2018-06-18 Thread Tanu Kaskinen
On Mon, 2018-06-18 at 11:30 +0300, Tanu Kaskinen wrote: > On Wed, 2018-06-13 at 21:55 +0100, jnq...@gmail.com wrote: > > deprecated since 2009 > > IMHO it doesn't matter when the API was deprecated. If some closed- > source and now unmaintained (and hence unfixable) app

Re: [pulseaudio-discuss] [patch] purge autoload API

2018-06-18 Thread Tanu Kaskinen
On Wed, 2018-06-13 at 21:55 +0100, jnq...@gmail.com wrote: > deprecated since 2009 IMHO it doesn't matter when the API was deprecated. If some closed- source and now unmaintained (and hence unfixable) application was using the API in 2008, and someone somewhere is still using that application, we

[pulseaudio-discuss] [PATCH] context: constify pa_context_set_error()

2018-06-18 Thread Tanu Kaskinen
This allows constifying public API functions that report their errors via the context error but don't modify the context in any other way. Philosophical arguments could be made why this is wrong, but I believe in practice this is a net positive change. --- src/pulse/context.c | 2 +-

Re: [pulseaudio-discuss] [patches] constification round #3

2018-06-18 Thread Tanu Kaskinen
On Fri, 2018-06-15 at 21:34 +0100, jnq...@gmail.com wrote: > On Fri, 2018-06-15 at 14:15 +0300, Tanu Kaskinen wrote: > > On Thu, 2018-06-07 at 05:01 +0100, jnq...@gmail.com wrote: > > > API constification set #3 > > > > > > Some API functions perform

Re: [pulseaudio-discuss] Set volume according to background noice with setting the highest limit

2018-06-15 Thread Tanu Kaskinen
On Thu, 2018-06-14 at 10:41 +0200, Andrej Šimko wrote: > Hello, > > is there a possibility in pulseaudio to set volume dynamically according > to background noice, but with setting the highest limit that will not be > overstepped? I want to set volume higher if there is higher noice in the >

Re: [pulseaudio-discuss] Enabling HSP profie in Pulseaudio

2018-06-15 Thread Tanu Kaskinen
On Wed, 2018-06-13 at 10:15 +, Chinthamol CS. wrote: > Hi all, > > Need to act pulseaudio as headset. Currently we are using pulseaudio 8.0 and > bluez_5.37 . > Current setting of default.pa is attaching with this email. > What changes are needed inorder to run pulseaudio in Hand set

Re: [pulseaudio-discuss] Enabling HSP profie in i.MX6 board

2018-06-15 Thread Tanu Kaskinen
On Mon, 2018-06-11 at 06:34 +, Chinthamol CS. wrote: > Hi all, > > I am using i.MX6 Evaluation board. I need to enable HSP profile in board and > record voice from board to a mobile phone. > I have connected one USB Mic to board to record audio input. > Currently "a2dp_source" profile is the

Re: [pulseaudio-discuss] [patches] constification round #3

2018-06-15 Thread Tanu Kaskinen
On Fri, 2018-06-15 at 14:15 +0300, Tanu Kaskinen wrote: > On Thu, 2018-06-07 at 05:01 +0100, jnq...@gmail.com wrote: > > API constification set #3 > > > > Some API functions perform validation routines which may modify the > > 'error' attribute of a context obje

Re: [pulseaudio-discuss] Occasional heavy click from default speakers, new in openSUSE Leap 15

2018-06-15 Thread Tanu Kaskinen
On Thu, 2018-06-14 at 12:43 -0400, Colin Beckingham wrote: > On 06/14/2018 10:16 AM, Tanu Kaskinen wrote: > > On Sat, 2018-06-02 at 10:36 -0400, Colin Beckingham wrote: > > > On May 25 openSUSE released a new distro update Leap 15 including > > > pulseaudio 11.1 > &g

Re: [pulseaudio-discuss] [patch] const stream internal

2018-06-14 Thread Tanu Kaskinen
On Thu, 2018-06-07 at 04:22 +0100, jnq...@gmail.com wrote: > quick patch to constify a couple of internal stream functions Thanks! Applied. -- Tanu https://liberapay.com/tanuk https://www.patreon.com/tanuk ___ pulseaudio-discuss mailing list

Re: [pulseaudio-discuss] Failure to connect Sony headsets

2018-06-14 Thread Tanu Kaskinen
On Thu, 2018-06-14 at 08:05 -0700, João Paulo Rechi Vita wrote: > > > I also had to disable module-card-restore, otherwise it tries to > > > switch to the saved a2dp_sink profile right when the card is created, > > > which also makes the device abort the AVDTP connection for some > > > reason. > >

Re: [pulseaudio-discuss] Occasional heavy click from default speakers, new in openSUSE Leap 15

2018-06-14 Thread Tanu Kaskinen
On Sat, 2018-06-02 at 10:36 -0400, Colin Beckingham wrote: > On May 25 openSUSE released a new distro update Leap 15 including > pulseaudio 11.1 > While in general sound works very well, there are occasional loud clicks > from default speakers > These loud clicks occur when loading a page in a

[pulseaudio-discuss] Release notes (almost) done, feedback welcome

2018-06-14 Thread Tanu Kaskinen
Hi all, I've finished (ignoring a couple of TODO items) the first draft of the release notes for 12.0. Is there anything to add/remove/change? https://www.freedesktop.org/wiki/Software/PulseAudio/Notes/12.0/ -- Tanu https://liberapay.com/tanuk https://www.patreon.com/tanuk

Re: [pulseaudio-discuss] Failure to connect Sony headsets

2018-06-14 Thread Tanu Kaskinen
On Thu, 2018-06-14 at 00:05 -0700, João Paulo Rechi Vita wrote: > Hello Luiz and Tanuk, > > I have been trying to understand a problem when trying to establish a > connection between my Sony MW-600 headset and my laptop (PulseAudio > 11.1 + a backport that gives higher priority to A2DP, BlueZ

Re: [pulseaudio-discuss] [announce] Rust bindings!

2018-06-13 Thread Tanu Kaskinen
On Tue, 2018-06-12 at 19:03 +0100, jnq...@gmail.com wrote: > On Tue, 2018-06-12 at 11:22 +0300, Tanu Kaskinen wrote: > > On Mon, 2018-05-28 at 19:37 +0100, jnq...@gmail.com wrote: > > > Hi everyone! > > > > > > Back in February I released 'binding' and 'sys' cr

Re: [pulseaudio-discuss] [PATCH] alsa-mixer: Don't move LFE in 2.1 and 4.1 modes on SB Omni Surround 5.1

2018-06-12 Thread Tanu Kaskinen
On Fri, 2018-06-01 at 13:38 +0300, Nazar Mokrynskyi wrote: > A bit hacky approach, but it allows to preserve LFE output position > even in reduced output modes 2.1 and 4.1. > > Signed-off-by: Nazar Mokrynskyi > --- > src/modules/alsa/mixer/profile-sets/sb-omni-surround-5.1.conf | 4 ++-- > 1

Re: [pulseaudio-discuss] [PATCH] cli-command: Report error in pa_play_file.

2018-06-12 Thread Tanu Kaskinen
On Tue, 2018-05-29 at 09:22 +0200, Tomaz Solc wrote: > Current code does not check whether pa_play_file call failed. Hence no error > is > reported in the cli interface if playback failed because e.g. file isn't > readable by the daemon. > --- > src/pulsecore/cli-command.c | 7 ++- > 1 file

Re: [pulseaudio-discuss] [announce] Rust bindings!

2018-06-12 Thread Tanu Kaskinen
On Mon, 2018-05-28 at 19:37 +0100, jnq...@gmail.com wrote: > Hi everyone! > > Back in February I released 'binding' and 'sys' crates for using > pulseaudio from Rust code. I had intended to make an announcement here > at the time, but I failed to do so, so I'm doing it now. > > fyi, the 'sys'

Re: [pulseaudio-discuss] [patches] constification 2/2

2018-06-12 Thread Tanu Kaskinen
On Mon, 2018-05-28 at 01:49 +0100, jnq...@gmail.com wrote: > Constification patch set ** 2 of 2 ** > > Collection of 15 patches constifying pointers in various parts of the > API. > > This collection of patches have no interdependencies, they can be > applied in any order. They do *not* depend

Re: [pulseaudio-discuss] [PATCH] alsa-mixer: make the mono mapping a fallback only

2018-06-11 Thread Tanu Kaskinen
On Fri, 2018-06-08 at 21:10 +0530, Arun Raghavan wrote: > > On Fri, 8 Jun 2018, at 2:09 AM, Tanu Kaskinen wrote: > > On Thu, 2018-06-07 at 17:17 +0200, Georg Chini wrote: > > > On 01.06.2018 10:24, Tanu Kaskinen wrote: > > > > If a sound card doesn't have the

Re: [pulseaudio-discuss] [PATCH] alsa-mixer: make the mono mapping a fallback only

2018-06-07 Thread Tanu Kaskinen
On Thu, 2018-06-07 at 17:17 +0200, Georg Chini wrote: > On 01.06.2018 10:24, Tanu Kaskinen wrote: > > If a sound card doesn't have the "front" device defined for it, we have > > to use the "hw" device for stereo. Not so long ago, the analog-stereo > >

Re: [pulseaudio-discuss] [patches] constification 1/2

2018-06-07 Thread Tanu Kaskinen
On Wed, 2018-06-06 at 17:57 +0100, jnq...@gmail.com wrote: > On Mon, 2018-06-04 at 13:28 +0300, Tanu Kaskinen wrote: > > On Mon, 2018-05-28 at 01:49 +0100, jnq...@gmail.com wrote: > > > Constification patch set ** 1 of 2 ** > > > > > > Collection of 16 pat

Re: [pulseaudio-discuss] [patches] constification 1/2

2018-06-04 Thread Tanu Kaskinen
On Mon, 2018-05-28 at 01:49 +0100, jnq...@gmail.com wrote: > Constification patch set ** 1 of 2 ** > > Collection of 16 patches constifying pointers in various parts of the > API. > > This collection of patches has interdependencies, they must be applied > in (roughly) the given order. > >

Re: [pulseaudio-discuss] [PATCH] format: Expose pa_format_info convenience getters in API

2018-06-01 Thread Tanu Kaskinen
On Sat, 2018-05-26 at 08:58 +0530, Arun Raghavan wrote: > diff --git a/src/pulse/format.h b/src/pulse/format.h > index 584032fb6..812454b9c 100644 > --- a/src/pulse/format.h > +++ b/src/pulse/format.h > @@ -213,6 +213,22 @@ int pa_format_info_get_prop_string_array(const > pa_format_info *f, const

[pulseaudio-discuss] [PATCH] alsa-mixer: make the mono mapping a fallback only

2018-06-01 Thread Tanu Kaskinen
If a sound card doesn't have the "front" device defined for it, we have to use the "hw" device for stereo. Not so long ago, the analog-stereo mapping had "hw:%f" in its device-strings and everything worked great, except that it caused trouble with the Intel HDMI LPE driver that uses the first "hw"

Re: [pulseaudio-discuss] [PATCH v2] udev-detect, alsa-card: Adopt avoid resampling option from daemon.conf

2018-05-31 Thread Tanu Kaskinen
On Fri, 2018-05-25 at 01:29 +0900, Sangchul Lee wrote: > Previously, the "avoid-resampling" option of daemon.conf is to make the > daemon try to use the stream sample rate if possible for all sinks or > sources. > > This patch applies this option to module-udev-detect and module-alsa-card > as a

Re: [pulseaudio-discuss] [PATCH 2/2] alsa: Add support for channel reconfiguration

2018-05-31 Thread Tanu Kaskinen
On Sun, 2018-05-20 at 11:58 +0530, Arun Raghavan wrote: > This is needed for supporting high-bitrate formats in passthrough mode. > The alsa-source reconfiguration path is untested at the moment as I do > not have hardware that can support multiple channel configurations for > capture. > > This

Re: [pulseaudio-discuss] [PATCH 1/2] sink: Allow reconfigure to change the complete sample spec

2018-05-30 Thread Tanu Kaskinen
On Sun, 2018-05-20 at 11:58 +0530, Arun Raghavan wrote: > Subject: sink: Allow reconfigure to change the complete sample spec Sources are changed in the same way, so s/sink/sink, source/. Also, it seems that the intention is to not allow changing the sample format, so "complete sample spec" is

Re: [pulseaudio-discuss] [PATCH] sink-input, source-output: Don't remap volume for passthrough streams

2018-05-30 Thread Tanu Kaskinen
On Sun, 2018-05-20 at 11:35 +0530, Arun Raghavan wrote: > This fixes an assert when we try to restore the original volume map on > the synthesized (100%) volume of a passthrough stream. > --- > src/pulsecore/sink-input.c| 2 +- > src/pulsecore/source-output.c | 2 +- > 2 files changed, 2

Re: [pulseaudio-discuss] Minor update to meson build

2018-05-30 Thread Tanu Kaskinen
On Sun, 2018-05-20 at 08:31 +0530, Arun Raghavan wrote: > The following patches update the meson build based on recent autofoo > changes and clean up some warnings from missing checks. All look good to me. (By the way, HAVE_SYS_WAIT_H is not checked in module-gconf.c and pasuspender.c before

Re: [pulseaudio-discuss] [PATCH] build-sys: Update meson.build based on recent changes

2018-05-30 Thread Tanu Kaskinen
On Sun, 2018-05-20 at 08:17 +0530, Arun Raghavan wrote: > Bump the protocol version, and drop (commented out) references to BlueZ > 4. > --- > meson.build | 2 +- > src/modules/meson.build | 2 -- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/meson.build

Re: [pulseaudio-discuss] [PATCH] alsa-mixer: More output modes for SB Omni Surround 5.1 and cleanup

2018-05-30 Thread Tanu Kaskinen
On Fri, 2018-05-25 at 22:02 +0300, Nazar Mokrynskyi wrote: > 20.05.18 14:09, Tanu Kaskinen пише: > > You don't need to write C code, the alsa configuration system should > > allow you to do this (the alsa configuration system is arguably even > > more difficult than C,

[pulseaudio-discuss] [PATCH] alsa-card: fix null dereference

2018-05-24 Thread Tanu Kaskinen
jack->melem can be null if the jack disappears between probing the card and the init_jacks() call. I don't know if jacks actually ever disappear like that (seems unlikely), but this check is in any case needed as long as init_jacks() has proper handling for the jack disappearing case (rather than

Re: [pulseaudio-discuss] How to prevent certain applications from changing recording volume?

2018-05-23 Thread Tanu Kaskinen
On Wed, 2018-05-23 at 16:48 +0200, Sven-Hendrik Haase wrote: > It changes the device volume. I often have to use web-based conference > tools and apparently browsers like auto adjusting the microphone gain. > However, this annoys as it is perfectly calibrated for other applications > already.

Re: [pulseaudio-discuss] How to prevent certain applications from changing recording volume?

2018-05-23 Thread Tanu Kaskinen
On Thu, 2018-05-17 at 20:15 +0200, Sven-Hendrik Haase wrote: > Hello, > > I would like to prevent certain applications from changing my recording > levels. I had a look at all the modules and none of them seem to do what I > want. I also searched the net far and wide about this but still can't

Re: [pulseaudio-discuss] Detecting success/error in cli protocol?

2018-05-23 Thread Tanu Kaskinen
On Thu, 2018-05-17 at 08:28 +0200, Tomaž Šolc wrote: > (apologies for sending an incomplete mail earlier) > > Hi > > is there a way to detect that a CLI command has succeeded or failed when > using the socket interface offered by module-cli-protocol-unix? > > Specifically I'm currently

Re: [pulseaudio-discuss] [PATCH] Added loopback module option (gtk3 version)

2018-05-23 Thread Tanu Kaskinen
On Sun, 2018-05-13 at 10:42 +0200, archli...@nicohood.de wrote: > From: NicoHood > > --- > src/paprefs.cc| 32 > src/paprefs.glade | 36 +++- > 2 files changed, 63 insertions(+), 5 deletions(-) You need to

Re: [pulseaudio-discuss] [PATCH 1/2] udev-detect, alsa-card: Adopt avoid resampling option from daemon.conf

2018-05-22 Thread Tanu Kaskinen
On Tue, 2018-05-22 at 23:55 +0900, Sangchul Lee wrote: > 2018-05-17 0:54 GMT+09:00 Tanu Kaskinen <ta...@iki.fi>: > > Also, the commit message says that the intention is to use the module > > argument with external devices, but I don't understand how you're > > really

Re: [pulseaudio-discuss] how to Start a pulseaudio application as a daemon with systemd

2018-05-21 Thread Tanu Kaskinen
On Sun, 2018-05-20 at 16:16 +0200, Christophe Lohr wrote: > Le 20/05/2018 à 13:28, Tanu Kaskinen a écrit : > > But what I think you should do is > > disabling the pulseaudio user service in systemd, using the command > > that I already gave: > > > >

[pulseaudio-discuss] [PATCH] client-conf: prefer client.conf over settings from X11

2018-05-20 Thread Tanu Kaskinen
The original thinking was probably that the X11 variables are kind of similar to environment variables, so they should override the settings in client.conf, but I don't think that's a good way to think about it. Unlike environment variables, the X11 variables are practically never set by the user,

Re: [pulseaudio-discuss] how to Start a pulseaudio application as a daemon with systemd

2018-05-20 Thread Tanu Kaskinen
On Sat, 2018-05-19 at 22:32 +0200, Christophe Lohr wrote: > Le 19/05/2018 à 18:47, Tanu Kaskinen a écrit : > > Since the address contains the machine id, I'm pretty sure the address > > is from the X server. > > Bingo! That's it! > In fact, I'm managing this via a ssh -X

Re: [pulseaudio-discuss] [PATCH] alsa-mixer: More output modes for SB Omni Surround 5.1 and cleanup

2018-05-20 Thread Tanu Kaskinen
On Sat, 2018-05-19 at 21:31 +0300, Nazar Mokrynskyi wrote: > 19.05.18 18:29, Tanu Kaskinen пише: > > Thanks! I applied this to the "next" branch. > > > > If you feel like doing more polishing work, it would be nice if you > > could add the surround21, surroun

Re: [pulseaudio-discuss] how to Start a pulseaudio application as a daemon with systemd

2018-05-19 Thread Tanu Kaskinen
On Sat, 2018-05-19 at 18:04 +0200, Christophe Lohr wrote: > Le 19/05/2018 à 16:44, Tanu Kaskinen a écrit : > > You can run "PULSE_LOG=99 pacat" to see where pacat tries > > to find the socket, > > $ PULSE_LOG=99 pacat > Parsing configuration file '/etc/pulse/cl

Re: [pulseaudio-discuss] issue with pulseaudio and gnome shell.

2018-05-19 Thread Tanu Kaskinen
On Thu, 2018-05-10 at 15:45 -0400, F. Heitkamp wrote: > I don't think this is a pulseaudio problem specifically, but I am stumped. > I have checked for missing libraries and references and can't find any. > I have two installation that are almost identical. One works the other > doesn't. > > The

Re: [pulseaudio-discuss] [PATCH] alsa-mixer: More output modes for SB Omni Surround 5.1 and cleanup

2018-05-19 Thread Tanu Kaskinen
On Wed, 2018-05-09 at 01:51 +0300, Nazar Mokrynskyi wrote: > There are only stereo and 5.1 output modes supported natively on this > sound card, but with this config more modes like 2.1, 4.0, 4.1 and 5.0 > are now exposed. Also profiles list is cleaner now with all profiles > explicitly specified.

Re: [pulseaudio-discuss] how to Start a pulseaudio application as a daemon with systemd

2018-05-19 Thread Tanu Kaskinen
On Fri, 2018-05-11 at 14:15 +0200, Christophe Lohr wrote: > Le 09/05/2018 à 09:34, Christophe Lohr a écrit : > > Many thanks for your advice. The 'system-wide' strategy is the solution > > to my problem. > > > > I configured it according to: > >

Re: [pulseaudio-discuss] [PATCH 1/2] udev-detect, alsa-card: Adopt avoid resampling option from daemon.conf

2018-05-16 Thread Tanu Kaskinen
On Tue, 2018-05-08 at 01:54 +0900, Sangchul Lee wrote: > Previously, the "avoid-resampling" option of daemon.conf is to make > the daemon try to use the stream sample rate if possible for all the > audio device regardless of built-in or not. > > This patch applies this option to audio devices -

Re: [pulseaudio-discuss] [PATCH v2] alsa-util: Set ALSA report_delay flag in pa_alsa_safe_delay()

2018-05-14 Thread Tanu Kaskinen
On Sun, 2018-05-13 at 12:20 +0200, Georg Chini wrote: > This patch breaks the build on older ALSA versions. Should we change the > dependency > to 1.1.0 which introduces snd_pcm_status_set_audio_htstamp_config() or > make the > usage of the function dependent on ALSA version? I'm ok with either

[pulseaudio-discuss] [ANNOUNCE] PulseAudio 11.99.1 (a.k.a. v12.0 release candidate 1)

2018-05-13 Thread Tanu Kaskinen
Hi all, The first release candidate for PulseAudio 12.0 is now available! As always, the purpose of the release candidate is to get some testing done before the final version is released. So, everybody is encouraged to try the new code and report back any regressions. Before upgrading, please

Re: [pulseaudio-discuss] [PATCH v2] alsa-util: Set ALSA report_delay flag in pa_alsa_safe_delay()

2018-05-11 Thread Tanu Kaskinen
On Fri, 2018-05-04 at 21:10 +0200, Georg Chini wrote: > The current code does not call snd_pcm_status_set_audio_htstamp_config() > to configure the way timestamps are updated in ALSA. In kernel 4.14 and > above a bug in ALSA has been fixed which changes timmestamp behavior. > This leads to

Re: [pulseaudio-discuss] [PATCH v3] bluez5-device: Fix memory leak in sco_process_render()

2018-05-07 Thread Tanu Kaskinen
On Thu, 2018-04-26 at 13:24 +0200, Georg Chini wrote: > sco_process_render does not unref the memblock when it encounters an error. > > This patch fixes the issue. It also changes the return value to 1 in the case > of EAGAIN. Because the data was already rendered and cannot be re-sent, we > have

Re: [pulseaudio-discuss] [PATCH] null-sink, null-source: Use realtime scheduling if possible

2018-05-07 Thread Tanu Kaskinen
On Sun, 2018-05-06 at 10:35 +0530, Arun Raghavan wrote: > We do this on other sink/source modules, and in general it makes sense > to do so here as well. > --- > src/modules/module-null-sink.c | 4 > src/modules/module-null-source.c | 4 > 2 files changed, 8 insertions(+) > > diff

Re: [pulseaudio-discuss] [PATCH v4] bluez5-device: Rewrite of thread function, reduce send buffer size for a2dp sink

2018-05-07 Thread Tanu Kaskinen
On Fri, 2018-05-04 at 21:10 +0200, Georg Chini wrote: > The rewrite of the thread function does not change functionality much, > most of it is only cleanup, minor bug fixing and documentation work. > > This patch also changes the send buffer size for a2dp sink to avoid lags > after temporary

Re: [pulseaudio-discuss] [PATCH] PROTOCOL: Bump to version 33

2018-05-05 Thread Tanu Kaskinen
On Fri, 2018-05-04 at 22:47 +0530, Arun Raghavan wrote: > Required for the addition of new pa_encoding_t values. > --- > PROTOCOL | 7 +++ > configure.ac | 2 +- > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/PROTOCOL b/PROTOCOL > index 546998b78..8117d0043 100644 >

Re: [pulseaudio-discuss] [PATCH] module-allow-passthrough: Don't crash if we can't find a sink

2018-05-05 Thread Tanu Kaskinen
On Fri, 2018-05-04 at 22:14 +0530, Arun Raghavan wrote: > module-allow-passthrough has a (necessary) hack to replicate the default > sink selection and format negotiation from sink-input.c. One thing that > got missed in this replication is the possibility that the sink input is > not compatible

[pulseaudio-discuss] [PATCH] allow-passthrough: fix hook return value

2018-05-05 Thread Tanu Kaskinen
-PA_ERR_NOENTITY is not a valid pa_hook_result_t value. --- src/modules/module-allow-passthrough.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/module-allow-passthrough.c b/src/modules/module-allow-passthrough.c index 16b421d79..a882e78ea 100644 ---

Re: [pulseaudio-discuss] [PATCH] core: Expose API to elevate a thread to realtime priority

2018-05-05 Thread Tanu Kaskinen
On Fri, 2018-05-04 at 21:01 +0530, Arun Raghavan wrote: > This should make it easier for clients to elevate their audio threads to > real time priority without having to dig through much through specific > system internals. > --- > src/map-file | 1 + >

[pulseaudio-discuss] [PATCH v2] sink-input, source-output: fix unitialized variable access

2018-05-05 Thread Tanu Kaskinen
The volume_map variable was initialized only for PCM streams, but the variable was passed to pa_cvolume_remap() also for non-PCM streams. The volume remapping is never necessary for passthrough streams (PCM or not), because no volume will be applied anyway, so let's skip the pa_cvolume_remap()

Re: [pulseaudio-discuss] [PATCH] core: Expose API to elevate a thread to realtime priority

2018-05-04 Thread Tanu Kaskinen
On Sat, 2018-04-21 at 09:51 +0530, Arun Raghavan wrote: > This should make it easier for clients to elevate their audio threads to > real time priority without having to dig through much through specific > system internals. > --- > src/modules/alsa/alsa-sink.c | 3 +- >

Re: [pulseaudio-discuss] [PATCH] ladspa-sink: fix incorrect error conditions

2018-05-04 Thread Tanu Kaskinen
On Fri, 2018-05-04 at 02:00 +0900, Sangchul Lee wrote: > From: Sangchul Lee > > fix codes to prevent null pointer dereference of cdata variable. > > Signed-off-by: Sangchul Lee > --- > src/modules/module-ladspa-sink.c | 2 +- > 1 file changed, 1

Re: [pulseaudio-discuss] [PATCH] rtp-send: remove dead code

2018-05-04 Thread Tanu Kaskinen
On Fri, 2018-05-04 at 01:27 +0900, Sangchul Lee wrote: > From: Sangchul Lee > > Signed-off-by: Sangchul Lee > --- > src/modules/rtp/module-rtp-send.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/src/modules/rtp/module-rtp-send.c >

[pulseaudio-discuss] [PATCH] rtp-send: fix a memory leak

2018-05-04 Thread Tanu Kaskinen
p is the return value of pa_sdp_build(), and pa_sdp_build() allocates the return value with pa_sprintf_malloc(), so p has to be freed after use. --- src/modules/rtp/module-rtp-send.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/modules/rtp/module-rtp-send.c

Re: [pulseaudio-discuss] bluetooth headset connection and disconnection status

2018-05-04 Thread Tanu Kaskinen
On Fri, 2018-05-04 at 21:13 +0900, Shinnosuke Suzuki wrote: > Hi, > > > You're saying that the audio stops, but that there's no drop-out. Those > > two things mean the same thing to me, so it's unclear to me what the > > nature of your problem is then. By "drop-out" I mean a situation where > >

Re: [pulseaudio-discuss] bluetooth headset connection and disconnection status

2018-05-03 Thread Tanu Kaskinen
On Wed, 2018-05-02 at 08:34 +0900, Shinnosuke Suzuki wrote: > Hi, > > > It's true that when the server processes the "list cards" command from > > pactl, packets to/from parec/pacat are not processed during time, but > > sending the card information shouldn't take a long time, so it sounds > >

<    1   2   3   4   5   6   7   8   9   10   >