On 13 February 2017 at 13:58, Tanu Kaskinen <ta...@iki.fi> wrote:
> On Fri, 2017-01-27 at 17:15 +0100, Wim Taymans wrote:
>> Hi All,
>>
>> I think (1) is quite ugly and requires you to modify many functions
>> with a new parameter that
>> is not at all r
Hi All,
I took another look at the access control patches.
There was a desire from Arun and Tanu to have the access control
checks more integrated
into the core objects instead of just some checks in the native protocol.
I was a bit reluctant to start this because it would involve passing
On 15 July 2016 at 11:14, David Henningsson <di...@ubuntu.com> wrote:
>
>
> On 2016-07-15 11:05, Wim Taymans wrote:
>
>> Hi guys,
>>
>> I'm having another look at the access control patches. I revived my old
>> patches and found some trouble with the
Hi guys,
I'm having another look at the access control patches. I revived my old
patches and found some trouble with the async stuff that I fixed here:
https://cgit.freedesktop.org/~wtay/pulseaudio/log/?h=access-hooks
There is also an example on how to start and complete an async access
check
inside pulseaudio, it can't
atomically update both the master volume and the volumes of all other
streams
Wim
On 19 October 2015 at 17:32, Alexander E. Patrakov <patra...@gmail.com>
wrote:
> 19.10.2015 19:38, Wim Taymans wrote:
>
>> Hi all,
>>
>> Now that we are ta
On 20 October 2015 at 06:53, Arun Raghavan <a...@accosted.net> wrote:
> On Mon, 2015-10-19 at 16:38 +0200, Wim Taymans wrote:
>
> I think this option is more or less the same as disabling flat volumes.
> The user is back to having at least two actions to control volume
&g
Hi all,
Now that we are talking about flat volumes again (but I don't want to
hijack the other thread), I would like to present another alternative to fix
the problems with flat-volumes.
The idea is that all apps, by default, operate in non-flat volume mode.
This means all volume control done
---
src/pulsecore/core-subscribe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/pulsecore/core-subscribe.c b/src/pulsecore/core-subscribe.c
index 61c779b..5a88b7e 100644
--- a/src/pulsecore/core-subscribe.c
+++ b/src/pulsecore/core-subscribe.c
@@ -206,7 +206,7 @@ void
/modules/module-access.c
@@ -0,0 +1,479 @@
+/***
+ This file is part of PulseAudio.
+
+ Copyright 2004-2006 Lennart Poettering
+2015 Wim Taymans wtaym...@redhat.com
+
+ PulseAudio is free software; you can redistribute it and/or modify
+ it under the terms of the GNU Lesser General Public
and then when the reply
becomes available, re-execute the command.
There is an example access control module that shows how one could implement
client specific access control checks.
The patch also contains a small typo fix that can probably be applied
independently.
Wim Taymans (5):
tagstruct: add
of PulseAudio.
+
+ Copyright 2004-2006 Lennart Poettering
+2015 Wim Taymans wtaym...@redhat.com
+
+ PulseAudio is free software; you can redistribute it and/or modify
+ it under the terms of the GNU Lesser General Public License as
+ published by the Free Software Foundation; either
---
po/LINGUAS |1 +
po/ko.po | 3012
2 files changed, 3013 insertions(+)
create mode 100644 po/ko.po
diff --git a/po/LINGUAS b/po/LINGUAS
index 71c73a5..58e2bf8 100644
--- a/po/LINGUAS
+++ b/po/LINGUAS
@@ -16,6 +16,7 @@ id
it
This is a patch to add korean translation that I keep around in RHEL7 but there
is no reason to not add this upstream. Translation are for 3.0 of pulseaudio.
Wim Taymans (1):
Add korean translation
po/LINGUAS |1 +
po/ko.po | 3012
Add a method to copy a tagstruct. This will also reset the read pointer
back to the beginning.
---
src/pulsecore/tagstruct.c | 13 +
src/pulsecore/tagstruct.h | 2 ++
2 files changed, 15 insertions(+)
diff --git a/src/pulsecore/tagstruct.c b/src/pulsecore/tagstruct.c
index
And to the list..
-- Forwarded message --
From: Wim Taymans wim.taym...@gmail.com
Date: 18 March 2015 at 09:34
Subject: Re: [pulseaudio-discuss] [PATCH 0/2] access-control prototype
To: Tanu Kaskinen tanu.kaski...@linux.intel.com
On 17 March 2015 at 20:37, Tanu Kaskinen
In addition to the HSP Audio Gateway, also add support for the HeadSet
profile in the native bluetooth backend. With this profile you can use
pulseaudio as a headset.
In the headset role, we create source and sink to receive and send the samples
from the gateway, respectively. The loopback device
This adds support for the HSP HS role and turns pulseaudio into a
Headset.
This is an updated patch that adds support for incomming SCO connections from
the Audio Gateway.
Wim Taymans (1):
backend-native: add support for the HSP HeadeSet profile
src/modules/bluetooth/backend-native.c
you think? I would love to hear your ideas.
[1] https://wiki.gnome.org/action/info/Projects/SandboxedApps/Sandbox
[2] http://cgit.freedesktop.org/~wtay/pulseaudio/log/?h=access-hooks
Wim Taymans (2):
access: add access control hooks
module-access: make policy object containing rules
src
.
+
+ Copyright 2004-2006 Lennart Poettering
+2015 Wim Taymans wtaym...@redhat.com
+
+ PulseAudio is free software; you can redistribute it and/or modify
+ it under the terms of the GNU Lesser General Public License as published
+ by the Free Software Foundation; either version 2.1
Make a policy object that contains the rules for checking access to
resources. The idea is that we can have different policies later and
then, depending on the client, use one of the policies.
---
src/modules/module-access.c | 184 +++-
1 file changed, 115
, Georg Chini ge...@chini.tk wrote:
On 17.02.2015 15:34, Wim Taymans wrote:
In addition to the HSP Audio Gateway, also add support for the HeadSet
profile in the native bluetooth backend. With this profile you can use
pulseaudio as a headset.
Just tested it with my old Nokia 6230. Connects
In some cases, depending on the instruction that performs the load, orc
ignores the size of the parameter when loading it for the first time.
Explicitly load the parameter into a temp to make sure it is loaded
correctly, like we do for the 2ch case.
See
Can you check in the log if the volume AT commands are sent to the headset?
What I can think of is maybe that the command is not formatted properly
(like missing a \n\r somewhere, I've seen some headset be picky about that).
Wim
On 14 November 2014 10:39, Arun Raghavan a...@accosted.net wrote:
:
On 14 Nov 2014 15:31, Wim Taymans wim.taym...@gmail.com wrote:
Can you compare with a hcidump of working volume?
It never actually worked for me. If you have one that works, I can compare
with what I get here ( well probably take a day or two).
-- Arun
Send the right command to set the speaker and microphone gain.
---
src/modules/bluetooth/backend-native.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/modules/bluetooth/backend-native.c
b/src/modules/bluetooth/backend-native.c
index 86af422..cea2db2 100644
---
Send the right command to set the speaker and microphone gain.
Note that setting the volume on the Headset should use the unsolicited
result code. Receiving the volume from the Headset uses the AT
command.
---
src/modules/bluetooth/backend-native.c | 8
1 file changed, 4 insertions(+),
This patch fixes the gain settings for Headsets by sending the right
commands. It replaces the previous patch.
Wim Taymans (1):
bluetooth: set gain correctly
src/modules/bluetooth/backend-native.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
--
1.9.3
Add a dispose function to the transport that is called before freeing
the transport. Useful for cleaning up extra userdata.
---
src/modules/bluetooth/bluez5-util.c | 2 ++
src/modules/bluetooth/bluez5-util.h | 2 ++
2 files changed, 4 insertions(+)
diff --git
Parse the gain changed AT commands from the headset and fire 2 new
hooks as a result. The device will connect to those hooks and change the
source/sink volumes.
When the source/sink volume changes, set the gain on the microphone or
speaker respectively. Make sure we do nothing if the transport
bits to
implement the following patches.
The patches also switches the default backend from ofono to native.
This patchset replaces the previously posted native backend patches and
incorporates the suggestions I received to date.
Wim Taymans (4):
bluez5-device: use get_profile_direction
(BLUETOOTH_HEADSET_BACKEND)
diff --git a/src/modules/bluetooth/backend-native.c
b/src/modules/bluetooth/backend-native.c
new file mode 100644
index 000..b3c4220
--- /dev/null
+++ b/src/modules/bluetooth/backend-native.c
@@ -0,0 +1,443 @@
+/***
+ This file is part of PulseAudio.
+
+ Copyright 2014 Wim Taymans
bits to
implement the last patch.
The patch also switches the default backend from ofono to native.
This patch replaces the previously posted native backend patches and
incorporates the suggestions I received.
Wim Taymans (3):
bluez5-device: use get_profile_direction
bluez5-util: add dispose
Use the get_profile_direction() helper function to decide when to add a
source and a sink instead of enumerating profiles.
---
src/modules/bluetooth/module-bluez5-device.c | 32 +---
1 file changed, 15 insertions(+), 17 deletions(-)
diff --git
Add a dispose function to the transport that is called before freeing
the transport. Useful for cleaning up extra userdata.
---
src/modules/bluetooth/bluez5-util.c | 2 ++
src/modules/bluetooth/bluez5-util.h | 2 ++
2 files changed, 4 insertions(+)
diff --git
This set of patches adds a simple handler for the HSP profile to bluez
and makes a new card for each connected device. This makes it possible to
send audio to a Headset. The profile is implemented in a new native
headset backend.
The first 4 patches are mostly some very small cleanups and
+if (imtu)
+*imtu = 48;
+
+if (omtu)
+*omtu = 48;
Out of curiosity, are these values fixed in the spec?
They are not but the kernel does not want to give us the real MTU values so
this is hardcoded for now.
+if (events PA_IO_EVENT_INPUT) {
+
With BlueZ 4 we support hardware volume, i.e. the 15 volume levels. This
is actually quite important, because if you rely on software volume,
there will be two independent volume controls for the headset: the
software volume in PulseAudio, and the headset's internal volume. Not
Use the get_profile_direction() helper function to decide when to add a
source and a sink instead of enumerating profiles.
---
src/modules/bluetooth/module-bluez5-device.c | 32 +---
1 file changed, 15 insertions(+), 17 deletions(-)
diff --git
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 7b56210..e1e2572 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1037,7 +1037,7 @@ else
BLUETOOTH_HEADSET_BACKEND=$with_bluetooth_headset_backend
fi
-AS_IF([test
bits to
implement the last patch.
The patch also switches the default backend from ofono to native.
Wim Taymans (5):
bluez5-device: use get_profile_direction
bluez5-util: add dispose function
bluez5-util: always DISCONNECT on free
configure: fix headset check
backend-native: add a new
Add a dispose function to the transport that is called before freeing
the transport. Useful for cleaning up extra userdata.
---
src/modules/bluetooth/bluez5-util.c | 2 ++
src/modules/bluetooth/bluez5-util.h | 2 ++
2 files changed, 4 insertions(+)
diff --git
(BLUETOOTH_HEADSET_BACKEND)
diff --git a/src/modules/bluetooth/backend-native.c
b/src/modules/bluetooth/backend-native.c
new file mode 100644
index 000..8af610c
--- /dev/null
+++ b/src/modules/bluetooth/backend-native.c
@@ -0,0 +1,474 @@
+/***
+ This file is part of PulseAudio.
+
+ Copyright 2014 Wim Taymans
We always disconnect before free, move the state changed function in the
free method.
---
src/modules/bluetooth/bluez5-util.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/modules/bluetooth/bluez5-util.c
b/src/modules/bluetooth/bluez5-util.c
index b5c0726..777aca9
We always disconnect before free, move the state changed function in the
free method.
---
src/modules/bluetooth/bluez5-util.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/modules/bluetooth/bluez5-util.c
b/src/modules/bluetooth/bluez5-util.c
index b5c0726..777aca9
Add a dispose function to the transport that is called before freeing
the transport. Useful for cleaning up extra userdata.
---
src/modules/bluetooth/bluez5-util.c | 2 ++
src/modules/bluetooth/bluez5-util.h | 2 ++
2 files changed, 4 insertions(+)
diff --git
Add simple support for the HSP profile. This allows pulseaudio to output
audio to a Headset using the HSP profile.
Make the null backend the default, now that it does something.
---
configure.ac | 4 +-
src/modules/bluetooth/backend-null.c | 457
Use the get_profile_direction() helper function to decide when to add a
source and a sink instead of enumerating profiles.
---
src/modules/bluetooth/module-bluez5-device.c | 32 +---
1 file changed, 15 insertions(+), 17 deletions(-)
diff --git
You can get that eror when there is a problem with fd-passing over DBus.
Anything special with your setup? SELinux, for example, did the same thing
to me. See if sudo setenforce 0 makes it work...
Wim
On 11 August 2014 15:07, Tanu Kaskinen tanu.kaski...@linux.intel.com
wrote:
On Fri,
Mark the sink as DYNAMIC_LATENCY and implement update_sink_latency_range
on its sink-input to collect the combined latency range of all sinks.
Implement update_requested_latency on the sink to configure the final
latency by combining the sink-input requested latencies. This makes us
honour the
the sink-inputs, we configure ourselves for
our calculated max_latency.
Inspired by the null-sink, we use the configured latency to make sure that the
null-renderer is woken up often enough.
Wim Taymans (1):
combine-sink: add suport for DYNAMIC_LATENCY
src/modules/module-combine-sink.c | 142
Mark the sink as DYNAMIC_LATENCY and implement update_sink_latency_range
on its sink-input to collect the combined latency range of all sinks.
Implement update_requested_latency on the sink to configure the final
latency by combining the sink-input requested latencies. This makes us
honour the
Here are the updated patches that add support for DYNAMIC_LATENCY in
the combine-sink module.
I've also include a small patch to rework the way outputs are added and
removed, I think this is nicer and more symetric.
Wim Taymans (2):
combine-sink: rework output add/remove
combine-sink: add
Add the output from its sink-input attached callback and remove it
again from the detach callback. This simplifies some output_enable
and we can also avoid posting 2 messages for the sink.
---
src/modules/module-combine-sink.c | 27 +++
1 file changed, 11 insertions(+), 16
Mark the sink as DYNAMIC_LATENCY and implement update_sink_latency_range
on its sink-input to collect the combined latency range of all sinks.
Implement update_requested_latency on the sink to configure the final
latency by combining the sink-input requested latencies. This makes us
honour the
54 matches
Mail list logo
