Re: [pulseaudio-discuss] [PATCH] Warn on attempts to build and load module-equalizer-sink

2014-12-02 Thread Jason Newton
On Tue, Dec 2, 2014 at 6:40 AM, David Henningsson wrote: > > > On 2014-12-02 13:36, Alexander E. Patrakov wrote: >> >> 02.12.2014 16:53, Tanu Kaskinen wrote: >>> >>> I'd lean on building the module by default. >>> >> >> OK, this then means that the ./configure warning is pointless (as it >> would

Re: [pulseaudio-discuss] [PATCH] Warn on attempts to build and load module-equalizer-sink

2014-12-02 Thread Alexander E. Patrakov
02.12.2014 19:40, David Henningsson wrote: With Arun's suggestions: module-equalizer-sink is currently unsupported, and can sometimes cause PulseAudio crashes, increased latency or audible artifacts. If you're facing audio problems, try unloading this module as a potential workaround. Ok with e

Re: [pulseaudio-discuss] [PATCH] Warn on attempts to build and load module-equalizer-sink

2014-12-02 Thread David Henningsson
On 2014-12-02 13:36, Alexander E. Patrakov wrote: 02.12.2014 16:53, Tanu Kaskinen wrote: I'd lean on building the module by default. OK, this then means that the ./configure warning is pointless (as it would be then shown in the default build). So this leaves us with a warning in the module

Re: [pulseaudio-discuss] [PATCH] Warn on attempts to build and load module-equalizer-sink

2014-12-02 Thread Alexander E. Patrakov
02.12.2014 16:53, Tanu Kaskinen wrote: I'd lean on building the module by default. OK, this then means that the ./configure warning is pointless (as it would be then shown in the default build). So this leaves us with a warning in the module itself. David: I have looked at the wording that

Re: [pulseaudio-discuss] [PATCH] Warn on attempts to build and load module-equalizer-sink

2014-12-02 Thread Arun Raghavan
On 2 December 2014 at 17:52, David Henningsson wrote: > > > On 2014-12-02 10:15, Alexander E. Patrakov wrote: >> >> 02.12.2014 14:02, David Henningsson wrote: >>> >>> >>> >>> On 2014-12-01 17:14, Alexander E. Patrakov wrote: +AS_HELP_STRING([--with-fftw],[Build FFTW-using module

Re: [pulseaudio-discuss] [PATCH] Warn on attempts to build and load module-equalizer-sink

2014-12-02 Thread David Henningsson
On 2014-12-02 10:15, Alexander E. Patrakov wrote: 02.12.2014 14:02, David Henningsson wrote: On 2014-12-01 17:14, Alexander E. Patrakov wrote: +AS_HELP_STRING([--with-fftw],[Build FFTW-using module (equalizer). Note: the module has known-wrong DSP logic])) +AS_IF([test "x$HAVE_FFTW" = "

Re: [pulseaudio-discuss] [PATCH] Warn on attempts to build and load module-equalizer-sink

2014-12-02 Thread Tanu Kaskinen
On Tue, 2014-12-02 at 10:02 +0100, David Henningsson wrote: > > On 2014-12-01 17:14, Alexander E. Patrakov wrote: > > +AS_HELP_STRING([--with-fftw],[Build FFTW-using module (equalizer). > > Note: the module has known-wrong DSP logic])) > > +AS_IF([test "x$HAVE_FFTW" = "x1"], ENABLE_FFTW="yes

Re: [pulseaudio-discuss] [PATCH] Warn on attempts to build and load module-equalizer-sink

2014-12-02 Thread Alexander E. Patrakov
02.12.2014 14:02, David Henningsson wrote: On 2014-12-01 17:14, Alexander E. Patrakov wrote: +AS_HELP_STRING([--with-fftw],[Build FFTW-using module (equalizer). Note: the module has known-wrong DSP logic])) +AS_IF([test "x$HAVE_FFTW" = "x1"], ENABLE_FFTW="yes (BAD IDEA)", ENABLE_FFTW=no) +

Re: [pulseaudio-discuss] [PATCH] Warn on attempts to build and load module-equalizer-sink

2014-12-02 Thread David Henningsson
On 2014-12-01 17:14, Alexander E. Patrakov wrote: +AS_HELP_STRING([--with-fftw],[Build FFTW-using module (equalizer). Note: the module has known-wrong DSP logic])) +AS_IF([test "x$HAVE_FFTW" = "x1"], ENABLE_FFTW="yes (BAD IDEA)", ENABLE_FFTW=no) += WARNING WARNING WARNING WARNING WARN

Re: [pulseaudio-discuss] [PATCH] Warn on attempts to build and load module-equalizer-sink

2014-12-01 Thread Jason Newton
Hm, how do you feel about leaving it default on? I don't want people on ubuntu or other distros who are using it (and they exist!) being suddenly islanded again like they have been repeatedly with the other ladspa equalizer frontends. I think that would lesson those users' opinion of pulse. If y

[pulseaudio-discuss] [PATCH] Warn on attempts to build and load module-equalizer-sink

2014-12-01 Thread Alexander E. Patrakov
Also, don't build it by default. Signed-off-by: Alexander E. Patrakov --- configure.ac| 24 +--- src/modules/module-equalizer-sink.c | 4 2 files changed, 25 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index fe8423f..9