Re: [pulseaudio-discuss] [PATCH] added two new commands to native API to control the combine sink slaves after the combine sink has been created

2017-01-27 Thread Steffen Pfendtner
To catch up your points: I will synchronise the pactl to pacmd. pulseaudio-dlna is using pactl too. I just missed that point. I share your view regarding the location of the new functions. A new file set src/pulsecore/combine-sink.[ch] is a good idea to remove this from the standard sink stuff.

Re: [pulseaudio-discuss] [PATCH] added two new commands to native API to control the combine sink slaves after the combine sink has been created

2017-01-11 Thread Tanu Kaskinen
On Wed, 2017-01-11 at 17:44 +0530, Arun Raghavan wrote: > On Wed, 11 Jan 2017, at 03:45 AM, Tanu Kaskinen wrote: > > Thanks for the patch! > > > > On Thu, 2017-01-05 at 20:13 +0100, Steffen Pfendtner wrote: > > > Subject: [PATCH] added two new commands to native API to control the > > > combine

Re: [pulseaudio-discuss] [PATCH] added two new commands to native API to control the combine sink slaves after the combine sink has been created

2017-01-11 Thread Arun Raghavan
On Wed, 11 Jan 2017, at 03:45 AM, Tanu Kaskinen wrote: > Thanks for the patch! > > On Thu, 2017-01-05 at 20:13 +0100, Steffen Pfendtner wrote: > > Subject: [PATCH] added two new commands to native API to control the > > combine sink slaves after the combine sink has been created > > There's a

Re: [pulseaudio-discuss] [PATCH] added two new commands to native API to control the combine sink slaves after the combine sink has been created

2017-01-10 Thread Tanu Kaskinen
Thanks for the patch! On Thu, 2017-01-05 at 20:13 +0100, Steffen Pfendtner wrote: > Subject: [PATCH] added two new commands to native API to control the combine > sink slaves after the combine sink has been created There's a misunderstanding: you edited the command line interface, not the

[pulseaudio-discuss] [PATCH] added two new commands to native API to control the combine sink slaves after the combine sink has been created

2017-01-05 Thread Steffen Pfendtner
--- src/modules/module-combine-sink.c | 92 +++ src/pulsecore/cli-command.c | 78 + src/pulsecore/sink.c | 32 ++ src/pulsecore/sink.h | 8 4 files changed, 210 insertions(+)